kraken: Sort futures orderbook bids in UpdateOrderbook (#1954)

* kraken: fix orderbook test

* thrasher/gk: nits

---------

Co-authored-by: shazbert <ryan.oharareid@thrasher.io>
This commit is contained in:
Ryan O'Hara-Reid
2025-06-25 09:05:06 +10:00
committed by GitHub
parent 12748ffaa7
commit 61a3d765ee

View File

@@ -464,11 +464,9 @@ func (k *Kraken) UpdateOrderbook(ctx context.Context, p currency.Pair, assetType
Asset: assetType,
ValidateOrderbook: k.ValidateOrderbook,
}
var err error
switch assetType {
case asset.Spot:
var orderbookNew *Orderbook
orderbookNew, err = k.GetDepth(ctx, p)
orderbookNew, err := k.GetDepth(ctx, p)
if err != nil {
return book, err
}
@@ -487,8 +485,7 @@ func (k *Kraken) UpdateOrderbook(ctx context.Context, p currency.Pair, assetType
}
}
case asset.Futures:
var futuresOB *FuturesOrderbookData
futuresOB, err = k.GetFuturesOrderbook(ctx, p)
futuresOB, err := k.GetFuturesOrderbook(ctx, p)
if err != nil {
return book, err
}
@@ -506,12 +503,11 @@ func (k *Kraken) UpdateOrderbook(ctx context.Context, p currency.Pair, assetType
Amount: futuresOB.Orderbook.Bids[y][1],
}
}
book.Bids.Reverse()
book.Bids.SortBids()
default:
return book, fmt.Errorf("%w %v", asset.ErrNotSupported, assetType)
}
err = book.Process()
if err != nil {
if err := book.Process(); err != nil {
return book, err
}
return orderbook.Get(k.Name, p, assetType)