From 61a3d765ee4bad73bf7d3c48624aabed5d1a0375 Mon Sep 17 00:00:00 2001 From: Ryan O'Hara-Reid Date: Wed, 25 Jun 2025 09:05:06 +1000 Subject: [PATCH] kraken: Sort futures orderbook bids in UpdateOrderbook (#1954) * kraken: fix orderbook test * thrasher/gk: nits --------- Co-authored-by: shazbert --- exchanges/kraken/kraken_wrapper.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/exchanges/kraken/kraken_wrapper.go b/exchanges/kraken/kraken_wrapper.go index b8624381..84bd0f2b 100644 --- a/exchanges/kraken/kraken_wrapper.go +++ b/exchanges/kraken/kraken_wrapper.go @@ -464,11 +464,9 @@ func (k *Kraken) UpdateOrderbook(ctx context.Context, p currency.Pair, assetType Asset: assetType, ValidateOrderbook: k.ValidateOrderbook, } - var err error switch assetType { case asset.Spot: - var orderbookNew *Orderbook - orderbookNew, err = k.GetDepth(ctx, p) + orderbookNew, err := k.GetDepth(ctx, p) if err != nil { return book, err } @@ -487,8 +485,7 @@ func (k *Kraken) UpdateOrderbook(ctx context.Context, p currency.Pair, assetType } } case asset.Futures: - var futuresOB *FuturesOrderbookData - futuresOB, err = k.GetFuturesOrderbook(ctx, p) + futuresOB, err := k.GetFuturesOrderbook(ctx, p) if err != nil { return book, err } @@ -506,12 +503,11 @@ func (k *Kraken) UpdateOrderbook(ctx context.Context, p currency.Pair, assetType Amount: futuresOB.Orderbook.Bids[y][1], } } - book.Bids.Reverse() + book.Bids.SortBids() default: return book, fmt.Errorf("%w %v", asset.ErrNotSupported, assetType) } - err = book.Process() - if err != nil { + if err := book.Process(); err != nil { return book, err } return orderbook.Get(k.Name, p, assetType)