feat: propagate errors on iSSG failures instead of publishing public error pages

This commit is contained in:
Travis Fischer
2021-02-01 11:44:33 -05:00
parent 040d11f5a6
commit e5278458a1
2 changed files with 24 additions and 16 deletions

View File

@@ -14,14 +14,18 @@ export const getStaticProps = async (context) => {
} catch (err) {
console.error('page error', domain, rawPageId, err)
return {
props: {
error: {
statusCode: err.statusCode || 500,
message: err.message
}
}
}
// we don't want to publish the error version of this page, so
// let next.js know explicitly that incremental SSG failed
throw err
// return {
// props: {
// error: {
// statusCode: err.statusCode || 500,
// message: err.message
// }
// }
// }
}
}

View File

@@ -11,14 +11,18 @@ export const getStaticProps = async () => {
} catch (err) {
console.error('page error', domain, err)
return {
props: {
error: {
statusCode: err.statusCode || 500,
message: err.message
}
}
}
// we don't want to publish the error version of this page, so
// let next.js know explicitly that incremental SSG failed
throw err
// return {
// props: {
// error: {
// statusCode: err.statusCode || 500,
// message: err.message
// }
// }
// }
}
}
export default function NotionDomainPage(props) {