Yordan Miladinov 3467914ab7 Binance/FTX: spot websocket fixes (#753) ...

* exchange/binance/websocket:

1. resolve order type by reading the dedicated executionReport field (X)

2. populate average price (computed as advised in docs: Z/z)

3. fee taken is now assigned to order.Detail.Fee (not to order.Detail.Cost)

4. proper order.Detail.Cost and order.Detail.CostAsset

* order.Detail: add a new field: FeeAsset

* exchange/binance/websocket: wsOrderUpdate: assign FeeAsset

* exchange/binance/websocket: wsOrderUpdate: use TransactionTime instead of EventTime (more precise) and populate order.Detail.TargetAmount

* exchange/binance/websocket: wsOrderUpdate: use full name for variables (isn't obvious otherwise), do not mix var and :=, order temporary variable by their order in order.Detail

* exchange/binance/websocket: order fields of WsOrderUpdateData by the documented/received-over-the-websocket order of fields

* exchange/binance/websocket: add explicitly "M" as WsOrderUpdateData.Ignored2, which would otherwise override small "m"

* exchange/binance/websocket: check for zero when computing averagePrice

* exchange/binance/test: update TestExecutionTypeToOrderStatus and TestWsOrderExecutionReport

* exchange/binance/websocket: wsOrderUpdate now reports cost thus far, not the total order cost as that cannot be predicted in the case of partially filled orders

* exchange/ftx/websocket: WsOrderDataStore now reports cost thus far, not the total order cost as that cannot be predicted in the case of partially filled orders

* exchange/binance/websocket: executionReport now does not set TargetAmount as it is not applicable

* exchanges: binance/websocket and ftx/websocket now properly set Date and LastUpdated time fields when reporting a trade

* exchange/binance/websocket: check if WsOrderUpdateData.CommissionAsset is populated when assigning feeAsset

* exchange/binance/test: fix TestWsOrderExecutionReport

2021-08-18 18:31:03 +10:00

26 KiB

Raw Blame History

View Raw