mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-13 23:16:45 +00:00
11468ab1b3
* Fix(kraken): Protect authToken with RWMutex to prevent race This commit introduces a sync.RWMutex to protect the global `authToken` variable in `exchanges/kraken/kraken_websocket.go`. The race condition occurred due to concurrent read/write access to `authToken` from different goroutines, notably between `WsConnect` (write) and functions like `wsCancelOrder`, `wsAddOrder`, `wsCancelAllOrders`, and `manageSubs` (read). The fix involves: - Adding `authTokenMutex.Lock()` before writing to `authToken` in `WsConnect` and `authTokenMutex.Unlock()` after. - Adding `authTokenMutex.RLock()` before reading `authToken` in `wsAddOrder`, `wsCancelOrder`, `wsCancelAllOrders`, and `manageSubs`, and `authTokenMutex.RUnlock()` after. This change resolves the data race reported in https://github.com/thrasher-corp/gocryptotrader/issues/1762. I ran tests in the `exchanges/kraken` package with the `-race` detector, and all tests passed without detecting any race conditions. * kraken: Add common websocketAuthToken func for concurrent read access * Kraken: Only set authToken on mission success * Refactor: Adjust websocket authentication handling to use setWebsocketAuthToken method and rename wsAuthMu to wsAuthMtx for clarity --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
GoCryptoTrader package Exchanges
This exchanges package is part of the GoCryptoTrader codebase.
This is still in active development
You can track ideas, planned features and what's in progress on our GoCryptoTrader Kanban board.
Join our slack to discuss all things related to GoCryptoTrader! GoCryptoTrader Slack
Current Features for exchanges
-
This package is used to connect and query data from supported exchanges.
-
Please checkout individual exchange README for more information on implementation
Guide for adding a new exchange
- A guide on implementing API support for a new exchange can be found here
websocket notes
- If contributing websocket improvements, please make sure order reports follow these rules.
Please click GoDocs chevron above to view current GoDoc information for this package
Contribution
Please feel free to submit any pull requests or suggest any desired features to be added.
When submitting a PR, please abide by our coding guidelines:
- Code must adhere to the official Go formatting guidelines (i.e. uses gofmt).
- Code must be documented adhering to the official Go commentary guidelines.
- Code must adhere to our coding style.
- Pull requests need to be based on and opened against the
masterbranch.
Donations
If this framework helped you in any way, or you would like to support the developers working on it, please donate Bitcoin to:
bc1qk0jareu4jytc0cfrhr5wgshsq8282awpavfahc