mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-14 07:26:47 +00:00
229f965192
The channels for the ws multiplexer weren't made; so any interaction with it would block. Tests passed because they invasively setup the multiplexer. There are quite a few architectural risks with this implementation pattern, such as leaking an uncancellable goro in a for-select loop. Ideally WsConnect should take a cancellable context and any selects should watch for ctx.Done() That's a very invasive and pervasive change though, so this fix is as minimal and atomic as possible. Will consider opening a PR for cancellable context or improving this multiplexer pattern.
GoCryptoTrader package Exchanges
This exchanges package is part of the GoCryptoTrader codebase.
This is still in active development
You can track ideas, planned features and what's in progress on this Trello board: https://trello.com/b/ZAhMhpOy/gocryptotrader.
Join our slack to discuss all things related to GoCryptoTrader! GoCryptoTrader Slack
Current Features for exchanges
-
This package is used to connect and query data from supported exchanges.
-
Please checkout individual exchange README for more information on implementation
Guide for adding a new exchange
- A guide on implementing API support for a new exchange can be found here
websocket notes
- If contributing websocket improvements, please make sure order reports follow these rules.
Please click GoDocs chevron above to view current GoDoc information for this package
Contribution
Please feel free to submit any pull requests or suggest any desired features to be added.
When submitting a PR, please abide by our coding guidelines:
- Code must adhere to the official Go formatting guidelines (i.e. uses gofmt).
- Code must be documented adhering to the official Go commentary guidelines.
- Code must adhere to our coding style.
- Pull requests need to be based on and opened against the
masterbranch.
Donations
If this framework helped you in any way, or you would like to support the developers working on it, please donate Bitcoin to:
bc1qk0jareu4jytc0cfrhr5wgshsq8282awpavfahc