Commit Graph

831 Commits

Author SHA1 Message Date
Adrian Gallagher
7315e6604c Kraken: Add support for XTZ based pairs 2018-10-23 17:12:06 +11:00
cranktakular
8cbe99cf2f Telegram testing and race condition fix. (#195)
* Telegram testing and race condition fix.

Improving telegram Setup test
More coverage for telegram PushEvent test
Adding telegram HandleMessages test
Adding telegram GetUpdates test
Adding telegram TestConnection test
Adding telegram SendMessage test
(Hopefully) completely fixed race conditions with slack testing

* Adding testing to communications.go
2018-10-23 15:40:25 +11:00
Adrian Gallagher
d0f5f46c9d Exchanges: Don't set or update currencies when supplied with a nil array 2018-10-23 15:10:56 +11:00
Adrian Gallagher
a94d88debf Update config test code 2018-10-19 00:07:42 -07:00
Adrian Gallagher
c2c7032858 Add debug logger and default data directory support 2018-10-19 17:26:00 +11:00
cranktakular
415332b446 Slack.go improvements and increasing coverage (#193)
* Slack.go improvements and increasing converage

Slack.go Adding handling for trying to send responses when the websocket isn't connected
Slack.go Adding handling for an error response other than "Socket URL has expired"
Slack.go Making handleErrorResponse return an error
Slack.go Making use of s.Connected
Slack.go Making HandleMessage return an error
Slack.go Removing SendHTTPGetRequestSlack, code now calls SendHTTPGetRequest from common.go instead

More coverage for slack GetChannelsString test
More coverage for slack GetUsernameByID test
Improving slack GetIDByName test
Adding slack GetGroupIDByName test
Improving slack GetChannelIDByName test
More coverage for slack GetUsersInGroup test
Adding slack WebSocketConnect test
Adding slack handlePresenceChange test
Adding slack handleMessageResponse test
Adding slack handleErrorResponse test
Adding slack handleHelloResponse test
Adding slack handleReconnectResponse test
Adding slack WebsocketSend test
Adding slack HandleMessage test
Adding slack SendHTTPGetRequestSlack test

* Fixing race conditions and missing exclamation mark.
2018-10-18 17:33:24 +11:00
Adrian Gallagher
0c92ccfa21 config: don't warn user of limited APIKey level for default forex provider 2018-10-17 16:13:32 +11:00
cranktakular
f4766fb4dd Coinbase error fix, deleting nearly completely unused test file, other minor changes (#191) 2018-10-12 12:53:32 +11:00
Adrian Gallagher
58096b689c Fix TestSetAssetTypes 2018-10-11 16:18:02 +11:00
Adrian Gallagher
be561dd077 Periodic available pairs update for manual exchanges 2018-10-11 15:47:12 +11:00
Adrian Gallagher
9b85b431ab BTCMarkets: Add automatic available pair updates 2018-10-11 12:25:58 +11:00
cranktakular
7c21cb6f84 Common.go testing (#190)
* Common.go testing:
Improved GetHMAC test
Cut ByteArrayToString from common, already have a function that does the same thing
more coverage for SendHTTPRequest test
Improved SendHTTPGetRequest test
added JSONDecode test
added UnixMillis test
added RecvWindow test
added FloatFromString test
added IntFromString test
added Int64FromString test
added TestTimeFromUnixTimestampFloat test
2018-10-09 14:49:21 +11:00
Adrian Gallagher
f6bce891c4 Add additional helper functions to pairs package 2018-10-05 15:21:06 +10:00
Adrian Gallagher
9dd0474c7c Huobi Hadax no longer supports BTC-USDT; update API endpoints and config available/enabled pairs 2018-10-03 17:17:23 +10:00
herenow
604443fbbb Fix Huobi's POST requests (#186)
* Fix Huobi's POST request content-type

If we try to send a POST request to Huobi w/ a content-type of
"application/x-www-form-urlencoded" we will receive an error:

Content type 'application/x-www-form-urlencoded;charset=UTF-8' not supported

Their english documentation is incorrect, it does not specify this atm,
translating their chinese documentation, it states:

"Content-Type: application/json must be declared in the POST request header;
Content-Type: application/x-www-form-urlencoded must be declared in the GET
request header. (Chinese users recommend setting Accept-Language: zh-cn)"

* Fix Huobi's place new order request (send as json)

We should not send the order details through url parameters, this
needs to be sent as a json payload via the request body.

Documentation:

https://github.com/huobiapi/API_Docs_en/wiki/REST_Reference#post-v1orderordersplace--make-an-order-in-huobipro

* Fix Huobi's margin transfer/margin order/withdraw requests

This requests data need to be sent as json, not as a query string.

Docs:

https://github.com/huobiapi/API_Docs_en/wiki/REST_Reference#post-v1dwtransfer-inmargin--transfer-asset-from-spot-account-to-margin-account

https://github.com/huobiapi/API_Docs_en/wiki/REST_Reference#post-v1marginorders--margin-application

https://github.com/huobiapi/API_Docs_en/wiki/REST_Reference#post-v1dwwithdrawapicreate---create-a-withdraw-application

* Fix Huobi's margin repayment request

This request data needs to be sent a json, not via the query string.

Also note, that the "order-id" parameter is already sent through the
url path, it does not need to be included in the request body.
2018-10-03 10:58:32 +10:00
Adrian Gallagher
7186ac2602 Merge pull request #187 from thrasher-/test123
Fixes frontend security issues
2018-10-03 10:57:36 +10:00
Scott Grant
2d334a9faf Fixes security issues
Signed-off-by: Scott Grant <scott.grant@thrasher.io>
2018-10-02 16:03:29 +10:00
Adrian Gallagher
17d9e92550 Merge pull request #185 from herenow/chore/optional-auth-pem-key
Optional Huobi’s auth private key signature param
2018-09-30 12:16:16 +10:00
herenow
0fdf76d264 Optional Huobi’s auth private key signature param
This is a security feature that was introduced briefly, where you were
required to upload a public key while generating your api keys, and for
authentication you had to use your private keys to sign the request and
send it through this “PrivateSignature” param.

This security feature was rolled back and it is not mentioned anymore
in Huobi’s documentation.

For backwards compatibility purposes we should still keep this feature
though, they still seem to accept this parameter, I guess if you have
one of this old api keys, that was generated with a given public key,
you still have to send it.
2018-09-29 19:25:38 -03:00
Adrian Gallagher
a2c5123c9e gemini: ensure interface isn't nil because conversion 2018-09-26 13:39:19 +10:00
Adrian Gallagher
bdd1fa3cdf config consistency check to ensure an enabled pair is supported by the exchange 2018-09-21 16:25:27 +10:00
Adrian Gallagher
a1bd39ddac bitmex: supports auto pair updating 2018-09-21 16:22:17 +10:00
Adrian Gallagher
6aa0359060 bugfix: okex - fix authenticated path requests 2018-09-20 15:27:01 +10:00
Adrian Gallagher
96cbf90446 Remove non-needed getter functions for currency pairs
Fixes https://github.com/thrasher-/gocryptotrader/issues/180
2018-09-20 15:01:11 +10:00
Adrian Gallagher
042c4bfef2 bugfix: don't index or range over data if length is zero 2018-09-20 14:46:38 +10:00
soxipy
fb4e2d1452 localbitcoins fixes (#177)
* General LocalBitcoin fixes

* Added override variables to config for exchange packages to allow different API URL's
2018-08-27 14:19:29 +10:00
Ryan O'Hara-Reid
ca0c22f422 Merge pull request #169 from ermalguni/master
OKEX websocket
resolves #158
2018-08-27 10:11:19 +10:00
Adrian Gallagher
b656c23295 Merge pull request #175 from shazbert/unreachable_code_fix
Fixed unreachable code in websocket client front-end code
2018-08-17 10:45:32 +10:00
Ryan O'Hara-Reid
9918896923 Fixed unreachable code 2018-08-17 10:41:04 +10:00
Adrian Gallagher
cdb4df98e7 Merge pull request #174 from gloriousCode/master
Fix build errors, warnings, vulnerabilities, linting for front-end
2018-08-17 08:22:58 +10:00
GloriousCode
a03e85ebfd Removes commented out imports in polyfills.ts
Keeps structure for future potential use
2018-08-16 18:35:17 +10:00
GloriousCode
6c0ad602da Lint fixes 2018-08-16 17:32:25 +10:00
GloriousCode
bdcf87ab03 0 vulnerabilities 2018-08-16 08:58:14 +10:00
GloriousCode
d80b2c96b2 npm audit run
Removes npx
2018-08-16 08:44:32 +10:00
GloriousCode
0a20061cc2 more fixes 2018-08-16 07:53:19 +10:00
GloriousCode
f7bc2433dd Fixes build issues. Removes warnings. 2018-08-16 07:16:40 +10:00
Adrian Gallagher
a7ed69c843 Merge pull request #173 from marcofranssen/hotfix/lowercase-missed-configs
Hotfix/lowercase missed configs
2018-08-13 12:04:31 +10:00
Marco Franssen
18489f7a30 Added test for config/all json response 2018-08-10 16:05:20 +02:00
Marco Franssen
15d9a9fb88 Added missing type for exchangeName parameter 2018-08-10 16:05:20 +02:00
Marco Franssen
cbbad60e78 Lowercased the remaining config values for the config/all endpoint 2018-08-10 16:05:20 +02:00
GloriousCode
625d5f47f7 Adds SVG images of logo 2018-08-10 17:25:36 +10:00
Ermal Guni
07ef1406ce fixed merge conflicts 2018-08-09 23:46:37 +02:00
Ryan O'Hara-Reid
06a0caec43 Bitmex exchange (#160)
* Added REST support for Bitmex

* Added Bitmex documentation updates

* Update config_example.json

* Added final REST functions for user account operations.

* Added initial websocket support

* Change function access
Added reconnection logic

* Added initial routine management
Updated wrapper functions

* General fixes
2018-08-09 16:31:29 +10:00
Adrian Gallagher
a0de1b78a7 Support configurable HTTP user agent per exchange 2018-08-07 13:05:13 +10:00
soxipy
efc6c8d31e Kraken rework + localbitcoins fixes (#170)
* OpenPosition

* AddOrder

* strict json schema

* localbitcoins DashBoard

* specific txid for OpenPositions

* catch exchange (not http) errors

* exchange errors: more informative

* proper API error handling

* strict AddOrder params/options encoding/validating

* TradeVolume and CancelOrder

* QueryLedgers

* GetLedgers

* GetTradesHistory

* QueryTrades

* GetClosedOrders

* GetClosedOrders: strict params

* QueryOrdersInfo

* UserRef is int32 according to doc

* CancelOrder

* GetOpenOrders

* GetTradeBalance

* GetBalance

* GetAssetPairs

* GetAsset

* GetServerTime

* no need for GeneralResponse

* TestGetServerTime fix
2018-08-06 21:38:41 +10:00
Ryan O'Hara-Reid
391e81b00e Updated docs (#171) 2018-08-06 21:33:57 +10:00
Marco Franssen
6c2f6df875 Lowercase json to be more compliant with javascript coding standards (#163) 2018-08-06 21:33:25 +10:00
Ermal Guni
cc7caf1a32 contract_id json error conversion 2018-08-05 18:31:01 +02:00
Ermal Guni
7377dca9a9 okex config pairs fixes 2018-08-05 17:51:02 +02:00
Ermal Guni
a7baed25d6 okex pairs fixes 2018-08-05 17:46:44 +02:00