d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 23:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Huobi: Fix TestPairFromContractExpiryCode on CW (#1866)

Browse Source 
When testing CW against today, we were using a time.Now().Truncate() and
documentation says to not do that.

Driveby refactored the tz out of the loop
This commit is contained in:
Gareth Kirwan
2025-04-01 08:06:46 +02:00
committed by GitHub
parent f69abcd0ae
commit e3618e1a09
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
exchanges/huobi/huobi_test.go
View File

@@ -1827,7 +1827,12 @@ func TestPairFromContractExpiryCode(t *testing.T) {
_, err := h.FetchTradablePairs(context.Background(), asset.Futures)
require.NoError(t, err)
n := time.Now().Truncate(24 * time.Hour)
tz, err := time.LoadLocation("Asia/Singapore") // Huobi HQ and apparent local time for when codes become effective
require.NoError(t, err, "LoadLocation must not error")
n := time.Now()
n = time.Date(n.Year(), n.Month(), n.Day(), 0, 0, 0, 0, tz) // Do not use Truncate; https://github.com/golang/go/issues/55921
for _, cType := range contractExpiryNames {
p, err := h.pairFromContractExpiryCode(currency.Pair{
Base: currency.BTC,
@@ -1844,8 +1849,6 @@ func TestPairFromContractExpiryCode(t *testing.T) {
require.True(t, ok, "%s type must be in contractExpiryNames", cType)
assert.Equal(t, currency.BTC, p.Base, "pair Base should be the same")
assert.Equal(t, exp, p.Quote, "pair Quote should be the same")
tz, err := time.LoadLocation("Asia/Singapore") // Huobi HQ and apparent local time for when codes become effective
require.NoError(t, err, "LoadLocation must not error")
d, err := time.ParseInLocation("060102", p.Quote.String(), tz)
require.NoError(t, err, "currency code must be a parsable date")
require.Falsef(t, d.Before(n), "%s expiry must be today or after", cType)