d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-20 07:26:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

OKEX websocket: Fix test race condition (#258)

Browse Source
This commit is contained in:
Ryan O'Hara-Reid
2019-03-25 16:16:19 +11:00
committed by Adrian Gallagher
parent 052b5c2f28
commit c49cf18677
1 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
exchanges/okcoin/okcoin_test.go
View File

@@ -21,7 +21,7 @@ const (
canManipulateRealOrders = false
)
var o = OKCoin{}
var o OKCoin
var testSetupRan bool
var spotCurrency = currency.NewPairWithDelimiter(currency.BTC.String(), currency.USD.String(), "-").Lower().String()
@@ -34,18 +34,6 @@ func TestSetDefaults(t *testing.T) {
t.Errorf("Test Failed - %v - SetDefaults() error", OKGroupExchange)
}
TestSetup(t)
t.Parallel()
}
// TestSetWsDefaults Sets websocket defaults
func TestSetWsDefaults(t *testing.T) {
if o.Name != OKGroupExchange {
o.SetDefaults()
}
if o.GetName() != OKGroupExchange {
t.Errorf("Test Failed - %v - SetDefaults() error", OKGroupExchange)
}
TestSetup(t)
}
// TestSetRealOrderDefaults Sets test defaults when test can impact real money/orders
@@ -852,10 +840,8 @@ func TestWsLogin(t *testing.T) {
// TestSubscribeToChannel API endpoint test
func TestSubscribeToChannel(t *testing.T) {
defer disconnectFromWS()
TestSetWsDefaults(t)
TestSetDefaults(t)
if o.WebsocketConn == nil {
o.Websocket.Shutdown()
err := setupWSConnection()
if err != nil {
t.Error(err)
@@ -864,6 +850,7 @@ func TestSubscribeToChannel(t *testing.T) {
if !o.Websocket.IsConnected() {
t.Skip()
}
defer disconnectFromWS()
channelName := "spot/depth:LTC-BTC"
err := o.WsSubscribeToChannel(channelName)
if err != nil {
@@ -890,7 +877,7 @@ func TestSubscribeToChannel(t *testing.T) {
// Then captures the error response
func TestSubscribeToNonExistantChannel(t *testing.T) {
defer disconnectFromWS()
TestSetWsDefaults(t)
TestSetDefaults(t)
if o.WebsocketConn == nil {
o.Websocket.Shutdown()
err := setupWSConnection()