d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 15:09:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Backtester: Fix intermittent race condition in TestExecuteStrategy (#2080)

Browse Source 
* Initial plan

* Fix intermittent race condition in TestExecuteStrategy

Add synchronization point after async ExecuteStrategy call to wait for
background goroutine completion before resetting metadata. This prevents
the race condition where Stop() could be called after metadata reset,
causing errAlreadyRan instead of the expected errLiveOnly.

Co-authored-by: thrasher- <4685270+thrasher-@users.noreply.github.com>

* Use assert.Eventually instead of manual polling loop

Replace manual for-loop polling with assert.Eventually for cleaner
and more idiomatic test synchronization.

Co-authored-by: gloriousCode <9261323+gloriousCode@users.noreply.github.com>

* Use require.Eventually instead of assert.Eventually

Change to require.Eventually to ensure test stops immediately if the
async goroutine doesn't complete, preventing potential race conditions
from leaking into subsequent test assertions.

Co-authored-by: shazbert <9391715+shazbert@users.noreply.github.com>

* Change error message from "should" to "must"

Update assertion message to reflect mandatory nature of the condition
when using require.Eventually.

Co-authored-by: shazbert <9391715+shazbert@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thrasher- <4685270+thrasher-@users.noreply.github.com>
Co-authored-by: gloriousCode <9261323+gloriousCode@users.noreply.github.com>
Co-authored-by: shazbert <9391715+shazbert@users.noreply.github.com>
This commit is contained in:
Copilot
2025-10-16 13:49:16 +11:00
committed by GitHub
parent 3eb4c7fa92
commit 7134ea0393
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
backtester/engine/backtest_test.go
View File

@@ -1641,6 +1641,10 @@ func TestExecuteStrategy(t *testing.T) {
err = bt.ExecuteStrategy(false)
require.NoError(t, err)
// Wait for the async goroutine to complete before proceeding
// to avoid race condition where Stop() is called after we reset metadata
require.Eventually(t, bt.HasRan, time.Second, 10*time.Millisecond, "async goroutine must complete")
bt.m.Lock()
bt.MetaData.LiveTesting = true
bt.MetaData.DateStarted = time.Time{}