Engine: Driveby assertify apiserver_test (#1959)

This commit is contained in:
Gareth Kirwan
2025-07-17 07:47:37 +07:00
committed by GitHub
parent 3f534a15f1
commit 2a9b84931c

View File

@@ -46,9 +46,7 @@ func TestStartRESTServer(t *testing.T) {
m.remoteConfig.DeprecatedRPC.Enabled = true
err = m.StartRESTServer()
if err != nil {
t.Fatal(err)
}
assert.NoError(t, err)
}
func TestStartWebsocketServer(t *testing.T) {
@@ -124,83 +122,57 @@ func TestWebsocketStop(t *testing.T) {
func TestIsRESTServerRunning(t *testing.T) {
t.Parallel()
m := &apiServerManager{}
if m.IsRESTServerRunning() {
t.Error("expected false")
}
assert.False(t, m.IsRESTServerRunning(), "should return correctly with empty type")
m.restStarted = 1
if !m.IsRESTServerRunning() {
t.Error("expected true")
}
m = nil
if m.IsRESTServerRunning() {
t.Error("expected false")
}
assert.True(t, m.IsRESTServerRunning(), "should return correctly with restStarted set")
assert.False(t, (*apiServerManager)(nil).IsRESTServerRunning(), "should return correctly on nil type")
}
func TestIsWebsocketServerRunning(t *testing.T) {
t.Parallel()
m := &apiServerManager{}
if m.IsWebsocketServerRunning() {
t.Error("expected false")
}
assert.False(t, m.IsWebsocketServerRunning(), "should return correctly with empty type")
m.websocketStarted = 1
if !m.IsWebsocketServerRunning() {
t.Error("expected true")
}
m = nil
if m.IsWebsocketServerRunning() {
t.Error("expected false")
}
assert.True(t, m.IsWebsocketServerRunning(), "should return correctly with websocketStarted set")
assert.False(t, (*apiServerManager)(nil).IsWebsocketServerRunning(), "should return correctly on nil type")
}
func TestGetAllActiveOrderbooks(t *testing.T) {
man := NewExchangeManager()
bs, err := man.NewExchangeByName("Bitstamp")
if err != nil {
t.Fatal(err)
}
require.NoError(t, err, "NewExchangeByName must not error")
bs.SetDefaults()
err = man.Add(bs)
require.NoError(t, err)
resp := getAllActiveOrderbooks(man)
if resp == nil {
t.Error("expected not nil")
}
assert.NotNil(t, resp)
}
func TestGetAllActiveTickers(t *testing.T) {
t.Parallel()
man := NewExchangeManager()
bs, err := man.NewExchangeByName("Bitstamp")
if err != nil {
t.Fatal(err)
}
require.NoError(t, err, "NewExchangeByName must not error")
bs.SetDefaults()
err = man.Add(bs)
require.NoError(t, err)
resp := getAllActiveTickers(man)
if resp == nil {
t.Error("expected not nil")
}
assert.NotNil(t, resp)
}
func TestGetAllActiveAccounts(t *testing.T) {
t.Parallel()
man := NewExchangeManager()
bs, err := man.NewExchangeByName("Bitstamp")
if err != nil {
t.Fatal(err)
}
require.NoError(t, err, "NewExchangeByName must not error")
bs.SetDefaults()
err = man.Add(bs)
require.NoError(t, err)
resp := getAllActiveAccounts(man)
if resp == nil {
t.Error("expected not nil")
}
assert.NotNil(t, resp)
}
func makeHTTPGetRequest(t *testing.T, response any) *http.Response {
@@ -208,9 +180,8 @@ func makeHTTPGetRequest(t *testing.T, response any) *http.Response {
w := httptest.NewRecorder()
err := writeResponse(w, response)
if err != nil {
t.Error("Failed to make response.", err)
}
require.NoError(t, err)
return w.Result()
}