d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 23:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Kucoin: Fix failing TestSubscribeBatchLimit (#1884)

Browse Source 
This test ensures we have eyes on what the subscription limit per
session is.
They've increased it from 300 to 400.

I think when I first did this, the code actually needed to know, but
it's still useful to ensure we know exactly where it sits.
This commit is contained in:
Gareth Kirwan
2025-04-10 08:45:04 +02:00
committed by GitHub
parent b4e45e9a1b
commit 19b42c80aa
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
exchanges/kucoin/kucoin_test.go
View File

@@ -3020,11 +3020,13 @@ func TestSubscribeBatches(t *testing.T) {
// TestSubscribeTickerAll ensures that ticker subscriptions switch to using all and it works
// TestSubscribeBatchLimit exercises the kucoin batch limits of 300 per connection
// Ensures batching of 100 pairs and the connection symbol limit is still 300 at Kucoin's end
// TestSubscribeBatchLimit exercises the kucoin batch limits of 400 per connection
// Ensures batching of 100 pairs and the connection symbol limit is still 400 at Kucoin's end
func TestSubscribeBatchLimit(t *testing.T) {
t.Parallel()
const expectedLimit = 400
ku := testInstance(t) //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
ku.Features.Subscriptions = subscription.List{}
testexch.SetupWs(t, ku)
@@ -3032,13 +3034,13 @@ func TestSubscribeBatchLimit(t *testing.T) {
avail, err := ku.GetAvailablePairs(asset.Spot)
require.NoError(t, err, "GetAvailablePairs must not error")
err = ku.CurrencyPairs.StorePairs(asset.Spot, avail[:299], true)
err = ku.CurrencyPairs.StorePairs(asset.Spot, avail[:expectedLimit], true)
require.NoError(t, err, "StorePairs must not error")
ku.Features.Subscriptions = subscription.List{{Asset: asset.Spot, Channel: subscription.AllTradesChannel}}
subs, err := ku.generateSubscriptions()
require.NoError(t, err, "generateSubscriptions must not error")
require.Len(t, subs, 3, "Must get 3 subs")
require.Len(t, subs, 4, "Must get 4 subs")
err = ku.Subscribe(subs)
require.NoError(t, err, "Subscribe must not error")
@@ -3046,16 +3048,17 @@ func TestSubscribeBatchLimit(t *testing.T) {
err = ku.Unsubscribe(subs)
require.NoError(t, err, "Unsubscribe must not error")
err = ku.CurrencyPairs.StorePairs(asset.Spot, avail[:320], true)
err = ku.CurrencyPairs.StorePairs(asset.Spot, avail[:expectedLimit+20], true)
require.NoError(t, err, "StorePairs must not error")
ku.Features.Subscriptions = subscription.List{{Asset: asset.Spot, Channel: subscription.AllTradesChannel}}
subs, err = ku.generateSubscriptions()
require.NoError(t, err, "generateSubscriptions must not error")
require.Len(t, subs, 4, "Must get 4 subs")
require.Len(t, subs, 5, "Must get 5 subs")
err = ku.Subscribe(subs)
assert.ErrorContains(t, err, "exceed max subscription count limitation of 300 per session", "Subscribe to MarketSnapshot should error above connection symbol limit")
require.Error(t, err, "Subscribe must error")
assert.ErrorContains(t, err, "exceed max subscription count limitation of 400 per session", "Subscribe to MarketSnapshot should error above connection symbol limit")
}
func TestSubscribeTickerAll(t *testing.T) {