Tests: Replace space with dash in header name

Node.js has forbidden header names with spaces in
6192c9892f.

The next error is thrown when the test sets the "some header" header:
Uncaught TypeError: Header name must be a valid HTTP Token ["some header"]

To fix it, replace spaces with dashes.
This commit is contained in:
Rob Wu
2016-02-19 00:32:37 +01:00
parent 8568c06b17
commit bbe3378c35
3 changed files with 6 additions and 6 deletions

View File

@@ -49,7 +49,7 @@ nock('http://example.com')
.get('/redirecttarget')
.reply(200, 'redirect target', {
'Some header': 'value'
'Some-header': 'value'
})
.head('/redirect')

View File

@@ -59,7 +59,7 @@ describe('memory usage', function() {
cors_api_url + 'http://127.0.0.1:' + server.address().port);
request.agent = false; // Force Connection: Close
request.headers = {
'Long header': new Array(requestSize * 1e3).join('x'),
'Long-header': new Array(requestSize * 1e3).join('x'),
};
(function requestAgain() {
if (remaining-- === 0) {

View File

@@ -142,11 +142,11 @@ describe('Basic functionality', function() {
.head('/example.com/redirect')
.redirects(0)
.expect('Access-Control-Allow-Origin', '*')
.expect('some header', 'value')
.expect('some-header', 'value')
.expect('x-request-url', 'http://example.com/redirect')
.expect('x-cors-redirect-1', '302 http://example.com/redirecttarget')
.expect('x-final-url', 'http://example.com/redirecttarget')
.expect('access-control-expose-headers', /some header,x-final-url/)
.expect('access-control-expose-headers', /some-header,x-final-url/)
.expectNoHeader('header at redirect')
.expect(200, '', done);
});
@@ -156,11 +156,11 @@ describe('Basic functionality', function() {
.get('/example.com/redirect')
.redirects(0)
.expect('Access-Control-Allow-Origin', '*')
.expect('some header', 'value')
.expect('some-header', 'value')
.expect('x-request-url', 'http://example.com/redirect')
.expect('x-cors-redirect-1', '302 http://example.com/redirecttarget')
.expect('x-final-url', 'http://example.com/redirecttarget')
.expect('access-control-expose-headers', /some header,x-final-url/)
.expect('access-control-expose-headers', /some-header,x-final-url/)
.expectNoHeader('header at redirect')
.expect(200, 'redirect target', done);
});