mirror of
https://github.com/instructkr/claude-code.git
synced 2026-05-25 15:06:44 +00:00
Compare commits
1 Commits
docs/roadm
...
docs/roadm
| Author | SHA1 | Date | |
|---|---|---|---|
|
536295d0e4 |
119
ROADMAP.md
119
ROADMAP.md
@@ -6429,93 +6429,62 @@ Original filing (2026-04-18): the session emitted `SessionStart hook (completed)
|
||||
|
||||
450. **`prompt` emits `kind:"missing_credentials"` JSON on STDERR (not stdout), leaving stdout at 0 bytes — automation pattern `output=$(claw prompt hello --output-format json)` captures nothing on auth-absent failure; `doctor` correctly surfaces `auth.status:"warn"` with `api_key_present:false` but exposes no `prompt_ready:false` field that automation can check before invoking `prompt`** — dogfooded 2026-05-16 by Jobdori on `a35ee9a0` in response to Clawhip pinpoint nudge at `1505208225321062521`. Exact reproduction (isolated env, no creds, fresh git repo, HEAD `a35ee9a0`): `timeout 5 env -i HOME=$ISOLATED_HOME PATH=$PATH CLAW_CONFIG_HOME=$PROBE/.claw-cfg claw prompt hello --output-format json > stdout.txt 2> stderr.txt` → stdout = **0 bytes**, stderr = 195 bytes containing `{"error":"missing Anthropic credentials…","exit_code":1,"hint":null,"kind":"missing_credentials","type":"error"}`, exit code 1. Confirms Gaebal's `1505208553793781792` pinpoint that `prompt` timeout + zero bytes was the prior state — HEAD `a35ee9a0` now correctly exits 1 with `kind:"missing_credentials"` **but the envelope is still routed to stderr** (issue #447 class, same class as prior entries #422, #435). **Contrast with `doctor`:** `claw doctor --output-format json 2>/dev/null` succeeds to stdout with `checks[auth].status:"warn"`, `api_key_present:false`, `auth_token_present:false` — but the auth check has no `prompt_ready:false` field. Automation that gates on `doctor` before invoking `prompt` must re-derive readiness from `api_key_present && auth_token_present` — there is no single canonical boolean. **Three compound problems:** (a) **stdout-empty on `--output-format json` failure**: same class as #447; `prompt`'s error envelope goes to stderr, not stdout. The canonical automation idiom `if ! result=$(claw prompt "q" --output-format json); then echo "$result" | jq .kind; fi` sees `$result=""` on failure — the jq call gets nothing. All `--output-format json` error paths must route JSON to stdout per #447 contract; (b) **`doctor` missing `prompt_ready` field**: `doctor --output-format json` already knows auth is absent (`api_key_present:false`) but surfaces no derived `prompt_ready:bool` or `prompt_blocked_reason:string` field. Automation must infer readiness from `api_key_present || auth_token_present || legacy_*_present` — a 5-field OR across legacy fields that is fragile as auth mechanisms evolve. A single `prompt_ready:false` (with `prompt_blocked_reason:"auth_missing"`) inside the `auth` check would give downstream a stable contract; (c) **`claw prompt` with no auth does no preflight and fires straight at the API**: the preflight check that `doctor` runs (auth discovery) is not reused by `prompt` to emit a fast typed error before attempting the network call. Both Gaebal's pinpoint (prompt hanging silently on older HEAD) and the current behavior (prompt hitting auth gate after a brief API attempt) stem from the same root: prompt does not short-circuit at the point where `doctor` already knows auth is absent. If `doctor` can emit `kind:"doctor"` with `auth.status:"warn"` in ~20ms without a network call, `prompt` should emit `kind:"missing_credentials"` in the same window and output it to stdout. **Required fix shape:** (a) `prompt --output-format json` must write the `kind:"missing_credentials"` JSON envelope to **stdout**, not stderr — same fix as #447 for all error envelopes; (b) add `prompt_ready:bool` and `prompt_blocked_reason:string|null` to the `auth` check in `doctor --output-format json`; derive it as `api_key_present || auth_token_present || legacy_saved_oauth_present`; (c) `prompt` must run the credential preflight check (same codepath as doctor's auth check) before attempting any API call and emit `{"kind":"missing_credentials","prompt_blocked_reason":"auth_missing"}` on **stdout** with exit 1 if the check fails; (d) `--output-format json` stdout routing fix must cover: `prompt`, `session list` (cross-ref #449), `skills uninstall` (cross-ref #431), `resume` (cross-ref #435), `acp serve` (cross-ref #443) — the full `kind:"missing_credentials"` class; (e) regression test: `claw prompt hello --output-format json` with no creds writes JSON to stdout (0 bytes stderr), exits 1, `kind:"missing_credentials"`, in under 200ms (no network attempt). **Why this matters:** `prompt` is the primary consumer entry point. Auth-absent failure routing to stderr breaks every automation wrapper that captures `$(claw prompt ... --output-format json)`. The `doctor` preflight metadata gap means auth-readiness checks require parsing 5 legacy fields instead of reading one boolean. Cross-references #447 (all JSON error envelopes on stderr), #449 (session list hits auth gate), #431 (skills uninstall hits auth gate), #357 (auth gate on local ops cluster), #422 (exit-code parity). Source: Jobdori live dogfood, `a35ee9a0`, 2026-05-16.
|
||||
|
||||
465. **`claw doctor` / `claw status` auth diagnostics report only `api_key_present` and `auth_token_present` booleans, but omit the *effective auth source* / header behavior when BOTH `ANTHROPIC_API_KEY` and `ANTHROPIC_AUTH_TOKEN` are set. The runtime resolves this state to `AuthSource::ApiKeyAndBearer` and sends both `x-api-key` and `Authorization: Bearer`, while the health surface simply says `status: ok` / `supported auth env vars are configured` with no `effective_auth_source`, no `headers_sent`, no precedence warning, and no “both configured” diagnostic. This reopens the exact auth-intent ambiguity #28 fixed for single-wrong-env cases, but in the mixed-env case where the request path is now different and the doctor surface is silent** — dogfooded 2026-05-24 across the 15:00–16:30 Clawhip nudge window (finalized for message `1508145078760378418`), reproduced on local `./rust/target/debug/claw` `git_sha 003b739d` (origin/main `f8e1bb72`) in a clean isolated env.
|
||||
|
||||
Reproduction:
|
||||
463. **Removed subcommands (`claw login`, `claw logout`) emit a hard-coded error sentinel that `classify_error_kind` then mis-buckets as `kind: "unknown"` instead of a typed `removed_subcommand` (or equivalent) kind, AND the `hint` field is `null` while the actual hint (`Set ANTHROPIC_API_KEY or ANTHROPIC_AUTH_TOKEN instead`) is jammed into the same single-line `error` string — so a CI claw that branches on `kind` cannot distinguish "you typed a removed command" from "we have no idea what happened," and a claw that reads `hint` to suggest remediation gets `null` even though the remediation text exists verbatim in the same envelope** — dogfooded 2026-05-24 for the 13:30 Clawhip pinpoint nudge at message `1508099780230906027`, reproduced on local `./rust/target/debug/claw` `git_sha 003b739d` (origin/main `f8e1bb72`). Live envelope from clean isolated env (`HOME=/tmp/iso19/home`, fresh `/tmp/iso19/proj` git init):
|
||||
|
||||
```bash
|
||||
$ env -i HOME=/tmp/iso23/home \
|
||||
ANTHROPIC_API_KEY=sk-ant-fake-apikey-BOTH \
|
||||
ANTHROPIC_AUTH_TOKEN=oauth-fake-bearer-BOTH \
|
||||
PATH=/usr/bin:/bin TERM=dumb \
|
||||
claw doctor --output-format json | jq '.checks[] | select(.name=="auth")'
|
||||
{
|
||||
"api_key_present": true,
|
||||
"auth_token_present": true,
|
||||
"details": [
|
||||
"Environment api_key=present auth_token=present"
|
||||
],
|
||||
"legacy_refresh_token_present": false,
|
||||
"legacy_saved_oauth_expires_at": null,
|
||||
"legacy_saved_oauth_present": false,
|
||||
"legacy_scopes": [],
|
||||
"name": "auth",
|
||||
"status": "ok",
|
||||
"summary": "supported auth env vars are configured"
|
||||
$ env -i HOME=/tmp/iso19/home PATH=/usr/bin:/bin TERM=dumb claw login --output-format json
|
||||
{"error":"`claw login` has been removed. Set ANTHROPIC_API_KEY or ANTHROPIC_AUTH_TOKEN instead.","hint":null,"kind":"unknown","type":"error"}
|
||||
|
||||
$ env -i HOME=/tmp/iso19/home PATH=/usr/bin:/bin TERM=dumb claw logout --output-format json
|
||||
{"error":"`claw logout` has been removed. Set ANTHROPIC_API_KEY or ANTHROPIC_AUTH_TOKEN instead.","hint":null,"kind":"unknown","type":"error"}
|
||||
```
|
||||
|
||||
Cross-input comparison (the classifier triple-inconsistency):
|
||||
|
||||
| Input | exit | `kind` | `hint` | What actually happened |
|
||||
|---|---|---|---|---|
|
||||
| `xyznotreal` (truly unknown) | 1 | `missing_credentials` | null | **Fell through to LLM-prompt path, billed-token risk** (covered by #108) |
|
||||
| `totally-fake-cmd` | 1 | `missing_credentials` | null | Same fallthrough as above |
|
||||
| `login` (removed) | 1 | **`unknown`** | **null** | Intercepted (good), wrong-kinded + hint discarded (this pinpoint) |
|
||||
| `logout` (removed) | 1 | **`unknown`** | **null** | Same as login |
|
||||
| `plugins` (formerly #78) | 0 | (works now) | — | Pre-grep confirmed #78 has been wired |
|
||||
|
||||
**Root cause traced:** `rust/crates/rusty-claude-cli/src/main.rs:951` returns the sentinel string from `removed_auth_surface_error()`:
|
||||
|
||||
```rust
|
||||
"login" | "logout" => Err(removed_auth_surface_error(rest[0].as_str())),
|
||||
```
|
||||
|
||||
Where `removed_auth_surface_error` at `main.rs:1150-1154` is:
|
||||
|
||||
```rust
|
||||
fn removed_auth_surface_error(command_name: &str) -> String {
|
||||
format!(
|
||||
"`claw {command_name}` has been removed. Set ANTHROPIC_API_KEY or ANTHROPIC_AUTH_TOKEN instead."
|
||||
)
|
||||
}
|
||||
```
|
||||
|
||||
Text mode says the same thing:
|
||||
|
||||
```
|
||||
Auth
|
||||
Status ok
|
||||
Summary supported auth env vars are configured
|
||||
Details
|
||||
- Environment api_key=present auth_token=present
|
||||
```
|
||||
|
||||
No field answers the operational question: **what auth mode will the actual request use?** The answer exists in runtime code but is not surfaced.
|
||||
|
||||
**Root cause traced:** `rust/crates/api/src/providers/anthropic.rs:656-666`:
|
||||
The single-line string then flows through `classify_error_kind` at `main.rs:253-286`:
|
||||
|
||||
```rust
|
||||
pub fn resolve_startup_auth_source<F>(load_oauth_config: F) -> Result<AuthSource, ApiError>
|
||||
where
|
||||
F: FnOnce() -> Result<Option<OAuthConfig>, ApiError>,
|
||||
{
|
||||
let _ = load_oauth_config;
|
||||
if let Some(api_key) = read_env_non_empty("ANTHROPIC_API_KEY")? {
|
||||
return match read_env_non_empty("ANTHROPIC_AUTH_TOKEN")? {
|
||||
Some(bearer_token) => Ok(AuthSource::ApiKeyAndBearer {
|
||||
api_key,
|
||||
bearer_token,
|
||||
}),
|
||||
None => Ok(AuthSource::ApiKey(api_key)),
|
||||
};
|
||||
}
|
||||
if let Some(bearer_token) = read_env_non_empty("ANTHROPIC_AUTH_TOKEN")? {
|
||||
return Ok(AuthSource::BearerToken(bearer_token));
|
||||
}
|
||||
Err(anthropic_missing_credentials())
|
||||
fn classify_error_kind(message: &str) -> &'static str {
|
||||
if message.contains("missing Anthropic credentials") { "missing_credentials" }
|
||||
else if message.contains("Manifest source files are missing") { "missing_manifests" }
|
||||
// ... 11 more specific patterns ...
|
||||
else { "unknown" }
|
||||
}
|
||||
```
|
||||
|
||||
And `anthropic.rs:952-954` documents the wire behavior in the 401 hint logic:
|
||||
The classifier has 13 explicit kinds; `has been removed` matches none → falls to `"unknown"`. And `split_error_hint` at `main.rs:290-295` splits on `\n` only — since the sentinel is one line, `hint` is always `None` even though everything after the first sentence IS the hint.
|
||||
|
||||
**Verification grep:** `grep -nE 'removed_subcommand|"removed"' rust/crates/rusty-claude-cli/src/main.rs` returns zero hits. The only test coverage for the removed subcommands is `main.rs:11793-11794`:
|
||||
|
||||
```rust
|
||||
// Only append the hint when the AuthSource is pure BearerToken. If both
|
||||
// api_key and bearer_token are present (`ApiKeyAndBearer`), the x-api-key
|
||||
// header is already being sent alongside the Bearer header ...
|
||||
assert!(!help.contains("claw login"));
|
||||
assert!(!help.contains("claw logout"));
|
||||
```
|
||||
|
||||
So the actual effective runtime state is **not** merely “two booleans true.” It is a third mode: `ApiKeyAndBearer`, with two headers sent. But `check_auth_health()` in `rust/crates/rusty-claude-cli/src/main.rs:2071-2150` only computes:
|
||||
Both assertions test `--help` text negative-presence only. No test asserts the error-envelope shape on actual `claw login` / `claw logout` invocation.
|
||||
|
||||
```rust
|
||||
let api_key_present = env::var("ANTHROPIC_API_KEY").ok().is_some_and(|value| !value.trim().is_empty());
|
||||
let auth_token_present = env::var("ANTHROPIC_AUTH_TOKEN").ok().is_some_and(|value| !value.trim().is_empty());
|
||||
// ... summary = "supported auth env vars are configured"
|
||||
.with_data(Map::from_iter([
|
||||
("api_key_present".to_string(), json!(api_key_present)),
|
||||
("auth_token_present".to_string(), json!(auth_token_present)),
|
||||
...
|
||||
]))
|
||||
```
|
||||
|
||||
It never calls or mirrors `resolve_startup_auth_source`, never emits `effective_auth_source`, and never warns when both mutually-confusing auth knobs are present.
|
||||
|
||||
**Why distinct from existing items:** ROADMAP **#28** fixed single-env-var auth copy: adjacent provider hints, `sk-ant-*` in `ANTHROPIC_AUTH_TOKEN` correction, and docs explaining `x-api-key` vs `Authorization: Bearer`. This pinpoint is the **mixed-env state** after #28: both env vars present, runtime sends both headers, and the doctor/status surface does not tell operators that a combined mode exists. ROADMAP **#37** removed `claw login` / `logout` and told users to set env vars instead; this entry shows the two official env vars can now be set together with no health warning or effective-source disclosure. ROADMAP **#463** covers removed-subcommand envelope kind/hint shape; same auth area but different surface. ROADMAP **#248** asks prompt lifecycle events to include auth source category during non-interactive runs; this entry is the local preflight counterpart: doctor/status should expose auth source before any prompt/API call. **None** of those items record that `doctor` reports “ok” for both official auth vars while hiding the `ApiKeyAndBearer` runtime mode.
|
||||
|
||||
**Why this matters:** (1) **Real users already confuse these two env vars.** #28 was filed because `sk-ant-*` keys in `ANTHROPIC_AUTH_TOKEN` produce bearer-header 401s. The mixed state (`ANTHROPIC_API_KEY` + stale/wrong `ANTHROPIC_AUTH_TOKEN`) is the natural next failure mode after users “try both.” (2) **The request sends both headers.** Whether Anthropic prioritizes `x-api-key`, bearer token, or rejects/confuses the pair is provider behavior; claw should not leave this invisible. (3) **`doctor` is supposed to be preflight truth.** It currently says `ok` and “supported auth env vars are configured,” which sounds healthier than the simpler single-key case, even though the operator may have two conflicting credentials. (4) **Automation cannot decide remediation.** A claw reading booleans cannot know whether to ask the user to unset `ANTHROPIC_AUTH_TOKEN`, unset `ANTHROPIC_API_KEY`, or leave both. A field like `effective_auth_source: "api_key_and_bearer"` plus `headers: ["x-api-key", "authorization_bearer"]` would make that deterministic. (5) **The runtime truth already exists.** `resolve_startup_auth_source` computes the exact enum; the diagnostic layer just reimplements a weaker boolean-only approximation.
|
||||
|
||||
**Required fix shape:** (a) Make `check_auth_health()` call the same auth-source resolver (or a shared redaction-safe helper) used by runtime startup, so diagnostics cannot drift from actual request behavior. (b) Add structured fields to the auth check JSON: `effective_auth_source: "api_key" | "bearer_token" | "api_key_and_bearer" | "none"`, `headers_sent: ["x-api-key", "authorization_bearer"]` (names only, no secrets), and `both_anthropic_auth_env_vars_present: bool`. (c) When both are present, downgrade auth check from `ok` to at least `warn` unless product policy explicitly supports sending both; summary should say `both ANTHROPIC_API_KEY and ANTHROPIC_AUTH_TOKEN are set; requests will send both x-api-key and bearer headers` with a hint to unset the stale/wrong one. (d) Mirror these fields into `status --output-format json`, not only `doctor`, because status is the lightweight preflight surface. (e) Add regression coverage for four states: none, API key only, bearer only, both. Assert the “both” state is not boolean-only and carries the combined-mode warning. **Acceptance check:** with both env vars set, `claw doctor --output-format json | jq -e '.checks[] | select(.name=="auth") | .effective_auth_source == "api_key_and_bearer" and (.headers_sent | index("x-api-key") and index("authorization_bearer")) and .status == "warn"'` should pass. Source: gaebal-gajae dogfood for 2026-05-24 15:00–16:30 Clawhip nudges; investigation was interrupted by subsequent nudge ticks, then finalized at 16:30 with code trace and ROADMAP entry. Coordination note: intentionally avoided F/CLAW_CONFIG_HOME because Jobdori publicly queued it as “next confirmed but unfiled”; this auth-precedence surface is orthogonal.
|
||||
**Why distinct from existing items:** ROADMAP **#37** (DONE) covered the removal POLICY (Claude-subscription login flow taken out, OAuth fallback ignored, slash commands removed, docs updated). #37 explicitly does NOT discuss the *error envelope shape* of the sentinel — only that the surface is removed. ROADMAP **#108** covers truly-unknown subcommand typos falling through to LLM-prompt dispatch with `kind:missing_credentials` — different code path (`_other => CliAction::Prompt`), different misclassification, different fix. ROADMAP **#109** covers config-loader warnings flattened to stderr prose (loader-side prose-vs-structure gap). ROADMAP **#77** introduced `classify_error_kind` and `split_error_hint` (the very functions this entry pinpoints) — and added 13 specific kinds for THEN-existing error sentinels, but the `removed_auth_surface_error` sentinel added under #37 was never registered with the classifier #77 built. **None** of these existing entries address the specific "removed subcommand sentinel + classifier inconsistency + hint field discarded" triple. **Why this matters:** (1) **CI fingerprinting breakage.** A claw that runs `if claw $cmd --output-format json | jq -e '.kind == "unknown"'` to decide "unrecoverable, escalate to human" treats `claw login` typos identically to genuine internal errors — bad escalation triage. A claw that branches on `kind == "removed_subcommand"` for a graceful migration prompt has no way to distinguish today. (2) **Hint field discarded** is the same anti-pattern as `build_date` (#462), `memory_files[]` (#459), `missing_credentials.hint` (#455), `init.artifacts[]` (#79), `status.panes[]` (#326), `version.build_date` (#462). The structured field exists, the data exists, the wiring is one line, the envelope drops it. (3) **Classifier completeness debt.** The `classify_error_kind` function is the authoritative `kind` taxonomy. Every new error sentinel added anywhere in the codebase must register here or fall to `"unknown"`. There is no compile-time check enforcing this. A grep against new `Err(format!(...))` and `Err("...".into())` sites would surface the gap. **#37 + #77 is the first known instance of the orphan-sentinel pattern;** the same drift likely affects newer sentinels too (e.g., ACP unsupported invocation, MCP unsupported config-key, etc. — none verified yet, but worth a sweep). (4) **Asymmetric remediation guidance.** The error string DOES contain the remediation. A human reading prose sees it. A machine reading the dedicated `hint` field gets `null`. The information exists; the envelope just discards it. **Required fix shape:** (a) **Introduce structured sentinel emission for removed subcommands.** Replace `Err(removed_auth_surface_error(...))` at `main.rs:951` with a typed error variant carrying `kind: RemovedSubcommand { name, replacement_env_vars: Vec<&str> }` so the JSON layer can serialize a structured `{"kind": "removed_subcommand", "subcommand": "login", "replacement": "Set ANTHROPIC_API_KEY or ANTHROPIC_AUTH_TOKEN instead.", "hint": "Set ANTHROPIC_API_KEY or ANTHROPIC_AUTH_TOKEN instead.", ...}` envelope without relying on string-contains classification. (b) **Add `"removed_subcommand"` to `classify_error_kind` taxonomy** as a defensive fallback for any other code path that may surface the sentinel as a String; key on `"has been removed"` substring. (c) **Make `removed_auth_surface_error` emit a two-line string** with the actionable advice on line 2 so `split_error_hint` populates `hint` non-null even on the string-only path. (d) **Add envelope-shape regression tests:** `output_format_contract.rs` should assert `claw login --output-format json` produces `{"kind": "removed_subcommand", "hint": <non-null string>, ...}` and `claw logout --output-format json` mirrors it; current asserts only test `--help` text. (e) **Sweep for other orphan sentinels.** Run `grep -rnE 'Err\(format!|Err\("' rust/crates/rusty-claude-cli/src/` and cross-check every match against `classify_error_kind` — file follow-up entries for any sentinel that lands in `"unknown"`. **Acceptance check (one-liner):** `claw login --output-format json 2>&1 | jq -e '.kind == "removed_subcommand" and (.hint | type == "string")'` should print `true` (currently `.kind == "unknown"` and `.hint == null` → exit 1). Source: gaebal-gajae dogfood for the 2026-05-24 13:30 Clawhip pinpoint nudge at message `1508099780230906027`. Pre-grep gate filtered 9 hypotheses down to 3 fresh (E=login/logout envelope, F=CLAW_CONFIG_HOME validation, G=skills empty envelope); F deferred to a later tick because it spans 5 distinct silent-failure modes that warrant their own consolidated entry; G confirmed working correctly (no pinpoint). E selected as the tightest single-function fix with the most concrete CI-impact angle.
|
||||
|
||||
Reference in New Issue
Block a user