Compare commits

..

1 Commits

3 changed files with 8 additions and 72 deletions

View File

@@ -6301,4 +6301,10 @@ Original filing (2026-04-18): the session emitted `SessionStart hook (completed)
380. **Top-level `tokens --help --output-format json` hangs with zero stdout/stderr instead of returning bounded command help JSON** — dogfooded 2026-04-30 for the 02:30 nudge on current `origin/main` / rebuilt `./rust/target/debug/claw` with embedded `git_sha` `d95b230c`. After verifying #358 covered `cost --help`, a fresh adjacent probe on the token-budget surface showed the same silent failure class: repeated bounded runs of `timeout 8 ./rust/target/debug/claw tokens --help --output-format json` exited `124` with `stdout=0` and `stderr=0`. In the same rebuilt binary, `version --output-format json` returned promptly with version/build metadata, proving the binary itself and JSON output path are reachable. This is distinct from #358's cost help hang: the affected surface is the sibling `tokens` command help, which agents use before estimating prompt/session token budgets. **Required fix shape:** (a) make `tokens --help --output-format json` return static/bounded stdout JSON with `kind:"help"` or `kind:"tokens"`, `action:"help"`, usage, options, examples, supported output formats, and related slash/direct commands; (b) ensure help rendering does not initialize slow token accounting, session, or provider state; (c) if any dynamic provider is consulted, return a typed JSON timeout/unavailable error instead of hanging; (d) add regression coverage proving tokens help in JSON mode returns within a deterministic budget. **Why this matters:** token budgeting is a preflight clawability surface. If help hangs silently, automation cannot safely discover how to inspect or constrain token usage before running expensive prompts, and budget-aware wrappers stall at the discovery step. Source: gaebal-gajae dogfood follow-up for the 02:30 nudge on rebuilt `./rust/target/debug/claw` `d95b230c`.
381. **Top-level `cache --help --output-format json` hangs with zero stdout/stderr instead of returning bounded command help JSON** — dogfooded 2026-04-30 for the 03:00 nudge on current `origin/main` / rebuilt `./rust/target/debug/claw` with embedded `git_sha` `d95b230c`. After #358 and #380 landed for the cost/tokens preflight help hangs, a fresh adjacent probe on the cache-control surface showed the same silent failure class: repeated bounded runs of `timeout --kill-after=1s 8s ./rust/target/debug/claw cache --help --output-format json` exited `124` with `stdout=0` and `stderr=0`. In the same rebuilt binary, `version --output-format json` returned promptly with version/build metadata, proving the binary itself and JSON output path are reachable. This is distinct from the separate `/cache` slash-command envelope mismatch class: the affected surface here is top-level `cache` command help, where agents need bounded local discovery before deciding whether to inspect, clear, or summarize cache state. **Required fix shape:** (a) make `cache --help --output-format json` return static/bounded stdout JSON with `kind:"help"` or `kind:"cache"`, `action:"help"`, usage, options, examples, supported output formats, and related slash/direct commands; (b) ensure help rendering does not initialize slow cache/session/provider state; (c) if any dynamic provider is consulted, return a typed JSON timeout/unavailable error instead of hanging; (d) add regression coverage proving cache help in JSON mode returns within a deterministic budget. **Why this matters:** cache inspection and cleanup are recovery/control-plane operations. If cache help hangs silently, claws cannot safely discover cache semantics before attempting cleanup, and automation stalls before it can choose a non-destructive cache action. Source: gaebal-gajae dogfood follow-up for the 03:00 nudge on rebuilt `./rust/target/debug/claw` `d95b230c`.
422. **`export --output-format json` and `--resume latest` report the same "no managed sessions" scenario using two different `kind` codes — `no_managed_sessions` vs `session_load_failed` — making "no session found" undetectable by a single kind-code check** — dogfooded 2026-04-30 KST (UTC+9) by Jobdori on `e939777f`. Running `claw export --output-format json` with no session present returns (on stderr, exit 1): `{"error":"no managed sessions found in .claw/sessions/<fingerprint>/","hint":"Start \`claw\` to create a session, then rerun with \`--resume latest\`.\nNote: claw partitions sessions per workspace fingerprint; sessions from other CWDs are invisible.","kind":"no_managed_sessions","type":"error"}`. Running `claw --resume latest /status --output-format json` with no session present returns (on stderr, exit 1): `{"error":"failed to restore session: no managed sessions found in .claw/sessions/<fingerprint>/","hint":"Start \`claw\` to create a session, then rerun with \`--resume latest\`.\nNote: claw partitions sessions per workspace fingerprint; sessions from other CWDs are invisible.","kind":"session_load_failed","type":"error"}`. Both describe the same root condition — there are no sessions to operate on — but they expose it via different `kind` discriminants. Automation that checks `kind == "no_managed_sessions"` to detect a cold workspace will miss the `--resume` path's `session_load_failed`, and vice versa. A wrapper that guards "run with --resume only if a session exists" must special-case both codes. The hint text is identical between them, suggesting the messages are logically equivalent. Additionally neither code matches the proposed canonical names `session_not_found` / `session_load_failed` as stable `ErrorKind` discriminants described in ROADMAP #77's fix shape, which explicitly proposes typed error-kind codes for session lifecycle failures. **Required fix shape:** (a) unify "no sessions found for this workspace fingerprint" under a single canonical `kind` code — either `no_managed_sessions` or `session_not_found` — used consistently by every command path that encounters an empty session registry; (b) if `session_load_failed` is a more general category (covering e.g. corrupt session files, IO errors, schema version mismatches), it should nest a concrete `reason:"no_managed_sessions"` or `reason:"session_not_found"` sub-field so callers can distinguish "empty registry" from "found but unreadable"; (c) align with the canonical error-kind contract proposed in #77; (d) add regression coverage proving `export` and `--resume latest` in an empty workspace both return an error with the same top-level `kind` code. **Why this matters:** session guard-rails in orchestration need a single stable `kind` to detect cold workspaces without enumerating all possible no-session synonyms. Two divergent codes for the same condition make defensive automation brittle and contradict the promise of machine-readable error envelopes. Source: Jobdori live dogfood, `e939777f`, 2026-04-30 KST (UTC+9).
392. **`init --output-format json` artifact entries only have `name` and `status` fields; `status: "skipped"` artifacts include no `reason` explaining why they were skipped** — dogfooded 2026-04-30 by Jobdori on `74338dc6`. Automation cannot distinguish "already exists" from "permission denied" from "dry_run". **Required fix:** add `reason: "already_exists"|"permission_denied"|"dry_run"|"excluded_by_config"` to each artifact; add `existing_path` for `already_exists`; add regression coverage. Source: Jobdori live dogfood, `74338dc6`, 2026-04-30.
393. **`help --output-format json` returns `{"kind":"help","message":"..."}` while `/help --output-format json` returns `{"kind":"help","text":"..."}` — the prose content field is named `message` in CLI subcommand form and `text` in slash-command form for the same `kind:"help"` response** — dogfooded 2026-04-30 by Jobdori on `52a909ce`. Automation must check `d.message || d.text`. **Required fix:** standardise on one field name; update SCHEMAS.md; add regression coverage. Source: Jobdori live dogfood, `52a909ce`, 2026-04-30.
394. **`skills --output-format json` skill entries include no `path` field; `origin.detail_label` is `null` for all 147 skills; two skills have `description: ">"` — a single-character parsing artifact** — dogfooded 2026-04-30 by Jobdori on `52a909ce`. Skill entry keys: `['active','description','name','origin','shadowed_by','source']` — no `path`. **Required fix:** add `path` to each entry; populate `origin.detail_label`; sanitize stub descriptions; add regression coverage. Source: Jobdori live dogfood, `52a909ce`, 2026-04-30.
395. **`version/doctor/sandbox/status --help` with `--output-format json` return plain-text instead of JSON; `agents/mcp --help` correctly return JSON — inconsistent `--help` JSON contract across subcommands** — dogfooded 2026-04-30 by Jobdori on `d95b230c`. **Required fix:** all subcommands must honour `--output-format json` for `--help`; add regression coverage. Source: Jobdori live dogfood, `d95b230c`, 2026-04-30.
396. **`sandbox --output-format json` response omits `action` field; `agents/mcp` include `action:"list"` — inconsistent structural envelope; also `requested_namespace:true` + `supported:false` mismatch has no typed `degraded` field** — dogfooded 2026-04-30 by Jobdori on `d95b230c`. **Required fix:** add `action:"status"` to inspect-style commands; add `degraded: bool` + `degraded_reasons[]`; add regression coverage. Source: Jobdori live dogfood, `d95b230c`, 2026-04-30.
397. **`mcp --output-format json` response has `summary: null` and no `count` field; `agents` has `summary: {active, shadowed, total}` and `count` — inconsistent list-command envelope; also `claw --output-format json mcp` emits unstructured `enabledPlugins is deprecated` warning to stderr** — dogfooded 2026-04-30 by Jobdori on `44cca205`. **Required fix:** add `count` + `summary` to `mcp` JSON; emit deprecation warnings as structured JSON when `--output-format json`; add regression coverage. Source: Jobdori live dogfood, `44cca205`, 2026-04-30.
398. **`doctor --output-format json` `system` check includes `git_sha` of the compiled binary but does not compare it against repo HEAD, reports `status:"ok"` even when binary SHA ≠ HEAD; `default_model` is `null` when no auth configured but has no typed `reason` or `auth_required` flag** — dogfooded 2026-04-30 by Jobdori on `e939777f`. Binary SHA `5eb1d7d8` ≠ HEAD `e939777f`, yet `system.status:"ok"`. **Required fix:** add `head_sha`, `git_sha_matches_head: bool`, `stale: bool`; set `status:"warn"` on mismatch; add `model_unavailable_reason`/`auth_required` when model is null; add regression coverage. Source: Jobdori live dogfood, `e939777f`, 2026-04-30.

View File

@@ -3542,37 +3542,6 @@ fn run_resume_command(
json: Some(handle_skills_slash_command_json(args.as_deref(), &cwd)?),
})
}
SlashCommand::Plugins { action, target } => {
// Only list is supported in resume mode (no runtime to reload)
match action.as_deref() {
Some("install") | Some("uninstall") | Some("enable") | Some("disable")
| Some("update") => {
return Err(
"resumed /plugins mutations are interactive-only; start `claw` and run `/plugins` in the REPL".into(),
);
}
_ => {}
}
let cwd = env::current_dir()?;
let loader = ConfigLoader::default_for(&cwd);
let runtime_config = loader.load()?;
let mut manager = build_plugin_manager(&cwd, &loader, &runtime_config);
let result =
handle_plugins_slash_command(action.as_deref(), target.as_deref(), &mut manager)?;
let action_str = action.as_deref().unwrap_or("list");
let json = serde_json::json!({
"kind": "plugin",
"action": action_str,
"target": target,
"message": &result.message,
"reload_runtime": result.reload_runtime,
});
Ok(ResumeCommandOutcome {
session: session.clone(),
message: Some(result.message),
json: Some(json),
})
}
SlashCommand::Doctor => {
let report = render_doctor_report()?;
Ok(ResumeCommandOutcome {
@@ -3659,6 +3628,7 @@ fn run_resume_command(
| SlashCommand::Model { .. }
| SlashCommand::Permissions { .. }
| SlashCommand::Session { .. }
| SlashCommand::Plugins { .. }
| SlashCommand::Login
| SlashCommand::Logout
| SlashCommand::Vim

View File

@@ -105,18 +105,6 @@ fn inventory_commands_emit_structured_json_when_requested() {
let skills = assert_json_command(&root, &["--output-format", "json", "skills"]);
assert_eq!(skills["kind"], "skills");
assert_eq!(skills["action"], "list");
let plugins = assert_json_command(&root, &["--output-format", "json", "plugins"]);
assert_eq!(plugins["kind"], "plugin");
assert_eq!(plugins["action"], "list");
assert!(
plugins["reload_runtime"].is_boolean(),
"plugins reload_runtime should be a boolean"
);
assert!(
plugins["target"].is_null(),
"plugins target should be null when no plugin is targeted"
);
}
#[test]
@@ -360,34 +348,6 @@ fn resumed_inventory_commands_emit_structured_json_when_requested() {
assert_eq!(skills["action"], "list");
assert!(skills["summary"]["total"].is_number());
assert!(skills["skills"].is_array());
let plugins = assert_json_command_with_env(
&root,
&[
"--output-format",
"json",
"--resume",
session_path.to_str().expect("utf8 session path"),
"/plugins",
],
&[
(
"CLAW_CONFIG_HOME",
config_home.to_str().expect("utf8 config home"),
),
("HOME", home.to_str().expect("utf8 home")),
],
);
assert_eq!(plugins["kind"], "plugin");
assert_eq!(plugins["action"], "list");
assert!(
plugins["reload_runtime"].is_boolean(),
"plugins reload_runtime should be a boolean"
);
assert!(
plugins["target"].is_null(),
"plugins target should be null when no plugin is targeted"
);
}
#[test]