From 7aec1e452a04d3dbf935837e9b8e96107466c487 Mon Sep 17 00:00:00 2001 From: jeffusion Date: Tue, 24 Mar 2026 13:17:09 +0800 Subject: [PATCH] fix(lint): apply biome cleanup for notification modules --- src/config/index.ts | 2 +- src/controllers/review.ts | 2 +- src/services/notification-manager.ts | 5 ++++- .../notification/base-notification-service.ts | 12 +++--------- .../providers/feishu-notification-service.ts | 12 ++---------- .../providers/wecom-notification-service.ts | 10 +--------- 6 files changed, 12 insertions(+), 31 deletions(-) diff --git a/src/config/index.ts b/src/config/index.ts index 64fa5da..594ea00 100644 --- a/src/config/index.ts +++ b/src/config/index.ts @@ -1,5 +1,5 @@ -import { configManager } from './config-manager.js'; import type { NotificationServiceConfig } from '../services/notification/types.js'; +import { configManager } from './config-manager.js'; type AppConfig = import('./config-manager.js').AppConfig; diff --git a/src/controllers/review.ts b/src/controllers/review.ts index c78d848..7053feb 100644 --- a/src/controllers/review.ts +++ b/src/controllers/review.ts @@ -6,9 +6,9 @@ import { codexEngine } from '../review/codex/codex-engine'; import { LocalRepoManager } from '../review/context/local-repo-manager'; import { SandboxExec } from '../review/context/sandbox-exec'; import { reviewEngine } from '../review/engine'; +import { PullRequestDetails, giteaService } from '../services/gitea'; import { getNotificationManager } from '../services/notification-manager'; import type { NotificationContext } from '../services/notification/types'; -import { PullRequestDetails, giteaService } from '../services/gitea'; import { logger } from '../utils/logger'; // Gitea webhook事件类型 diff --git a/src/services/notification-manager.ts b/src/services/notification-manager.ts index 03a181f..f740a4b 100644 --- a/src/services/notification-manager.ts +++ b/src/services/notification-manager.ts @@ -1,5 +1,8 @@ -import { createNotificationManager, type NotificationManager } from './notification/notification-manager.js'; import { getNotificationConfigs } from '../config/index.js'; +import { + type NotificationManager, + createNotificationManager, +} from './notification/notification-manager.js'; export function getNotificationManager(): NotificationManager { const configs = getNotificationConfigs(); diff --git a/src/services/notification/base-notification-service.ts b/src/services/notification/base-notification-service.ts index 4ed5cf0..e04c541 100644 --- a/src/services/notification/base-notification-service.ts +++ b/src/services/notification/base-notification-service.ts @@ -41,17 +41,11 @@ export abstract class BaseNotificationService implements INotificationService { await this.sendMessage(message); } - protected abstract buildIssueCreatedMessage( - context: NotificationContext - ): NotificationMessage; + protected abstract buildIssueCreatedMessage(context: NotificationContext): NotificationMessage; - protected abstract buildIssueClosedMessage( - context: NotificationContext - ): NotificationMessage; + protected abstract buildIssueClosedMessage(context: NotificationContext): NotificationMessage; - protected abstract buildIssueAssignedMessage( - context: NotificationContext - ): NotificationMessage; + protected abstract buildIssueAssignedMessage(context: NotificationContext): NotificationMessage; protected abstract buildPrCreatedMessage(context: NotificationContext): NotificationMessage; diff --git a/src/services/notification/providers/feishu-notification-service.ts b/src/services/notification/providers/feishu-notification-service.ts index a92eab8..80ed7ec 100644 --- a/src/services/notification/providers/feishu-notification-service.ts +++ b/src/services/notification/providers/feishu-notification-service.ts @@ -1,10 +1,6 @@ -import * as crypto from 'crypto'; +import * as crypto from 'node:crypto'; import { BaseNotificationService } from '../base-notification-service.js'; -import type { - NotificationContext, - NotificationMessage, - NotificationServiceConfig, -} from '../types.js'; +import type { NotificationContext, NotificationMessage } from '../types.js'; type FeishuApiResponse = { code?: number; @@ -21,10 +17,6 @@ function parseFeishuResponse(raw: unknown): FeishuApiResponse { export class FeishuNotificationService extends BaseNotificationService { readonly provider = 'feishu' as const; - constructor(config: NotificationServiceConfig) { - super(config); - } - async sendMessage(message: NotificationMessage): Promise { if (!this.config.webhookUrl) { throw new Error('Feishu webhook URL is not configured'); diff --git a/src/services/notification/providers/wecom-notification-service.ts b/src/services/notification/providers/wecom-notification-service.ts index 930b1cd..c9273cd 100644 --- a/src/services/notification/providers/wecom-notification-service.ts +++ b/src/services/notification/providers/wecom-notification-service.ts @@ -1,9 +1,5 @@ import { BaseNotificationService } from '../base-notification-service.js'; -import type { - NotificationContext, - NotificationMessage, - NotificationServiceConfig, -} from '../types.js'; +import type { NotificationContext, NotificationMessage } from '../types.js'; type WeComApiResponse = { errcode?: number; @@ -13,10 +9,6 @@ type WeComApiResponse = { export class WeComNotificationService extends BaseNotificationService { readonly provider = 'wecom' as const; - constructor(config: NotificationServiceConfig) { - super(config); - } - async sendMessage(message: NotificationMessage): Promise { if (!this.config.webhookUrl) { throw new Error('WeCom webhook URL is not configured');