jeffusion/archived-gitea-ai-assistant
1
0
Fork 0
mirror of https://github.com/jeffusion/gitea-ai-assistant.git synced 2026-06-08 07:26:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(config): make persistOverrides resilient to read-only filesystems

Browse Source 
Atomic rename (temp→target) fails on K8s volumes with EBUSY/EXDEV/EROFS.
Fall back to direct writeFile when rename fails, with best-effort
cleanup of orphaned temp files.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)
This commit is contained in:
jeffusion
2026-03-04 17:29:02 +08:00
committed by 路遥知码力
parent 2587576514
commit 3f2817d6c3
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/config/config-manager.ts
View File

@@ -10,7 +10,7 @@
import { randomUUID } from 'node:crypto'; import { randomUUID } from 'node:crypto';
import { readFileSync } from 'node:fs'; import { readFileSync } from 'node:fs';
import { mkdir, readFile, rename, writeFile } from 'node:fs/promises'; import { mkdir, readFile, rename, unlink, writeFile } from 'node:fs/promises';
import { dirname, resolve } from 'node:path'; import { dirname, resolve } from 'node:path';
import { config as dotenvConfig } from 'dotenv'; import { config as dotenvConfig } from 'dotenv';
import { z } from 'zod'; import { z } from 'zod';
@@ -204,7 +204,7 @@ class ConfigManager {
} }
} }
/** Persist current overrides to disk atomically (write temp → rename). */ /** Persist current overrides to disk. Tries atomic rename; falls back to direct write. */
private async persistOverrides(): Promise<void> { private async persistOverrides(): Promise<void> {
const dir = dirname(this.overridesPath); const dir = dirname(this.overridesPath);
await mkdir(dir, { recursive: true }); await mkdir(dir, { recursive: true });
@@ -215,9 +215,18 @@ class ConfigManager {
overrides: { ...this.overrides }, overrides: { ...this.overrides },
}; };
const json = JSON.stringify(payload, null, 2);
// Atomic rename may fail on K8s volumes (EBUSY/EXDEV); fall back to direct write.
const tmpPath = `${this.overridesPath}.${randomUUID()}.tmp`; const tmpPath = `${this.overridesPath}.${randomUUID()}.tmp`;
await writeFile(tmpPath, JSON.stringify(payload, null, 2), 'utf-8'); try {
await rename(tmpPath, this.overridesPath); await writeFile(tmpPath, json, 'utf-8');
await rename(tmpPath, this.overridesPath);
} catch {
await writeFile(this.overridesPath, json, 'utf-8');
// Clean up orphaned tmp file (best effort)
try { await unlink(tmpPath); } catch { /* ignore */ }
}
} }
// ── Core API ───────────────────────────────────────────────────────────── // ── Core API ─────────────────────────────────────────────────────────────