Files
gocryptotrader/gctscript/wrappers/gct/gctwrapper_test.go
Romano c9bead8ff3 exchanges/credentials: Improve handling and error reporting (#1886)
* Improve credential handling and error reporting
Swapped out empty credential returns with more specific errors to make things clearer and avoid weird behavior. Added safeguards to handle nil credentials in WebSocket data processing. This gives us better error handling and more reliable fallback options when managing credentials.

* Rewrite gctwrapper test assertions to use substring matching instead of exact string matching

This prevents test failures caused by minor error message formatting changes

* Correct mutex use in GetCredentials

Move mutex from local credentials copy to shares resource access
We were locking the mutex when modifying a local copy instead of when reading from shared credentials
Moved RLock/RUnlock to wrap b.API.credentials access remoived the unnecessary locks when changing the local copy

Reduce lock contention and fix potential race conditions

* Replace test assertions with testify/require package in gctwrapper_test.go

* remove unnecesarry mutex locks in GetCredentials and fix test

* credentials test use require.ErrorIs

* Fix: improve credential handling in BTCMarkets websocket

* Refactor error messages and improve test assertions

* Update exchanges/credentials.go

* Update gctscript/wrappers/gct/gctwrapper_test.go

* credentials: Remove redundant comment for sub account override

---------

Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io>
2025-05-07 12:26:51 +10:00

317 lines
8.0 KiB
Go

package gct
import (
"context"
"errors"
"log"
"os"
"path/filepath"
"reflect"
"testing"
objects "github.com/d5/tengo/v2"
"github.com/stretchr/testify/require"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/config"
"github.com/thrasher-corp/gocryptotrader/engine"
exchange "github.com/thrasher-corp/gocryptotrader/exchanges"
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
"github.com/thrasher-corp/gocryptotrader/gctscript/modules"
"github.com/thrasher-corp/gocryptotrader/gctscript/modules/gct"
)
func TestMain(m *testing.M) {
settings := engine.Settings{
CoreSettings: engine.CoreSettings{
EnableDryRun: true,
EnableDepositAddressManager: true,
},
ConfigFile: filepath.Join("..", "..", "..", "testdata", "configtest.json"),
DataDir: filepath.Join("..", "..", "..", "testdata", "gocryptotrader"),
}
var err error
engine.Bot, err = engine.NewFromSettings(&settings, nil)
if err != nil {
log.Fatalf("Error from engine.NewFromSettings: %s", err)
}
em := engine.NewExchangeManager()
exch, err := em.NewExchangeByName(exch.Value)
if err != nil {
log.Fatalf("Error from NewExchangeByName: %s", err)
}
cfg, err := exchange.GetDefaultConfig(context.Background(), exch)
if err != nil {
log.Fatalf("Error during GetDefaultConfig: %s", err)
}
if err = exch.Setup(cfg); err != nil {
log.Fatalf("Error during exch.Setup: %s", err)
}
if err = em.Add(exch); err != nil {
log.Fatalf("Error during ExchangeManager.Add: %s", err)
}
engine.Bot.ExchangeManager = em
engine.Bot.WithdrawManager, err = engine.SetupWithdrawManager(em, nil, true)
if err != nil {
log.Fatalf("Error during engine.SetupWithdrawManage: %s", err)
}
engine.Bot.DepositAddressManager = engine.SetupDepositAddressManager()
err = engine.Bot.DepositAddressManager.Sync(engine.Bot.GetAllExchangeCryptocurrencyDepositAddresses())
if err != nil {
log.Fatalf("Error syncing DepositAddressManager: %s", err)
}
engine.Bot.OrderManager, err = engine.SetupOrderManager(em, &engine.CommunicationManager{}, &engine.Bot.ServicesWG, &config.OrderManager{})
if err != nil {
log.Fatalf("Error during SetupOrderManager: %s", err)
}
if err = engine.Bot.OrderManager.Start(); err != nil {
log.Fatalf("Error starting OrderManager: %s", err)
}
modules.SetModuleWrapper(Setup())
os.Exit(m.Run())
}
func TestSetup(t *testing.T) {
x := Setup()
xType := reflect.TypeOf(x).String()
if xType != "*gct.Wrapper" {
t.Fatalf("SetupCommunicationManager() should return pointer to Wrapper instead received: %v", x)
}
}
var (
exch = &objects.String{
Value: "Bitstamp",
}
exchError = &objects.String{
Value: "error",
}
currencyPair = &objects.String{
Value: "BTC-USD",
}
delimiter = &objects.String{
Value: "-",
}
assetType = &objects.String{
Value: "spot",
}
orderID = &objects.String{
Value: "1235",
}
ctx = &gct.Context{}
tv = objects.TrueValue
fv = objects.FalseValue
errTestFailed = errors.New("test failed")
)
func TestExchangeOrderbook(t *testing.T) {
t.Parallel()
_, err := gct.ExchangeOrderbook(ctx, exch, currencyPair, delimiter, assetType)
if err != nil {
t.Fatal(err)
}
_, err = gct.ExchangeOrderbook(ctx, exchError, currencyPair, delimiter, assetType)
if err != nil && errors.Is(err, errTestFailed) {
t.Fatal(err)
}
_, err = gct.ExchangeOrderbook()
if !errors.Is(err, objects.ErrWrongNumArguments) {
t.Error(err)
}
}
func TestExchangeTicker(t *testing.T) {
t.Parallel()
_, err := gct.ExchangeTicker(ctx, exch, currencyPair, delimiter, assetType)
if err != nil {
t.Fatal(err)
}
_, err = gct.ExchangeTicker(ctx, exchError, currencyPair, delimiter, assetType)
if err != nil && errors.Is(err, errTestFailed) {
t.Fatal(err)
}
_, err = gct.ExchangeTicker()
if !errors.Is(err, objects.ErrWrongNumArguments) {
t.Error(err)
}
}
func TestExchangeExchanges(t *testing.T) {
t.Parallel()
_, err := gct.ExchangeExchanges(tv)
if err != nil {
t.Fatal(err)
}
_, err = gct.ExchangeExchanges(exch)
if err != nil {
t.Fatal(err)
}
_, err = gct.ExchangeExchanges(fv)
if err != nil {
t.Fatal(err)
}
_, err = gct.ExchangeExchanges()
if !errors.Is(err, objects.ErrWrongNumArguments) {
t.Error(err)
}
}
func TestExchangePairs(t *testing.T) {
t.Parallel()
_, err := gct.ExchangePairs(exch, tv, assetType)
if err != nil {
t.Fatal(err)
}
_, err = gct.ExchangePairs(exchError, tv, assetType)
if err != nil && errors.Is(err, errTestFailed) {
t.Fatal(err)
}
_, err = gct.ExchangePairs()
if !errors.Is(err, objects.ErrWrongNumArguments) {
t.Error(err)
}
}
func TestExchangeAccountInfo(t *testing.T) {
t.Parallel()
_, err := gct.ExchangeAccountInfo()
require.ErrorIs(t, err, objects.ErrWrongNumArguments)
obj, err := gct.ExchangeAccountInfo(ctx, exch, assetType)
require.NoError(t, err)
rString, ok := objects.ToString(obj)
require.True(t, ok, "ExchangeAccountInfo return value must return correctly from objects.ToString")
require.Contains(t, rString, "Bitstamp REST or Websocket authentication support is not enabled")
}
func TestExchangeOrderQuery(t *testing.T) {
t.Parallel()
_, err := gct.ExchangeOrderQuery()
if !errors.Is(err, objects.ErrWrongNumArguments) {
t.Fatal(err)
}
_, err = gct.ExchangeOrderQuery(ctx, exch, orderID)
if err != nil && err != common.ErrNotYetImplemented {
t.Error(err)
}
}
func TestExchangeOrderCancel(t *testing.T) {
t.Parallel()
_, err := gct.ExchangeOrderCancel()
if !errors.Is(err, objects.ErrWrongNumArguments) {
t.Fatal(err)
}
_, err = gct.ExchangeOrderCancel(ctx, exch, orderID, currencyPair, assetType)
if err != nil && err != common.ErrNotYetImplemented {
t.Error(err)
}
}
func TestExchangeOrderSubmit(t *testing.T) {
t.Parallel()
_, err := gct.ExchangeOrderSubmit()
require.ErrorIs(t, err, objects.ErrWrongNumArguments)
orderSide := &objects.String{Value: "ASK"}
orderType := &objects.String{Value: "LIMIT"}
orderPrice := &objects.Float{Value: 1}
orderAmount := &objects.Float{Value: 1}
orderAsset := &objects.String{Value: asset.Spot.String()}
obj, err := gct.ExchangeOrderSubmit(ctx,
exch,
currencyPair,
delimiter,
orderType,
orderSide,
orderPrice,
orderAmount,
orderID,
orderAsset)
require.NoError(t, err)
rString, ok := objects.ToString(obj)
require.True(t, ok, "ExchangeOrderSubmit return value must return correctly from objects.ToString")
require.Contains(t, rString, "Bitstamp REST or Websocket authentication support is not enabled")
}
func TestAllModuleNames(t *testing.T) {
t.Parallel()
x := gct.AllModuleNames()
xType := reflect.TypeOf(x).Kind()
if xType != reflect.Slice {
t.Errorf("AllModuleNames() should return slice instead received: %v", x)
}
}
func TestExchangeDepositAddress(t *testing.T) {
t.Parallel()
_, err := gct.ExchangeDepositAddress()
if !errors.Is(err, objects.ErrWrongNumArguments) {
t.Fatal(err)
}
currCode := &objects.String{Value: "BTC"}
chain := &objects.String{Value: ""}
_, err = gct.ExchangeDepositAddress(exch, currCode, chain)
if err != nil && err.Error() != "deposit address store is nil" {
t.Error(err)
}
}
func TestExchangeWithdrawCrypto(t *testing.T) {
t.Parallel()
_, err := gct.ExchangeWithdrawCrypto()
if !errors.Is(err, objects.ErrWrongNumArguments) {
t.Fatal(err)
}
currCode := &objects.String{Value: "BTC"}
desc := &objects.String{Value: "HELLO"}
address := &objects.String{Value: "0xTHISISALEGITBTCADDRESSS"}
amount := &objects.Float{Value: 1.0}
_, err = gct.ExchangeWithdrawCrypto(ctx,
exch,
currCode,
address,
address,
amount,
amount,
desc)
if err != nil {
t.Error(err)
}
}
func TestExchangeWithdrawFiat(t *testing.T) {
t.Parallel()
_, err := gct.ExchangeWithdrawFiat()
if !errors.Is(err, objects.ErrWrongNumArguments) {
t.Fatal(err)
}
currCode := &objects.String{Value: "TEST"}
amount := &objects.Float{Value: 1.0}
desc := &objects.String{Value: "2"}
bankID := &objects.String{Value: "3!"}
_, err = gct.ExchangeWithdrawFiat(ctx, exch, currCode, desc, amount, bankID)
if err != nil && err.Error() != "exchange Bitstamp bank details not found for TEST" {
t.Error(err)
}
}