mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-21 15:10:12 +00:00
* buffer/orderbook: shift orderbook update logic from buffer package to orderbook package * Update exchanges/orderbook/depth.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * linter: fixes * spelling: fix * samboss: add in some todos * sammy nit: add unlock on error * sammy nits: rm ptr to slice field buffer in orderbookHolder * sammy nits: Add more coverage bro * sammy nits: even more coverage * gk: nits on commentary * gk: nits change sort.Slice to slices.SortFunc * gk: fix commentary on buffer clearing * gk: nits fin * linter: fix * Update exchange/websocket/buffer/buffer.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchange/websocket/buffer/buffer.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchanges/orderbook/tranches.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchanges/orderbook/orderbook.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchange/websocket/buffer/buffer_test.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchange/websocket/buffer/buffer_test.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchanges/orderbook/incremental_updates.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * gk: refresh action types and names * gk nits: consolidate error vars and naming * gk nits: more name changes * gk nits; buffer tests update * gk nits: error var names change * linter: FIX * it gets inlined but there is an alloc * rn field in TODO * Update exchanges/binance/binance_websocket.go Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io> * Update exchanges/binance/binance_websocket.go Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io> * orderbook: shift verify/validate funcs to validate.go and rn Verify() -> Validate() * orderbook: validate even in presence of checksum and allow cowboy mode * buffer; fix test * kraken: fix futures orderbook by reversing incoming bids * okx: change default spread pair * Update exchanges/orderbook/validate.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchanges/orderbook/validate.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchanges/orderbook/validate.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchanges/orderbook/validate.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchanges/orderbook/validate.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * gk: initial nits * rn fields V(v)erifyorderbook to V(v)alidateOrderbook * buffer/orderbook: nilguard in validate and change method receiver w -> o --------- Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io>
205 lines
5.8 KiB
Go
205 lines
5.8 KiB
Go
package gateio
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/thrasher-corp/gocryptotrader/currency"
|
|
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
|
|
"github.com/thrasher-corp/gocryptotrader/exchanges/kline"
|
|
"github.com/thrasher-corp/gocryptotrader/exchanges/orderbook"
|
|
"github.com/thrasher-corp/gocryptotrader/exchanges/subscription"
|
|
testexch "github.com/thrasher-corp/gocryptotrader/internal/testing/exchange"
|
|
)
|
|
|
|
func TestProcessOrderbookUpdate(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
m := newWsOBUpdateManager(0)
|
|
err := m.ProcessOrderbookUpdate(t.Context(), g, 1337, &orderbook.Update{})
|
|
assert.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)
|
|
|
|
pair := currency.NewPair(currency.BABY, currency.BABYDOGE)
|
|
err = g.Websocket.Orderbook.LoadSnapshot(&orderbook.Book{
|
|
Exchange: g.Name,
|
|
Pair: pair,
|
|
Asset: asset.USDTMarginedFutures,
|
|
Bids: []orderbook.Level{{Price: 1, Amount: 1}},
|
|
Asks: []orderbook.Level{{Price: 1, Amount: 1}},
|
|
LastUpdated: time.Now(),
|
|
LastPushed: time.Now(),
|
|
LastUpdateID: 1336,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
err = m.ProcessOrderbookUpdate(t.Context(), g, 1337, &orderbook.Update{
|
|
UpdateID: 1338,
|
|
Pair: pair,
|
|
Asset: asset.USDTMarginedFutures,
|
|
AllowEmpty: true,
|
|
UpdateTime: time.Now(),
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
// Test orderbook snapshot is behind update
|
|
err = m.ProcessOrderbookUpdate(t.Context(), g, 1340, &orderbook.Update{
|
|
UpdateID: 1341,
|
|
Pair: pair,
|
|
Asset: asset.USDTMarginedFutures,
|
|
AllowEmpty: true,
|
|
UpdateTime: time.Now(),
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
cache := m.LoadCache(pair, asset.USDTMarginedFutures)
|
|
|
|
cache.mtx.Lock()
|
|
assert.Len(t, cache.updates, 1)
|
|
assert.True(t, cache.updating)
|
|
cache.mtx.Unlock()
|
|
|
|
// Test orderbook snapshot is behind update
|
|
err = m.ProcessOrderbookUpdate(t.Context(), g, 1342, &orderbook.Update{
|
|
UpdateID: 1343,
|
|
Pair: pair,
|
|
Asset: asset.USDTMarginedFutures,
|
|
AllowEmpty: true,
|
|
UpdateTime: time.Now(),
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
cache.mtx.Lock()
|
|
assert.Len(t, cache.updates, 2)
|
|
assert.True(t, cache.updating)
|
|
cache.mtx.Unlock()
|
|
|
|
time.Sleep(time.Millisecond * 2) // Allow sync delay to pass
|
|
|
|
cache.mtx.Lock()
|
|
assert.Empty(t, cache.updates)
|
|
assert.False(t, cache.updating)
|
|
cache.mtx.Unlock()
|
|
}
|
|
|
|
func TestLoadCache(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
m := newWsOBUpdateManager(0)
|
|
pair := currency.NewPair(currency.BABY, currency.BABYDOGE)
|
|
cache := m.LoadCache(pair, asset.USDTMarginedFutures)
|
|
assert.NotNil(t, cache)
|
|
assert.Len(t, m.lookup, 1)
|
|
|
|
// Test cache is reused
|
|
cache2 := m.LoadCache(pair, asset.USDTMarginedFutures)
|
|
assert.Equal(t, cache, cache2)
|
|
}
|
|
|
|
func TestSyncOrderbook(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
g := new(Gateio)
|
|
require.NoError(t, testexch.Setup(g), "Setup must not error")
|
|
require.NoError(t, g.UpdateTradablePairs(t.Context(), false))
|
|
|
|
// Add dummy subscription so that it can be matched and a limit/level can be extracted for initial orderbook sync spot.
|
|
err := g.Websocket.AddSubscriptions(nil, &subscription.Subscription{Channel: subscription.OrderbookChannel, Interval: kline.HundredMilliseconds})
|
|
require.NoError(t, err)
|
|
|
|
m := newWsOBUpdateManager(defaultWSSnapshotSyncDelay)
|
|
|
|
for _, a := range []asset.Item{asset.Spot, asset.USDTMarginedFutures} {
|
|
pair := currency.NewPair(currency.ETH, currency.USDT)
|
|
err := g.CurrencyPairs.EnablePair(a, pair)
|
|
require.NoError(t, err)
|
|
cache := m.LoadCache(pair, a)
|
|
|
|
cache.updates = []pendingUpdate{{update: &orderbook.Update{Pair: pair, Asset: a}}}
|
|
cache.updating = true
|
|
err = cache.SyncOrderbook(t.Context(), g, pair, a)
|
|
require.NoError(t, err)
|
|
require.False(t, cache.updating)
|
|
require.Empty(t, cache.updates)
|
|
|
|
expectedLimit := 20
|
|
if a == asset.Spot {
|
|
expectedLimit = 100
|
|
}
|
|
|
|
b, err := g.Websocket.Orderbook.GetOrderbook(pair, a)
|
|
require.NoError(t, err)
|
|
require.Len(t, b.Bids, expectedLimit)
|
|
require.Len(t, b.Asks, expectedLimit)
|
|
}
|
|
}
|
|
|
|
func TestApplyPendingUpdates(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
g := new(Gateio)
|
|
require.NoError(t, testexch.Setup(g), "Setup must not error")
|
|
require.NoError(t, g.UpdateTradablePairs(t.Context(), false))
|
|
|
|
m := newWsOBUpdateManager(defaultWSSnapshotSyncDelay)
|
|
pair := currency.NewPair(currency.LTC, currency.USDT)
|
|
err := g.Websocket.Orderbook.LoadSnapshot(&orderbook.Book{
|
|
Exchange: g.Name,
|
|
Pair: pair,
|
|
Asset: asset.USDTMarginedFutures,
|
|
Bids: []orderbook.Level{{Price: 1, Amount: 1}},
|
|
Asks: []orderbook.Level{{Price: 1, Amount: 1}},
|
|
LastUpdated: time.Now(),
|
|
LastPushed: time.Now(),
|
|
LastUpdateID: 1335,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
cache := m.LoadCache(pair, asset.USDTMarginedFutures)
|
|
|
|
update := &orderbook.Update{
|
|
UpdateID: 1339,
|
|
Pair: pair,
|
|
Asset: asset.USDTMarginedFutures,
|
|
AllowEmpty: true,
|
|
UpdateTime: time.Now(),
|
|
}
|
|
|
|
cache.updates = []pendingUpdate{{update: update, firstUpdateID: 1337}}
|
|
err = cache.applyPendingUpdates(g, asset.USDTMarginedFutures)
|
|
require.ErrorIs(t, err, errOrderbookSnapshotOutdated)
|
|
|
|
cache.updates[0].firstUpdateID = 1336
|
|
err = cache.applyPendingUpdates(g, asset.USDTMarginedFutures)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestApplyOrderbookUpdate(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
g := new(Gateio)
|
|
require.NoError(t, testexch.Setup(g), "Setup must not error")
|
|
require.NoError(t, g.UpdateTradablePairs(t.Context(), false))
|
|
|
|
pair := currency.NewBTCUSDT()
|
|
|
|
update := &orderbook.Update{
|
|
Pair: pair,
|
|
Asset: asset.USDTMarginedFutures,
|
|
AllowEmpty: true,
|
|
UpdateTime: time.Now(),
|
|
}
|
|
|
|
err := applyOrderbookUpdate(g, update)
|
|
require.ErrorIs(t, err, orderbook.ErrDepthNotFound)
|
|
|
|
update.Asset = asset.Spot
|
|
err = applyOrderbookUpdate(g, update)
|
|
require.ErrorIs(t, err, orderbook.ErrDepthNotFound)
|
|
|
|
update.Pair = currency.NewPair(currency.BABY, currency.BABYDOGE)
|
|
err = applyOrderbookUpdate(g, update)
|
|
require.NoError(t, err)
|
|
}
|