Files
gocryptotrader/exchanges/bybit/bybit_websocket.go
Jaydeep Rajpurohit 247da918a8 exchanges: Add ByBit support (#887)
* few fixes and add ratelimiter

* adds test

* revert configtest.json changes

* configtest updated

* WIP: adds public endpoint support

* WIP: adds public endpoint support

* adds public endpoint support

* WIP: adds auth. endpoint support

* adds test for auth. endpoint

* fixes

* adds auth. endpoint support

* WIP: ws support

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* Testing

* Complete WS spot testing

* adds support for ws events

* minor change

* WIP: adds REST support for CoinMarginedFutures

* Fixes

* WIP: adds REST support for CoinMarginedFutures

* Fixes

* improvement in SPOT REST

* Typo fix

* WIP: add REST support for CMF Account API

* minor fixes

* WIP: add support for CMF conditional orders and few minor fixes

* complete support for CMF conditional orders

* adds support for public CMF endpoint

* adds support for CMF position API

* Complete REST CMF support

* WIP

* Testing REST CMF support

* Testing REST CMF support

* Testing REST CMF support completed

* WIP: add support for UMF

* completed non-auth UMF

* WIP: add support for REST Auth. UMF

* WIP: add support for REST Auth. UMF and some improvements

* WIP

* WIP

* WIP

* completed REST UMF

* renaming

* adds REST support for futures

* add testcases for UMF and some optimizations

* add testcases for futures

* Testing UMF, futures and its changes

* Fixes

* Fixes after testing

* WIP

* WIP

* WIP

* completed ws USDT futures support

* WIP: ws support for futures

* fixes in WS futures

* fixes in WS support

* roll back changes made for WS CMF, USDT and Futures

* fixes

* WIP

* WIP

* fixes

* Steps for new PR

* WIP

* WIP

* WIP

* WIP

* complete PR setup

* fixes for successfully running tests

* update in symbol for futures pair in test file

* WIP

* Fixes in test file and other minor fix

* fix testdata/configtest.json

* reset CONTRIBUTORS file

* review changes

* remove unwanted file

* remove redundant code

* improvisation

* adds comment for exported functions

* remove unwanted TODO and commented code

* fix

* improvisation

* fix

* defined errors

* improvisation

* improvisation

* improvisation

* updates test

* adds comment for exported types

* review changes

* review changes

* fix

* fixes

* Changes for making BYBIT compatible with existing code base

* Test file changes

* Changes for making BYBIT compatible with existing code base

* Changes for making BYBIT compatible with existing code base

* fix lint issues

* fix

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* WIP

* add test cases for new API's

* minor improvements

* add missing API and their tests

* minor fixes

* add bybitTime

* add bybitTimeSec, bybitTimeMilliSec, bybitTimeNanoSec and necessary support

* fix GetTradeHistory function

* error handling

* test fixes

* add GetServerTime API

* adds GetHistoricCandlesExtended and review changes

* test fixes

* minor fix

* integrating CMF Bybit recent change log

* minor fixes

* adds extractCurrencyPair

* minor fixes

* minor fix

* review changes

* adds variable declaration of error

* review commit

* adds embeddable type in API response for all API and integrate it

* fixes

* adds authentication WS connection

* review changes

* review changes

* compatible changes

* adds asset to GetWithdrawalsHistory

* adds asset_type in rpc.proto

* adds asset argument in gctcli withdrawal request command

* improve error handling in exchange API error

* web socket fix

* review changes

* improvements

* improvements

* minor fix

* review changes

* fixing wrapper issues

* fixes

* fixes

* review changes

* add test cases

* fix for GetActiveOrders

* lint fixes

* fixes in websocket

* adds wrapper testcases

* adds wrapper testcases

* adds wrapper testcases

* fixes

* fix issue with GetHistoricCandlesExtended

* fix merge issues

* improving error reporting

* adds wrapper testcases and a minor fix

* gctrpc changes

* adds test cases
fixes in websocket

* review changes for ws

* review changes in WS

* fix gctrpc

* merge fixes

* review changes

* WIP

* updates pair in configs

* adds new asset USDCMarginedFutures

* adds URL const for USDCMarginedFutures

* adds API support

* minor fixes

* adds kline API

* minor fix

* adds API

* adds API

* adds API

* WIP

* WIP

* WIP

* adds support for USDC auth requests to SendAuthHTTPRequest

* adds SendUSDCAuthHTTPRequest

* run test and fix them

* rollback support added for Auth. USDC request inside SendAuthHTTPRequest

* adds API and test cases

* adds API and test cases

* adds APIs and test cases

* adds APIs

* adds rate limit for USDC

* adds USDCMarginedFutures to wrapper

* adds USDC testcases in wrapper and fix few issues

* minor test fixes

* minor test fixes

* fix lint issues

* WIP

* Merge changes

* minor fixes

* remove "else" and optimize

* review changes

* review changes

* review changes

* fix lint issue

* merge fix

* fix test

* fix templates and run them

* changes after merge

* review changes and improvements

* code improvement

* fixes with respect to changes in API response in documentation

* fixed review change in test

* adds check in CancelExistingOrder

* update exchange template

* review changes

* adds GetDepositAddress API

* WIP: adds GetOrderHistory

* complete GetOrderHistory

* fixes

* adds test case

* fixes and add WithdrawFund API

* WIP

* WIP

* updating all SendAuthHTTPRequest call

* adds WithdrawCryptocurrencyFunds

* update test cases

* fix lint issues

* fixes after merge

* adds GetAvailableTransferChains and few fixes

* minor fix in GetDepositAddress

* minor fix with WS ping/pong handling

* add ping handler for WS Auth.

* fix typo mistake

* update doc
2022-08-08 11:29:43 +10:00

556 lines
14 KiB
Go

package bybit
import (
"context"
"encoding/json"
"errors"
"fmt"
"net/http"
"strconv"
"strings"
"time"
"github.com/gorilla/websocket"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/common/crypto"
"github.com/thrasher-corp/gocryptotrader/currency"
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
"github.com/thrasher-corp/gocryptotrader/exchanges/order"
"github.com/thrasher-corp/gocryptotrader/exchanges/orderbook"
"github.com/thrasher-corp/gocryptotrader/exchanges/stream"
"github.com/thrasher-corp/gocryptotrader/exchanges/ticker"
"github.com/thrasher-corp/gocryptotrader/exchanges/trade"
"github.com/thrasher-corp/gocryptotrader/log"
)
const (
bybitWSBaseURL = "wss://stream.bybit.com/"
wsSpotPublicTopicV2 = "spot/quote/ws/v2"
wsSpotPrivate = "spot/ws"
bybitWebsocketTimer = 20 * time.Second
wsOrderbook = "depth"
wsTicker = "bookTicker"
wsTrades = "trade"
wsKlines = "kline"
wsAccountInfo = "outboundAccountInfo"
wsOrderExecution = "executionReport"
wsTickerInfo = "ticketInfo"
sub = "sub" // event for subscribe
cancel = "cancel" // event for unsubscribe
)
var comms = make(chan stream.Response)
// WsConnect connects to a websocket feed
func (by *Bybit) WsConnect() error {
if !by.Websocket.IsEnabled() || !by.IsEnabled() || !by.IsAssetWebsocketSupported(asset.Spot) {
return errors.New(stream.WebsocketNotEnabled)
}
var dialer websocket.Dialer
err := by.Websocket.Conn.Dial(&dialer, http.Header{})
if err != nil {
return err
}
by.Websocket.Conn.SetupPingHandler(stream.PingHandler{
MessageType: websocket.TextMessage,
Message: []byte(`{"op":"ping"}`),
Delay: bybitWebsocketTimer,
})
by.Websocket.Wg.Add(1)
go by.wsReadData(by.Websocket.Conn)
if by.IsWebsocketAuthenticationSupported() {
err = by.WsAuth(context.TODO())
if err != nil {
by.Websocket.DataHandler <- err
by.Websocket.SetCanUseAuthenticatedEndpoints(false)
}
}
by.Websocket.Wg.Add(1)
go by.WsDataHandler()
return nil
}
// WsAuth sends an authentication message to receive auth data
func (by *Bybit) WsAuth(ctx context.Context) error {
var dialer websocket.Dialer
err := by.Websocket.AuthConn.Dial(&dialer, http.Header{})
if err != nil {
return err
}
by.Websocket.AuthConn.SetupPingHandler(stream.PingHandler{
MessageType: websocket.TextMessage,
Message: []byte(`{"op":"ping"}`),
Delay: bybitWebsocketTimer,
})
by.Websocket.Wg.Add(1)
go by.wsReadData(by.Websocket.AuthConn)
creds, err := by.GetCredentials(ctx)
if err != nil {
return err
}
intNonce := (time.Now().Unix() + 1) * 1000
strNonce := strconv.FormatInt(intNonce, 10)
hmac, err := crypto.GetHMAC(
crypto.HashSHA256,
[]byte("GET/realtime"+strNonce),
[]byte(creds.Secret),
)
if err != nil {
return err
}
sign := crypto.HexEncodeToString(hmac)
req := Authenticate{
Operation: "auth",
Args: []interface{}{creds.Key, intNonce, sign},
}
return by.Websocket.AuthConn.SendJSONMessage(req)
}
// Subscribe sends a websocket message to receive data from the channel
func (by *Bybit) Subscribe(channelsToSubscribe []stream.ChannelSubscription) error {
var errs common.Errors
for i := range channelsToSubscribe {
var subReq WsReq
subReq.Topic = channelsToSubscribe[i].Channel
subReq.Event = sub
formattedPair, err := by.FormatExchangeCurrency(channelsToSubscribe[i].Currency, asset.Spot)
if err != nil {
errs = append(errs, err)
continue
}
if channelsToSubscribe[i].Channel == wsKlines {
subReq.Parameters = WsParams{
Symbol: formattedPair.String(),
IsBinary: true,
KlineType: "1m",
}
} else {
subReq.Parameters = WsParams{
Symbol: formattedPair.String(),
IsBinary: true,
}
}
err = by.Websocket.Conn.SendJSONMessage(subReq)
if err != nil {
errs = append(errs, err)
continue
}
by.Websocket.AddSuccessfulSubscriptions(channelsToSubscribe[i])
}
if errs != nil {
return errs
}
return nil
}
// Unsubscribe sends a websocket message to stop receiving data from the channel
func (by *Bybit) Unsubscribe(channelsToUnsubscribe []stream.ChannelSubscription) error {
var errs common.Errors
for i := range channelsToUnsubscribe {
var unSub WsReq
unSub.Event = cancel
unSub.Topic = channelsToUnsubscribe[i].Channel
formattedPair, err := by.FormatExchangeCurrency(channelsToUnsubscribe[i].Currency, asset.Spot)
if err != nil {
errs = append(errs, err)
continue
}
unSub.Parameters = WsParams{
Symbol: formattedPair.String(),
}
err = by.Websocket.Conn.SendJSONMessage(unSub)
if err != nil {
errs = append(errs, err)
continue
}
by.Websocket.RemoveSuccessfulUnsubscriptions(channelsToUnsubscribe[i])
}
if errs != nil {
return errs
}
return nil
}
// wsReadData receives and passes on websocket messages for processing
func (by *Bybit) wsReadData(ws stream.Connection) {
defer by.Websocket.Wg.Done()
for {
resp := ws.ReadMessage()
if resp.Raw == nil {
return
}
comms <- resp
}
}
// GenerateDefaultSubscriptions generates default subscription
func (by *Bybit) GenerateDefaultSubscriptions() ([]stream.ChannelSubscription, error) {
var subscriptions []stream.ChannelSubscription
var channels = []string{wsTicker, wsTrades, wsOrderbook, wsKlines}
pairs, err := by.GetEnabledPairs(asset.Spot)
if err != nil {
return nil, err
}
for z := range pairs {
for x := range channels {
subscriptions = append(subscriptions,
stream.ChannelSubscription{
Channel: channels[x],
Currency: pairs[z],
Asset: asset.Spot,
})
}
}
return subscriptions, nil
}
func stringToOrderStatus(status string) (order.Status, error) {
switch status {
case "NEW":
return order.New, nil
case "CANCELED":
return order.Cancelled, nil
case "REJECTED":
return order.Rejected, nil
case "TRADE":
return order.PartiallyFilled, nil
case "EXPIRED":
return order.Expired, nil
default:
return order.UnknownStatus, errors.New(status + " not recognised as order status")
}
}
// WsDataHandler handles data from wsReadData
func (by *Bybit) WsDataHandler() {
defer by.Websocket.Wg.Done()
for {
select {
case <-by.Websocket.ShutdownC:
return
case resp := <-comms:
err := by.wsHandleData(resp.Raw)
if err != nil {
by.Websocket.DataHandler <- err
}
}
}
}
func (by *Bybit) wsHandleData(respRaw []byte) error {
var result interface{}
err := json.Unmarshal(respRaw, &result)
if err != nil {
return err
}
switch d := result.(type) {
case map[string]interface{}:
if method, ok := d["event"].(string); ok {
if strings.EqualFold(method, sub) {
return nil
}
if strings.EqualFold(method, cancel) {
return nil
}
}
if t, ok := d["topic"].(string); ok {
switch t {
case wsOrderbook:
var data WsOrderbook
err := json.Unmarshal(respRaw, &data)
if err != nil {
return err
}
p, err := by.extractCurrencyPair(data.OBData.Symbol, asset.Spot)
if err != nil {
return err
}
err = by.wsUpdateOrderbook(&data.OBData, p, asset.Spot)
if err != nil {
return err
}
return nil
case wsTrades:
if !by.IsSaveTradeDataEnabled() {
return nil
}
var data WsTrade
err := json.Unmarshal(respRaw, &data)
if err != nil {
return err
}
p, err := by.extractCurrencyPair(data.Parameters.Symbol, asset.Spot)
if err != nil {
return err
}
side := order.Sell
if data.TradeData.Side {
side = order.Buy
}
return trade.AddTradesToBuffer(by.Name, trade.Data{
Timestamp: data.TradeData.Time.Time(),
CurrencyPair: p,
AssetType: asset.Spot,
Exchange: by.Name,
Price: data.TradeData.Price,
Amount: data.TradeData.Size,
Side: side,
TID: data.TradeData.ID,
})
case wsTicker:
var data WsSpotTicker
err := json.Unmarshal(respRaw, &data)
if err != nil {
return err
}
p, err := by.extractCurrencyPair(data.Ticker.Symbol, asset.Spot)
if err != nil {
return err
}
by.Websocket.DataHandler <- &ticker.Price{
ExchangeName: by.Name,
Bid: data.Ticker.Bid,
Ask: data.Ticker.Ask,
LastUpdated: data.Ticker.Time.Time(),
AssetType: asset.Spot,
Pair: p,
}
return nil
case wsKlines:
var data KlineStream
err := json.Unmarshal(respRaw, &data)
if err != nil {
return err
}
p, err := by.extractCurrencyPair(data.Kline.Symbol, asset.Spot)
if err != nil {
return err
}
by.Websocket.DataHandler <- stream.KlineData{
Pair: p,
AssetType: asset.Spot,
Exchange: by.Name,
StartTime: data.Kline.StartTime.Time(),
Interval: data.Parameters.KlineType,
OpenPrice: data.Kline.OpenPrice,
ClosePrice: data.Kline.ClosePrice,
HighPrice: data.Kline.HighPrice,
LowPrice: data.Kline.LowPrice,
Volume: data.Kline.Volume,
}
return nil
default:
by.Websocket.DataHandler <- stream.UnhandledMessageWarning{Message: by.Name + stream.UnhandledMessage + string(respRaw)}
}
}
if m, ok := d["auth"]; ok {
log.Infof(log.WebsocketMgr, "%v received auth response: %v", by.Name, m)
return nil
}
if m, ok := d["pong"]; ok {
log.Infof(log.WebsocketMgr, "%v received pong: %v", by.Name, m)
return nil
}
case []interface{}:
for i := range d {
obj, ok := d[i].(map[string]interface{})
if !ok {
return common.GetAssertError("map[string]interface{}", d[i])
}
e, ok := obj["e"].(string)
if !ok {
return common.GetAssertError("string", obj["e"])
}
switch e {
case wsAccountInfo:
var data []wsAccount
err := json.Unmarshal(respRaw, &data)
if err != nil {
return fmt.Errorf("%v - Could not convert to outboundAccountInfo structure %w",
by.Name,
err)
}
by.Websocket.DataHandler <- data
return nil
case wsOrderExecution:
var data []wsOrderUpdate
err := json.Unmarshal(respRaw, &data)
if err != nil {
return fmt.Errorf("%v - Could not convert to executionReport structure %w",
by.Name,
err)
}
for j := range data {
oType, err := order.StringToOrderType(data[j].OrderType)
if err != nil {
by.Websocket.DataHandler <- order.ClassificationError{
Exchange: by.Name,
OrderID: data[j].OrderID,
Err: err,
}
}
var oSide order.Side
oSide, err = order.StringToOrderSide(data[j].Side)
if err != nil {
by.Websocket.DataHandler <- order.ClassificationError{
Exchange: by.Name,
OrderID: data[j].OrderID,
Err: err,
}
}
var oStatus order.Status
oStatus, err = stringToOrderStatus(data[j].OrderStatus)
if err != nil {
by.Websocket.DataHandler <- order.ClassificationError{
Exchange: by.Name,
OrderID: data[j].OrderID,
Err: err,
}
}
p, err := by.extractCurrencyPair(data[j].Symbol, asset.Spot)
if err != nil {
return err
}
by.Websocket.DataHandler <- order.Detail{
Price: data[j].Price,
Amount: data[j].Quantity,
ExecutedAmount: data[j].CumulativeFilledQuantity,
RemainingAmount: data[j].Quantity - data[j].CumulativeFilledQuantity,
Exchange: by.Name,
OrderID: data[j].OrderID,
Type: oType,
Side: oSide,
Status: oStatus,
AssetType: asset.Spot,
Date: data[j].OrderCreationTime.Time(),
Pair: p,
ClientOrderID: data[j].ClientOrderID,
Trades: []order.TradeHistory{
{
Price: data[j].Price,
Amount: data[j].Quantity,
Exchange: by.Name,
Timestamp: data[j].OrderCreationTime.Time(),
},
},
}
}
return nil
case wsTickerInfo:
var data []wsOrderFilled
err := json.Unmarshal(respRaw, &data)
if err != nil {
return fmt.Errorf("%v - Could not convert to ticketInfo structure %w",
by.Name,
err)
}
for j := range data {
var oSide order.Side
oSide, err = order.StringToOrderSide(data[j].Side)
if err != nil {
by.Websocket.DataHandler <- order.ClassificationError{
Exchange: by.Name,
OrderID: data[j].OrderID,
Err: err,
}
}
p, err := by.extractCurrencyPair(data[j].Symbol, asset.Spot)
if err != nil {
return err
}
by.Websocket.DataHandler <- &order.Detail{
Exchange: by.Name,
OrderID: data[j].OrderID,
Side: oSide,
AssetType: asset.Spot,
Pair: p,
Price: data[j].Price,
Amount: data[j].Quantity,
Date: data[j].Timestamp.Time(),
Trades: []order.TradeHistory{
{
Price: data[j].Price,
Amount: data[j].Quantity,
Exchange: by.Name,
Timestamp: data[j].Timestamp.Time(),
TID: data[j].TradeID,
IsMaker: data[j].IsMaker,
},
},
}
}
return nil
}
}
}
return fmt.Errorf("unhandled stream data %s", string(respRaw))
}
func (by *Bybit) wsUpdateOrderbook(update *WsOrderbookData, p currency.Pair, assetType asset.Item) error {
if update == nil || (len(update.Asks) == 0 && len(update.Bids) == 0) {
return errors.New("no orderbook data")
}
asks := make([]orderbook.Item, len(update.Asks))
for i := range update.Asks {
target, err := strconv.ParseFloat(update.Asks[i][0], 64)
if err != nil {
return err
}
amount, err := strconv.ParseFloat(update.Asks[i][1], 64)
if err != nil {
return err
}
asks[i] = orderbook.Item{Price: target, Amount: amount}
}
bids := make([]orderbook.Item, len(update.Bids))
for i := range update.Bids {
target, err := strconv.ParseFloat(update.Bids[i][0], 64)
if err != nil {
return err
}
amount, err := strconv.ParseFloat(update.Bids[i][1], 64)
if err != nil {
return err
}
bids[i] = orderbook.Item{Price: target, Amount: amount}
}
return by.Websocket.Orderbook.LoadSnapshot(&orderbook.Base{
Bids: bids,
Asks: asks,
Pair: p,
LastUpdated: update.Time.Time(),
Asset: assetType,
Exchange: by.Name,
VerifyOrderbook: by.CanVerifyOrderbook,
})
}