mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-16 23:16:48 +00:00
* added mfi and example * renamed to moving average * converted to array return type and added obv and mfi * started work on test coverage * test coverage added for rsi & mfi * test coverage added for all indicators removed go mod replace moved to append helper method * moved all indicators to new appendTo and increased test coverage * added additional test and bumped go-talib to latest commi * go.mod update * linter fixes * go mod clean up * small fixes * reverted changes from previous attempt to rework as data is still incorrect now passing full OHLCV data back to script binding * testing new structure of passing full ohlcv data * started linking ohlcv to gctscript * OHCLV link up completed reworking passing back to indicators started * OHCLV link up completed reworking passing back to indicators started * added test coverage for tofloat * linter fixes (gofmt) * removed unused value * improved test coverage * added correct detection for 1w added ParseInterval test coverage moved OHCLV string to const * removed unused value * first round of changes addressed * all indicators have been split with packages named after each indicator and a new calculate() method added * linters * fixed tests * added check to check ta is running in validator for uploading * Added test data for OHLCV testing new indicator interface for wrapper * typed const to float64 * reworked validator data to generate previous timestamps * rewored macd to return slice of array * adding bbands linking and example * why didn't this pick it up before :D * bumped up total number of modules for test * moved parseIndicator to exchange added comments * test coverage added for ParseMAType & ParseIndicatorSelector * gofmt * WIP changes * updated tests for bbands & obv bumped to latest go-talib * move multiple use strong to const * reverted rpc.pb.go to master * added 4w option * removed selector from obv as unneeded * improved test coverage and reworked all indicator methods on how they pass errors back * order incoming OHCLV data * revert go.mod * removed verbose toggles * added spot asset type * removed 4w as its unused/uncommon * renamed * reworked further tests * converted all examples to use coinbasepro for consistency * updated all date ranges to 2019 + 6 months * backported binance OHLCV wrapper from #479 * removed o * rounded numbers * chnage requests addressed and attempt to fix MACD... today has been really unproctive code wise :D * Migrated to gct-ta library * Corrected test import * wording changes on test * removed TA lib from go.mod * PR changes addressed Removed parallel running from tests due to slight possibility in very extreme cases TestExecution might not be set to the expected value and will cause lower test coverage * removed pkg folder * bumped gct-ta version * gct-ta version bump
81 lines
2.2 KiB
Go
81 lines
2.2 KiB
Go
package indicators
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"math"
|
|
"strings"
|
|
|
|
objects "github.com/d5/tengo/v2"
|
|
"github.com/thrasher-corp/gct-ta/indicators"
|
|
"github.com/thrasher-corp/gocryptotrader/gctscript/modules"
|
|
"github.com/thrasher-corp/gocryptotrader/gctscript/wrappers/validator"
|
|
)
|
|
|
|
// MACDModule MACD indicator commands
|
|
var MACDModule = map[string]objects.Object{
|
|
"calculate": &objects.UserFunction{Name: "calculate", Value: macd},
|
|
}
|
|
|
|
func macd(args ...objects.Object) (objects.Object, error) {
|
|
if len(args) != 4 {
|
|
return nil, objects.ErrWrongNumArguments
|
|
}
|
|
|
|
r := &objects.Array{}
|
|
if validator.IsTestExecution.Load() == true {
|
|
return r, nil
|
|
}
|
|
|
|
ohlcvInput := objects.ToInterface(args[0])
|
|
ohlcvInputData, valid := ohlcvInput.([]interface{})
|
|
if !valid {
|
|
return nil, fmt.Errorf(modules.ErrParameterConvertFailed, OHLCV)
|
|
}
|
|
|
|
var ohlcvClose []float64
|
|
var allErrors []string
|
|
for x := range ohlcvInputData {
|
|
t := ohlcvInputData[x].([]interface{})
|
|
value, err := toFloat64(t[4])
|
|
if err != nil {
|
|
allErrors = append(allErrors, err.Error())
|
|
}
|
|
ohlcvClose = append(ohlcvClose, value)
|
|
}
|
|
|
|
inFastPeriod, ok := objects.ToInt(args[1])
|
|
if !ok {
|
|
allErrors = append(allErrors, fmt.Sprintf(modules.ErrParameterConvertFailed, inFastPeriod))
|
|
}
|
|
|
|
inSlowPeriod, ok := objects.ToInt(args[2])
|
|
if !ok {
|
|
allErrors = append(allErrors, fmt.Sprintf(modules.ErrParameterConvertFailed, inSlowPeriod))
|
|
}
|
|
|
|
inTimePeriod, ok := objects.ToInt(args[3])
|
|
if !ok {
|
|
allErrors = append(allErrors, fmt.Sprintf(modules.ErrParameterConvertFailed, inTimePeriod))
|
|
}
|
|
|
|
if len(allErrors) > 0 {
|
|
return nil, errors.New(strings.Join(allErrors, ", "))
|
|
}
|
|
|
|
macd, macdSignal, macdHist := indicators.MACD(ohlcvClose, inFastPeriod, inSlowPeriod, inTimePeriod)
|
|
for x := range macdHist {
|
|
tempMACD := &objects.Array{}
|
|
tempMACD.Value = append(tempMACD.Value, &objects.Float{Value: math.Round(macdHist[x]*100) / 100})
|
|
if macd != nil {
|
|
tempMACD.Value = append(tempMACD.Value, &objects.Float{Value: math.Round(macd[x]*100) / 100})
|
|
}
|
|
if macdSignal != nil {
|
|
tempMACD.Value = append(tempMACD.Value, &objects.Float{Value: math.Round(macdSignal[x]*100) / 100})
|
|
}
|
|
r.Value = append(r.Value, tempMACD)
|
|
}
|
|
|
|
return r, nil
|
|
}
|