mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-30 23:16:52 +00:00
* reworked request struct and exchange response started work on validation system * removed import cycle until work around * Added intial withdraw support via CLI added * Added Crypto command to gctcli * moved var declartion to single line * Test updates for binance and anx * All exchange tests have been updated test coverage added to validate * First pass at adding withdrawl select from database * started adding basic lru cache system * Added basic LRU cache including Add Get Remove Contains ContainsOrAdd Clear * wording changes on comments * removed exported var's in strut as they are not required * Added README * README updates * corrected ID on commands * rm line :D * merged in origin/cache * linter fixes (gofmt) * Added basic cache lookup to events * swapped to mutex over rwmutex updated comments * unexported getNewest & getOldest * unexported getNewest & getOldest * Updated comments and cited references in source * updated comments * WIP * Migrated exchange WithdrawFiat wrapper to new struct response * Migrated exchange WithdrawFiat wrapper to new struct response * started work on bank management * Added exchange level banking details back with migration to banking package * Removed broken tests for now * Added validation to bank accounts * removed duplicate bank details from withdraw struct * Test coverage increased * gofmt * merged upstream/master with clean up * First pass at adding command line linking to gctcli * added validation for crypto address, added gctcli support to retreive previous withdrawal requests * general cleanup * general cleanup * reordered imports * Increased test coverage moved to database sublogger * Pass incorrect currency no longer return error from c.CheckBankAccountConfig * remove TestMain() for now as other tests in this package will need to be reworked * Happy little race car * Reverted to upstream tests * Added test covarege for validation method, corrected response on cli protobuf * query clean up and removal of duplicated code * cleaned up queries into singlem ethod increased test coverage * Migrated international fund withdraw to new exchange response and added cache size override * Migrated international fund withdraw to new exchange response and added cache size override * Extended gctcli commands * lowered default cache to 25 * small code clean up * added get by date method * add returned error * cli commands cleaing return error on nil results to fix out of bounds * merged write & read helpers into one for test coverage and increased engine/withdraw test coverage * gofmt * Added test coverage for valid ID * removed unused param * converted to use timestamp package from protobuf * gofmt * use built in RFC3339 timestamp * remove setting of CreatedAt & UpdatedAt and allow ORm to take care of it * also use ptype on byid * code flow improvements * remove inverse conditional check and linters run * removed test data * removed comment * removed comment * also write failures to database for auditing * converted to use default time for start & end * Default to time.Now() minus 30 days * Default to time.Now() minus 30 days * small code clean up * fixed missing semicolon on migrations, code clean up * updated sqlite migrations * Added additonal check for exchange level bank account if global is not found * case sensativity fix for currency names * use correct compare * test coverage fixed * removed space * return pointer to banking.Account * return pointer to banking.Account * added else check back to validate() * Added empty string as default to migration over NULL due to retrivial of data
148 lines
3.5 KiB
Go
148 lines
3.5 KiB
Go
package banking
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/thrasher-corp/gocryptotrader/currency"
|
|
)
|
|
|
|
var (
|
|
testBankAccounts = []Account{
|
|
{
|
|
Enabled: true,
|
|
ID: "valid-test-bank-01",
|
|
BankName: "Test Bank",
|
|
BankAddress: "42 Bank Street",
|
|
BankPostalCode: "13337",
|
|
BankPostalCity: "Satoshiville",
|
|
BankCountry: "Japan",
|
|
AccountName: "Satoshi Nakamoto",
|
|
AccountNumber: "0234",
|
|
SWIFTCode: "91272837",
|
|
BSBNumber: "123456",
|
|
IBAN: "98218738671897",
|
|
SupportedCurrencies: "AUD,USD",
|
|
SupportedExchanges: "test-exchange",
|
|
},
|
|
{
|
|
Enabled: false,
|
|
ID: "invalid-test-bank-01",
|
|
BankName: "",
|
|
BankAddress: "",
|
|
BankPostalCode: "",
|
|
BankPostalCity: "",
|
|
BankCountry: "",
|
|
AccountName: "",
|
|
AccountNumber: "",
|
|
SWIFTCode: "",
|
|
BSBNumber: "",
|
|
IBAN: "",
|
|
SupportedCurrencies: "",
|
|
SupportedExchanges: "",
|
|
},
|
|
}
|
|
)
|
|
|
|
func TestMain(m *testing.M) {
|
|
Accounts = append(Accounts, testBankAccounts...)
|
|
os.Exit(m.Run())
|
|
}
|
|
|
|
func TestGetBankAccountByID(t *testing.T) {
|
|
_, err := GetBankAccountByID("valid-test-bank-01")
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
_, err = GetBankAccountByID("invalid-test-")
|
|
if err == nil {
|
|
t.Error("error expected for invalid account received nil")
|
|
}
|
|
}
|
|
|
|
func TestAccount_Validate(t *testing.T) {
|
|
valid, err := GetBankAccountByID("valid-test-bank-01")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err = valid.Validate(); err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
invalid := testBankAccounts[1]
|
|
if err = invalid.Validate(); err == nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
invalid = testBankAccounts[0]
|
|
invalid.SupportedCurrencies = "AUD"
|
|
invalid.BSBNumber = ""
|
|
if err = invalid.Validate(); err == nil {
|
|
t.Error("Expected error when Currency is AUD but no BSB set")
|
|
}
|
|
|
|
invalid = testBankAccounts[0]
|
|
invalid.SupportedExchanges = ""
|
|
if err = invalid.Validate(); err != nil {
|
|
t.Error("Expected error when Currency is AUD but no BSB set")
|
|
}
|
|
if invalid.SupportedExchanges != "ALL" {
|
|
t.Error("expected SupportedExchanges to return \"ALL\" after validation")
|
|
}
|
|
|
|
invalid = testBankAccounts[0]
|
|
invalid.SWIFTCode = ""
|
|
invalid.IBAN = ""
|
|
invalid.SupportedCurrencies = "USD"
|
|
if err = invalid.Validate(); err == nil {
|
|
t.Error("Expected error when no Swift/IBAN set")
|
|
}
|
|
}
|
|
|
|
func TestAccount_ValidateForWithdrawal(t *testing.T) {
|
|
v, err := GetBankAccountByID("valid-test-bank-01")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
errWith := v.ValidateForWithdrawal("test-exchange", currency.AUD)
|
|
if errWith != nil {
|
|
t.Fatal(errWith)
|
|
}
|
|
v.BSBNumber = ""
|
|
errWith = v.ValidateForWithdrawal("test-exchange", currency.AUD)
|
|
if errWith != nil {
|
|
if errWith[0] != ErrBSBRequiredforAUD {
|
|
t.Fatal(errWith)
|
|
}
|
|
}
|
|
v.SWIFTCode = ""
|
|
v.IBAN = ""
|
|
errWith = v.ValidateForWithdrawal("test-exchange", currency.USD)
|
|
if errWith != nil {
|
|
if errWith[0] != ErrIBANSwiftNotSet {
|
|
t.Fatal(errWith)
|
|
}
|
|
}
|
|
errWith = v.ValidateForWithdrawal("test-exchange-nope", currency.AUD)
|
|
if errWith != nil {
|
|
if errWith[0] != "Exchange test-exchange-nope not supported by bank account" {
|
|
t.Fatal(errWith)
|
|
}
|
|
}
|
|
v.AccountNumber = ""
|
|
errWith = v.ValidateForWithdrawal("test-exchange", currency.AUD)
|
|
if errWith != nil {
|
|
if errWith[0] != ErrAccountCannotBeEmpty {
|
|
t.Fatal(errWith)
|
|
}
|
|
}
|
|
v.Enabled = false
|
|
errWith = v.ValidateForWithdrawal("test-exchange", currency.AUD)
|
|
if errWith != nil {
|
|
if errWith[0] != ErrBankAccountDisabled {
|
|
t.Fatal(errWith)
|
|
}
|
|
}
|
|
}
|