mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-24 23:16:52 +00:00
* reworked request struct and exchange response started work on validation system * removed import cycle until work around * Added intial withdraw support via CLI added * Added Crypto command to gctcli * moved var declartion to single line * Test updates for binance and anx * All exchange tests have been updated test coverage added to validate * First pass at adding withdrawl select from database * started adding basic lru cache system * Added basic LRU cache including Add Get Remove Contains ContainsOrAdd Clear * wording changes on comments * removed exported var's in strut as they are not required * Added README * README updates * corrected ID on commands * rm line :D * merged in origin/cache * linter fixes (gofmt) * Added basic cache lookup to events * swapped to mutex over rwmutex updated comments * unexported getNewest & getOldest * unexported getNewest & getOldest * Updated comments and cited references in source * updated comments * WIP * Migrated exchange WithdrawFiat wrapper to new struct response * Migrated exchange WithdrawFiat wrapper to new struct response * started work on bank management * Added exchange level banking details back with migration to banking package * Removed broken tests for now * Added validation to bank accounts * removed duplicate bank details from withdraw struct * Test coverage increased * gofmt * merged upstream/master with clean up * First pass at adding command line linking to gctcli * added validation for crypto address, added gctcli support to retreive previous withdrawal requests * general cleanup * general cleanup * reordered imports * Increased test coverage moved to database sublogger * Pass incorrect currency no longer return error from c.CheckBankAccountConfig * remove TestMain() for now as other tests in this package will need to be reworked * Happy little race car * Reverted to upstream tests * Added test covarege for validation method, corrected response on cli protobuf * query clean up and removal of duplicated code * cleaned up queries into singlem ethod increased test coverage * Migrated international fund withdraw to new exchange response and added cache size override * Migrated international fund withdraw to new exchange response and added cache size override * Extended gctcli commands * lowered default cache to 25 * small code clean up * added get by date method * add returned error * cli commands cleaing return error on nil results to fix out of bounds * merged write & read helpers into one for test coverage and increased engine/withdraw test coverage * gofmt * Added test coverage for valid ID * removed unused param * converted to use timestamp package from protobuf * gofmt * use built in RFC3339 timestamp * remove setting of CreatedAt & UpdatedAt and allow ORm to take care of it * also use ptype on byid * code flow improvements * remove inverse conditional check and linters run * removed test data * removed comment * removed comment * also write failures to database for auditing * converted to use default time for start & end * Default to time.Now() minus 30 days * Default to time.Now() minus 30 days * small code clean up * fixed missing semicolon on migrations, code clean up * updated sqlite migrations * Added additonal check for exchange level bank account if global is not found * case sensativity fix for currency names * use correct compare * test coverage fixed * removed space * return pointer to banking.Account * return pointer to banking.Account * added else check back to validate() * Added empty string as default to migration over NULL due to retrivial of data
95 lines
2.3 KiB
Go
95 lines
2.3 KiB
Go
package banking
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/thrasher-corp/gocryptotrader/common"
|
|
"github.com/thrasher-corp/gocryptotrader/currency"
|
|
)
|
|
|
|
// GetBankAccountByID Returns a bank account based on its ID
|
|
func GetBankAccountByID(id string) (*Account, error) {
|
|
m.Lock()
|
|
defer m.Unlock()
|
|
|
|
for x := range Accounts {
|
|
if strings.EqualFold(Accounts[x].ID, id) {
|
|
return &Accounts[x], nil
|
|
}
|
|
}
|
|
return nil, fmt.Errorf(ErrBankAccountNotFound, id)
|
|
}
|
|
|
|
// ExchangeSupported Checks if exchange is supported by bank account
|
|
func (b *Account) ExchangeSupported(exchange string) bool {
|
|
exchList := strings.Split(b.SupportedExchanges, ",")
|
|
return common.StringDataCompareInsensitive(exchList, exchange)
|
|
}
|
|
|
|
// Validate validates bank account settings
|
|
func (b *Account) Validate() error {
|
|
if b.BankName == "" ||
|
|
b.BankAddress == "" ||
|
|
b.BankPostalCode == "" ||
|
|
b.BankPostalCity == "" ||
|
|
b.BankCountry == "" ||
|
|
b.AccountName == "" ||
|
|
b.SupportedCurrencies == "" {
|
|
return fmt.Errorf(
|
|
"banking details for %s is enabled but variables not set correctly",
|
|
b.BankName)
|
|
}
|
|
|
|
if b.SupportedExchanges == "" {
|
|
b.SupportedExchanges = "ALL"
|
|
}
|
|
|
|
if strings.Contains(strings.ToUpper(
|
|
b.SupportedCurrencies),
|
|
currency.AUD.String()) {
|
|
if b.BSBNumber == "" {
|
|
return fmt.Errorf(
|
|
"banking details for %s is enabled but BSB/SWIFT values not set",
|
|
b.BankName)
|
|
}
|
|
} else {
|
|
if b.IBAN == "" && b.SWIFTCode == "" {
|
|
return fmt.Errorf(
|
|
"banking details for %s is enabled but SWIFT/IBAN values not set",
|
|
b.BankName)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ValidateForWithdrawal confirms bank account meets minimum requirements to submit
|
|
// a withdrawal request
|
|
func (b *Account) ValidateForWithdrawal(exchange string, cur currency.Code) (err []string) {
|
|
if !b.Enabled {
|
|
err = append(err, ErrBankAccountDisabled)
|
|
}
|
|
if !b.ExchangeSupported(exchange) {
|
|
err = append(err, "Exchange "+exchange+" not supported by bank account")
|
|
}
|
|
|
|
if b.AccountNumber == "" {
|
|
err = append(err, ErrAccountCannotBeEmpty)
|
|
}
|
|
|
|
if !common.StringDataCompareInsensitive(strings.Split(b.SupportedCurrencies, ","), cur.String()) {
|
|
err = append(err, ErrCurrencyNotSupportedByAccount)
|
|
}
|
|
|
|
if cur.Upper() == currency.AUD {
|
|
if b.BSBNumber == "" {
|
|
err = append(err, ErrBSBRequiredforAUD)
|
|
}
|
|
} else {
|
|
if b.IBAN == "" && b.SWIFTCode == "" {
|
|
err = append(err, ErrIBANSwiftNotSet)
|
|
}
|
|
}
|
|
return
|
|
}
|