mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-13 15:09:42 +00:00
fafee93e1b
* Sonic: Add sonic_on build tag Thinking about other ways to do this, but they amount to the same thing. It's messy, but I don't have another idea. * Okx: Remove redundant useAsIs on slices Slices are automatically used-as-is, so passing true for these types was unnecessary. Removing the field simplifies rationalising inverting the flag * Okx: Unify timestamp response types * Okx: Change ResetRFQMMPStatus to return a types.Time * Okx: Move withdrawData type to types * Okx: Fix AccountConfiguration slice return * Okx: Improve SendHTTPRequest documentation * Okx: Extend tests for UseAsIs non-defaults * Okx: Fix GetPublicUnderlying with sonic 1.12.9 Using **result for slices with useAsItIs causes sonic to fail. This might be addressed upstream, but it's also not clear what the unmarshal behaviour for an untyped reference to a typed reference should be in the RFC, so we could get a golang.org/encoding/json regression on this too. There's no harm in fixing this, for consistency, to match our handling for non-slice []any wrapping to just use the pointer as is. Note: As of today this requires sonic:main for this to work, because of the other bug: ``` M go.mod - github.com/bytedance/sonic v1.12.9 + github.com/bytedance/sonic v1.12.10-0.20250224121557-e30ac4f2e4fe ``` * Okx: Remove redundant slice check This code didn't work, and if I make it look at rv.Elem().Kind() it errors. Haven't dug too deeply but right now I think we just remove it. * Okx: Simplify SendHTTPRequest by removing UseAsIs Looks to be entirely derivable * Okx: Remove http check that resps must contain data GetAnnouncementTyeps failing in US because of empty response. But also any situation where there really is no data. e.g. GetCandlesticks might return no candlesticks for a period and instrument, because there aren't any. That shouldn't be an error. More saliently if you request orders, or something similar. So, since that check wasn't working before, and it's causing issues now, I'm going to remove it. * Okx: Fix TestGetAnnouncementTypes failing in US announcement-types returns empty in the US, where our github actions run. That's kinda okay. Just don't test we get any back * Sonic: Default to sonic off We've seen too many fatal panics and races with sonic, both in GCT runs and being reported in sonic, to default to it being turned on right now. Whilst we have faith sonic will get through these with time, for now the sensible thing to do for our users is make sonic opt-in. This also removes any of the conditions around 386, etc. If someone wants to run with sonic, they can. Most notably if they're trying out an experimental sonic branch that supports 386, etc.
24 lines
1.1 KiB
Go
24 lines
1.1 KiB
Go
//go:build !sonic_on
|
|
|
|
package json
|
|
|
|
import "encoding/json" //nolint:depguard // Acceptable use in gct json wrapper
|
|
|
|
// Implementation is a constant string that represents the current JSON implementation package
|
|
const Implementation = "encoding/json"
|
|
|
|
var (
|
|
// Marshal returns the JSON encoding of v. See the "encoding/json" documentation for Marshal
|
|
Marshal = json.Marshal
|
|
// Unmarshal parses the JSON-encoded data and stores the result in the value pointed to by v. See the "encoding/json" documentation for Unmarshal
|
|
Unmarshal = json.Unmarshal
|
|
// NewEncoder returns a new encoder that writes to w. See the "encoding/json" documentation for NewEncoder
|
|
NewEncoder = json.NewEncoder
|
|
// NewDecoder returns a new decoder that reads from r. See the "encoding/json" documentation for NewDecoder
|
|
NewDecoder = json.NewDecoder
|
|
// MarshalIndent is like Marshal but applies Indent to format the output. See the "encoding/json" documentation for MarshalIndent
|
|
MarshalIndent = json.MarshalIndent
|
|
// Valid reports whether data is a valid JSON encoding. See the "encoding/json" documentation for Valid
|
|
Valid = json.Valid
|
|
)
|