mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-21 07:26:48 +00:00
* reworked request struct and exchange response started work on validation system * removed import cycle until work around * Added intial withdraw support via CLI added * Added Crypto command to gctcli * moved var declartion to single line * Test updates for binance and anx * All exchange tests have been updated test coverage added to validate * First pass at adding withdrawl select from database * started adding basic lru cache system * Added basic LRU cache including Add Get Remove Contains ContainsOrAdd Clear * wording changes on comments * removed exported var's in strut as they are not required * Added README * README updates * corrected ID on commands * rm line :D * merged in origin/cache * linter fixes (gofmt) * Added basic cache lookup to events * swapped to mutex over rwmutex updated comments * unexported getNewest & getOldest * unexported getNewest & getOldest * Updated comments and cited references in source * updated comments * WIP * Migrated exchange WithdrawFiat wrapper to new struct response * Migrated exchange WithdrawFiat wrapper to new struct response * started work on bank management * Added exchange level banking details back with migration to banking package * Removed broken tests for now * Added validation to bank accounts * removed duplicate bank details from withdraw struct * Test coverage increased * gofmt * merged upstream/master with clean up * First pass at adding command line linking to gctcli * added validation for crypto address, added gctcli support to retreive previous withdrawal requests * general cleanup * general cleanup * reordered imports * Increased test coverage moved to database sublogger * Pass incorrect currency no longer return error from c.CheckBankAccountConfig * remove TestMain() for now as other tests in this package will need to be reworked * Happy little race car * Reverted to upstream tests * Added test covarege for validation method, corrected response on cli protobuf * query clean up and removal of duplicated code * cleaned up queries into singlem ethod increased test coverage * Migrated international fund withdraw to new exchange response and added cache size override * Migrated international fund withdraw to new exchange response and added cache size override * Extended gctcli commands * lowered default cache to 25 * small code clean up * added get by date method * add returned error * cli commands cleaing return error on nil results to fix out of bounds * merged write & read helpers into one for test coverage and increased engine/withdraw test coverage * gofmt * Added test coverage for valid ID * removed unused param * converted to use timestamp package from protobuf * gofmt * use built in RFC3339 timestamp * remove setting of CreatedAt & UpdatedAt and allow ORm to take care of it * also use ptype on byid * code flow improvements * remove inverse conditional check and linters run * removed test data * removed comment * removed comment * also write failures to database for auditing * converted to use default time for start & end * Default to time.Now() minus 30 days * Default to time.Now() minus 30 days * small code clean up * fixed missing semicolon on migrations, code clean up * updated sqlite migrations * Added additonal check for exchange level bank account if global is not found * case sensativity fix for currency names * use correct compare * test coverage fixed * removed space * return pointer to banking.Account * return pointer to banking.Account * added else check back to validate() * Added empty string as default to migration over NULL due to retrivial of data
272 lines
5.8 KiB
Go
272 lines
5.8 KiB
Go
package withdraw
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/thrasher-corp/gocryptotrader/core"
|
|
"github.com/thrasher-corp/gocryptotrader/currency"
|
|
"github.com/thrasher-corp/gocryptotrader/portfolio"
|
|
"github.com/thrasher-corp/gocryptotrader/portfolio/banking"
|
|
)
|
|
|
|
const (
|
|
testBTCAddress = "0xTHISISALEGITBTCADDRESSHONEST"
|
|
)
|
|
|
|
var (
|
|
validFiatRequest = &Request{
|
|
Fiat: &FiatRequest{},
|
|
Exchange: "test-exchange",
|
|
Currency: currency.AUD,
|
|
Description: "Test Withdrawal",
|
|
Amount: 0.1,
|
|
Type: Fiat,
|
|
}
|
|
|
|
invalidRequest = &Request{
|
|
Type: Fiat,
|
|
}
|
|
|
|
invalidCurrencyFiatRequest = &Request{
|
|
Fiat: &FiatRequest{
|
|
Bank: &banking.Account{},
|
|
},
|
|
Currency: currency.BTC,
|
|
Amount: 1,
|
|
Type: Fiat,
|
|
}
|
|
|
|
validCryptoRequest = &Request{
|
|
Crypto: &CryptoRequest{
|
|
Address: core.BitcoinDonationAddress,
|
|
},
|
|
Currency: currency.BTC,
|
|
Description: "Test Withdrawal",
|
|
Amount: 0.1,
|
|
Type: Crypto,
|
|
}
|
|
|
|
invalidCryptoNilRequest = &Request{
|
|
Currency: currency.BTC,
|
|
Description: "Test Withdrawal",
|
|
Amount: 0.1,
|
|
Type: Crypto,
|
|
}
|
|
|
|
invalidCryptoNegativeFeeRequest = &Request{
|
|
Crypto: &CryptoRequest{
|
|
Address: core.BitcoinDonationAddress,
|
|
FeeAmount: -0.1,
|
|
},
|
|
Currency: currency.BTC,
|
|
Description: "Test Withdrawal",
|
|
Amount: 0.1,
|
|
Type: Crypto,
|
|
}
|
|
|
|
invalidCurrencyCryptoRequest = &Request{
|
|
Crypto: &CryptoRequest{
|
|
Address: core.BitcoinDonationAddress,
|
|
},
|
|
Currency: currency.AUD,
|
|
Amount: 0,
|
|
Type: Crypto,
|
|
}
|
|
|
|
invalidCryptoNoAddressRequest = &Request{
|
|
Crypto: &CryptoRequest{},
|
|
Currency: currency.BTC,
|
|
Description: "Test Withdrawal",
|
|
Amount: 0.1,
|
|
Type: Crypto,
|
|
}
|
|
|
|
invalidCryptoNonWhiteListedAddressRequest = &Request{
|
|
Crypto: &CryptoRequest{
|
|
Address: testBTCAddress,
|
|
},
|
|
Currency: currency.BTC,
|
|
Description: "Test Withdrawal",
|
|
Amount: 0.1,
|
|
Type: Crypto,
|
|
}
|
|
|
|
invalidType = &Request{
|
|
Type: Unknown,
|
|
Currency: currency.BTC,
|
|
Amount: 0.1,
|
|
}
|
|
)
|
|
|
|
func TestMain(m *testing.M) {
|
|
err := portfolio.Portfolio.AddAddress(core.BitcoinDonationAddress, "test", currency.BTC, 1500)
|
|
if err != nil {
|
|
fmt.Printf("failed to add portfolio address with reason: %v, unable to continue tests", err)
|
|
os.Exit(0)
|
|
}
|
|
portfolio.Portfolio.Addresses[0].WhiteListed = true
|
|
portfolio.Portfolio.Addresses[0].ColdStorage = true
|
|
portfolio.Portfolio.Addresses[0].SupportedExchanges = "BTC Markets,Binance"
|
|
|
|
err = portfolio.Portfolio.AddAddress(testBTCAddress, "test", currency.BTC, 1500)
|
|
if err != nil {
|
|
fmt.Printf("failed to add portfolio address with reason: %v, unable to continue tests", err)
|
|
os.Exit(0)
|
|
}
|
|
portfolio.Portfolio.Addresses[1].SupportedExchanges = "BTC Markets,Binance"
|
|
|
|
banking.Accounts = append(banking.Accounts,
|
|
banking.Account{
|
|
Enabled: true,
|
|
ID: "test-bank-01",
|
|
BankName: "Test Bank",
|
|
BankAddress: "42 Bank Street",
|
|
BankPostalCode: "13337",
|
|
BankPostalCity: "Satoshiville",
|
|
BankCountry: "Japan",
|
|
AccountName: "Satoshi Nakamoto",
|
|
AccountNumber: "0234",
|
|
BSBNumber: "123456",
|
|
SWIFTCode: "91272837",
|
|
IBAN: "98218738671897",
|
|
SupportedCurrencies: "AUD,USD",
|
|
SupportedExchanges: "test-exchange",
|
|
},
|
|
)
|
|
|
|
os.Exit(m.Run())
|
|
}
|
|
|
|
func TestValid(t *testing.T) {
|
|
err := Validate(invalidType)
|
|
if err != nil {
|
|
if err.Error() != ErrInvalidRequest.Error() {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateFiat(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
request *Request
|
|
requestType RequestType
|
|
bankAccountID string
|
|
output interface{}
|
|
}{
|
|
{
|
|
"Valid",
|
|
validFiatRequest,
|
|
Fiat,
|
|
"test-bank-01",
|
|
nil,
|
|
},
|
|
{
|
|
"Invalid",
|
|
invalidRequest,
|
|
Fiat,
|
|
"",
|
|
errors.New("invalid request type"),
|
|
},
|
|
{
|
|
name: "NoRequest",
|
|
request: nil,
|
|
requestType: 3,
|
|
output: ErrRequestCannotBeNil,
|
|
},
|
|
{
|
|
"CryptoCurrency",
|
|
invalidCurrencyFiatRequest,
|
|
Fiat,
|
|
"",
|
|
errors.New(ErrStrCurrencyNotFiat + ", " + banking.ErrBankAccountDisabled + ", " + banking.ErrAccountCannotBeEmpty + ", " + banking.ErrCurrencyNotSupportedByAccount + ", " + banking.ErrIBANSwiftNotSet),
|
|
},
|
|
}
|
|
|
|
for _, tests := range testCases {
|
|
test := tests
|
|
t.Run(test.name, func(t *testing.T) {
|
|
if test.requestType < 3 {
|
|
test.request.Type = test.requestType
|
|
}
|
|
if test.bankAccountID != "" {
|
|
v, err := banking.GetBankAccountByID(test.bankAccountID)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
test.request.Fiat.Bank = v
|
|
}
|
|
err := Validate(test.request)
|
|
if err != nil {
|
|
if test.output.(error).Error() != err.Error() {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidateCrypto(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
request *Request
|
|
output interface{}
|
|
}{
|
|
{
|
|
"Valid",
|
|
validCryptoRequest,
|
|
nil,
|
|
},
|
|
{
|
|
"Invalid",
|
|
invalidRequest,
|
|
ErrInvalidRequest,
|
|
},
|
|
{
|
|
"Invalid-Nil",
|
|
invalidCryptoNilRequest,
|
|
ErrInvalidRequest,
|
|
},
|
|
{
|
|
"NoRequest",
|
|
nil,
|
|
ErrRequestCannotBeNil,
|
|
},
|
|
{
|
|
"FiatCurrency",
|
|
invalidCurrencyCryptoRequest,
|
|
errors.New(ErrStrAmountMustBeGreaterThanZero + ", " + ErrStrCurrencyNotCrypto),
|
|
},
|
|
{
|
|
"NoAddress",
|
|
invalidCryptoNoAddressRequest,
|
|
errors.New(ErrStrAddressNotWhiteListed + ", " + ErrStrExchangeNotSupportedByAddress + ", " + ErrStrAddressNotSet),
|
|
},
|
|
{
|
|
"NonWhiteListed",
|
|
invalidCryptoNonWhiteListedAddressRequest,
|
|
errors.New(ErrStrAddressNotWhiteListed),
|
|
},
|
|
{
|
|
"NegativeFee",
|
|
invalidCryptoNegativeFeeRequest,
|
|
errors.New(ErrStrFeeCannotBeNegative),
|
|
},
|
|
}
|
|
|
|
for _, tests := range testCases {
|
|
test := tests
|
|
t.Run(test.name, func(t *testing.T) {
|
|
err := Validate(test.request)
|
|
if err != nil {
|
|
if err.Error() != test.output.(error).Error() {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|