mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-14 07:26:47 +00:00
* GHA, tests: Add additional checks for common issues These checks include: - Ensuring that all testify funcs use their formatted variants (e.g., `assert.Equalf(t, expected, actual)` instead of `assert.Equal(t, expected, actual)`). - Replacing `%s` with %q - Enforcing consistent usage of should/must wording for testify assert/require messages * Add support for checking backticked string format specifiers and fix issues * tests: Fix error comparisons * tests: Replace errors.Is(err, nil) usage with testify and automate check * refactor: Rename ExtractPort to ExtractPortOrDefault * tests: Replace assert with require for error handling in multiple test files * tests: Replace assert with require for error handling and improve assertions in data tests * tests: Fix typo in assertion message for StreamVol test * OKX: Fix GetOpenInterestAndVolumeStrike test with instrument selection and improved assertions * OKX: Revert intentional error check * Improve error message for expiry time check in GetOpenInterestAndVolumeStrike test
240 lines
5.5 KiB
Go
240 lines
5.5 KiB
Go
package engine
|
|
|
|
import (
|
|
"errors"
|
|
"log"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/thrasher-corp/gocryptotrader/database"
|
|
"github.com/thrasher-corp/gocryptotrader/database/drivers"
|
|
)
|
|
|
|
func CreateDatabase(t *testing.T) {
|
|
t.Helper()
|
|
// fun workarounds to globals ruining testing
|
|
database.DB.DataPath = t.TempDir()
|
|
|
|
t.Cleanup(func() {
|
|
if database.DB.IsConnected() {
|
|
err := database.DB.CloseConnection()
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestSetupDatabaseConnectionManager(t *testing.T) {
|
|
_, err := SetupDatabaseConnectionManager(nil)
|
|
if !errors.Is(err, errNilConfig) {
|
|
t.Errorf("error '%v', expected '%v'", err, errNilConfig)
|
|
}
|
|
|
|
m, err := SetupDatabaseConnectionManager(&database.Config{})
|
|
assert.NoError(t, err)
|
|
|
|
if m == nil {
|
|
t.Error("expected manager")
|
|
}
|
|
}
|
|
|
|
func TestStartSQLite(t *testing.T) {
|
|
CreateDatabase(t)
|
|
m, err := SetupDatabaseConnectionManager(&database.Config{})
|
|
assert.NoError(t, err)
|
|
|
|
var wg sync.WaitGroup
|
|
err = m.Start(&wg)
|
|
if !errors.Is(err, database.ErrDatabaseSupportDisabled) {
|
|
t.Errorf("error '%v', expected '%v'", err, database.ErrDatabaseSupportDisabled)
|
|
}
|
|
m, err = SetupDatabaseConnectionManager(&database.Config{Enabled: true})
|
|
assert.NoError(t, err)
|
|
|
|
err = m.Start(&wg)
|
|
if !errors.Is(err, database.ErrNoDatabaseProvided) {
|
|
t.Errorf("error '%v', expected '%v'", err, database.ErrNoDatabaseProvided)
|
|
}
|
|
m.cfg = database.Config{Driver: database.DBSQLite}
|
|
err = m.Start(&wg)
|
|
if !errors.Is(err, database.ErrDatabaseSupportDisabled) {
|
|
t.Errorf("error '%v', expected '%v'", err, database.ErrDatabaseSupportDisabled)
|
|
}
|
|
_, err = SetupDatabaseConnectionManager(&database.Config{
|
|
Enabled: true,
|
|
Driver: database.DBSQLite,
|
|
ConnectionDetails: drivers.ConnectionDetails{
|
|
Host: "localhost",
|
|
Database: "test.db",
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
// This test does not care for a successful connection
|
|
func TestStartPostgres(t *testing.T) {
|
|
m, err := SetupDatabaseConnectionManager(&database.Config{})
|
|
assert.NoError(t, err)
|
|
|
|
var wg sync.WaitGroup
|
|
err = m.Start(&wg)
|
|
if !errors.Is(err, database.ErrDatabaseSupportDisabled) {
|
|
t.Errorf("error '%v', expected '%v'", err, database.ErrDatabaseSupportDisabled)
|
|
}
|
|
m.cfg.Enabled = true
|
|
err = m.Start(&wg)
|
|
if !errors.Is(err, database.ErrNoDatabaseProvided) {
|
|
t.Errorf("error '%v', expected '%v'", err, database.ErrNoDatabaseProvided)
|
|
}
|
|
m.cfg.Driver = database.DBPostgreSQL
|
|
err = m.Start(&wg)
|
|
if !errors.Is(err, database.ErrFailedToConnect) {
|
|
t.Errorf("error '%v', expected '%v'", err, database.ErrFailedToConnect)
|
|
}
|
|
}
|
|
|
|
func TestDatabaseConnectionManagerIsRunning(t *testing.T) {
|
|
CreateDatabase(t)
|
|
m, err := SetupDatabaseConnectionManager(&database.Config{
|
|
Enabled: true,
|
|
Driver: database.DBSQLite,
|
|
ConnectionDetails: drivers.ConnectionDetails{
|
|
Host: "localhost",
|
|
Database: "test.db",
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
|
|
if m.IsRunning() {
|
|
t.Error("expected false")
|
|
}
|
|
var wg sync.WaitGroup
|
|
err = m.Start(&wg)
|
|
assert.NoError(t, err)
|
|
|
|
if !m.IsRunning() {
|
|
t.Error("expected true")
|
|
}
|
|
m = nil
|
|
if m.IsRunning() {
|
|
t.Error("expected false")
|
|
}
|
|
}
|
|
|
|
func TestDatabaseConnectionManagerStop(t *testing.T) {
|
|
CreateDatabase(t)
|
|
m, err := SetupDatabaseConnectionManager(&database.Config{
|
|
Enabled: true,
|
|
Driver: database.DBSQLite,
|
|
ConnectionDetails: drivers.ConnectionDetails{
|
|
Host: "localhost",
|
|
Database: "test.db",
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
|
|
err = m.Stop()
|
|
if !errors.Is(err, ErrSubSystemNotStarted) {
|
|
t.Errorf("error '%v', expected '%v'", err, ErrSubSystemNotStarted)
|
|
}
|
|
|
|
var wg sync.WaitGroup
|
|
err = m.Start(&wg)
|
|
assert.NoError(t, err)
|
|
|
|
err = m.Stop()
|
|
assert.NoError(t, err)
|
|
|
|
m = nil
|
|
err = m.Stop()
|
|
if !errors.Is(err, ErrNilSubsystem) {
|
|
t.Errorf("error '%v', expected '%v'", err, ErrNilSubsystem)
|
|
}
|
|
}
|
|
|
|
func TestCheckConnection(t *testing.T) {
|
|
CreateDatabase(t)
|
|
var m *DatabaseConnectionManager
|
|
err := m.checkConnection()
|
|
if !errors.Is(err, ErrNilSubsystem) {
|
|
t.Errorf("error '%v', expected '%v'", err, ErrNilSubsystem)
|
|
}
|
|
m, err = SetupDatabaseConnectionManager(&database.Config{
|
|
Enabled: true,
|
|
Driver: database.DBSQLite,
|
|
ConnectionDetails: drivers.ConnectionDetails{
|
|
Host: "localhost",
|
|
Database: "test.db",
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
|
|
err = m.checkConnection()
|
|
if !errors.Is(err, ErrSubSystemNotStarted) {
|
|
t.Errorf("error '%v', expected '%v'", err, ErrSubSystemNotStarted)
|
|
}
|
|
var wg sync.WaitGroup
|
|
err = m.Start(&wg)
|
|
assert.NoError(t, err)
|
|
|
|
err = m.checkConnection()
|
|
assert.NoError(t, err)
|
|
|
|
err = m.Stop()
|
|
assert.NoError(t, err)
|
|
|
|
err = m.checkConnection()
|
|
if !errors.Is(err, ErrSubSystemNotStarted) {
|
|
t.Errorf("error '%v', expected '%v'", err, ErrSubSystemNotStarted)
|
|
}
|
|
|
|
err = m.Start(&wg)
|
|
assert.NoError(t, err)
|
|
|
|
err = m.checkConnection()
|
|
assert.NoError(t, err)
|
|
|
|
m.dbConn.SetConnected(false)
|
|
err = m.checkConnection()
|
|
if !errors.Is(err, database.ErrDatabaseNotConnected) {
|
|
t.Errorf("error '%v', expected '%v'", err, database.ErrDatabaseNotConnected)
|
|
}
|
|
|
|
err = m.Stop()
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
func TestGetInstance(t *testing.T) {
|
|
CreateDatabase(t)
|
|
m, err := SetupDatabaseConnectionManager(&database.Config{
|
|
Enabled: true,
|
|
Driver: database.DBSQLite,
|
|
ConnectionDetails: drivers.ConnectionDetails{
|
|
Host: "localhost",
|
|
Database: "test.db",
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
|
|
db := m.GetInstance()
|
|
if db != nil {
|
|
t.Error("expected nil")
|
|
}
|
|
var wg sync.WaitGroup
|
|
err = m.Start(&wg)
|
|
assert.NoError(t, err)
|
|
|
|
db = m.GetInstance()
|
|
if db == nil {
|
|
t.Error("expected not nil")
|
|
}
|
|
|
|
m = nil
|
|
db = m.GetInstance()
|
|
if db != nil {
|
|
t.Error("expected nil")
|
|
}
|
|
}
|