Files
gocryptotrader/exchanges/btcmarkets/btcmarkets_websocket.go
Gareth Kirwan 52c6b3bf0b Websocket: Various refactors and test improvements (#1466)
* Websocket: Remove IsInit and simplify SetProxyAddress

IsInit was basically the same as IsConnected.
Any time Connect was called both would be set to true.
Any time we had a disconnect they'd both be set to false
Shutdown() incorrectly didn't setInit(false)

SetProxyAddress simplified to only reconnect a connected Websocket.
Any other state means it hasn't been Connected, or it's about to
reconnect anyway.
There's no handling for IsConnecting previously, either, so I've wrapped
that behind the main mutex.

* Websocket: Expand and Assertify tests

* Websocket: Simplify state transistions

* Websocket: Simplify Connecting/Connected state

* Websocket: Tests and errors for websocket

* Websocket: Make WebsocketNotEnabled a real error

This allows for testing and avoids the repetition.
If each returned error is a error.New() you can never use errors.Is()

* Websocket: Add more testable errors

* Websocket: Improve GenerateMessageID test

Testing just the last id doesn't feel very robust

* Websocket: Protect Setup() from races

* Websocket: Use atomics instead of mutex

This was spurred by looking at the setState call in trafficMonitor and
the effect on blocking and efficiency.
With the new atomic types in Go 1.19, and the small types in use here,
atomics should be safe for our usage. bools should be truly atomic,
and uint32 is atomic when the accepted value range is less than one byte/uint8 since
that can be written atomicly by concurrent processors.
Maybe that's not even a factor any more, however we don't even have to worry enough to check.

* Websocket: Fix and simplify traffic monitor

trafficMonitor had a check throttle at the end of the for loop to stop it just gobbling the (blocking) trafficAlert channel non-stop.
That makes sense, except that nothing is sent to the trafficAlert channel if there's no listener.
So that means that it's out by one second on the trafficAlert, because any traffic received during the pause is doesn't try to send a traffic alert.

The unstopped timer is deliberately leaked for later GC when shutdown.
It won't delay/block anything, and it's a trivial memory leak during an infrequent event.

Deliberately Choosing to recreate the timer each time instead of using Stop, drain and reset

* Websocket: Split traficMonitor test on behaviours

* Websocket: Remove trafficMonitor connected status

trafficMonitor does not need to set the connection to be connected.
Connect() does that. Anything after that should result in a full
shutdown and restart. It can't and shouldn't become connected
unexpectedly, and this is most likely a race anyway.

Also dropped trafficCheckInterval to 100ms to mitigate races of traffic
alerts being buffered for too long.

* Websocket: Set disconnected earlier in Shutdown

This caused a possible race where state is still connected, but we start
to trigger interested actors via ShutdownC and Wait.
They may check state and then call Shutdown again, such as
trafficMonitor

* Websocket: Wait 5s for slow tests to pass traffic draining

Keep getting failures upstream on test rigs.
Think they can be very contended, so this pushes the boundary right out
to 5s
2024-02-23 18:39:25 +11:00

488 lines
12 KiB
Go

package btcmarkets
import (
"context"
"encoding/json"
"errors"
"fmt"
"hash/crc32"
"net/http"
"strconv"
"strings"
"time"
"github.com/gorilla/websocket"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/common/crypto"
"github.com/thrasher-corp/gocryptotrader/currency"
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
"github.com/thrasher-corp/gocryptotrader/exchanges/order"
"github.com/thrasher-corp/gocryptotrader/exchanges/orderbook"
"github.com/thrasher-corp/gocryptotrader/exchanges/stream"
"github.com/thrasher-corp/gocryptotrader/exchanges/subscription"
"github.com/thrasher-corp/gocryptotrader/exchanges/ticker"
"github.com/thrasher-corp/gocryptotrader/exchanges/trade"
"github.com/thrasher-corp/gocryptotrader/log"
)
const (
btcMarketsWSURL = "wss://socket.btcmarkets.net/v2"
)
var (
errTypeAssertionFailure = errors.New("type assertion failure")
errChecksumFailure = errors.New("crc32 checksum failure")
authChannels = []string{fundChange, heartbeat, orderChange}
)
// WsConnect connects to a websocket feed
func (b *BTCMarkets) WsConnect() error {
if !b.Websocket.IsEnabled() || !b.IsEnabled() {
return stream.ErrWebsocketNotEnabled
}
var dialer websocket.Dialer
err := b.Websocket.Conn.Dial(&dialer, http.Header{})
if err != nil {
return err
}
if b.Verbose {
log.Debugf(log.ExchangeSys, "%s Connected to Websocket.\n", b.Name)
}
b.Websocket.Wg.Add(1)
go b.wsReadData()
return nil
}
// wsReadData receives and passes on websocket messages for processing
func (b *BTCMarkets) wsReadData() {
defer b.Websocket.Wg.Done()
for {
resp := b.Websocket.Conn.ReadMessage()
if resp.Raw == nil {
return
}
err := b.wsHandleData(resp.Raw)
if err != nil {
b.Websocket.DataHandler <- err
}
}
}
// UnmarshalJSON implements the unmarshaler interface.
func (w *WebsocketOrderbook) UnmarshalJSON(data []byte) error {
resp := make([][3]interface{}, len(data))
err := json.Unmarshal(data, &resp)
if err != nil {
return err
}
*w = WebsocketOrderbook(make(orderbook.Items, len(resp)))
for x := range resp {
sPrice, ok := resp[x][0].(string)
if !ok {
return fmt.Errorf("price string %w", errTypeAssertionFailure)
}
var price float64
price, err = strconv.ParseFloat(sPrice, 64)
if err != nil {
return err
}
sAmount, ok := resp[x][1].(string)
if !ok {
return fmt.Errorf("amount string %w", errTypeAssertionFailure)
}
var amount float64
amount, err = strconv.ParseFloat(sAmount, 64)
if err != nil {
return err
}
count, ok := resp[x][2].(float64)
if !ok {
return fmt.Errorf("count float64 %w", errTypeAssertionFailure)
}
(*w)[x] = orderbook.Item{
Amount: amount,
Price: price,
OrderCount: int64(count),
}
}
return nil
}
func (b *BTCMarkets) wsHandleData(respRaw []byte) error {
var wsResponse WsMessageType
err := json.Unmarshal(respRaw, &wsResponse)
if err != nil {
return err
}
switch wsResponse.MessageType {
case heartbeat:
if b.Verbose {
log.Debugf(log.ExchangeSys, "%v - Websocket heartbeat received %s", b.Name, respRaw)
}
case wsOB:
var ob WsOrderbook
err := json.Unmarshal(respRaw, &ob)
if err != nil {
return err
}
if ob.Snapshot {
err = b.Websocket.Orderbook.LoadSnapshot(&orderbook.Base{
Pair: ob.Currency,
Bids: orderbook.Items(ob.Bids),
Asks: orderbook.Items(ob.Asks),
LastUpdated: ob.Timestamp,
LastUpdateID: ob.SnapshotID,
Asset: asset.Spot,
Exchange: b.Name,
VerifyOrderbook: b.CanVerifyOrderbook,
})
} else {
err = b.Websocket.Orderbook.Update(&orderbook.Update{
UpdateTime: ob.Timestamp,
UpdateID: ob.SnapshotID,
Asset: asset.Spot,
Bids: orderbook.Items(ob.Bids),
Asks: orderbook.Items(ob.Asks),
Pair: ob.Currency,
Checksum: ob.Checksum,
})
}
if err != nil {
if errors.Is(err, orderbook.ErrOrderbookInvalid) {
err2 := b.ReSubscribeSpecificOrderbook(ob.Currency)
if err2 != nil {
return err2
}
}
return err
}
return nil
case tradeEndPoint:
if !b.IsSaveTradeDataEnabled() {
return nil
}
var t WsTrade
err := json.Unmarshal(respRaw, &t)
if err != nil {
return err
}
p, err := currency.NewPairFromString(t.Currency)
if err != nil {
return err
}
side := order.Buy
if t.Side == "Ask" {
side = order.Sell
}
return trade.AddTradesToBuffer(b.Name, trade.Data{
Timestamp: t.Timestamp,
CurrencyPair: p,
AssetType: asset.Spot,
Exchange: b.Name,
Price: t.Price,
Amount: t.Volume,
Side: side,
TID: strconv.FormatInt(t.TradeID, 10),
})
case tick:
var tick WsTick
err := json.Unmarshal(respRaw, &tick)
if err != nil {
return err
}
p, err := currency.NewPairFromString(tick.Currency)
if err != nil {
return err
}
b.Websocket.DataHandler <- &ticker.Price{
ExchangeName: b.Name,
Volume: tick.Volume,
High: tick.High24,
Low: tick.Low24h,
Bid: tick.Bid,
Ask: tick.Ask,
Last: tick.Last,
LastUpdated: tick.Timestamp,
AssetType: asset.Spot,
Pair: p,
}
case fundChange:
var transferData WsFundTransfer
err := json.Unmarshal(respRaw, &transferData)
if err != nil {
return err
}
b.Websocket.DataHandler <- transferData
case orderChange:
var orderData WsOrderChange
err := json.Unmarshal(respRaw, &orderData)
if err != nil {
return err
}
originalAmount := orderData.OpenVolume
var price float64
var trades []order.TradeHistory
var orderID = strconv.FormatInt(orderData.OrderID, 10)
for x := range orderData.Trades {
var isMaker bool
if orderData.Trades[x].LiquidityType == "Maker" {
isMaker = true
}
trades = append(trades, order.TradeHistory{
Price: orderData.Trades[x].Price,
Amount: orderData.Trades[x].Volume,
Fee: orderData.Trades[x].Fee,
Exchange: b.Name,
TID: strconv.FormatInt(orderData.Trades[x].TradeID, 10),
IsMaker: isMaker,
})
price = orderData.Trades[x].Price
originalAmount += orderData.Trades[x].Volume
}
oType, err := order.StringToOrderType(orderData.OrderType)
if err != nil {
b.Websocket.DataHandler <- order.ClassificationError{
Exchange: b.Name,
OrderID: orderID,
Err: err,
}
}
oSide, err := order.StringToOrderSide(orderData.Side)
if err != nil {
b.Websocket.DataHandler <- order.ClassificationError{
Exchange: b.Name,
OrderID: orderID,
Err: err,
}
}
oStatus, err := order.StringToOrderStatus(orderData.Status)
if err != nil {
b.Websocket.DataHandler <- order.ClassificationError{
Exchange: b.Name,
OrderID: orderID,
Err: err,
}
}
p, err := currency.NewPairFromString(orderData.MarketID)
if err != nil {
b.Websocket.DataHandler <- order.ClassificationError{
Exchange: b.Name,
OrderID: orderID,
Err: err,
}
}
creds, err := b.GetCredentials(context.TODO())
if err != nil {
b.Websocket.DataHandler <- order.ClassificationError{
Exchange: b.Name,
OrderID: orderID,
Err: err,
}
}
b.Websocket.DataHandler <- &order.Detail{
Price: price,
Amount: originalAmount,
RemainingAmount: orderData.OpenVolume,
Exchange: b.Name,
OrderID: orderID,
ClientID: creds.ClientID,
Type: oType,
Side: oSide,
Status: oStatus,
AssetType: asset.Spot,
Date: orderData.Timestamp,
Trades: trades,
Pair: p,
}
case "error":
var wsErr WsError
err := json.Unmarshal(respRaw, &wsErr)
if err != nil {
return err
}
return fmt.Errorf("%v websocket error. Code: %v Message: %v", b.Name, wsErr.Code, wsErr.Message)
default:
b.Websocket.DataHandler <- stream.UnhandledMessageWarning{Message: b.Name + stream.UnhandledMessage + string(respRaw)}
return nil
}
return nil
}
func (b *BTCMarkets) generateDefaultSubscriptions() ([]subscription.Subscription, error) {
var channels = []string{wsOB, tick, tradeEndPoint}
enabledCurrencies, err := b.GetEnabledPairs(asset.Spot)
if err != nil {
return nil, err
}
var subscriptions []subscription.Subscription
for i := range channels {
for j := range enabledCurrencies {
subscriptions = append(subscriptions, subscription.Subscription{
Channel: channels[i],
Pair: enabledCurrencies[j],
Asset: asset.Spot,
})
}
}
if b.Websocket.CanUseAuthenticatedEndpoints() {
for i := range authChannels {
subscriptions = append(subscriptions, subscription.Subscription{
Channel: authChannels[i],
})
}
}
return subscriptions, nil
}
// Subscribe sends a websocket message to receive data from the channel
func (b *BTCMarkets) Subscribe(subs []subscription.Subscription) error {
var payload WsSubscribe
if len(subs) > 1 {
// TODO: Expand this to stream package as this assumes that we are doing
// an initial sync.
payload.MessageType = subscribe
} else {
payload.MessageType = addSubscription
payload.ClientType = clientType
}
var authenticate bool
for i := range subs {
if !authenticate && common.StringDataContains(authChannels, subs[i].Channel) {
authenticate = true
}
payload.Channels = append(payload.Channels, subs[i].Channel)
if subs[i].Pair.IsEmpty() {
continue
}
pair := subs[i].Pair.String()
if common.StringDataCompare(payload.MarketIDs, pair) {
continue
}
payload.MarketIDs = append(payload.MarketIDs, pair)
}
if authenticate {
creds, err := b.GetCredentials(context.TODO())
if err != nil {
return err
}
signTime := strconv.FormatInt(time.Now().UnixMilli(), 10)
strToSign := "/users/self/subscribe" + "\n" + signTime
var tempSign []byte
tempSign, err = crypto.GetHMAC(crypto.HashSHA512,
[]byte(strToSign),
[]byte(creds.Secret))
if err != nil {
return err
}
sign := crypto.Base64Encode(tempSign)
payload.Key = creds.Key
payload.Signature = sign
payload.Timestamp = signTime
}
if err := b.Websocket.Conn.SendJSONMessage(payload); err != nil {
return err
}
b.Websocket.AddSuccessfulSubscriptions(subs...)
return nil
}
// Unsubscribe sends a websocket message to manage and remove a subscription.
func (b *BTCMarkets) Unsubscribe(subs []subscription.Subscription) error {
payload := WsSubscribe{
MessageType: removeSubscription,
ClientType: clientType,
}
for i := range subs {
payload.Channels = append(payload.Channels, subs[i].Channel)
if subs[i].Pair.IsEmpty() {
continue
}
pair := subs[i].Pair.String()
if common.StringDataCompare(payload.MarketIDs, pair) {
continue
}
payload.MarketIDs = append(payload.MarketIDs, pair)
}
err := b.Websocket.Conn.SendJSONMessage(payload)
if err != nil {
return err
}
b.Websocket.RemoveSubscriptions(subs...)
return nil
}
// ReSubscribeSpecificOrderbook removes the subscription and the subscribes
// again to fetch a new snapshot in the event of a de-sync event.
func (b *BTCMarkets) ReSubscribeSpecificOrderbook(pair currency.Pair) error {
sub := []subscription.Subscription{{
Channel: wsOB,
Pair: pair,
Asset: asset.Spot,
}}
if err := b.Unsubscribe(sub); err != nil {
return err
}
return b.Subscribe(sub)
}
// checksum provides assurance on current in memory liquidity
func checksum(ob *orderbook.Base, checksum uint32) error {
check := crc32.ChecksumIEEE([]byte(concat(ob.Bids) + concat(ob.Asks)))
if check != checksum {
return fmt.Errorf("%s %s %s ID: %v expected: %v but received: %v %w",
ob.Exchange,
ob.Pair,
ob.Asset,
ob.LastUpdateID,
checksum,
check,
errChecksumFailure)
}
return nil
}
// concat concatenates price and amounts together for checksum processing
func concat(liquidity orderbook.Items) string {
length := 10
if len(liquidity) < 10 {
length = len(liquidity)
}
var c string
for x := 0; x < length; x++ {
c += trim(liquidity[x].Price) + trim(liquidity[x].Amount)
}
return c
}
// trim turns value into string, removes the decimal point and all the leading
// zeros.
func trim(value float64) string {
valstr := strconv.FormatFloat(value, 'f', -1, 64)
valstr = strings.ReplaceAll(valstr, ".", "")
valstr = strings.TrimLeft(valstr, "0")
return valstr
}