Files
gocryptotrader/exchanges/request/request.go
Scott c7b3ace78c testing: bybit references, bybit mock testing, pair formatting, standards improvement (#1322)
* fixes tests

* pair formats and extra fixes

* quick change before shazbert sees

* sneaky lint

* adds bybit mock testing and fixes test

* whoops

* error response instead

* classic forgetting to lint

* bybit live test no longer auto-records results

* ty thrasher- Update exchanges/bybit/bybit_wrapper.go

Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io>

---------

Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io>
2023-08-21 14:48:56 +10:00

414 lines
11 KiB
Go

package request
import (
"context"
"encoding/json"
"errors"
"fmt"
"io"
"net/http"
"net/http/httputil"
"net/url"
"sync/atomic"
"time"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/common/timedmutex"
"github.com/thrasher-corp/gocryptotrader/exchanges/mock"
"github.com/thrasher-corp/gocryptotrader/exchanges/nonce"
"github.com/thrasher-corp/gocryptotrader/log"
)
const (
// UnsetRequest is an unset request authentication level
UnsetRequest AuthType = 0
// UnauthenticatedRequest denotes a request with no credentials
UnauthenticatedRequest = iota << 1
// AuthenticatedRequest denotes a request using API credentials
AuthenticatedRequest
contextVerboseFlag verbosity = "verbose"
)
// AuthType helps distinguish the purpose of a HTTP request
type AuthType uint8
var (
// ErrRequestSystemIsNil defines and error if the request system has not
// been set up yet.
ErrRequestSystemIsNil = errors.New("request system is nil")
// ErrAuthRequestFailed is a wrapping error to denote that it's an auth request that failed
ErrAuthRequestFailed = errors.New("authenticated request failed")
errMaxRequestJobs = errors.New("max request jobs reached")
errRequestFunctionIsNil = errors.New("request function is nil")
errRequestItemNil = errors.New("request item is nil")
errInvalidPath = errors.New("invalid path")
errHeaderResponseMapIsNil = errors.New("header response map is nil")
errFailedToRetryRequest = errors.New("failed to retry request")
errContextRequired = errors.New("context is required")
errTransportNotSet = errors.New("transport not set, cannot set timeout")
errRequestTypeUnpopulated = errors.New("request type bool is not populated")
)
// New returns a new Requester
func New(name string, httpRequester *http.Client, opts ...RequesterOption) (*Requester, error) {
protectedClient, err := newProtectedClient(httpRequester)
if err != nil {
return nil, fmt.Errorf("cannot set up a new requester for %s: %w", name, err)
}
r := &Requester{
_HTTPClient: protectedClient,
name: name,
backoff: DefaultBackoff(),
retryPolicy: DefaultRetryPolicy,
maxRetries: MaxRetryAttempts,
timedLock: timedmutex.NewTimedMutex(DefaultMutexLockTimeout),
reporter: globalReporter,
}
for _, o := range opts {
o(r)
}
return r, nil
}
// SendPayload handles sending HTTP/HTTPS requests
func (r *Requester) SendPayload(ctx context.Context, ep EndpointLimit, newRequest Generate, requestType AuthType) error {
if r == nil {
return ErrRequestSystemIsNil
}
if ctx == nil {
return errContextRequired
}
if requestType == UnsetRequest {
return errRequestTypeUnpopulated
}
defer r.timedLock.UnlockIfLocked()
if newRequest == nil {
return errRequestFunctionIsNil
}
if atomic.LoadInt32(&r.jobs) >= MaxRequestJobs {
return errMaxRequestJobs
}
atomic.AddInt32(&r.jobs, 1)
err := r.doRequest(ctx, ep, newRequest)
atomic.AddInt32(&r.jobs, -1)
if err != nil && requestType == AuthenticatedRequest {
err = common.AppendError(err, ErrAuthRequestFailed)
}
return err
}
// validateRequest validates the requester item fields
func (i *Item) validateRequest(ctx context.Context, r *Requester) (*http.Request, error) {
if i == nil {
return nil, errRequestItemNil
}
if i.Path == "" {
return nil, errInvalidPath
}
if i.HeaderResponse != nil && *i.HeaderResponse == nil {
return nil, errHeaderResponseMapIsNil
}
if !i.NonceEnabled {
r.timedLock.LockForDuration()
}
req, err := http.NewRequestWithContext(ctx, i.Method, i.Path, i.Body)
if err != nil {
return nil, err
}
if i.HTTPDebugging {
// Err not evaluated due to validation check above
dump, _ := httputil.DumpRequestOut(req, true)
log.Debugf(log.RequestSys, "DumpRequest:\n%s", dump)
}
for k, v := range i.Headers {
req.Header.Add(k, v)
}
if r.userAgent != "" && req.Header.Get(userAgent) == "" {
req.Header.Add(userAgent, r.userAgent)
}
return req, nil
}
// DoRequest performs a HTTP/HTTPS request with the supplied params
func (r *Requester) doRequest(ctx context.Context, endpoint EndpointLimit, newRequest Generate) error {
for attempt := 1; ; attempt++ {
// Check if context has finished before executing new attempt.
select {
case <-ctx.Done():
return ctx.Err()
default:
}
// Initiate a rate limit reservation and sleep on requested endpoint
err := r.InitiateRateLimit(ctx, endpoint)
if err != nil {
return fmt.Errorf("failed to rate limit HTTP request: %w", err)
}
p, err := newRequest()
if err != nil {
return err
}
req, err := p.validateRequest(ctx, r)
if err != nil {
return err
}
verbose := isVerbose(ctx, p.Verbose)
if verbose {
log.Debugf(log.RequestSys, "%s attempt %d request path: %s", r.name, attempt, p.Path)
for k, d := range req.Header {
log.Debugf(log.RequestSys, "%s request header [%s]: %s", r.name, k, d)
}
log.Debugf(log.RequestSys, "%s request type: %s", r.name, p.Method)
if p.Body != nil {
log.Debugf(log.RequestSys, "%s request body: %v", r.name, p.Body)
}
}
start := time.Now()
resp, err := r._HTTPClient.do(req)
if r.reporter != nil && err == nil {
r.reporter.Latency(r.name, p.Method, p.Path, time.Since(start))
}
if retry, checkErr := r.retryPolicy(resp, err); checkErr != nil {
return checkErr
} else if retry {
if err == nil {
// If the body isn't fully read, the connection cannot be re-used
r.drainBody(resp.Body)
}
if attempt > r.maxRetries {
if err != nil {
return fmt.Errorf("%w, err: %v", errFailedToRetryRequest, err)
}
return fmt.Errorf("%w, status: %s", errFailedToRetryRequest, resp.Status)
}
after := RetryAfter(resp, time.Now())
backoff := r.backoff(attempt)
delay := backoff
if after > backoff {
delay = after
}
if dl, ok := req.Context().Deadline(); ok && dl.Before(time.Now().Add(delay)) {
if err != nil {
return fmt.Errorf("deadline would be exceeded by retry, err: %v", err)
}
return fmt.Errorf("deadline would be exceeded by retry, status: %s", resp.Status)
}
if verbose {
log.Errorf(log.RequestSys,
"%s request has failed. Retrying request in %s, attempt %d",
r.name,
delay,
attempt)
}
time.Sleep(delay)
continue
}
contents, err := io.ReadAll(resp.Body)
if err != nil {
return err
}
// Even in the case of an erroneous condition below, yield the parsed
// response to caller.
var unmarshallError error
if p.Result != nil {
unmarshallError = json.Unmarshal(contents, p.Result)
}
if p.HTTPRecording {
// This dumps http responses for future mocking implementations
err = mock.HTTPRecord(resp, r.name, contents)
if err != nil {
return fmt.Errorf("mock recording failure %w, request %v: resp: %v", err, req, resp)
}
}
if p.HeaderResponse != nil {
for k, v := range resp.Header {
(*p.HeaderResponse)[k] = v
}
}
if resp.StatusCode < http.StatusOK ||
resp.StatusCode > http.StatusNoContent {
return fmt.Errorf("%s unsuccessful HTTP status code: %d raw response: %s",
r.name,
resp.StatusCode,
string(contents))
}
if p.HTTPDebugging {
dump, dumpErr := httputil.DumpResponse(resp, false)
if err != nil {
log.Errorf(log.RequestSys, "DumpResponse invalid response: %v:", dumpErr)
}
log.Debugf(log.RequestSys, "DumpResponse Headers (%v):\n%s", p.Path, dump)
log.Debugf(log.RequestSys, "DumpResponse Body (%v):\n %s", p.Path, string(contents))
}
err = resp.Body.Close()
if err != nil {
log.Errorf(log.RequestSys,
"%s failed to close request body %s",
r.name,
err)
}
if verbose {
log.Debugf(log.RequestSys,
"HTTP status: %s, Code: %v",
resp.Status,
resp.StatusCode)
if !p.HTTPDebugging {
log.Debugf(log.RequestSys,
"%s raw response: %s",
r.name,
string(contents))
}
}
return unmarshallError
}
}
func (r *Requester) drainBody(body io.ReadCloser) {
if _, err := io.Copy(io.Discard, io.LimitReader(body, drainBodyLimit)); err != nil {
log.Errorf(log.RequestSys,
"%s failed to drain request body %s",
r.name,
err)
}
if err := body.Close(); err != nil {
log.Errorf(log.RequestSys,
"%s failed to close request body %s",
r.name,
err)
}
}
// GetNonce returns a nonce for requests. This locks and enforces concurrent
// nonce FIFO on the buffered job channel
func (r *Requester) GetNonce(isNano bool) nonce.Value {
r.timedLock.LockForDuration()
if r.Nonce.Get() == 0 {
if isNano {
r.Nonce.Set(time.Now().UnixNano())
} else {
r.Nonce.Set(time.Now().Unix())
}
return r.Nonce.Get()
}
return r.Nonce.GetInc()
}
// GetNonceMilli returns a nonce for requests. This locks and enforces concurrent
// nonce FIFO on the buffered job channel this is for millisecond
func (r *Requester) GetNonceMilli() nonce.Value {
r.timedLock.LockForDuration()
if r.Nonce.Get() == 0 {
r.Nonce.Set(time.Now().UnixMilli())
return r.Nonce.Get()
}
return r.Nonce.GetInc()
}
// SetProxy sets a proxy address for the client transport
func (r *Requester) SetProxy(p *url.URL) error {
if r == nil {
return ErrRequestSystemIsNil
}
return r._HTTPClient.setProxy(p)
}
// SetHTTPClient sets exchanges HTTP client
func (r *Requester) SetHTTPClient(newClient *http.Client) error {
if r == nil {
return ErrRequestSystemIsNil
}
protectedClient, err := newProtectedClient(newClient)
if err != nil {
return err
}
r._HTTPClient = protectedClient
return nil
}
// SetHTTPClientTimeout sets the timeout value for the exchanges HTTP Client and
// also the underlying transports idle connection timeout
func (r *Requester) SetHTTPClientTimeout(timeout time.Duration) error {
if r == nil {
return ErrRequestSystemIsNil
}
return r._HTTPClient.setHTTPClientTimeout(timeout)
}
// SetHTTPClientUserAgent sets the exchanges HTTP user agent
func (r *Requester) SetHTTPClientUserAgent(userAgent string) error {
if r == nil {
return ErrRequestSystemIsNil
}
r.userAgent = userAgent
return nil
}
// GetHTTPClientUserAgent gets the exchanges HTTP user agent
func (r *Requester) GetHTTPClientUserAgent() (string, error) {
if r == nil {
return "", ErrRequestSystemIsNil
}
return r.userAgent, nil
}
// Shutdown releases persistent memory for garbage collection.
func (r *Requester) Shutdown() error {
if r == nil {
return ErrRequestSystemIsNil
}
return r._HTTPClient.release()
}
// WithVerbose adds verbosity to a request context so that specific requests
// can have distinct verbosity without impacting all requests.
func WithVerbose(ctx context.Context) context.Context {
return context.WithValue(ctx, contextVerboseFlag, true)
}
// isVerbose checks main verbosity first then checks context verbose values
// for specific request verbosity.
func isVerbose(ctx context.Context, verbose bool) bool {
if verbose {
return true
}
isCtxVerbose, _ := ctx.Value(contextVerboseFlag).(bool)
return isCtxVerbose
}