mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-13 23:16:45 +00:00
23c82bead4
* Bitfinex: Handle Errors in tickers without panic * Bitfinex: Use TypeAssertError for tickers * Bitfinex: Refactor and improve ticker handling * Unify Ticker response handling * Simplify/Humanify errors in parsing ticker responses * Remove polymorphic response handling for < 10 fields, seems [antiquated according to docs](https://docs.bitfinex.com/reference/rest-public-ticker) * Add test coverage for tickers * Bitfinex: Ignore resp format errs in GetTickers We're still getting: `received 'invalid ticker response format for tALT2612:USD field BidSize from [100 <nil> 100 <nil> <nil> <nil> <nil> <nil> <nil> <nil>]` too frequently right now. Considered: * Special casing tALT2612:*; However if it's happening with this curr it'll probably happen again * Warning about the error; However it'd just be persistent, unactionable and annoying noise in the logs of a running server So the conclusion is to just silently ignore it * Bitfinex: Accept locked market in TestUpdateTicker
GoCryptoTrader package Exchanges
This exchanges package is part of the GoCryptoTrader codebase.
This is still in active development
You can track ideas, planned features and what's in progress on this Trello board: https://trello.com/b/ZAhMhpOy/gocryptotrader.
Join our slack to discuss all things related to GoCryptoTrader! GoCryptoTrader Slack
Current Features for exchanges
-
This package is used to connect and query data from supported exchanges.
-
Please checkout individual exchange README for more information on implementation
Guide for adding a new exchange
- A guide on implementing API support for a new exchange can be found here
websocket notes
- If contributing websocket improvements, please make sure order reports follow these rules.
Please click GoDocs chevron above to view current GoDoc information for this package
Contribution
Please feel free to submit any pull requests or suggest any desired features to be added.
When submitting a PR, please abide by our coding guidelines:
- Code must adhere to the official Go formatting guidelines (i.e. uses gofmt).
- Code must be documented adhering to the official Go commentary guidelines.
- Code must adhere to our coding style.
- Pull requests need to be based on and opened against the
masterbranch.
Donations
If this framework helped you in any way, or you would like to support the developers working on it, please donate Bitcoin to:
bc1qk0jareu4jytc0cfrhr5wgshsq8282awpavfahc