mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-22 23:16:48 +00:00
219ed903bc
* Config: Version Management * Engine: Improve visibility of TestConfigAllJsonResponse failures * Config: Update cmd/config to allow upgrades * Config: Add Version2 to rename GDAX * Config: Restructure versioning to share types This restructure allows us to share types between versions, avoids needing to import the versions, and puts the test fixtures in same package. It's a win on all fronts * Config: Fix SetNTPCheck using log Called from engine before logger is inited, and also just wrong to use log to communicate with user * Config: Improve TestMigrateConfig * Config: Drop requirement for versions to be registered in sequence Checking the versions at Deploy is much saner. * Config: Fix file encrypted but flag not set * Config: Add -edit and encryption upgrade to cmd/config This simplifies the handling for encryption prompts by moving it to a field on config, allowing us to simplify all the places were were passing around config Also moves password entry to being secure (echo-off) * Tests: Fix inconsistent should/must assertions
114 lines
3.8 KiB
Go
114 lines
3.8 KiB
Go
package versions
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/buger/jsonparser"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/thrasher-corp/gocryptotrader/common"
|
|
)
|
|
|
|
func TestDeploy(t *testing.T) {
|
|
t.Parallel()
|
|
m := manager{}
|
|
_, err := m.Deploy(context.Background(), []byte(``))
|
|
assert.ErrorIs(t, err, errNoVersions)
|
|
|
|
m.registerVersion(1, &TestVersion1{})
|
|
_, err = m.Deploy(context.Background(), []byte(``))
|
|
require.ErrorIs(t, err, errVersionIncompatible)
|
|
|
|
m = manager{}
|
|
|
|
m.registerVersion(0, &Version0{})
|
|
_, err = m.Deploy(context.Background(), []byte(`not an object`))
|
|
require.ErrorIs(t, err, jsonparser.KeyPathNotFoundError, "Must throw the correct error trying to add version to bad json")
|
|
require.ErrorIs(t, err, common.ErrSettingField, "Must throw the correct error trying to add version to bad json")
|
|
require.ErrorContains(t, err, "version", "Must throw the correct error trying to add version to bad json")
|
|
|
|
_, err = m.Deploy(context.Background(), []byte(`{"version":"not an int"}`))
|
|
require.ErrorIs(t, err, common.ErrGettingField, "Must throw the correct error trying to get version from bad json")
|
|
|
|
in := []byte(`{"version":0,"exchanges":[{"name":"Juan"}]}`)
|
|
j, err := m.Deploy(context.Background(), in)
|
|
require.NoError(t, err)
|
|
require.Equal(t, string(in), string(j))
|
|
|
|
m.registerVersion(1, &Version1{})
|
|
j, err = m.Deploy(context.Background(), in)
|
|
require.NoError(t, err)
|
|
require.Contains(t, string(j), `"version":1`)
|
|
|
|
m.versions = m.versions[:1]
|
|
j, err = m.Deploy(context.Background(), j)
|
|
require.NoError(t, err)
|
|
require.Contains(t, string(j), `"version":0`)
|
|
|
|
m.versions = append(m.versions, &TestVersion2{ConfigErr: true, ExchErr: false}) // Bit hacky, but this will actually work
|
|
_, err = m.Deploy(context.Background(), j)
|
|
require.ErrorIs(t, err, errUpgrade)
|
|
|
|
m.versions[1] = &TestVersion2{ConfigErr: false, ExchErr: true}
|
|
_, err = m.Deploy(context.Background(), in)
|
|
require.Implements(t, (*ExchangeVersion)(nil), m.versions[1])
|
|
require.ErrorIs(t, err, errUpgrade)
|
|
}
|
|
|
|
// TestExchangeDeploy exercises exchangeDeploy
|
|
// There are a number of error paths we can't currently cover without exposing unacceptable risks to the hot-paths as well
|
|
func TestExchangeDeploy(t *testing.T) {
|
|
t.Parallel()
|
|
m := manager{}
|
|
_, err := m.Deploy(context.Background(), []byte(``))
|
|
assert.ErrorIs(t, err, errNoVersions)
|
|
|
|
v := &TestVersion2{}
|
|
in := []byte(`{"version":0,"exchanges":[{}]}`)
|
|
_, err = exchangeDeploy(context.Background(), v, ExchangeVersion.UpgradeExchange, in)
|
|
require.ErrorIs(t, err, errModifyingExchange)
|
|
require.ErrorIs(t, err, common.ErrGettingField)
|
|
require.ErrorIs(t, err, jsonparser.KeyPathNotFoundError)
|
|
require.ErrorContains(t, err, "`name`")
|
|
|
|
in = []byte(`{"version":0,"exchanges":[{"name":"Juan"},{"name":"Megashaft"}]}`)
|
|
_, err = exchangeDeploy(context.Background(), v, ExchangeVersion.UpgradeExchange, in)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestRegisterVersion(t *testing.T) {
|
|
t.Parallel()
|
|
m := manager{}
|
|
|
|
m.registerVersion(0, &Version0{})
|
|
assert.NotEmpty(t, m.versions)
|
|
|
|
m.registerVersion(2, &TestVersion2{})
|
|
require.Equal(t, 3, len(m.versions), "Must allocate a space for missing version 1")
|
|
require.NotNil(t, m.versions[2], "Must put Version 2 in the correct slot")
|
|
require.Nil(t, m.versions[1], "Must leave Version 1 alone")
|
|
|
|
m.registerVersion(1, &TestVersion1{})
|
|
require.Equal(t, 3, len(m.versions), "Must leave len alone when registering out-of-sequence")
|
|
require.NotNil(t, m.versions[1], "Must put Version 1 in the correct slot")
|
|
}
|
|
|
|
func TestLatest(t *testing.T) {
|
|
t.Parallel()
|
|
m := manager{}
|
|
_, err := m.latest()
|
|
require.ErrorIs(t, err, errNoVersions)
|
|
|
|
m.registerVersion(0, &Version0{})
|
|
m.registerVersion(1, &Version1{})
|
|
v, err := m.latest()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, 1, v)
|
|
|
|
m.registerVersion(2, &Version2{})
|
|
v, err = m.latest()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, 2, v)
|
|
}
|