mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-22 15:10:13 +00:00
* Config: Version Management * Engine: Improve visibility of TestConfigAllJsonResponse failures * Config: Update cmd/config to allow upgrades * Config: Add Version2 to rename GDAX * Config: Restructure versioning to share types This restructure allows us to share types between versions, avoids needing to import the versions, and puts the test fixtures in same package. It's a win on all fronts * Config: Fix SetNTPCheck using log Called from engine before logger is inited, and also just wrong to use log to communicate with user * Config: Improve TestMigrateConfig * Config: Drop requirement for versions to be registered in sequence Checking the versions at Deploy is much saner. * Config: Fix file encrypted but flag not set * Config: Add -edit and encryption upgrade to cmd/config This simplifies the handling for encryption prompts by moving it to a field on config, allowing us to simplify all the places were were passing around config Also moves password entry to being secure (echo-off) * Tests: Fix inconsistent should/must assertions
199 lines
5.7 KiB
Go
199 lines
5.7 KiB
Go
// Package versions handles config upgrades and downgrades
|
|
/*
|
|
- Versions must be stateful, and not rely upon type definitions in the config pkg
|
|
|
|
- Instead versions should localise types into vN/types.go to avoid issues with subsequent changes
|
|
|
|
- Versions must upgrade to the next version. Do not retrospectively change versions to match new type changes. Create a new version
|
|
|
|
- Versions must implement ExchangeVersion or ConfigVersion, and may implement both
|
|
*/
|
|
package versions
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"log"
|
|
"slices"
|
|
"strconv"
|
|
"sync"
|
|
|
|
"github.com/buger/jsonparser"
|
|
"github.com/thrasher-corp/gocryptotrader/common"
|
|
)
|
|
|
|
var (
|
|
errMissingVersion = errors.New("missing version")
|
|
errVersionIncompatible = errors.New("version does not implement ConfigVersion or ExchangeVersion")
|
|
errModifyingExchange = errors.New("error modifying exchange config")
|
|
errNoVersions = errors.New("error retrieving latest config version: No config versions are registered")
|
|
errApplyingVersion = errors.New("error applying version")
|
|
)
|
|
|
|
// ConfigVersion is a version that affects the general configuration
|
|
type ConfigVersion interface {
|
|
UpgradeConfig(context.Context, []byte) ([]byte, error)
|
|
DowngradeConfig(context.Context, []byte) ([]byte, error)
|
|
}
|
|
|
|
// ExchangeVersion is a version that affects specific exchange configurations
|
|
type ExchangeVersion interface {
|
|
Exchanges() []string // Use `*` for all exchanges
|
|
UpgradeExchange(context.Context, []byte) ([]byte, error)
|
|
DowngradeExchange(context.Context, []byte) ([]byte, error)
|
|
}
|
|
|
|
// manager contains versions registerVersioned during import init
|
|
type manager struct {
|
|
m sync.RWMutex
|
|
versions []any
|
|
}
|
|
|
|
// Manager is a public instance of the config version manager
|
|
var Manager = &manager{}
|
|
|
|
// Deploy upgrades or downgrades the config between versions
|
|
func (m *manager) Deploy(ctx context.Context, j []byte) ([]byte, error) {
|
|
if err := m.checkVersions(); err != nil {
|
|
return j, err
|
|
}
|
|
|
|
target, err := m.latest()
|
|
if err != nil {
|
|
return j, err
|
|
}
|
|
|
|
m.m.RLock()
|
|
defer m.m.RUnlock()
|
|
|
|
current64, err := jsonparser.GetInt(j, "version")
|
|
current := int(current64)
|
|
switch {
|
|
case errors.Is(err, jsonparser.KeyPathNotFoundError):
|
|
current = -1
|
|
case err != nil:
|
|
return j, fmt.Errorf("%w `version`: %w", common.ErrGettingField, err)
|
|
case target == current:
|
|
return j, nil
|
|
}
|
|
|
|
for current != target {
|
|
next := current + 1
|
|
action := "upgrade"
|
|
configMethod := ConfigVersion.UpgradeConfig
|
|
exchMethod := ExchangeVersion.UpgradeExchange
|
|
|
|
if target < current {
|
|
next = current - 1
|
|
action = "downgrade"
|
|
configMethod = ConfigVersion.DowngradeConfig
|
|
exchMethod = ExchangeVersion.DowngradeExchange
|
|
}
|
|
|
|
log.Printf("Running %s to config version %v\n", action, next)
|
|
|
|
patch := m.versions[next]
|
|
|
|
if cPatch, ok := patch.(ConfigVersion); ok {
|
|
if j, err = configMethod(cPatch, ctx, j); err != nil {
|
|
return j, fmt.Errorf("%w %s to %v: %w", errApplyingVersion, action, next, err)
|
|
}
|
|
}
|
|
|
|
if ePatch, ok := patch.(ExchangeVersion); ok {
|
|
if j, err = exchangeDeploy(ctx, ePatch, exchMethod, j); err != nil {
|
|
return j, fmt.Errorf("%w %s to %v: %w", errApplyingVersion, action, next, err)
|
|
}
|
|
}
|
|
|
|
current = next
|
|
|
|
if j, err = jsonparser.Set(j, []byte(strconv.Itoa(current)), "version"); err != nil {
|
|
return j, fmt.Errorf("%w `version` during %s to %v: %w", common.ErrSettingField, action, next, err)
|
|
}
|
|
}
|
|
|
|
log.Println("Version management finished")
|
|
|
|
return j, nil
|
|
}
|
|
|
|
func exchangeDeploy(ctx context.Context, patch ExchangeVersion, method func(ExchangeVersion, context.Context, []byte) ([]byte, error), j []byte) ([]byte, error) {
|
|
var errs error
|
|
wanted := patch.Exchanges()
|
|
var i int
|
|
eFunc := func(exchOrig []byte, _ jsonparser.ValueType, _ int, _ error) {
|
|
defer func() { i++ }()
|
|
name, err := jsonparser.GetString(exchOrig, "name")
|
|
if err != nil {
|
|
errs = common.AppendError(errs, fmt.Errorf("%w: %w `name`: %w", errModifyingExchange, common.ErrGettingField, err))
|
|
return
|
|
}
|
|
for _, want := range wanted {
|
|
if want != "*" && want != name {
|
|
continue
|
|
}
|
|
exchNew, err := method(patch, ctx, exchOrig)
|
|
if err != nil {
|
|
errs = common.AppendError(errs, fmt.Errorf("%w: %w", errModifyingExchange, err))
|
|
continue
|
|
}
|
|
if !bytes.Equal(exchNew, exchOrig) {
|
|
if j, err = jsonparser.Set(j, exchNew, "exchanges", "["+strconv.Itoa(i)+"]"); err != nil {
|
|
errs = common.AppendError(errs, fmt.Errorf("%w: %w `exchanges.[%d]`: %w", errModifyingExchange, common.ErrSettingField, i, err))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
v, dataType, _, err := jsonparser.Get(j, "exchanges")
|
|
switch {
|
|
case errors.Is(err, jsonparser.KeyPathNotFoundError), dataType != jsonparser.Array:
|
|
return j, nil
|
|
case err != nil:
|
|
return j, fmt.Errorf("%w: %w `exchanges`: %w", errModifyingExchange, common.ErrGettingField, err)
|
|
}
|
|
if _, err := jsonparser.ArrayEach(bytes.Clone(v), eFunc); err != nil {
|
|
return j, err
|
|
}
|
|
return j, errs
|
|
}
|
|
|
|
// registerVersion takes instances of config versions and adds them to the registry
|
|
func (m *manager) registerVersion(ver int, v any) {
|
|
m.m.Lock()
|
|
defer m.m.Unlock()
|
|
if ver >= len(m.versions) {
|
|
m.versions = slices.Grow(m.versions, ver+1)[:ver+1]
|
|
}
|
|
m.versions[ver] = v
|
|
}
|
|
|
|
// latest returns the highest version number
|
|
func (m *manager) latest() (int, error) {
|
|
m.m.RLock()
|
|
defer m.m.RUnlock()
|
|
if len(m.versions) == 0 {
|
|
return 0, errNoVersions
|
|
}
|
|
return len(m.versions) - 1, nil
|
|
}
|
|
|
|
// checkVersions ensures that registered versions are consistent
|
|
func (m *manager) checkVersions() error {
|
|
m.m.RLock()
|
|
defer m.m.RUnlock()
|
|
for ver, v := range m.versions {
|
|
switch v.(type) {
|
|
case ExchangeVersion, ConfigVersion:
|
|
default:
|
|
return fmt.Errorf("%w: %v", errVersionIncompatible, ver)
|
|
}
|
|
if v == nil {
|
|
return fmt.Errorf("%w: v%v", errMissingVersion, ver)
|
|
}
|
|
}
|
|
return nil
|
|
}
|