mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-13 23:16:45 +00:00
* Websocket: Remove IsInit and simplify SetProxyAddress IsInit was basically the same as IsConnected. Any time Connect was called both would be set to true. Any time we had a disconnect they'd both be set to false Shutdown() incorrectly didn't setInit(false) SetProxyAddress simplified to only reconnect a connected Websocket. Any other state means it hasn't been Connected, or it's about to reconnect anyway. There's no handling for IsConnecting previously, either, so I've wrapped that behind the main mutex. * Websocket: Expand and Assertify tests * Websocket: Simplify state transistions * Websocket: Simplify Connecting/Connected state * Websocket: Tests and errors for websocket * Websocket: Make WebsocketNotEnabled a real error This allows for testing and avoids the repetition. If each returned error is a error.New() you can never use errors.Is() * Websocket: Add more testable errors * Websocket: Improve GenerateMessageID test Testing just the last id doesn't feel very robust * Websocket: Protect Setup() from races * Websocket: Use atomics instead of mutex This was spurred by looking at the setState call in trafficMonitor and the effect on blocking and efficiency. With the new atomic types in Go 1.19, and the small types in use here, atomics should be safe for our usage. bools should be truly atomic, and uint32 is atomic when the accepted value range is less than one byte/uint8 since that can be written atomicly by concurrent processors. Maybe that's not even a factor any more, however we don't even have to worry enough to check. * Websocket: Fix and simplify traffic monitor trafficMonitor had a check throttle at the end of the for loop to stop it just gobbling the (blocking) trafficAlert channel non-stop. That makes sense, except that nothing is sent to the trafficAlert channel if there's no listener. So that means that it's out by one second on the trafficAlert, because any traffic received during the pause is doesn't try to send a traffic alert. The unstopped timer is deliberately leaked for later GC when shutdown. It won't delay/block anything, and it's a trivial memory leak during an infrequent event. Deliberately Choosing to recreate the timer each time instead of using Stop, drain and reset * Websocket: Split traficMonitor test on behaviours * Websocket: Remove trafficMonitor connected status trafficMonitor does not need to set the connection to be connected. Connect() does that. Anything after that should result in a full shutdown and restart. It can't and shouldn't become connected unexpectedly, and this is most likely a race anyway. Also dropped trafficCheckInterval to 100ms to mitigate races of traffic alerts being buffered for too long. * Websocket: Set disconnected earlier in Shutdown This caused a possible race where state is still connected, but we start to trigger interested actors via ShutdownC and Wait. They may check state and then call Shutdown again, such as trafficMonitor * Websocket: Wait 5s for slow tests to pass traffic draining Keep getting failures upstream on test rigs. Think they can be very contended, so this pushes the boundary right out to 5s
315 lines
8.1 KiB
Go
315 lines
8.1 KiB
Go
package stream
|
|
|
|
import (
|
|
"bytes"
|
|
"compress/flate"
|
|
"compress/gzip"
|
|
"crypto/rand"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"math/big"
|
|
"net"
|
|
"net/http"
|
|
"net/url"
|
|
"sync/atomic"
|
|
"time"
|
|
|
|
"github.com/gorilla/websocket"
|
|
"github.com/thrasher-corp/gocryptotrader/log"
|
|
)
|
|
|
|
// SendMessageReturnResponse will send a WS message to the connection and wait
|
|
// for response
|
|
func (w *WebsocketConnection) SendMessageReturnResponse(signature, request interface{}) ([]byte, error) {
|
|
m, err := w.Match.Set(signature)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer m.Cleanup()
|
|
|
|
b, err := json.Marshal(request)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("error marshaling json for %s: %w", signature, err)
|
|
}
|
|
|
|
start := time.Now()
|
|
err = w.SendRawMessage(websocket.TextMessage, b)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
timer := time.NewTimer(w.ResponseMaxLimit)
|
|
|
|
select {
|
|
case payload := <-m.C:
|
|
if w.Reporter != nil {
|
|
w.Reporter.Latency(w.ExchangeName, b, time.Since(start))
|
|
}
|
|
|
|
return payload, nil
|
|
case <-timer.C:
|
|
timer.Stop()
|
|
return nil, fmt.Errorf("%s websocket connection: timeout waiting for response with signature: %v", w.ExchangeName, signature)
|
|
}
|
|
}
|
|
|
|
// Dial sets proxy urls and then connects to the websocket
|
|
func (w *WebsocketConnection) Dial(dialer *websocket.Dialer, headers http.Header) error {
|
|
if w.ProxyURL != "" {
|
|
proxy, err := url.Parse(w.ProxyURL)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
dialer.Proxy = http.ProxyURL(proxy)
|
|
}
|
|
|
|
var err error
|
|
var conStatus *http.Response
|
|
|
|
w.Connection, conStatus, err = dialer.Dial(w.URL, headers)
|
|
if err != nil {
|
|
if conStatus != nil {
|
|
return fmt.Errorf("%s websocket connection: %v %v %v Error: %w", w.ExchangeName, w.URL, conStatus, conStatus.StatusCode, err)
|
|
}
|
|
return fmt.Errorf("%s websocket connection: %v Error: %w", w.ExchangeName, w.URL, err)
|
|
}
|
|
defer conStatus.Body.Close()
|
|
|
|
if w.Verbose {
|
|
log.Infof(log.WebsocketMgr, "%v Websocket connected to %s\n", w.ExchangeName, w.URL)
|
|
}
|
|
select {
|
|
case w.Traffic <- struct{}{}:
|
|
default:
|
|
}
|
|
w.setConnectedStatus(true)
|
|
return nil
|
|
}
|
|
|
|
// SendJSONMessage sends a JSON encoded message over the connection
|
|
func (w *WebsocketConnection) SendJSONMessage(data interface{}) error {
|
|
if !w.IsConnected() {
|
|
return fmt.Errorf("%s websocket connection: cannot send message to a disconnected websocket",
|
|
w.ExchangeName)
|
|
}
|
|
|
|
w.writeControl.Lock()
|
|
defer w.writeControl.Unlock()
|
|
|
|
if w.Verbose {
|
|
log.Debugf(log.WebsocketMgr,
|
|
"%s websocket connection: sending message to websocket %+v\n",
|
|
w.ExchangeName,
|
|
data)
|
|
}
|
|
|
|
if w.RateLimit > 0 {
|
|
time.Sleep(time.Duration(w.RateLimit) * time.Millisecond)
|
|
if !w.IsConnected() {
|
|
return fmt.Errorf("%v websocket connection: cannot send message to a disconnected websocket",
|
|
w.ExchangeName)
|
|
}
|
|
}
|
|
return w.Connection.WriteJSON(data)
|
|
}
|
|
|
|
// SendRawMessage sends a message over the connection without JSON encoding it
|
|
func (w *WebsocketConnection) SendRawMessage(messageType int, message []byte) error {
|
|
if !w.IsConnected() {
|
|
return fmt.Errorf("%v websocket connection: cannot send message to a disconnected websocket",
|
|
w.ExchangeName)
|
|
}
|
|
|
|
w.writeControl.Lock()
|
|
defer w.writeControl.Unlock()
|
|
|
|
if w.Verbose {
|
|
log.Debugf(log.WebsocketMgr,
|
|
"%v websocket connection: sending message [%s]\n",
|
|
w.ExchangeName,
|
|
message)
|
|
}
|
|
if w.RateLimit > 0 {
|
|
time.Sleep(time.Duration(w.RateLimit) * time.Millisecond)
|
|
if !w.IsConnected() {
|
|
return fmt.Errorf("%v websocket connection: cannot send message to a disconnected websocket",
|
|
w.ExchangeName)
|
|
}
|
|
}
|
|
if !w.IsConnected() {
|
|
return fmt.Errorf("%v websocket connection: cannot send message to a disconnected websocket",
|
|
w.ExchangeName)
|
|
}
|
|
return w.Connection.WriteMessage(messageType, message)
|
|
}
|
|
|
|
// SetupPingHandler will automatically send ping or pong messages based on
|
|
// WebsocketPingHandler configuration
|
|
func (w *WebsocketConnection) SetupPingHandler(handler PingHandler) {
|
|
if handler.UseGorillaHandler {
|
|
h := func(msg string) error {
|
|
err := w.Connection.WriteControl(handler.MessageType,
|
|
[]byte(msg),
|
|
time.Now().Add(handler.Delay))
|
|
if err == websocket.ErrCloseSent {
|
|
return nil
|
|
} else if e, ok := err.(net.Error); ok && e.Timeout() {
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
w.Connection.SetPingHandler(h)
|
|
return
|
|
}
|
|
w.Wg.Add(1)
|
|
defer w.Wg.Done()
|
|
go func() {
|
|
ticker := time.NewTicker(handler.Delay)
|
|
for {
|
|
select {
|
|
case <-w.ShutdownC:
|
|
ticker.Stop()
|
|
return
|
|
case <-ticker.C:
|
|
err := w.SendRawMessage(handler.MessageType, handler.Message)
|
|
if err != nil {
|
|
log.Errorf(log.WebsocketMgr,
|
|
"%v websocket connection: ping handler failed to send message [%s]",
|
|
w.ExchangeName,
|
|
handler.Message)
|
|
return
|
|
}
|
|
}
|
|
}
|
|
}()
|
|
}
|
|
|
|
// setConnectedStatus sets connection status if changed it will return true.
|
|
// TODO: Swap out these atomic switches and opt for sync.RWMutex.
|
|
func (w *WebsocketConnection) setConnectedStatus(b bool) bool {
|
|
if b {
|
|
return atomic.SwapInt32(&w.connected, 1) == 0
|
|
}
|
|
return atomic.SwapInt32(&w.connected, 0) == 1
|
|
}
|
|
|
|
// IsConnected exposes websocket connection status
|
|
func (w *WebsocketConnection) IsConnected() bool {
|
|
return atomic.LoadInt32(&w.connected) == 1
|
|
}
|
|
|
|
// ReadMessage reads messages, can handle text, gzip and binary
|
|
func (w *WebsocketConnection) ReadMessage() Response {
|
|
mType, resp, err := w.Connection.ReadMessage()
|
|
if err != nil {
|
|
if IsDisconnectionError(err) {
|
|
if w.setConnectedStatus(false) {
|
|
// NOTE: When w.setConnectedStatus() returns true the underlying
|
|
// state was changed and this infers that the connection was
|
|
// externally closed and an error is reported else Shutdown()
|
|
// method on WebsocketConnection type has been called and can
|
|
// be skipped.
|
|
select {
|
|
case w.readMessageErrors <- err:
|
|
default:
|
|
// bypass if there is no receiver, as this stops it returning
|
|
// when shutdown is called.
|
|
log.Warnf(log.WebsocketMgr,
|
|
"%s failed to relay error: %v",
|
|
w.ExchangeName,
|
|
err)
|
|
}
|
|
}
|
|
}
|
|
return Response{}
|
|
}
|
|
|
|
select {
|
|
case w.Traffic <- struct{}{}:
|
|
default: // Non-Blocking write ensures 1 buffered signal per trafficCheckInterval to avoid flooding
|
|
}
|
|
|
|
var standardMessage []byte
|
|
switch mType {
|
|
case websocket.TextMessage:
|
|
standardMessage = resp
|
|
case websocket.BinaryMessage:
|
|
standardMessage, err = w.parseBinaryResponse(resp)
|
|
if err != nil {
|
|
log.Errorf(log.WebsocketMgr,
|
|
"%v websocket connection: parseBinaryResponse error: %v",
|
|
w.ExchangeName,
|
|
err)
|
|
return Response{}
|
|
}
|
|
}
|
|
if w.Verbose {
|
|
log.Debugf(log.WebsocketMgr,
|
|
"%v websocket connection: message received: %v",
|
|
w.ExchangeName,
|
|
string(standardMessage))
|
|
}
|
|
return Response{Raw: standardMessage, Type: mType}
|
|
}
|
|
|
|
// parseBinaryResponse parses a websocket binary response into a usable byte array
|
|
func (w *WebsocketConnection) parseBinaryResponse(resp []byte) ([]byte, error) {
|
|
var reader io.ReadCloser
|
|
var err error
|
|
if len(resp) >= 2 && resp[0] == 31 && resp[1] == 139 { // Detect GZIP
|
|
reader, err = gzip.NewReader(bytes.NewReader(resp))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
} else {
|
|
reader = flate.NewReader(bytes.NewReader(resp))
|
|
}
|
|
standardMessage, err := io.ReadAll(reader)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return standardMessage, reader.Close()
|
|
}
|
|
|
|
// GenerateMessageID Creates a random message ID
|
|
func (w *WebsocketConnection) GenerateMessageID(highPrec bool) int64 {
|
|
var min int64 = 1e8
|
|
var max int64 = 2e8
|
|
if highPrec {
|
|
max = 2e12
|
|
min = 1e12
|
|
}
|
|
// utilization of hard coded positive numbers and default crypto/rand
|
|
// io.reader will panic on error instead of returning
|
|
randomNumber, err := rand.Int(rand.Reader, big.NewInt(max-min+1))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
return randomNumber.Int64() + min
|
|
}
|
|
|
|
// Shutdown shuts down and closes specific connection
|
|
func (w *WebsocketConnection) Shutdown() error {
|
|
if w == nil || w.Connection == nil {
|
|
return nil
|
|
}
|
|
w.setConnectedStatus(false)
|
|
return w.Connection.UnderlyingConn().Close()
|
|
}
|
|
|
|
// SetURL sets connection URL
|
|
func (w *WebsocketConnection) SetURL(url string) {
|
|
w.URL = url
|
|
}
|
|
|
|
// SetProxy sets connection proxy
|
|
func (w *WebsocketConnection) SetProxy(proxy string) {
|
|
w.ProxyURL = proxy
|
|
}
|
|
|
|
// GetURL returns the connection URL
|
|
func (w *WebsocketConnection) GetURL() string {
|
|
return w.URL
|
|
}
|