mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-14 07:26:47 +00:00
* golangci: Enable err checking linter to expose unchecked errors. * gct: handle errors across the board * gct: handle errors NOTE: Found bug in FTX (WIP) * linter: fix issues * ftx/exchanges: fix bug where error was being returned when setting pair management variables to an already enabled state * bitmex: fix bug where a dangly supported asset in config danglied up the place. * linter: fix more linter issues * linter: fix my terrible spelling. * currency: fix test * exchanges: fix tests * logger: fix test * exchanges: fix tests * glorious: nits * vm: revert rm variable and instigate test
644 lines
14 KiB
Go
644 lines
14 KiB
Go
package request
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"log"
|
|
"math"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"os"
|
|
"strconv"
|
|
"strings"
|
|
"sync"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
|
|
"golang.org/x/time/rate"
|
|
)
|
|
|
|
const unexpected = "unexpected values"
|
|
|
|
var testURL string
|
|
var serverLimit *rate.Limiter
|
|
|
|
func TestMain(m *testing.M) {
|
|
serverLimitInterval := time.Millisecond * 500
|
|
serverLimit = NewRateLimit(serverLimitInterval, 1)
|
|
serverLimitRetry := NewRateLimit(serverLimitInterval, 1)
|
|
sm := http.NewServeMux()
|
|
sm.HandleFunc("/", func(w http.ResponseWriter, req *http.Request) {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
_, err := io.WriteString(w, `{"response":true}`)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
})
|
|
sm.HandleFunc("/error", func(w http.ResponseWriter, req *http.Request) {
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
_, err := io.WriteString(w, `{"error":true}`)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
})
|
|
sm.HandleFunc("/timeout", func(w http.ResponseWriter, req *http.Request) {
|
|
time.Sleep(time.Millisecond * 100)
|
|
w.WriteHeader(http.StatusGatewayTimeout)
|
|
})
|
|
sm.HandleFunc("/rate", func(w http.ResponseWriter, req *http.Request) {
|
|
if !serverLimit.Allow() {
|
|
http.Error(w,
|
|
http.StatusText(http.StatusTooManyRequests),
|
|
http.StatusTooManyRequests)
|
|
_, err := io.WriteString(w, `{"response":false}`)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
return
|
|
}
|
|
_, err := io.WriteString(w, `{"response":true}`)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
})
|
|
sm.HandleFunc("/rate-retry", func(w http.ResponseWriter, req *http.Request) {
|
|
if !serverLimitRetry.Allow() {
|
|
w.Header().Add("Retry-After", strconv.Itoa(int(math.Round(serverLimitInterval.Seconds()))))
|
|
http.Error(w,
|
|
http.StatusText(http.StatusTooManyRequests),
|
|
http.StatusTooManyRequests)
|
|
_, err := io.WriteString(w, `{"response":false}`)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
return
|
|
}
|
|
_, err := io.WriteString(w, `{"response":true}`)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
})
|
|
sm.HandleFunc("/always-retry", func(w http.ResponseWriter, req *http.Request) {
|
|
w.Header().Add("Retry-After", time.Now().Format(time.RFC1123))
|
|
w.WriteHeader(http.StatusTooManyRequests)
|
|
_, err := io.WriteString(w, `{"response":false}`)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
})
|
|
|
|
server := httptest.NewServer(sm)
|
|
testURL = server.URL
|
|
issues := m.Run()
|
|
server.Close()
|
|
os.Exit(issues)
|
|
}
|
|
|
|
func TestNewRateLimit(t *testing.T) {
|
|
t.Parallel()
|
|
r := NewRateLimit(time.Second*10, 5)
|
|
if r.Limit() != 0.5 {
|
|
t.Fatal(unexpected)
|
|
}
|
|
|
|
// Ensures rate limiting factor is the same
|
|
r = NewRateLimit(time.Second*2, 1)
|
|
if r.Limit() != 0.5 {
|
|
t.Fatal(unexpected)
|
|
}
|
|
|
|
// Test for open rate limit
|
|
r = NewRateLimit(time.Second*2, 0)
|
|
if r.Limit() != rate.Inf {
|
|
t.Fatal(unexpected)
|
|
}
|
|
|
|
r = NewRateLimit(0, 69)
|
|
if r.Limit() != rate.Inf {
|
|
t.Fatal(unexpected)
|
|
}
|
|
}
|
|
|
|
func TestCheckRequest(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
r := New("TestRequest",
|
|
new(http.Client))
|
|
ctx := context.Background()
|
|
|
|
var check *Item
|
|
_, err := check.validateRequest(ctx, &Requester{})
|
|
if err == nil {
|
|
t.Fatal(unexpected)
|
|
}
|
|
|
|
_, err = check.validateRequest(ctx, nil)
|
|
if err == nil {
|
|
t.Fatal(unexpected)
|
|
}
|
|
|
|
_, err = check.validateRequest(ctx, r)
|
|
if err == nil {
|
|
t.Fatal(unexpected)
|
|
}
|
|
|
|
check = &Item{}
|
|
_, err = check.validateRequest(ctx, r)
|
|
if err == nil {
|
|
t.Fatal(unexpected)
|
|
}
|
|
|
|
check.Path = testURL
|
|
check.Method = " " // Forces method check; "" automatically converts to GET
|
|
_, err = check.validateRequest(ctx, r)
|
|
if err == nil {
|
|
t.Fatal(unexpected)
|
|
}
|
|
|
|
check.Method = http.MethodPost
|
|
_, err = check.validateRequest(ctx, r)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var passback http.Header
|
|
check.HeaderResponse = &passback
|
|
_, err = check.validateRequest(ctx, r)
|
|
if err == nil {
|
|
t.Fatal("expected error when underlying memory is not allocated")
|
|
}
|
|
passback = http.Header{}
|
|
|
|
// Test setting headers
|
|
check.Headers = map[string]string{
|
|
"Content-Type": "Super awesome HTTP party experience",
|
|
}
|
|
|
|
// Test user agent set
|
|
r.UserAgent = "r00t axxs"
|
|
req, err := check.validateRequest(ctx, r)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if req.Header.Get("Content-Type") != "Super awesome HTTP party experience" {
|
|
t.Fatal(unexpected)
|
|
}
|
|
|
|
if req.UserAgent() != "r00t axxs" {
|
|
t.Fatal(unexpected)
|
|
}
|
|
}
|
|
|
|
type GlobalLimitTest struct {
|
|
Auth *rate.Limiter
|
|
UnAuth *rate.Limiter
|
|
}
|
|
|
|
var errEndpointLimitNotFound = errors.New("endpoint limit not found")
|
|
|
|
func (g *GlobalLimitTest) Limit(ctx context.Context, e EndpointLimit) error {
|
|
switch e {
|
|
case Auth:
|
|
if g.Auth == nil {
|
|
return errors.New("auth rate not set")
|
|
}
|
|
return g.Auth.Wait(ctx)
|
|
case UnAuth:
|
|
if g.UnAuth == nil {
|
|
return errors.New("unauth rate not set")
|
|
}
|
|
return g.UnAuth.Wait(ctx)
|
|
default:
|
|
return fmt.Errorf("cannot execute functionality: %d %w",
|
|
e,
|
|
errEndpointLimitNotFound)
|
|
}
|
|
}
|
|
|
|
var globalshell = GlobalLimitTest{
|
|
Auth: NewRateLimit(time.Millisecond*600, 1),
|
|
UnAuth: NewRateLimit(time.Second*1, 100)}
|
|
|
|
func TestDoRequest(t *testing.T) {
|
|
t.Parallel()
|
|
r := New("test", new(http.Client), WithLimiter(&globalshell))
|
|
|
|
ctx := context.Background()
|
|
err := (*Requester)(nil).SendPayload(ctx, Unset, nil)
|
|
if !errors.Is(errRequestSystemIsNil, err) {
|
|
t.Fatalf("expected: %v but received: %v", errRequestSystemIsNil, err)
|
|
}
|
|
err = r.SendPayload(ctx, Unset, nil)
|
|
if !errors.Is(errRequestFunctionIsNil, err) {
|
|
t.Fatalf("expected: %v but received: %v", errRequestFunctionIsNil, err)
|
|
}
|
|
|
|
err = r.SendPayload(ctx, UnAuth, func() (*Item, error) { return nil, nil })
|
|
if !errors.Is(errRequestItemNil, err) {
|
|
t.Fatalf("expected: %v but received: %v", errRequestItemNil, err)
|
|
}
|
|
|
|
err = r.SendPayload(ctx, UnAuth, func() (*Item, error) { return &Item{}, nil })
|
|
if !errors.Is(errInvalidPath, err) {
|
|
t.Fatalf("expected: %v but received: %v", errInvalidPath, err)
|
|
}
|
|
|
|
var nilHeader http.Header
|
|
err = r.SendPayload(ctx, UnAuth, func() (*Item, error) {
|
|
return &Item{
|
|
Path: testURL,
|
|
HeaderResponse: &nilHeader,
|
|
}, nil
|
|
})
|
|
if !errors.Is(errHeaderResponseMapIsNil, err) {
|
|
t.Fatalf("expected: %v but received: %v", errHeaderResponseMapIsNil, err)
|
|
}
|
|
|
|
// Invalid/missing endpoint limit
|
|
err = r.SendPayload(ctx, Unset, func() (*Item, error) {
|
|
return &Item{
|
|
Path: testURL,
|
|
}, nil
|
|
})
|
|
if !errors.Is(err, errEndpointLimitNotFound) {
|
|
t.Fatalf("expected: %v but received: %v", errEndpointLimitNotFound, err)
|
|
}
|
|
|
|
// Force debug
|
|
err = r.SendPayload(ctx, UnAuth, func() (*Item, error) {
|
|
return &Item{
|
|
Path: testURL,
|
|
Headers: map[string]string{
|
|
"test": "supertest",
|
|
},
|
|
Body: strings.NewReader("test"),
|
|
HTTPDebugging: true,
|
|
Verbose: true,
|
|
}, nil
|
|
})
|
|
if !errors.Is(err, nil) {
|
|
t.Fatalf("received: %v but expected: %v", err, nil)
|
|
}
|
|
|
|
// Fail new request call
|
|
newError := errors.New("request item failure")
|
|
err = r.SendPayload(ctx, UnAuth, func() (*Item, error) {
|
|
return nil, newError
|
|
})
|
|
if !errors.Is(err, newError) {
|
|
t.Fatalf("received: %v but expected: %v", err, newError)
|
|
}
|
|
|
|
// max request job ceiling
|
|
r.jobs = MaxRequestJobs
|
|
err = r.SendPayload(ctx, UnAuth, func() (*Item, error) {
|
|
return &Item{Path: testURL}, nil
|
|
})
|
|
if !errors.Is(err, errMaxRequestJobs) {
|
|
t.Fatalf("received: %v but expected: %v", err, errMaxRequestJobs)
|
|
}
|
|
// reset jobs
|
|
r.jobs = 0
|
|
|
|
// timeout checker
|
|
r.HTTPClient.Timeout = time.Millisecond * 50
|
|
err = r.SendPayload(ctx, UnAuth, func() (*Item, error) {
|
|
return &Item{Path: testURL + "/timeout"}, nil
|
|
})
|
|
if !errors.Is(err, errFailedToRetryRequest) {
|
|
t.Fatalf("received: %v but expected: %v", err, errFailedToRetryRequest)
|
|
}
|
|
// reset timeout
|
|
r.HTTPClient.Timeout = 0
|
|
|
|
// Check JSON
|
|
var resp struct {
|
|
Response bool `json:"response"`
|
|
}
|
|
|
|
// Check header contents
|
|
var passback = http.Header{}
|
|
err = r.SendPayload(ctx, UnAuth, func() (*Item, error) {
|
|
return &Item{
|
|
Method: http.MethodGet,
|
|
Path: testURL,
|
|
Result: &resp,
|
|
HeaderResponse: &passback,
|
|
}, nil
|
|
})
|
|
if !errors.Is(err, nil) {
|
|
t.Fatalf("received: %v but expected: %v", err, nil)
|
|
}
|
|
|
|
if passback.Get("Content-Length") != "17" {
|
|
t.Fatal("incorrect header value")
|
|
}
|
|
|
|
if passback.Get("Content-Type") != "application/json" {
|
|
t.Fatal("incorrect header value")
|
|
}
|
|
|
|
// Check error
|
|
var respErr struct {
|
|
Error bool `json:"error"`
|
|
}
|
|
err = r.SendPayload(ctx, UnAuth, func() (*Item, error) {
|
|
return &Item{
|
|
Method: http.MethodGet,
|
|
Path: testURL,
|
|
Result: &respErr,
|
|
}, nil
|
|
})
|
|
if !errors.Is(err, nil) {
|
|
t.Fatalf("received: %v but expected: %v", err, nil)
|
|
}
|
|
|
|
if respErr.Error {
|
|
t.Fatal("unexpected value")
|
|
}
|
|
|
|
// Check client side rate limit
|
|
var failed int32
|
|
var wg sync.WaitGroup
|
|
wg.Add(5)
|
|
for i := 0; i < 5; i++ {
|
|
go func(wg *sync.WaitGroup) {
|
|
var resp struct {
|
|
Response bool `json:"response"`
|
|
}
|
|
payloadError := r.SendPayload(ctx, Auth, func() (*Item, error) {
|
|
return &Item{
|
|
Method: http.MethodGet,
|
|
Path: testURL + "/rate",
|
|
Result: &resp,
|
|
AuthRequest: true,
|
|
}, nil
|
|
})
|
|
wg.Done()
|
|
if payloadError != nil {
|
|
atomic.StoreInt32(&failed, 1)
|
|
log.Fatal(payloadError)
|
|
}
|
|
if !resp.Response {
|
|
atomic.StoreInt32(&failed, 1)
|
|
log.Fatal(unexpected)
|
|
}
|
|
}(&wg)
|
|
}
|
|
wg.Wait()
|
|
|
|
if failed != 0 {
|
|
t.Fatal("request failed")
|
|
}
|
|
}
|
|
|
|
func TestDoRequest_Retries(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
backoff := func(n int) time.Duration {
|
|
return 0
|
|
}
|
|
r := New("test", new(http.Client), WithBackoff(backoff))
|
|
var failed int32
|
|
var wg sync.WaitGroup
|
|
wg.Add(4)
|
|
for i := 0; i < 4; i++ {
|
|
go func(wg *sync.WaitGroup) {
|
|
defer wg.Done()
|
|
var resp struct {
|
|
Response bool `json:"response"`
|
|
}
|
|
payloadError := r.SendPayload(context.Background(), Auth, func() (*Item, error) {
|
|
return &Item{
|
|
Method: http.MethodGet,
|
|
Path: testURL + "/rate-retry",
|
|
Result: &resp,
|
|
AuthRequest: true,
|
|
}, nil
|
|
})
|
|
if payloadError != nil {
|
|
atomic.StoreInt32(&failed, 1)
|
|
log.Fatal(payloadError)
|
|
}
|
|
if !resp.Response {
|
|
atomic.StoreInt32(&failed, 1)
|
|
log.Fatal(unexpected)
|
|
}
|
|
}(&wg)
|
|
}
|
|
wg.Wait()
|
|
|
|
if failed != 0 {
|
|
t.Fatal("request failed")
|
|
}
|
|
}
|
|
|
|
func TestDoRequest_RetryNonRecoverable(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
backoff := func(n int) time.Duration {
|
|
return 0
|
|
}
|
|
r := New("test", new(http.Client), WithBackoff(backoff))
|
|
err := r.SendPayload(context.Background(), Unset, func() (*Item, error) {
|
|
return &Item{
|
|
Method: http.MethodGet,
|
|
Path: testURL + "/always-retry",
|
|
}, nil
|
|
})
|
|
if !errors.Is(err, errFailedToRetryRequest) {
|
|
t.Fatalf("received: %v but expected: %v", err, errFailedToRetryRequest)
|
|
}
|
|
}
|
|
|
|
func TestDoRequest_NotRetryable(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
notRetryErr := errors.New("not retryable")
|
|
retry := func(resp *http.Response, err error) (bool, error) {
|
|
return false, notRetryErr
|
|
}
|
|
backoff := func(n int) time.Duration {
|
|
return time.Duration(n) * time.Millisecond
|
|
}
|
|
r := New("test", new(http.Client), WithRetryPolicy(retry), WithBackoff(backoff))
|
|
err := r.SendPayload(context.Background(), Unset, func() (*Item, error) {
|
|
return &Item{
|
|
Method: http.MethodGet,
|
|
Path: testURL + "/always-retry",
|
|
}, nil
|
|
})
|
|
if !errors.Is(err, notRetryErr) {
|
|
t.Fatalf("received: %v but expected: %v", err, notRetryErr)
|
|
}
|
|
}
|
|
|
|
func TestGetNonce(t *testing.T) {
|
|
t.Parallel()
|
|
r := New("test",
|
|
new(http.Client),
|
|
WithLimiter(&globalshell))
|
|
|
|
n1 := r.GetNonce(false)
|
|
n2 := r.GetNonce(false)
|
|
if n1 == n2 {
|
|
t.Fatal(unexpected)
|
|
}
|
|
|
|
r2 := New("test",
|
|
new(http.Client),
|
|
WithLimiter(&globalshell))
|
|
n3 := r2.GetNonce(true)
|
|
n4 := r2.GetNonce(true)
|
|
if n3 == n4 {
|
|
t.Fatal(unexpected)
|
|
}
|
|
}
|
|
|
|
func TestGetNonceMillis(t *testing.T) {
|
|
t.Parallel()
|
|
r := New("test",
|
|
new(http.Client),
|
|
WithLimiter(&globalshell))
|
|
m1 := r.GetNonceMilli()
|
|
m2 := r.GetNonceMilli()
|
|
if m1 == m2 {
|
|
log.Fatal(unexpected)
|
|
}
|
|
}
|
|
|
|
func TestSetProxy(t *testing.T) {
|
|
t.Parallel()
|
|
r := New("test",
|
|
&http.Client{Transport: new(http.Transport)},
|
|
WithLimiter(&globalshell))
|
|
u, err := url.Parse("http://www.google.com")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
err = r.SetProxy(u)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
u, err = url.Parse("")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
err = r.SetProxy(u)
|
|
if err == nil {
|
|
t.Fatal("error cannot be nil")
|
|
}
|
|
}
|
|
|
|
func TestBasicLimiter(t *testing.T) {
|
|
r := New("test",
|
|
new(http.Client),
|
|
WithLimiter(NewBasicRateLimit(time.Second, 1)))
|
|
i := Item{
|
|
Path: "http://www.google.com",
|
|
Method: http.MethodGet,
|
|
}
|
|
ctx := context.Background()
|
|
|
|
tn := time.Now()
|
|
err := r.SendPayload(ctx, Unset, func() (*Item, error) { return &i, nil })
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
err = r.SendPayload(ctx, Unset, func() (*Item, error) { return &i, nil })
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if time.Since(tn) < time.Second {
|
|
t.Error("rate limit issues")
|
|
}
|
|
|
|
ctx, cancel := context.WithDeadline(ctx, tn.Add(time.Nanosecond))
|
|
defer cancel()
|
|
err = r.SendPayload(ctx, Unset, func() (*Item, error) { return &i, nil })
|
|
if !errors.Is(err, context.DeadlineExceeded) {
|
|
t.Fatalf("receieved: %v but expected: %v", err, context.DeadlineExceeded)
|
|
}
|
|
}
|
|
|
|
func TestEnableDisableRateLimit(t *testing.T) {
|
|
r := New("TestRequest",
|
|
new(http.Client),
|
|
WithLimiter(NewBasicRateLimit(time.Minute, 1)))
|
|
ctx := context.Background()
|
|
|
|
var resp interface{}
|
|
err := r.SendPayload(ctx, Auth, func() (*Item, error) {
|
|
return &Item{
|
|
Method: http.MethodGet,
|
|
Path: testURL,
|
|
Result: &resp,
|
|
AuthRequest: true,
|
|
}, nil
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
err = r.EnableRateLimiter()
|
|
if err == nil {
|
|
t.Fatal("error cannot be nil")
|
|
}
|
|
|
|
err = r.DisableRateLimiter()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
err = r.SendPayload(ctx, Auth, func() (*Item, error) {
|
|
return &Item{
|
|
Method: http.MethodGet,
|
|
Path: testURL,
|
|
Result: &resp,
|
|
AuthRequest: true,
|
|
}, nil
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
err = r.DisableRateLimiter()
|
|
if err == nil {
|
|
t.Fatal("error cannot be nil")
|
|
}
|
|
|
|
err = r.EnableRateLimiter()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
ti := time.NewTicker(time.Second)
|
|
c := make(chan struct{})
|
|
go func(c chan struct{}) {
|
|
err = r.SendPayload(ctx, Auth, func() (*Item, error) {
|
|
return &Item{
|
|
Method: http.MethodGet,
|
|
Path: testURL,
|
|
Result: &resp,
|
|
AuthRequest: true,
|
|
}, nil
|
|
})
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
c <- struct{}{}
|
|
}(c)
|
|
|
|
select {
|
|
case <-c:
|
|
t.Fatal("rate limiting failure")
|
|
case <-ti.C:
|
|
// Correct test
|
|
}
|
|
}
|