Files
gocryptotrader/log/logger_test.go
Ryan O'Hara-Reid 4e135c9590 logger: reduce go routine generation (#992)
* logger: reduce go routine generation

* logger: shift most of processing and prep work to the worker pool, add pool for fields because each log we are pushing the struct to the heap, has better segregation now and includes a buffer in scope instead of relying on a pool

* logger: shift fmt package calls to worker pool

* logger: conform tests to new design

* linter: fix issues

* Update log/logger_test.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update log/logger_test.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* UN-GLORIOUS: nits

* logger: Handle config variable

* logger: NITERINOS BY GLORIOUS CODE

* logger: revert

* glorious: nits

* Panic at the disco: fix

* Panic at the disco: fix

* logger: make sure logger closed and job channel emptied on start up error

* fix tests

* logger: reduce globals

* logger: finished reduces globals, reduce workers to one too keep everything in line.

* logger: remove comments

* logger/exhchange: linter issues

* db/test: fix linter

* logger: add tests shift wait before unlock

* logger: consolidate worker code; fix linter issue and make sure we can sustain writing for external testing.

* logger: fix race and warn for conflict in config

* logger: fix name and add to tests

* logger: remove zero value field

* glorious: panic fix and removal of code

* logger: reinstate channels in close

* logger: shift reinstate processing to SetupGlobalLogger

* logger: segregate config.json from internal log.Config

* logger: fix silly mistake that is silly

* engine: Add protection for nil issues and implement new constructor in tests

* logger: Force singular mutex usage throughout package, throw away funcs that are not used outside of this package, unexport a bunch. Fix tests.

* logger: actually set advanced settings

* Update log/loggers.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update log/loggers.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update log/loggers.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update log/loggers.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update log/logger_multiwriter.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* glorious: nits

* logger: test issue when not purging temp file and contents

* loggertest: add more protections for the panics

* linter: fix

* glorious: nits

* cleanup

* logger: linter fix

* linter: fix(?) :/

* linter: revert change

* linter: fix

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>
Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io>
2022-10-24 11:46:18 +11:00

759 lines
18 KiB
Go

package log
import (
"errors"
"io"
"log"
"os"
"strings"
"testing"
"time"
"github.com/thrasher-corp/gocryptotrader/common/convert"
)
var (
testConfigEnabled = &Config{
Enabled: convert.BoolPtr(true),
SubLoggerConfig: SubLoggerConfig{
Output: "console",
Level: "INFO|WARN|DEBUG|ERROR",
},
AdvancedSettings: advancedSettings{
ShowLogSystemName: convert.BoolPtr(true),
Spacer: " | ",
TimeStampFormat: timestampFormat,
Headers: headers{
Info: "[INFO]",
Warn: "[WARN]",
Debug: "[DEBUG]",
Error: "[ERROR]",
},
},
SubLoggers: []SubLoggerConfig{
{
Name: "lOg",
Level: "INFO|DEBUG|WARN|ERROR",
Output: "stdout",
}},
}
testConfigDisabled = &Config{
Enabled: convert.BoolPtr(false),
SubLoggerConfig: SubLoggerConfig{Output: "console"},
}
tempDir string
)
func TestMain(m *testing.M) {
err := setupTestLoggers()
if err != nil {
log.Fatal("cannot set up test loggers", err)
}
tempDir, err = os.MkdirTemp(os.TempDir(), "")
if err != nil {
log.Fatal("Cannot create temporary file", err)
}
log.Println("temp dir created at:", tempDir)
err = SetLogPath(tempDir)
if err != nil {
log.Fatal("Cannot set log path", err)
}
r := m.Run()
err = CloseLogger()
if err != nil {
log.Fatalf("CloseLogger() failed %v", err)
}
err = os.RemoveAll(tempDir)
if err != nil {
log.Fatal("failed to remove temp file:", tempDir, err)
}
os.Exit(r)
}
func setupTestLoggers() error {
err := SetGlobalLogConfig(testConfigEnabled)
if err != nil {
return err
}
err = SetupGlobalLogger()
if err != nil {
return err
}
return SetupSubLoggers(testConfigEnabled.SubLoggers)
}
func SetupDisabled() error {
err := SetGlobalLogConfig(testConfigDisabled)
if err != nil {
return err
}
err = SetupGlobalLogger()
if err != nil {
return err
}
return SetupSubLoggers(testConfigDisabled.SubLoggers)
}
func TestSetGlobalLogConfig(t *testing.T) {
t.Parallel()
err := SetGlobalLogConfig(nil)
if !errors.Is(err, errConfigNil) {
t.Fatalf("received: '%v' but expected: '%v'", err, errConfigNil)
}
err = SetGlobalLogConfig(testConfigEnabled)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
}
func TestSetLogPath(t *testing.T) {
t.Parallel()
err := SetLogPath("")
if !errors.Is(err, errLogPathIsEmpty) {
t.Fatalf("received: '%v' but expected: '%v'", err, errLogPathIsEmpty)
}
err = SetLogPath(tempDir)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
if path := GetLogPath(); path != tempDir {
t.Fatalf("received: '%v' but expected: '%v'", path, tempDir)
}
}
func TestSetFileLoggingState(t *testing.T) {
t.Parallel()
SetFileLoggingState(true)
if !getFileLoggingState() {
t.Fatal("unexpected value")
}
SetFileLoggingState(false)
if getFileLoggingState() {
t.Fatal("unexpected value")
}
}
func getFileLoggingState() bool {
mu.RLock()
defer mu.RUnlock()
return fileLoggingConfiguredCorrectly
}
func TestAddWriter(t *testing.T) {
t.Parallel()
_, err := multiWriter(io.Discard, io.Discard)
if !errors.Is(err, errWriterAlreadyLoaded) {
t.Fatalf("received: '%v' but expected: '%v'", err, errWriterAlreadyLoaded)
}
mw, err := multiWriter()
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
err = mw.add(io.Discard)
if err != nil {
t.Fatal(err)
}
err = mw.add(os.Stdin)
if err != nil {
t.Fatal(err)
}
err = mw.add(os.Stdout)
if err != nil {
t.Fatal(err)
}
err = mw.add(nil)
if !errors.Is(err, errWriterIsNil) {
t.Fatalf("received: '%v' but expected: '%v'", err, errWriterIsNil)
}
if total := len(mw.writers); total != 3 {
t.Errorf("expected m.Writers to be 3 %v", total)
}
}
type WriteShorter struct{}
func (w *WriteShorter) Write(p []byte) (int, error) {
return 1, nil
}
type WriteError struct{}
func (w *WriteError) Write(p []byte) (int, error) {
return 0, errWriteError
}
var errWriteError = errors.New("write error")
func TestMultiWriterWrite(t *testing.T) {
t.Parallel()
fields := &logFields{}
buff := newTestBuffer()
var err error
fields.output, err = multiWriter(io.Discard, buff)
if err != nil {
t.Fatal(err)
}
payload := "woooooooooooooooooooooooooooooooooooow"
fields.output.StageLogEvent(func() string { return payload }, "", "", "", "", false, false)
if err != nil {
t.Fatal(err)
}
<-buff.Finished
if contents := buff.Read(); !strings.Contains(contents, payload) {
t.Errorf("received: '%v' but expected: '%v'", contents, payload)
}
fields.output, err = multiWriter(&WriteShorter{}, io.Discard)
if err != nil {
t.Fatal(err)
}
fields.output.StageLogEvent(func() string { return payload }, "", "", "", "", false, false) // Will display error: Logger write error: *log.WriteShorter short write
fields.output, err = multiWriter(&WriteError{}, io.Discard)
if err != nil {
t.Fatal(err)
}
fields.output.StageLogEvent(func() string { return payload }, "", "", "", "", false, false) // Will display error: Logger write error: *log.WriteError write error
}
func TestGetWriters(t *testing.T) {
t.Parallel()
err := getWritersProtected(nil)
if !errors.Is(err, errSubloggerConfigIsNil) {
t.Fatalf("received: '%v' but expected: '%v'", err, errSubloggerConfigIsNil)
}
outputWriters := "stDout|stderr|filE"
mu.Lock()
fileLoggingConfiguredCorrectly = false
_, err = getWriters(&SubLoggerConfig{Output: outputWriters})
if !errors.Is(err, errFileLoggingNotConfiguredCorrectly) {
t.Fatalf("received: '%v' but expected: '%v'", err, errFileLoggingNotConfiguredCorrectly)
}
fileLoggingConfiguredCorrectly = true
_, err = getWriters(&SubLoggerConfig{Output: outputWriters})
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
mu.Unlock()
outputWriters = "stdout|stderr|noobs"
err = getWritersProtected(&SubLoggerConfig{Output: outputWriters})
if !errors.Is(err, errUnhandledOutputWriter) {
t.Fatalf("received: '%v' but expected: '%v'", err, errUnhandledOutputWriter)
}
}
func getWritersProtected(s *SubLoggerConfig) error {
mu.RLock()
defer mu.RUnlock()
_, err := getWriters(s)
return err
}
func TestGenDefaultSettings(t *testing.T) {
t.Parallel()
if cfg := GenDefaultSettings(); cfg.Enabled == nil {
t.Fatal("unexpected items in struct")
}
}
func TestLevel(t *testing.T) {
t.Parallel()
_, err := Level("LOG")
if err != nil {
t.Errorf("Failed to get log %s levels skipping", err)
}
_, err = Level("totallyinvalidlogger")
if err == nil {
t.Error("Expected error on invalid logger")
}
}
func TestSetLevel(t *testing.T) {
t.Parallel()
newLevel, err := SetLevel("LOG", "ERROR")
if err != nil {
t.Skipf("Failed to get log %s levels skipping", err)
}
if newLevel.Info || newLevel.Debug || newLevel.Warn {
t.Error("failed to set level correctly")
}
if !newLevel.Error {
t.Error("failed to set level correctly")
}
_, err = SetLevel("abc12345556665", "ERROR")
if err == nil {
t.Error("SetLevel() Should return error on invalid logger")
}
}
func TestConfigureSubLogger(t *testing.T) {
t.Parallel()
mw := &multiWriterHolder{writers: []io.Writer{newTestBuffer()}}
mu.Lock()
defer mu.Unlock()
err := configureSubLogger("LOG", "INFO", mw)
if err != nil {
t.Skipf("configureSubLogger() returned unexpected error %v", err)
}
if (Global.levels != Levels{Info: true}) {
t.Error("configureSubLogger() incorrectly configure subLogger")
}
if Global.name != "LOG" {
t.Error("configureSubLogger() Failed to uppercase name")
}
}
func TestSplitLevel(t *testing.T) {
t.Parallel()
levelsInfoDebug := splitLevel("INFO|DEBUG")
expected := Levels{
Info: true,
Debug: true,
Warn: false,
Error: false,
}
if levelsInfoDebug != expected {
t.Errorf("splitLevel() returned invalid data expected: %+v got: %+v", expected, levelsInfoDebug)
}
}
func TestStageNewLogEvent(t *testing.T) {
t.Parallel()
w := newTestBuffer()
mw := &multiWriterHolder{writers: []io.Writer{w}}
fields := &logFields{output: mw}
fields.output.StageLogEvent(func() string { return "out" }, "header", "SUBLOGGER", " space ", "", false, false)
<-w.Finished
if contents := w.Read(); contents != "header space space out\n" {
t.Errorf("received: '%v' but expected: '%v'", contents, "header space space out\n")
}
}
func TestInfo(t *testing.T) {
t.Parallel()
w := newTestBuffer()
mw := &multiWriterHolder{writers: []io.Writer{w}}
sl, err := NewSubLogger("TESTYMCTESTALOTINFO")
if err != nil {
t.Fatal(err)
}
sl.setLevelsProtected(splitLevel("INFO"))
err = sl.setOutputProtected(mw)
if err != nil {
t.Fatal(err)
}
Info(sl, "Hello")
<-w.Finished
contents := w.Read()
if !strings.Contains(contents, "Hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "Hello")
}
Infof(sl, "%s", "hello")
<-w.Finished
contents = w.Read()
if !strings.Contains(contents, "hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "hello")
}
Infoln(sl, "hello", "hello")
<-w.Finished
contents = w.Read()
if !strings.Contains(contents, "hello hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "hello hello")
}
_, err = SetLevel("TESTYMCTESTALOTINFO", "")
if err != nil {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
// Should not write to buffer at all as it should return if functionality
// is not enabled.
Info(sl, "HelloHello")
contents = w.Read()
if contents != "" {
t.Errorf("received: '%v' but expected: '%v'", contents, "")
}
Infoln(sl, "HelloHello")
contents = w.Read()
if contents != "" {
t.Errorf("received: '%v' but expected: '%v'", contents, "")
}
}
func TestDebug(t *testing.T) {
t.Parallel()
w := newTestBuffer()
mw := &multiWriterHolder{writers: []io.Writer{w}}
sl, err := NewSubLogger("TESTYMCTESTALOTDEBUG")
if err != nil {
t.Fatal(err)
}
sl.setLevelsProtected(splitLevel("DEBUG"))
err = sl.setOutputProtected(mw)
if err != nil {
t.Fatal(err)
}
Debug(sl, "Hello")
<-w.Finished
contents := w.Read()
if !strings.Contains(contents, "Hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "Hello")
}
Debugf(sl, "%s", "hello")
<-w.Finished
contents = w.Read()
if !strings.Contains(contents, "hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "hello")
}
Debugln(sl, "hello", "hello")
<-w.Finished
contents = w.Read()
if !strings.Contains(contents, "hello hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "hello hello")
}
_, err = SetLevel("TESTYMCTESTALOTDEBUG", "")
if err != nil {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
// Should not write to buffer at all as it should return if functionality
// is not enabled.
Debug(sl, "HelloHello")
contents = w.Read()
if contents != "" {
t.Errorf("received: '%v' but expected: '%v'", contents, "")
}
Debugln(sl, "HelloHello")
contents = w.Read()
if contents != "" {
t.Errorf("received: '%v' but expected: '%v'", contents, "")
}
}
func TestWarn(t *testing.T) {
t.Parallel()
w := newTestBuffer()
mw := &multiWriterHolder{writers: []io.Writer{w}}
sl, err := NewSubLogger("TESTYMCTESTALOTWARN")
if err != nil {
t.Fatal(err)
}
sl.setLevelsProtected(splitLevel("WARN"))
err = sl.setOutputProtected(mw)
if err != nil {
t.Fatal(err)
}
Warn(sl, "Hello")
<-w.Finished
contents := w.Read()
if !strings.Contains(contents, "Hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "Hello")
}
Warnf(sl, "%s", "hello")
<-w.Finished
contents = w.Read()
if !strings.Contains(contents, "hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "hello")
}
Warnln(sl, "hello", "hello")
<-w.Finished
contents = w.Read()
if !strings.Contains(contents, "hello hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "hello hello")
}
_, err = SetLevel("TESTYMCTESTALOTWARN", "")
if err != nil {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
// Should not write to buffer at all as it shhould return if functionality
// is not enabled.
Warn(sl, "HelloHello")
contents = w.Read()
if contents != "" {
t.Errorf("received: '%v' but expected: '%v'", contents, "")
}
Warnln(sl, "HelloHello")
contents = w.Read()
if contents != "" {
t.Errorf("received: '%v' but expected: '%v'", contents, "")
}
}
func TestError(t *testing.T) {
t.Parallel()
w := newTestBuffer()
mw := &multiWriterHolder{writers: []io.Writer{w}}
sl, err := NewSubLogger("TESTYMCTESTALOTERROR")
if err != nil {
t.Fatal(err)
}
sl.setLevelsProtected(splitLevel("ERROR"))
err = sl.setOutputProtected(nil)
if !errors.Is(err, errMultiWriterHolderIsNil) {
t.Errorf("received: '%v' but expected: '%v'", err, errMultiWriterHolderIsNil)
}
err = sl.setOutputProtected(mw)
if err != nil {
t.Fatal(err)
}
Error(sl, "Hello")
<-w.Finished
contents := w.Read()
if !strings.Contains(contents, "Hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "Hello")
}
Errorf(sl, "%s", "hello")
<-w.Finished
contents = w.Read()
if !strings.Contains(contents, "hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "hello")
}
Errorln(sl, "hello", "hello")
<-w.Finished
contents = w.Read()
if !strings.Contains(contents, "hello hello") {
t.Errorf("received: '%v' but expected: '%v'", contents, "hello hello")
}
_, err = SetLevel("TESTYMCTESTALOTERROR", "")
if err != nil {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
// Should not write to buffer at all as it shhould return if functionality
// is not enabled.
Error(sl, "HelloHello")
contents = w.Read()
if contents != "" {
t.Errorf("received: '%v' but expected: '%v'", contents, "")
}
Errorln(sl, "HelloHello")
contents = w.Read()
if contents != "" {
t.Errorf("received: '%v' but expected: '%v'", contents, "")
}
}
func (sl *SubLogger) setLevelsProtected(newLevels Levels) {
mu.Lock()
sl.setLevels(newLevels)
mu.Unlock()
}
func (sl *SubLogger) setOutputProtected(o *multiWriterHolder) error {
mu.Lock()
defer mu.Unlock()
return sl.setOutput(o)
}
func TestSubLoggerName(t *testing.T) {
t.Parallel()
w := newTestBuffer()
mw := &multiWriterHolder{writers: []io.Writer{w}}
mw.StageLogEvent(func() string { return "out" }, "header", "SUBLOGGER", "||", time.RFC3339, true, false)
<-w.Finished
contents := w.Read()
if !strings.Contains(contents, "SUBLOGGER") {
t.Error("Expected SUBLOGGER in output")
}
mw.StageLogEvent(func() string { return "out" }, "header", "SUBLOGGER", "||", time.RFC3339, false, false)
<-w.Finished
contents = w.Read()
if strings.Contains(contents, "SUBLOGGER") {
t.Error("Unexpected SUBLOGGER in output")
}
}
func TestNewSubLogger(t *testing.T) {
t.Parallel()
_, err := NewSubLogger("")
if !errors.Is(err, errEmptyLoggerName) {
t.Fatalf("received: %v but expected: %v", err, errEmptyLoggerName)
}
sl, err := NewSubLogger("TESTERINOS")
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
Debug(sl, "testerinos")
_, err = NewSubLogger("TESTERINOS")
if !errors.Is(err, ErrSubLoggerAlreadyRegistered) {
t.Fatalf("received: %v but expected: %v", err, ErrSubLoggerAlreadyRegistered)
}
}
func TestRotateWrite(t *testing.T) {
t.Parallel()
empty := Rotate{Rotate: convert.BoolPtr(true), FileName: "test.txt"}
payload := make([]byte, defaultMaxSize*megabyte+1)
_, err := empty.Write(payload)
if !errors.Is(err, errExceedsMaxFileSize) {
t.Fatalf("received: %v but expected: %v", err, errExceedsMaxFileSize)
}
empty.MaxSize = 1
payload = make([]byte, 1*megabyte+1)
_, err = empty.Write(payload)
if !errors.Is(err, errExceedsMaxFileSize) {
t.Fatalf("received: %v but expected: %v", err, errExceedsMaxFileSize)
}
// test write
payload = make([]byte, 1*megabyte-1)
_, err = empty.Write(payload)
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
// test rotate
payload = make([]byte, 1*megabyte)
_, err = empty.Write(payload)
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
err = empty.Close()
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
}
func TestOpenNew(t *testing.T) {
t.Parallel()
empty := Rotate{}
err := empty.openNew()
if !errors.Is(err, errFileNameIsEmpty) {
t.Fatalf("received: %v but expected: %v", err, errFileNameIsEmpty)
}
empty.FileName = "wow.txt"
err = empty.openNew()
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
err = empty.Close()
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
}
type testBuffer struct {
value string
Finished chan struct{}
}
func (tb *testBuffer) Write(p []byte) (int, error) {
tb.value = string(p)
tb.Finished <- struct{}{}
return len(p), nil
}
func (tb *testBuffer) Read() string {
defer func() { tb.value = "" }()
return tb.value
}
func newTestBuffer() *testBuffer {
return &testBuffer{Finished: make(chan struct{}, 1)}
}
// 2140294 770.0 ns/op 0 B/op 0 allocs/op
func BenchmarkNewLogEvent(b *testing.B) {
mw := &multiWriterHolder{writers: []io.Writer{io.Discard}}
for i := 0; i < b.N; i++ {
mw.StageLogEvent(func() string { return "somedata" }, "header", "sublog", "||", time.RFC3339, true, false)
}
}
// BenchmarkInfo-8 1000000 64971 ns/op 47 B/op 1 allocs/op
func BenchmarkInfo(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
Info(Global, "Hello this is an info benchmark")
}
}
// BenchmarkInfoDisabled-8 47124242 24.16 ns/op 0 B/op 0 allocs/op
func BenchmarkInfoDisabled(b *testing.B) {
if err := SetupDisabled(); err != nil {
b.Fatal(err)
}
b.ResetTimer()
for n := 0; n < b.N; n++ {
Info(Global, "Hello this is an info benchmark")
}
}
// BenchmarkInfof-8 1000000 72641 ns/op 178 B/op 4 allocs/op
func BenchmarkInfof(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
Infof(Global, "Hello this is an infof benchmark %v %v %v\n", n, 1, 2)
}
}
// BenchmarkInfoln-8 1000000 68152 ns/op 121 B/op 3 allocs/op
func BenchmarkInfoln(b *testing.B) {
b.ResetTimer()
for n := 0; n < b.N; n++ {
Infoln(Global, "Hello this is an infoln benchmark")
}
}