Files
gocryptotrader/exchanges/bybit/bybit_websocket_requests_test.go
Ryan O'Hara-Reid 3f8d799613 bybit: Add websocket trading functionality across all assets (#1672)
* fix whoops

* const trafficCheckInterval; rm testmain

* y

* fix lint

* bump time check window

* stream: fix intermittant test failures while testing routines and remove code that is not needed.

* spells

* cant do what I did

* protect race due to routine.

* update testURL

* use mock websocket connection instead of test URL's

* linter: fix

* remove url because its throwing errors on CI builds

* connections drop all the time, don't need to worry about not being able to echo back ws data as it can be easily reviewed _test file side.

* remove another superfluous url thats not really set up for this

* spawn overwatch routine when there is no errors, inline checker instead of waiting for a time period, add sleep inline with echo handler as this is really quick and wanted to ensure that latency is handing correctly

* linter: fixerino uperino

* fix ID bug, why I do this, I don't know.

* glorious: panix

* linter: things

* whoops

* dont need to make consecutive Unix() calls

* websocket: fix potential panic on error and no responses and adding waitForResponses

* bybit: enable multiconnection handling across websocket endpoints

* rm debug lines

* bybit: Add websocket trading functionality across all assets

* rm json parser and handle in json package instead

* in favour of json package unmarshalling

* Add bool ConnectionDoesNotRequireSubscriptions so that we don't need to handle dummy sub

* handle pong response

* spelling

* linter: fix

* fix processing issues with tickers

* fix processing issues with tickers

* linter: fix

* linter: fix again

* * change field name OutboundRequestSignature to WrapperDefinedConnectionSignature for agnostic inbound and outbound connections.
* change method name GetOutboundConnection to GetConnection for agnostic inbound and outbound connections.
* drop outbound field map for improved performance just using a range and field check (less complex as well)
* change field name connections to connectionToWrapper for better clarity

* spells and magic and wands

* merge: fixup

* linter: fix

* spelling: fix

* glorious: nits

* comparable check for signature

* mv err var

* rm comment as it does not

* update time fields for orderbook latency

* fix time conversion

* Add func MatchReturnResponses

* glorious: nits and stuff

* lint: fix

* attempt to fix race

* linter: fix

* fix tests

* types/time: strict usage of time type for usage with unix timestamps

* fix tests etc

* Allow match back with order details

* Add time in force values for different order types + extra return information on websocket trading

* glorious: nits

* gk: nits; engine log cleanup

* gk: nits; OCD

* gk: nits; move function change file names

* gk: nits; 🚀

* gk: nits; convert variadic function and message inspection to interface and include a specific function for that handling so as to not need nil on every call

* gk: nits; continued

* gk: engine nits; rm loaded exchange

* gk: nits; drop WebsocketLoginResponse

* stream: Add match method EnsureMatchWithData

* gk: nits; rn Inspect to IsFinal

* gk: nits; rn to MessageFilter

* linter: fix

* gateio: update rate limit definitions (cherry-pick)

* Add test and missing

* Shared REST rate limit definitions with Websocket service, set lookup item to nil for systems that do not require rate limiting; add glorious nit

* integrate rate limits for websocket trading spot

* bybit: split public and private processing to dedicated handler add supporting function and tests

* use correct handler for private inbound connection

* bybit/websocket: allow a shared ID between outbound payloads for inbound matching

* conform to match upstream changes

* standardise names to upstream style

* fix wrapper standards test when sending a auth request through a websocket connection

* whoops

* Update exchanges/gateio/gateio_types.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* glorious: nits

* linter: fix

* linter: overload

* whoops

* spelling fixes on recent merge

* glorious: nits

* linter: fix?

* glorious: nits

* gk: assert errors touched

* gk: unexport derive functions

* gk: nitssssssss

* fix test

* gk: nitters v1

* gk: http status

* gk/nits: Add getAssetFromFuturesPair

* gk: nits single response when submitting

* gk: new pair with delimiter in tests

* gk: param update slice to slice of pointers

* gk: add asset type in params, includes t.Context() for tests

* linter: fix

* linter: fix

* fix merge whoopsie

* glorious: nits

* gk: nit

* linter: fix

* glorious: nits

* linter/misc: fix and remove meows

* linter: fix

* misc/linter: fix

* change function names

* okx: update requestID gen func without func wrapping

* RM: functions not needed

* Update docs/ADD_NEW_EXCHANGE.md

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* gk: nitsssssss

* linter: fix

* Update exchanges/bybit/bybit_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* Update exchanges/bybit/bybit_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* gk: nit words

* cranktakular: nits

* websocket: skip connections with subscriptions not required during channel flush

* websocket: simplify error handling in FlushChannels using if short

* linter: fix

* cranktakular: nits and expand coverage

* linter: fix?

* misc fix

* cranktakular: missing nit which I thumbed up but did not do. Sillllllly billlyyyy nilllyyy

* fix comments

* bybit: fix merge regression on websocket message filter

* cranktakular: nits

* bybit: Add global rate limits for websocket

* ai: nits

* linter: fix

* cranktakular: purge DCP ref/handling and add another TODO

* Update exchanges/bybit/bybit_websocket.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* glorious: nits

* fix test

* fix alignment issue and rm println

* Update exchanges/bybit/bybit_websocket.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update exchanges/bybit/bybit_websocket.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* glorious: fix

* Update exchanges/bybit/bybit_websocket.go

Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io>

* bybit: use connection method for segregated match on multi-connection

* cleanup after master merge

* fix test and config whoops

* cranktakular: nits

* exchange: add missing tests for base method websocket order funcs

* cranktakular: nits and refresh + tests

* cranktakular: pedantic nits

* linter: fixes

* t.Parallel tests

* glorious nit

* Update exchange/websocket/connection.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* gk: nits

* boss king: nits

* canktakular: nits

* Update exchanges/bybit/bybit_websocket.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* Update exchanges/bybit/bybit_websocket_requests.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* Update exchanges/bybit/bybit_websocket_requests.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* Update exchanges/bybit/bybit_websocket_requests.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* Update exchanges/bybit/bybit_websocket_requests.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* gk: nits

* linter: fix

* Update exchanges/bybit/bybit.go

Co-authored-by: Samuael A. <39623015+samuael@users.noreply.github.com>

* Update exchanges/bybit/bybit.go

Co-authored-by: Samuael A. <39623015+samuael@users.noreply.github.com>

* bossking: nits

* gk: much nicer design

* gk: revised naming for consideration

* gk: nits

* gk: nits restrict in configtest.json and not worry about many pairs enabled

* rm log

* linter: fix

* codex: nit

* cranktakular: nits

* Update exchanges/bybit/bybit_websocket_requests.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update exchanges/bybit/bybit_websocket_requests.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* Update exchanges/bybit/bybit_wrapper.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* glorious: nits!

* thrasher: nits

---------

Co-authored-by: shazbert <ryan.oharareid@thrasher.io>
Co-authored-by: Scott <gloriousCode@users.noreply.github.com>
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>
Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io>
Co-authored-by: Samuael A. <39623015+samuael@users.noreply.github.com>
2025-09-17 13:45:58 +10:00

211 lines
6.4 KiB
Go

package bybit
import (
"path/filepath"
"testing"
"github.com/stretchr/testify/require"
"github.com/thrasher-corp/gocryptotrader/config"
"github.com/thrasher-corp/gocryptotrader/currency"
"github.com/thrasher-corp/gocryptotrader/exchange/order/limits"
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
"github.com/thrasher-corp/gocryptotrader/exchanges/order"
"github.com/thrasher-corp/gocryptotrader/exchanges/sharedtestvalues"
testutils "github.com/thrasher-corp/gocryptotrader/internal/testing/utils"
)
func TestWSCreateOrder(t *testing.T) {
t.Parallel()
arg := &PlaceOrderRequest{}
_, err := e.WSCreateOrder(t.Context(), arg)
require.ErrorIs(t, err, errCategoryNotSet)
arg.Category = cSpot
_, err = e.WSCreateOrder(t.Context(), arg)
require.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)
arg.Symbol = currency.NewBTCUSDT()
_, err = e.WSCreateOrder(t.Context(), arg)
require.ErrorIs(t, err, order.ErrSideIsInvalid)
arg.Side = "Buy"
_, err = e.WSCreateOrder(t.Context(), arg)
require.ErrorIs(t, err, order.ErrTypeIsInvalid)
arg.OrderType = "Limit"
_, err = e.WSCreateOrder(t.Context(), arg)
require.ErrorIs(t, err, limits.ErrAmountBelowMin)
arg.OrderQuantity = 0.0001
arg.TriggerDirection = 69
_, err = e.WSCreateOrder(t.Context(), arg)
require.ErrorIs(t, err, errInvalidTriggerDirection)
arg.TriggerDirection = 0
arg.OrderFilter = "dodgy"
_, err = e.WSCreateOrder(t.Context(), arg)
require.ErrorIs(t, err, errInvalidOrderFilter)
arg.OrderFilter = "Order"
arg.TriggerPriceType = "dodgy"
_, err = e.WSCreateOrder(t.Context(), arg)
require.ErrorIs(t, err, errInvalidTriggerPriceType)
sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
got, err := e.WSCreateOrder(t.Context(), &PlaceOrderRequest{
Category: cSpot,
Symbol: currency.NewBTCUSDT(),
Side: "Buy",
OrderType: "Limit",
Price: 55000,
OrderQuantity: -0.0001, // Replace with a valid quantity
TimeInForce: "FOK", // Replace with GTC to submit a valid order if outside current trading price range.
})
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWebsocketSubmitOrder(t *testing.T) {
t.Parallel()
// Test quote amount needs to be used due to protocol trade requirements
s := &order.Submit{
Exchange: e.Name,
Pair: currency.NewBTCUSDT(),
AssetType: asset.Spot,
Side: order.Buy,
Type: order.Market,
Amount: 0.0001,
}
_, err := e.WebsocketSubmitOrder(t.Context(), s)
require.ErrorIs(t, err, order.ErrAmountMustBeSet)
sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
s.Type = order.Limit
s.Price = 55000
s.Amount = -0.0001 // Replace with a valid quantity
got, err := e.WebsocketSubmitOrder(t.Context(), s)
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWSAmendOrder(t *testing.T) {
t.Parallel()
arg := &AmendOrderRequest{}
_, err := e.WSAmendOrder(t.Context(), arg)
require.ErrorIs(t, err, errCategoryNotSet)
arg.Category = cSpot
_, err = e.WSAmendOrder(t.Context(), arg)
require.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)
arg.Symbol = currency.NewBTCUSDT()
_, err = e.WSAmendOrder(t.Context(), arg)
require.ErrorIs(t, err, errEitherOrderIDOROrderLinkIDRequired)
sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
arg.OrderID = "1793353687809485568" // Replace with a valid order ID
arg.OrderQuantity = 0.0002
got, err := e.WSAmendOrder(t.Context(), arg)
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWebsocketModifyOrder(t *testing.T) {
t.Parallel()
mod := &order.Modify{
Pair: currency.NewBTCUSDT(),
AssetType: asset.Spot,
Amount: 0.0001,
OrderID: "1793388409122024192", // Replace with a valid order ID
}
sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
got, err := e.WebsocketModifyOrder(t.Context(), mod)
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWSCancelOrder(t *testing.T) {
t.Parallel()
arg := &CancelOrderRequest{}
_, err := e.WSCancelOrder(t.Context(), arg)
require.ErrorIs(t, err, errCategoryNotSet)
arg.Category = cSpot
_, err = e.WSCancelOrder(t.Context(), arg)
require.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)
arg.Symbol = currency.NewBTCUSDT()
_, err = e.WSCancelOrder(t.Context(), arg)
require.ErrorIs(t, err, errEitherOrderIDOROrderLinkIDRequired)
arg.OrderID = "1793353687809485568" // Replace with a valid order ID
arg.OrderFilter = "dodgy"
_, err = e.WSCancelOrder(t.Context(), arg)
require.ErrorIs(t, err, errInvalidOrderFilter)
arg.Category = cLinear
_, err = e.WSCancelOrder(t.Context(), arg)
require.ErrorIs(t, err, errInvalidCategory)
arg.Category = cSpot
arg.OrderFilter = "Order"
sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
got, err := e.WSCancelOrder(t.Context(), arg)
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWebsocketCancelOrder(t *testing.T) {
t.Parallel()
cancel := &order.Cancel{
OrderID: "1793388409122024192", // Replace with a valid order ID
Pair: currency.NewBTCUSDT(),
AssetType: asset.Spot,
}
sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
err := e.WebsocketCancelOrder(t.Context(), cancel)
require.NoError(t, err)
}
// getWebsocketInstance returns a websocket instance copy for live bi-directional testing
func getWebsocketInstance(t *testing.T) *Exchange {
t.Helper()
cfg := &config.Config{}
root, err := testutils.RootPathFromCWD()
require.NoError(t, err)
err = cfg.LoadConfig(filepath.Join(root, "testdata", "configtest.json"), true)
require.NoError(t, err)
pairs := &e.CurrencyPairs
e := new(Exchange) //nolint:govet // Intentional shadow
e.SetDefaults()
bConf, err := cfg.GetExchangeConfig("Bybit")
require.NoError(t, err)
bConf.API.AuthenticatedSupport = true
bConf.API.AuthenticatedWebsocketSupport = true
bConf.API.Credentials.Key = apiKey
bConf.API.Credentials.Secret = apiSecret
require.NoError(t, e.Setup(bConf), "Setup must not error")
e.CurrencyPairs.Load(pairs)
require.NoError(t, e.Websocket.Connect())
return e
}