Files
gocryptotrader/exchanges/gateio/gateio_websocket_request_spot_test.go
Ryan O'Hara-Reid cad7586e98 exchange/websocket, gateio: Rename/export package again, add websocket request functions for futures trading (#1603)
* gateio: Add multi asset websocket support WIP.

* meow

* Add tests and shenanigans

* integrate flushing and for enabling/disabling pairs from rpc shenanigans

* some changes

* linter: fixes strikes again.

* Change name ConnectionAssociation -> ConnectionCandidate for better clarity on purpose. Change connections map to point to candidate to track subscriptions for future dynamic connections holder and drop struct ConnectionDetails.

* Add subscription tests (state functional)

* glorious:nits + proxy handling

* Spelling

* linter: fixerino

* instead of nil, dont do nil.

* clean up nils

* cya nils

* don't need to set URL or check if its running

* stream match update

* update tests

* linter: fix

* glorious: nits + handle context cancellations

* stop ping handler routine leak

* * Fix bug where reader routine on error that is not a disconnection error but websocket frame error or anything really makes the reader routine return and then connection never cycles and the buffer gets filled.
* Handle reconnection via an errors.Is check which is simpler and in that scope allow for quick disconnect reconnect without waiting for connection cycle.
* Dial now uses code from DialContext but just calls context.Background()
* Don't allow reader to return on parse binary response error. Just output error and return a non nil response

* Allow rollback on connect on any error across all connections

* fix shadow jutsu

* glorious/gk: nitters - adds in ws mock server

* linter: fix

* fix deadlock on connection as the previous channel had no reader and would hang connection reader for eternity.

* glorious: whooops

* gk: nits

* Leak issue and edge case

* Websocket: Add SendMessageReturnResponses

* whooooooopsie

* gk: nitssssss

* Update exchanges/stream/stream_match.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* Update exchanges/stream/stream_match_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* linter: appease the linter gods

* gk: nits

* gk: drain brain

* started

* more changes before merge match pr

* gateio: still building out

* gateio: finish spot

* fix up tests in gateio

* Add tests for stream package

* rm unused field

* glorious: nits

* rn files, specifically set function names to asset and offload routing to websocket type.

* linter: fix

* Add futures websocket request support

* gateio: integrate with IBOTExchange (cherry pick my nose)

* linter: fix

* glorious: nits

* add counter and update gateio

* fix collision issue

* Update exchanges/stream/websocket.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* glorious: nits

* add tests

* linter: fix

* After merge

* Add error connection info

* upgrade to upstream merge

* Fix edge case where it does not reconnect made by an already closed connection

* stream coverage

* glorious: nits

* glorious: nits removed asset error handling in stream package

* linter: fix

* rm block

* Add basic readme

* fix asset enabled flush cycle for multi connection

* spella: fix

* linter: fix

* Add glorious suggestions, fix some race thing

* reinstate name before any routine gets spawned

* stop on error in mock tests

* glorious: nits

* Set correct price

* glorious: nits found in CI build

* Add test for drain, bumped wait times as there seems to be something happening on macos CI builds, used context.WithTimeout because its instant.

* mutex across shutdown and connect for protection

* lint: fix

* test time withoffset, reinstate stop

* fix whoops

* const trafficCheckInterval; rm testmain

* y

* fix lint

* bump time check window

* stream: fix intermittant test failures while testing routines and remove code that is not needed.

* spells

* cant do what I did

* protect race due to routine.

* update testURL

* use mock websocket connection instead of test URL's

* linter: fix

* remove url because its throwing errors on CI builds

* connections drop all the time, don't need to worry about not being able to echo back ws data as it can be easily reviewed _test file side.

* remove another superfluous url thats not really set up for this

* spawn overwatch routine when there is no errors, inline checker instead of waiting for a time period, add sleep inline with echo handler as this is really quick and wanted to ensure that latency is handing correctly

* linter: fixerino uperino

* fix ID bug, why I do this, I don't know.

* glorious: panix

* linter: things

* whoops

* dont need to make consecutive Unix() calls

* websocket: fix potential panic on error and no responses and adding waitForResponses

* rm json parser and handle in json package instead

* in favour of json package unmarshalling

* linter: fix

* linter: fix again

* * change field name OutboundRequestSignature to WrapperDefinedConnectionSignature for agnostic inbound and outbound connections.
* change method name GetOutboundConnection to GetConnection for agnostic inbound and outbound connections.
* drop outbound field map for improved performance just using a range and field check (less complex as well)
* change field name connections to connectionToWrapper for better clarity

* spells and magic and wands

* glorious: nits

* comparable check for signature

* mv err var

* glorious: nits and stuff

* attempt to fix race

* glorious: nits

* gk: nits; engine log cleanup

* gk: nits; OCD

* gk: nits; move function change file names

* gk: nits; 🚀

* gk: nits; convert variadic function and message inspection to interface and include a specific function for that handling so as to not need nil on every call

* gk: nits; continued

* gk: engine nits; rm loaded exchange

* gk: nits; drop WebsocketLoginResponse

* stream: Add match method EnsureMatchWithData

* gk: nits; rn Inspect to IsFinal

* gk: nits; rn to MessageFilter

* linter: fix

* gateio: update rate limit definitions (cherry-pick)

* Add test and missing

* Shared REST rate limit definitions with Websocket service, set lookup item to nil for systems that do not require rate limiting; add glorious nit

* integrate rate limits for websocket trading spot

* conform to match upstream changes

* standardise names to upstream style

* fix wrapper standards test when sending a auth request through a websocket connection

* whoops

* Update exchanges/gateio/gateio_types.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* glorious: nits

* linter: fix

* linter: overload

* whoops

* spelling fixes on recent merge

* glorious: nits

* linter: fix?

* glorious: nits

* gk: assert errors touched

* gk: unexport derive functions

* gk: nitssssssss

* fix test

* gk: nitters v1

* gk: http status

* gk/nits: Add getAssetFromFuturesPair

* gk: nits single response when submitting

* gk: new pair with delimiter in tests

* gk: param update slice to slice of pointers

* gk: add asset type in params, includes t.Context() for tests

* linter: fix

* linter: fix

* fix merge whoopsie

* glorious: nits

* gk: nit

* shift over to websocket package error

* internal/exchange/websocket -> exchange/websocket

* PEAK OCD!

* appease the OCD gods

* thrasher: nits

---------

Co-authored-by: shazbert <ryan.oharareid@thrasher.io>
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>
Co-authored-by: Scott <gloriousCode@users.noreply.github.com>
2025-04-11 16:47:33 +10:00

237 lines
8.4 KiB
Go

package gateio
import (
"strings"
"testing"
"github.com/stretchr/testify/require"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/currency"
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
"github.com/thrasher-corp/gocryptotrader/exchanges/order"
"github.com/thrasher-corp/gocryptotrader/exchanges/sharedtestvalues"
testexch "github.com/thrasher-corp/gocryptotrader/internal/testing/exchange"
)
func TestWebsocketLogin(t *testing.T) {
t.Parallel()
err := g.websocketLogin(t.Context(), nil, "")
require.ErrorIs(t, err, common.ErrNilPointer)
sharedtestvalues.SkipTestIfCredentialsUnset(t, g, canManipulateRealOrders)
g := newExchangeWithWebsocket(t, asset.Spot) //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
c, err := g.Websocket.GetConnection(asset.Spot)
require.NoError(t, err)
err = g.websocketLogin(t.Context(), c, "")
require.ErrorIs(t, err, errChannelEmpty)
err = g.websocketLogin(t.Context(), c, "spot.login")
require.NoError(t, err)
}
func TestWebsocketSpotSubmitOrder(t *testing.T) {
t.Parallel()
_, err := g.WebsocketSpotSubmitOrder(t.Context(), &CreateOrderRequest{})
require.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)
out := &CreateOrderRequest{CurrencyPair: currency.NewPair(currency.NewCode("GT"), currency.USDT).Format(currency.PairFormat{Uppercase: true, Delimiter: "_"})}
_, err = g.WebsocketSpotSubmitOrder(t.Context(), out)
require.ErrorIs(t, err, order.ErrSideIsInvalid)
out.Side = strings.ToLower(order.Sell.String())
_, err = g.WebsocketSpotSubmitOrder(t.Context(), out)
require.ErrorIs(t, err, errInvalidAmount)
out.Amount = 1
out.Type = "limit"
_, err = g.WebsocketSpotSubmitOrder(t.Context(), out)
require.ErrorIs(t, err, errInvalidPrice)
out.Price = 100
sharedtestvalues.SkipTestIfCredentialsUnset(t, g, canManipulateRealOrders)
g := newExchangeWithWebsocket(t, asset.Spot) //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
got, err := g.WebsocketSpotSubmitOrder(t.Context(), out)
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWebsocketSpotSubmitOrders(t *testing.T) {
t.Parallel()
_, err := g.WebsocketSpotSubmitOrders(t.Context())
require.ErrorIs(t, err, errOrdersEmpty)
out := &CreateOrderRequest{}
_, err = g.WebsocketSpotSubmitOrders(t.Context(), out)
require.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)
out.CurrencyPair = currency.NewBTCUSDT()
_, err = g.WebsocketSpotSubmitOrders(t.Context(), out)
require.ErrorIs(t, err, order.ErrSideIsInvalid)
out.Side = strings.ToLower(order.Buy.String())
_, err = g.WebsocketSpotSubmitOrders(t.Context(), out)
require.ErrorIs(t, err, errInvalidAmount)
out.Amount = 0.0003
out.Type = "limit"
_, err = g.WebsocketSpotSubmitOrders(t.Context(), out)
require.ErrorIs(t, err, errInvalidPrice)
out.Price = 20000
sharedtestvalues.SkipTestIfCredentialsUnset(t, g, canManipulateRealOrders)
g := newExchangeWithWebsocket(t, asset.Spot) //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
// test single order
got, err := g.WebsocketSpotSubmitOrders(t.Context(), out)
require.NoError(t, err)
require.NotEmpty(t, got)
// test batch orders
got, err = g.WebsocketSpotSubmitOrders(t.Context(), out, out)
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWebsocketSpotCancelOrder(t *testing.T) {
t.Parallel()
_, err := g.WebsocketSpotCancelOrder(t.Context(), "", currency.EMPTYPAIR, "")
require.ErrorIs(t, err, order.ErrOrderIDNotSet)
_, err = g.WebsocketSpotCancelOrder(t.Context(), "1337", currency.EMPTYPAIR, "")
require.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)
sharedtestvalues.SkipTestIfCredentialsUnset(t, g, canManipulateRealOrders)
g := newExchangeWithWebsocket(t, asset.Spot) //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
got, err := g.WebsocketSpotCancelOrder(t.Context(), "644913098758", BTCUSDT, "")
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWebsocketSpotCancelAllOrdersByIDs(t *testing.T) {
t.Parallel()
_, err := g.WebsocketSpotCancelAllOrdersByIDs(t.Context(), []WebsocketOrderBatchRequest{})
require.ErrorIs(t, err, errNoOrdersToCancel)
out := WebsocketOrderBatchRequest{}
_, err = g.WebsocketSpotCancelAllOrdersByIDs(t.Context(), []WebsocketOrderBatchRequest{out})
require.ErrorIs(t, err, order.ErrOrderIDNotSet)
out.OrderID = "1337"
_, err = g.WebsocketSpotCancelAllOrdersByIDs(t.Context(), []WebsocketOrderBatchRequest{out})
require.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)
out.Pair = BTCUSDT
sharedtestvalues.SkipTestIfCredentialsUnset(t, g, canManipulateRealOrders)
g := newExchangeWithWebsocket(t, asset.Spot) //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
out.OrderID = "644913101755"
got, err := g.WebsocketSpotCancelAllOrdersByIDs(t.Context(), []WebsocketOrderBatchRequest{out})
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWebsocketSpotCancelAllOrdersByPair(t *testing.T) {
t.Parallel()
_, err := g.WebsocketSpotCancelAllOrdersByPair(t.Context(), currency.NewPairWithDelimiter("LTC", "USDT", "_"), 0, "")
require.ErrorIs(t, err, order.ErrSideIsInvalid)
sharedtestvalues.SkipTestIfCredentialsUnset(t, g, canManipulateRealOrders)
g := newExchangeWithWebsocket(t, asset.Spot) //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
got, err := g.WebsocketSpotCancelAllOrdersByPair(t.Context(), currency.EMPTYPAIR, order.Buy, "")
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWebsocketSpotAmendOrder(t *testing.T) {
t.Parallel()
_, err := g.WebsocketSpotAmendOrder(t.Context(), nil)
require.ErrorIs(t, err, common.ErrNilPointer)
amend := &WebsocketAmendOrder{}
_, err = g.WebsocketSpotAmendOrder(t.Context(), amend)
require.ErrorIs(t, err, order.ErrOrderIDNotSet)
amend.OrderID = "1337"
_, err = g.WebsocketSpotAmendOrder(t.Context(), amend)
require.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)
amend.Pair = BTCUSDT
_, err = g.WebsocketSpotAmendOrder(t.Context(), amend)
require.ErrorIs(t, err, errInvalidAmount)
amend.Amount = "0.0004"
sharedtestvalues.SkipTestIfCredentialsUnset(t, g, canManipulateRealOrders)
g := newExchangeWithWebsocket(t, asset.Spot) //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
amend.OrderID = "645029162673"
got, err := g.WebsocketSpotAmendOrder(t.Context(), amend)
require.NoError(t, err)
require.NotEmpty(t, got)
}
func TestWebsocketSpotGetOrderStatus(t *testing.T) {
t.Parallel()
_, err := g.WebsocketSpotGetOrderStatus(t.Context(), "", currency.EMPTYPAIR, "")
require.ErrorIs(t, err, order.ErrOrderIDNotSet)
_, err = g.WebsocketSpotGetOrderStatus(t.Context(), "1337", currency.EMPTYPAIR, "")
require.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)
sharedtestvalues.SkipTestIfCredentialsUnset(t, g, canManipulateRealOrders)
testexch.UpdatePairsOnce(t, g)
g := newExchangeWithWebsocket(t, asset.Spot)
got, err := g.WebsocketSpotGetOrderStatus(t.Context(), "644999650452", BTCUSDT, "")
require.NoError(t, err)
require.NotEmpty(t, got)
}
// getWebsocketInstance returns a websocket instance copy for testing.
// This restricts the pairs to a single pair per asset type to reduce test time.
func newExchangeWithWebsocket(t *testing.T, a asset.Item) *Gateio {
t.Helper()
if apiKey == "" || apiSecret == "" {
t.Skip()
}
g := new(Gateio)
require.NoError(t, testexch.Setup(g), "Test instance Setup must not error")
testexch.UpdatePairsOnce(t, g)
g.API.AuthenticatedSupport = true
g.API.AuthenticatedWebsocketSupport = true
g.SetCredentials(apiKey, apiSecret, "", "", "", "")
g.Websocket.SetCanUseAuthenticatedEndpoints(true)
switch a {
case asset.Spot:
avail, err := g.GetAvailablePairs(a)
require.NoError(t, err)
if len(avail) > 1 { // reduce pairs to 1 to speed up tests
avail = avail[:1]
}
require.NoError(t, g.SetPairs(avail, a, true))
case asset.Futures:
avail, err := g.GetAvailablePairs(a)
require.NoError(t, err)
usdtPairs, err := avail.GetPairsByQuote(currency.USDT) // Get USDT margin pairs
require.NoError(t, err)
btcPairs, err := avail.GetPairsByQuote(currency.USD) // Get BTC margin pairs
require.NoError(t, err)
// below makes sure there is both a USDT and BTC pair available
// so that allows two connections to be made.
avail[0] = usdtPairs[0]
avail[1] = btcPairs[0]
avail = avail[:2]
require.NoError(t, g.SetPairs(avail, a, true))
default:
require.NoError(t, g.CurrencyPairs.SetAssetEnabled(a, false))
}
require.NoError(t, g.Websocket.Connect())
return g
}