Files
gocryptotrader/currency/manager.go
Gareth Kirwan 37b1121bbd BTSE: Fix duplicate pair errors on Million pairs (M_*) (#1401)
* BTSE: Fix duplicate error on Million pairs (M_*)

BTSE has listed Pitbull token with two symbols:
PIT-USD and M_PIT-USD for millons of PIT / USD.
The native token is not tradable, so we ignore them and
get a base of M_PIT because that's what later APIs will accept

* BTSE: Fix test errors on locked market

* Common: Improve AppendError and ExcludeError

This change switches from a stateful multiError to caring more about the
Unwrap() []error interface, the same as [go standard
lib](https://github.com/golang/go/blob/go1.21.4/src/errors/wrap.go#L54-L68)

Notably, if we implement Unwrap() []error and do NOT implement Is() then
we get free compatibility with the core functions.

The only distateful thing here is needing to deeply unwrap fmt.Errorf
errors, since they don't flatten. I can't see any way around that

* Pairs: Fix exchange config Pairs loading

When a pair string contained two punctuation runes, the first one is used,
and the configFormat is ignored.

This fix checks the list and corrects any with the wrong delimiter, or
errors if the format is inconsistent.

* BTSE: Fix all tickers retrieved by GetTicker

PR #764 introduced GetTickers, but it wasn't rolled out to BTSE.
This fix ensures that when one ticker is a locked market, the rest continue to
function. Particularly important if the locked market wasn't even
enabled anyway.

* Kucoin: Fix test config future pairs

* BTSE: Remove PIT tests; Token removed

BTSE have removed the PIT token pairs

All these changes stand, and this just removes the test

* ITBit: Fix fatal error on second run

This fix removes incorrect config pair delimiter, because it would be
re-inserted into config the first run, and then error the second time.

This delimiter doesn't match the config we have.
There's no implementation of fetching pairs, so what's in config files
now is all that matters

* Engine: Fix TestConfigAllJsonResponse

* Clarity of non-matching json improved
* Handling for fixing pair delimiters
2023-12-19 14:40:13 +11:00

555 lines
14 KiB
Go

package currency
import (
"encoding/json"
"errors"
"fmt"
"strings"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/common/convert"
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
)
var (
// ErrAssetAlreadyEnabled defines an error for the pairs management system
// that declares the asset is already enabled.
ErrAssetAlreadyEnabled = errors.New("asset already enabled")
// ErrPairAlreadyEnabled returns when enabling a pair that is already enabled
ErrPairAlreadyEnabled = errors.New("pair already enabled")
// ErrPairNotEnabled returns when looking for a pair that is not enabled
ErrPairNotEnabled = errors.New("pair not enabled")
// ErrPairNotFound is returned when a currency pair is not found
ErrPairNotFound = errors.New("pair not found")
// ErrAssetIsNil is an error when the asset has not been populated by the
// configuration
ErrAssetIsNil = errors.New("asset is nil")
// ErrPairNotContainedInAvailablePairs defines an error when a pair is not
// contained in the available pairs list and is not supported by the
// exchange for that asset type.
ErrPairNotContainedInAvailablePairs = errors.New("pair not contained in available pairs")
// ErrPairManagerNotInitialised is returned when a pairs manager is requested, but has not been setup
ErrPairManagerNotInitialised = errors.New("pair manager not initialised")
// ErrAssetNotFound is returned when an asset does not exist in the pairstore
ErrAssetNotFound = errors.New("asset type not found in pair store")
// ErrSymbolStringEmpty is an error when a symbol string is empty
ErrSymbolStringEmpty = errors.New("symbol string is empty")
errPairStoreIsNil = errors.New("pair store is nil")
errPairFormatIsNil = errors.New("pair format is nil")
errPairMatcherIsNil = errors.New("pair matcher is nil")
errPairConfigFormatNil = errors.New("pair config format is nil")
)
// GetAssetTypes returns a list of stored asset types
func (p *PairsManager) GetAssetTypes(enabled bool) asset.Items {
p.mutex.RLock()
defer p.mutex.RUnlock()
assetTypes := make(asset.Items, 0, len(p.Pairs))
for k, ps := range p.Pairs {
if enabled && (ps.AssetEnabled == nil || !*ps.AssetEnabled) {
continue
}
assetTypes = append(assetTypes, k)
}
return assetTypes
}
// Get gets the currency pair config based on the asset type
func (p *PairsManager) Get(a asset.Item) (*PairStore, error) {
if !a.IsValid() {
return nil, fmt.Errorf("%s %w", a, asset.ErrNotSupported)
}
p.mutex.RLock()
defer p.mutex.RUnlock()
c, ok := p.Pairs[a]
if !ok {
return nil,
fmt.Errorf("cannot get pair store, %v %w", a, asset.ErrNotSupported)
}
return c.copy()
}
// Match returns a currency pair based on the supplied symbol and asset type
func (p *PairsManager) Match(symbol string, a asset.Item) (Pair, error) {
if symbol == "" {
return EMPTYPAIR, ErrSymbolStringEmpty
}
symbol = strings.ToLower(symbol)
p.mutex.RLock()
defer p.mutex.RUnlock()
if p.matcher == nil {
return EMPTYPAIR, errPairMatcherIsNil
}
pair, ok := p.matcher[key{symbol, a}]
if !ok {
return EMPTYPAIR, fmt.Errorf("%w for %v %v", ErrPairNotFound, symbol, a)
}
return *pair, nil
}
// Store stores a new currency pair config based on its asset type
func (p *PairsManager) Store(a asset.Item, ps *PairStore) error {
if !a.IsValid() {
return fmt.Errorf("%s %w", a, asset.ErrNotSupported)
}
cpy, err := ps.copy()
if err != nil {
return err
}
p.mutex.Lock()
if p.Pairs == nil {
p.Pairs = make(map[asset.Item]*PairStore)
}
p.Pairs[a] = cpy
if p.matcher == nil {
p.matcher = make(map[key]*Pair)
}
for x := range cpy.Available {
p.matcher[key{
Symbol: cpy.Available[x].Base.Lower().String() + cpy.Available[x].Quote.Lower().String(),
Asset: a}] = &cpy.Available[x]
}
p.mutex.Unlock()
return nil
}
// Delete deletes a map entry based on the supplied asset type
func (p *PairsManager) Delete(a asset.Item) {
p.mutex.Lock()
vals, ok := p.Pairs[a]
if !ok {
p.mutex.Unlock()
return
}
for x := range vals.Available {
delete(p.matcher, key{Symbol: vals.Available[x].Base.Lower().String() + vals.Available[x].Quote.Lower().String(), Asset: a})
}
delete(p.Pairs, a)
p.mutex.Unlock()
}
// GetPairs gets a list of stored pairs based on the asset type and whether
// they're enabled or not
func (p *PairsManager) GetPairs(a asset.Item, enabled bool) (Pairs, error) {
if !a.IsValid() {
return nil, fmt.Errorf("%s %w", a, asset.ErrNotSupported)
}
p.mutex.RLock()
defer p.mutex.RUnlock()
pairStore, ok := p.Pairs[a]
if !ok {
return nil, nil
}
if !enabled {
availPairs := make(Pairs, len(pairStore.Available))
copy(availPairs, pairStore.Available)
return availPairs, nil
}
lenCheck := len(pairStore.Enabled)
if lenCheck == 0 {
return nil, nil
}
// NOTE: enabledPairs is declared before the next check for comparison
// reasons within exchange update pairs functionality.
enabledPairs := make(Pairs, lenCheck)
copy(enabledPairs, pairStore.Enabled)
err := pairStore.Available.ContainsAll(pairStore.Enabled, true)
if err != nil {
err = fmt.Errorf("%w of asset type %s", err, a)
}
return enabledPairs, err
}
// StoreFormat stores a new format for request or config format.
func (p *PairsManager) StoreFormat(a asset.Item, pFmt *PairFormat, config bool) error {
if !a.IsValid() {
return fmt.Errorf("%s %w", a, asset.ErrNotSupported)
}
if pFmt == nil {
return errPairFormatIsNil
}
cpy := *pFmt
p.mutex.Lock()
defer p.mutex.Unlock()
if p.Pairs == nil {
p.Pairs = make(map[asset.Item]*PairStore)
}
pairStore, ok := p.Pairs[a]
if !ok {
pairStore = new(PairStore)
p.Pairs[a] = pairStore
}
if config {
pairStore.ConfigFormat = &cpy
} else {
pairStore.RequestFormat = &cpy
}
return nil
}
// StorePairs stores a list of pairs based on the asset type and whether
// they're enabled or not
func (p *PairsManager) StorePairs(a asset.Item, pairs Pairs, enabled bool) error {
if !a.IsValid() {
return fmt.Errorf("%s %w", a, asset.ErrNotSupported)
}
// NOTE: Length check not needed in this scenario as it has the ability to
// remove the entire stored list if needed.
cpy := make(Pairs, len(pairs))
copy(cpy, pairs)
p.mutex.Lock()
defer p.mutex.Unlock()
if p.Pairs == nil {
p.Pairs = make(map[asset.Item]*PairStore)
}
pairStore, ok := p.Pairs[a]
if !ok {
pairStore = new(PairStore)
p.Pairs[a] = pairStore
}
if enabled {
pairStore.Enabled = cpy
} else {
pairStore.Available = cpy
if p.matcher == nil {
p.matcher = make(map[key]*Pair)
}
for x := range pairStore.Available {
p.matcher[key{
Symbol: pairStore.Available[x].Base.Lower().String() + pairStore.Available[x].Quote.Lower().String(),
Asset: a}] = &pairStore.Available[x]
}
}
return nil
}
// EnsureOnePairEnabled not all assets have pairs, eg options
// search for an asset that does and enable one if none are enabled
// error if no currency pairs found for an entire exchange
// returns the asset and pair of a pair if it has been enabled
func (p *PairsManager) EnsureOnePairEnabled() (Pair, asset.Item, error) {
if p == nil {
return EMPTYPAIR, asset.Empty, common.ErrNilPointer
}
p.mutex.Lock()
defer p.mutex.Unlock()
for _, v := range p.Pairs {
if v.AssetEnabled == nil ||
!*v.AssetEnabled ||
len(v.Available) == 0 {
continue
}
if len(v.Enabled) > 0 {
return EMPTYPAIR, asset.Empty, nil
}
}
for k, v := range p.Pairs {
if v.AssetEnabled == nil ||
!*v.AssetEnabled ||
len(v.Available) == 0 {
continue
}
rp, err := v.Available.GetRandomPair()
if err != nil {
return EMPTYPAIR, asset.Empty, err
}
p.Pairs[k].Enabled = v.Enabled.Add(rp)
return rp, k, nil
}
return EMPTYPAIR, asset.Empty, ErrCurrencyPairsEmpty
}
// DisablePair removes the pair from the enabled pairs list if found
func (p *PairsManager) DisablePair(a asset.Item, pair Pair) error {
if !a.IsValid() {
return fmt.Errorf("%s %w", a, asset.ErrNotSupported)
}
if pair.IsEmpty() {
return ErrCurrencyPairEmpty
}
p.mutex.Lock()
defer p.mutex.Unlock()
pairStore, err := p.getPairStoreRequiresLock(a)
if err != nil {
return err
}
enabled, err := pairStore.Enabled.Remove(pair)
if err != nil {
return err
}
pairStore.Enabled = enabled
return nil
}
// EnablePair adds a pair to the list of enabled pairs if it exists in the list
// of available pairs and isn't already added
func (p *PairsManager) EnablePair(a asset.Item, pair Pair) error {
if !a.IsValid() {
return fmt.Errorf("%s %w", a, asset.ErrNotSupported)
}
if pair.IsEmpty() {
return ErrCurrencyPairEmpty
}
p.mutex.Lock()
defer p.mutex.Unlock()
pairStore, err := p.getPairStoreRequiresLock(a)
if err != nil {
return err
}
if pairStore.Enabled.Contains(pair, true) {
return fmt.Errorf("%s %w", pair, ErrPairAlreadyEnabled)
}
if !pairStore.Available.Contains(pair, true) {
return fmt.Errorf("%s %w in the list of available pairs",
pair, ErrPairNotFound)
}
pairStore.Enabled = pairStore.Enabled.Add(pair)
return nil
}
// IsPairEnabled checks if a pair is enabled for an enabled asset type
func (p *PairsManager) IsPairEnabled(pair Pair, a asset.Item) (bool, error) {
if !a.IsValid() {
return false, fmt.Errorf("%s %w", a, asset.ErrNotSupported)
}
if pair.IsEmpty() {
return false, ErrCurrencyPairEmpty
}
p.mutex.RLock()
defer p.mutex.RUnlock()
pairStore, err := p.getPairStoreRequiresLock(a)
if err != nil {
return false, err
}
if pairStore.AssetEnabled == nil {
return false, fmt.Errorf("%s %w", a, ErrAssetIsNil)
}
return *pairStore.AssetEnabled && pairStore.Enabled.Contains(pair, true), nil
}
// IsAssetEnabled checks to see if an asset is enabled
func (p *PairsManager) IsAssetEnabled(a asset.Item) error {
if !a.IsValid() {
return fmt.Errorf("%s %w", a, asset.ErrNotSupported)
}
p.mutex.RLock()
defer p.mutex.RUnlock()
pairStore, err := p.getPairStoreRequiresLock(a)
if err != nil {
return err
}
if pairStore.AssetEnabled == nil {
return fmt.Errorf("%s %w", a, ErrAssetIsNil)
}
if !*pairStore.AssetEnabled {
return fmt.Errorf("%s %w", a, asset.ErrNotEnabled)
}
return nil
}
// SetAssetEnabled sets if an asset is enabled or disabled for first run
func (p *PairsManager) SetAssetEnabled(a asset.Item, enabled bool) error {
if !a.IsValid() {
return fmt.Errorf("%s %w", a, asset.ErrNotSupported)
}
p.mutex.Lock()
defer p.mutex.Unlock()
pairStore, err := p.getPairStoreRequiresLock(a)
if err != nil {
return err
}
if pairStore.AssetEnabled == nil {
pairStore.AssetEnabled = convert.BoolPtr(enabled)
return nil
}
if !*pairStore.AssetEnabled && !enabled {
return errors.New("asset already disabled")
} else if *pairStore.AssetEnabled && enabled {
return ErrAssetAlreadyEnabled
}
*pairStore.AssetEnabled = enabled
return nil
}
// Load sets the pair manager from a seed without copying mutexes
func (p *PairsManager) Load(seed *PairsManager) error {
if seed == nil {
return fmt.Errorf("%w PairsManager", common.ErrNilPointer)
}
p.mutex.Lock()
defer p.mutex.Unlock()
seed.mutex.RLock()
defer seed.mutex.RUnlock()
var pN PairsManager
j, err := json.Marshal(seed)
if err != nil {
return err
}
err = json.Unmarshal(j, &pN)
if err != nil {
return err
}
p.BypassConfigFormatUpgrades = pN.BypassConfigFormatUpgrades
if pN.UseGlobalFormat {
p.UseGlobalFormat = pN.UseGlobalFormat
p.RequestFormat = pN.RequestFormat
p.ConfigFormat = pN.ConfigFormat
}
p.LastUpdated = pN.LastUpdated
p.Pairs = pN.Pairs
return nil
}
func (p *PairsManager) getPairStoreRequiresLock(a asset.Item) (*PairStore, error) {
if p.Pairs == nil {
return nil, fmt.Errorf("%w when requesting %v pairs", ErrPairManagerNotInitialised, a)
}
pairStore, ok := p.Pairs[a]
if !ok {
return nil, fmt.Errorf("%w %v", ErrAssetNotFound, a)
}
if pairStore == nil {
return nil, errors.New("currency store is nil")
}
return pairStore, nil
}
// SetDelimitersFromConfig ensures that the pairs adhere to the configured delimiters
// Pairs.Unmarshal doesn't know what the delimiter is, so uses the first punctuation rune
func (p *PairsManager) SetDelimitersFromConfig() error {
for a, s := range p.Pairs {
cf := s.ConfigFormat
if cf == nil {
cf = p.ConfigFormat
}
if cf == nil {
return errPairConfigFormatNil
}
for i, p := range []Pairs{s.Enabled, s.Available} {
for j := range p {
if p[j].Delimiter == cf.Delimiter {
continue
}
nP, err := NewPairDelimiter(p[j].String(), cf.Delimiter)
if err != nil {
return fmt.Errorf("%s.%s.%s: %w", a, []string{"enabled", "available"}[i], p[j], err)
}
p[j] = nP
}
}
}
return nil
}
// UnmarshalJSON implements the unmarshal json interface so that the key can be
// correctly unmarshalled from a string into a uint.
func (fs *FullStore) UnmarshalJSON(d []byte) error {
var temp map[string]*PairStore
err := json.Unmarshal(d, &temp)
if err != nil {
return err
}
*fs = make(FullStore, len(temp))
for key, val := range temp {
ai, err := asset.New(key)
if err != nil {
return err
}
(*fs)[ai] = val
}
return nil
}
// MarshalJSON implements the marshal json interface so that the key can be
// correctly marshalled from a uint.
func (fs FullStore) MarshalJSON() ([]byte, error) {
temp := make(map[string]*PairStore, len(fs))
for key, val := range fs {
temp[key.String()] = val
}
return json.Marshal(temp)
}
// copy copies and segregates pair store from internal and external calls.
func (ps *PairStore) copy() (*PairStore, error) {
if ps == nil {
return nil, errPairStoreIsNil
}
var assetEnabled *bool
if ps.AssetEnabled != nil {
assetEnabled = convert.BoolPtr(*ps.AssetEnabled)
}
enabled := make(Pairs, len(ps.Enabled))
copy(enabled, ps.Enabled)
avail := make(Pairs, len(ps.Available))
copy(avail, ps.Available)
var rFmt *PairFormat
if ps.RequestFormat != nil {
cpy := *ps.RequestFormat
rFmt = &cpy
}
var cFmt *PairFormat
if ps.ConfigFormat != nil {
cpy := *ps.ConfigFormat
cFmt = &cpy
}
return &PairStore{
AssetEnabled: assetEnabled,
Enabled: enabled,
Available: avail,
RequestFormat: rFmt,
ConfigFormat: cFmt,
}, nil
}