mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-18 23:16:49 +00:00
1199f38546
* Websocket: Use ErrSubscribedAlready instead of errChannelAlreadySubscribed * Subscriptions: Replace Pair with Pairs Given that some subscriptions have multiple pairs, support that as the standard. * Docs: Update subscriptions in add new exch * RPC: Update Subscription Pairs * Linter: Disable testifylint.Len We deliberately use Equal over Len to avoid spamming the contents of large Slices * Websocket: Add suffix to state consts * Binance: Subscription Pairs support * Bitfinex: Subscription Pairs support * Bithumb: Subscription Pairs support * Bitmex: Subscription Pairs support * Bitstamp: Subscription Pairs support * BTCMarkets: Subscription Pairs support * BTSE: Subscription Pairs support * Coinbase: Subscription Pairs support * Coinut: Subscription Pairs support * GateIO: Subscription Pairs support * Gemini: Subscription Pairs support and improvement * Hitbtc: Subscription Pairs support * Huboi: Subscription Pairs support * Kucoin: Subscription Pairs support * Okcoin: Subscription Pairs support * Poloniex: Subscription Pairs support * Kraken: Add subscription Pairs support Note: This is a naieve implementation because we want to rebase the kraken websocket rewrite on top of this * Bybit: Subscription Pairs support * Okx: Subscription Pairs support * Bitmex: Subsription configuration * Fixes unauthenticated websocket left as CanUseAuth * Fixes auth subs happening privately * CoinbasePro: Subscription Configuration * Consolidate ProductIDs when all subscriptions are for the same list * Websocket: Log actual sent message when Verbose * Subscriptions: Improve clarity of which key is which in Match * Subscriptions: Lint fix for HugeParam * Subscriptions: Add AddPairs and move keys from test * Subscriptions: Simplify subscription keys and add key types * Subscriptions: Add List.GroupPairs Rename sub.AddPairs * Subscription: Fix ExactKey not matching 0 pairs * Subscriptions: Remove unused IdentityKey and HasPairKey * Subscriptions: Fix GetKey test * Subscriptions: Test coverage improvements * Websocket: Change State on Add/Remove * Subscriptions: Improve error context * Subscriptions: Fix Enable: false subs not ignored * Bitfinex: Fix WsAuth test failing on DataHandler DataHandler is eaten by dataMonitor now, so we need to use ToRoutine * Deribit: Subscription Pairs support * Websocket: Accept nil lists for checkSubscriptions If the user passes in a nil (implicitly empty) list, we would not panic. Therefore the burden of correctness about that data lies with them. The list of subscriptions is empty, and that's okay, and possibly convenient * Websocket: Add context to NilPointer errors * Subscriptions: Add context to nil errors * Exchange: Fix error expectations in UnsubToWSChans
111 lines
4.5 KiB
Go
111 lines
4.5 KiB
Go
package subscription
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/thrasher-corp/gocryptotrader/currency"
|
|
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
|
|
"github.com/thrasher-corp/gocryptotrader/exchanges/kline"
|
|
)
|
|
|
|
// DummyKey is a test key type that ensures that cross compatible keys can be used
|
|
// It will panic if Match() is called
|
|
type DummyKey struct {
|
|
*Subscription
|
|
detonator testing.TB
|
|
}
|
|
|
|
var _ MatchableKey = DummyKey{} // Enforce DummyKey must implement MatchableKey
|
|
|
|
// GetSubscription returns the underlying subscription
|
|
func (k DummyKey) GetSubscription() *Subscription {
|
|
return k.Subscription
|
|
}
|
|
|
|
// Match implements MatchableKey
|
|
func (k DummyKey) Match(_ MatchableKey) bool {
|
|
k.detonator.Fatal("DummyKey Match should never be called")
|
|
return false
|
|
}
|
|
|
|
// TestExactKeyMatch exercises ExactKey.Match
|
|
func TestExactKeyMatch(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
key := &ExactKey{&Subscription{Channel: TickerChannel}}
|
|
try := &DummyKey{&Subscription{Channel: OrderbookChannel}, t}
|
|
|
|
require.False(t, key.Match(nil), "Match on a nil must return false")
|
|
require.False(t, key.Match(try), "Gate 1: Match must reject a bad Channel")
|
|
try.Channel = TickerChannel
|
|
require.True(t, key.Match(try), "Gate 1: Match must accept a good Channel")
|
|
key.Asset = asset.Spot
|
|
require.False(t, key.Match(try), "Gate 2: Match must reject a bad Asset")
|
|
try.Asset = asset.Spot
|
|
require.True(t, key.Match(try), "Gate 2: Match must accept a good Asset")
|
|
key.Pairs = currency.Pairs{btcusdtPair}
|
|
require.False(t, key.Match(try), "Gate 3: Match must reject B empty Pairs when key has Pairs")
|
|
try.Pairs = currency.Pairs{btcusdtPair}
|
|
key.Pairs = nil
|
|
require.False(t, key.Match(try), "Gate 3: Match must reject B has Pairs when key has empty Pairs")
|
|
key.Pairs = currency.Pairs{btcusdtPair}
|
|
require.True(t, key.Match(try), "Gate 3: Match must accept matching pairs")
|
|
key.Pairs = currency.Pairs{ethusdcPair}
|
|
require.False(t, key.Match(try), "Gate 3: Match must reject when key.Pairs not matching")
|
|
try.Pairs = currency.Pairs{btcusdtPair, ethusdcPair}
|
|
require.False(t, key.Match(try), "Gate 3: Match must reject when key.Pairs is only a subset")
|
|
key.Pairs = currency.Pairs{ethusdcPair, btcusdtPair}
|
|
require.True(t, key.Match(try), "Gate 3: Match accept when Pairs match in different order")
|
|
key.Levels = 4
|
|
require.False(t, key.Match(try), "Gate 4: Match must reject a bad Level")
|
|
try.Levels = 4
|
|
require.True(t, key.Match(try), "Gate 4: Match must accept a good Level")
|
|
key.Interval = kline.FiveMin
|
|
require.False(t, key.Match(try), "Gate 5: Match must reject a bad Interval")
|
|
try.Interval = kline.FiveMin
|
|
require.True(t, key.Match(try), "Gate 5: Match must accept a good Interval")
|
|
}
|
|
|
|
// TestExactKeyString exercises ExactKey.String
|
|
func TestExactKeyString(t *testing.T) {
|
|
t.Parallel()
|
|
key := &ExactKey{}
|
|
assert.Equal(t, "Uninitialised ExactKey", key.String())
|
|
key = &ExactKey{&Subscription{Asset: asset.Spot, Channel: TickerChannel, Pairs: currency.Pairs{ethusdcPair, btcusdtPair}}}
|
|
assert.Equal(t, "ticker spot ETH/USDC,BTC/USDT", key.String())
|
|
}
|
|
|
|
// TestIgnoringPairsKeyMatch exercises IgnoringPairsKey.Match
|
|
func TestIgnoringPairsKeyMatch(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
key := &IgnoringPairsKey{&Subscription{Channel: TickerChannel, Pairs: currency.Pairs{btcusdtPair}}}
|
|
try := &DummyKey{&Subscription{Channel: OrderbookChannel, Pairs: currency.Pairs{ethusdcPair}}, t}
|
|
|
|
require.False(t, key.Match(nil), "Match on a nil must return false")
|
|
require.False(t, key.Match(try), "Gate 1: Match must reject a bad Channel")
|
|
try.Channel = TickerChannel
|
|
require.True(t, key.Match(try), "Gate 1: Match must accept a good Channel")
|
|
key.Asset = asset.Spot
|
|
require.False(t, key.Match(try), "Gate 2: Match must reject a bad Asset")
|
|
try.Asset = asset.Spot
|
|
require.True(t, key.Match(try), "Gate 2: Match must accept a good Asset")
|
|
key.Levels = 4
|
|
require.False(t, key.Match(try), "Gate 3: Match must reject a bad Level")
|
|
try.Levels = 4
|
|
require.True(t, key.Match(try), "Gate 3: Match must accept a good Level")
|
|
key.Interval = kline.FiveMin
|
|
require.False(t, key.Match(try), "Gate 4: Match must reject a bad Interval")
|
|
try.Interval = kline.FiveMin
|
|
require.True(t, key.Match(try), "Gate 4: Match must accept a good Interval")
|
|
}
|
|
|
|
// TestIgnoringPairsKeyString exercises IgnoringPairsKey.String
|
|
func TestIgnoringPairsKeyString(t *testing.T) {
|
|
t.Parallel()
|
|
key := &IgnoringPairsKey{&Subscription{Asset: asset.Spot, Channel: TickerChannel, Pairs: currency.Pairs{ethusdcPair, btcusdtPair}}}
|
|
assert.Equal(t, "ticker spot", key.String())
|
|
}
|