Files
gocryptotrader/engine/ntp_manager_test.go
Adrian Gallagher a5b638bfb7 GHA: Add additional checks for common issues (#1922)
* GHA, tests: Add additional checks for common issues

These checks include:
- Ensuring that all testify funcs use their formatted variants (e.g., `assert.Equalf(t, expected, actual)` instead of `assert.Equal(t, expected, actual)`).
- Replacing `%s` with %q
- Enforcing consistent usage of should/must wording for testify assert/require messages

* Add support for checking backticked string format specifiers and fix issues

* tests: Fix error comparisons

* tests: Replace errors.Is(err, nil) usage with testify and automate check

* refactor: Rename ExtractPort to ExtractPortOrDefault

* tests: Replace assert with require for error handling in multiple test files

* tests: Replace assert with require for error handling and improve assertions in data tests

* tests: Fix typo in assertion message for StreamVol test

* OKX: Fix GetOpenInterestAndVolumeStrike test with instrument selection and improved assertions

* OKX: Revert intentional error check

* Improve error message for expiry time check in GetOpenInterestAndVolumeStrike test
2025-05-28 12:26:51 +10:00

186 lines
4.0 KiB
Go

package engine
import (
"errors"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/thrasher-corp/gocryptotrader/config"
)
func TestSetupNTPManager(t *testing.T) {
_, err := setupNTPManager(nil, false)
if !errors.Is(err, errNilConfig) {
t.Errorf("error '%v', expected '%v'", err, errNilConfig)
}
_, err = setupNTPManager(&config.NTPClientConfig{}, false)
if !errors.Is(err, errNilNTPConfigValues) {
t.Errorf("error '%v', expected '%v'", err, errNilNTPConfigValues)
}
sec := time.Second
cfg := &config.NTPClientConfig{
AllowedDifference: &sec,
AllowedNegativeDifference: &sec,
}
m, err := setupNTPManager(cfg, false)
assert.NoError(t, err)
if m == nil {
t.Error("expected manager")
}
}
func TestNTPManagerIsRunning(t *testing.T) {
var m *ntpManager
if m.IsRunning() {
t.Error("expected false")
}
sec := time.Second
cfg := &config.NTPClientConfig{
AllowedDifference: &sec,
AllowedNegativeDifference: &sec,
Level: 1,
}
m, err := setupNTPManager(cfg, false)
assert.NoError(t, err)
if m.IsRunning() {
t.Error("expected false")
}
err = m.Start()
if err != nil {
t.Error(err)
}
if !m.IsRunning() {
t.Error("expected true")
}
}
func TestNTPManagerStart(t *testing.T) {
var m *ntpManager
err := m.Start()
if !errors.Is(err, ErrNilSubsystem) {
t.Errorf("error '%v', expected '%v'", err, ErrNilSubsystem)
}
sec := time.Second
cfg := &config.NTPClientConfig{
AllowedDifference: &sec,
AllowedNegativeDifference: &sec,
}
m, err = setupNTPManager(cfg, true)
assert.NoError(t, err)
err = m.Start()
if !errors.Is(err, errNTPManagerDisabled) {
t.Errorf("error '%v', expected '%v'", err, errNTPManagerDisabled)
}
m.level = 1
err = m.Start()
assert.NoError(t, err)
err = m.Start()
if !errors.Is(err, ErrSubSystemAlreadyStarted) {
t.Errorf("error '%v', expected '%v'", err, ErrSubSystemAlreadyStarted)
}
}
func TestNTPManagerStop(t *testing.T) {
var m *ntpManager
err := m.Stop()
if !errors.Is(err, ErrNilSubsystem) {
t.Errorf("error '%v', expected '%v'", err, ErrNilSubsystem)
}
sec := time.Second
cfg := &config.NTPClientConfig{
AllowedDifference: &sec,
AllowedNegativeDifference: &sec,
Level: 1,
}
m, err = setupNTPManager(cfg, true)
assert.NoError(t, err)
err = m.Stop()
if !errors.Is(err, ErrSubSystemNotStarted) {
t.Errorf("error '%v', expected '%v'", err, ErrSubSystemNotStarted)
}
err = m.Start()
assert.NoError(t, err)
err = m.Stop()
assert.NoError(t, err)
}
func TestFetchNTPTime(t *testing.T) {
var m *ntpManager
_, err := m.FetchNTPTime()
if !errors.Is(err, ErrNilSubsystem) {
t.Errorf("error '%v', expected '%v'", err, ErrNilSubsystem)
}
sec := time.Second
cfg := &config.NTPClientConfig{
AllowedDifference: &sec,
AllowedNegativeDifference: &sec,
Level: 1,
}
m, err = setupNTPManager(cfg, true)
assert.NoError(t, err)
_, err = m.FetchNTPTime()
if !errors.Is(err, ErrSubSystemNotStarted) {
t.Errorf("error '%v', expected '%v'", err, ErrSubSystemNotStarted)
}
err = m.Start()
assert.NoError(t, err)
tt, err := m.FetchNTPTime()
assert.NoError(t, err)
if tt.IsZero() {
t.Error("expected time")
}
m.pools = []string{"0.pool.ntp.org:123"}
tt, err = m.FetchNTPTime()
assert.NoError(t, err)
if tt.IsZero() {
t.Error("expected time")
}
}
func TestProcessTime(t *testing.T) {
sec := time.Second
cfg := &config.NTPClientConfig{
AllowedDifference: &sec,
AllowedNegativeDifference: &sec,
Level: 1,
Pool: []string{"0.pool.ntp.org:123"},
}
m, err := setupNTPManager(cfg, true)
assert.NoError(t, err)
err = m.processTime()
if !errors.Is(err, ErrSubSystemNotStarted) {
t.Errorf("error '%v', expected '%v'", err, ErrSubSystemNotStarted)
}
err = m.Start()
assert.NoError(t, err)
err = m.processTime()
assert.NoError(t, err)
m.allowedDifference = time.Duration(1)
m.allowedNegativeDifference = time.Duration(1)
err = m.processTime()
assert.NoError(t, err)
}