Files
gocryptotrader/engine/connection_manager_test.go
Adrian Gallagher a5b638bfb7 GHA: Add additional checks for common issues (#1922)
* GHA, tests: Add additional checks for common issues

These checks include:
- Ensuring that all testify funcs use their formatted variants (e.g., `assert.Equalf(t, expected, actual)` instead of `assert.Equal(t, expected, actual)`).
- Replacing `%s` with %q
- Enforcing consistent usage of should/must wording for testify assert/require messages

* Add support for checking backticked string format specifiers and fix issues

* tests: Fix error comparisons

* tests: Replace errors.Is(err, nil) usage with testify and automate check

* refactor: Rename ExtractPort to ExtractPortOrDefault

* tests: Replace assert with require for error handling in multiple test files

* tests: Replace assert with require for error handling and improve assertions in data tests

* tests: Fix typo in assertion message for StreamVol test

* OKX: Fix GetOpenInterestAndVolumeStrike test with instrument selection and improved assertions

* OKX: Revert intentional error check

* Improve error message for expiry time check in GetOpenInterestAndVolumeStrike test
2025-05-28 12:26:51 +10:00

118 lines
2.5 KiB
Go

package engine
import (
"errors"
"testing"
"github.com/stretchr/testify/assert"
"github.com/thrasher-corp/gocryptotrader/config"
)
func TestSetupConnectionManager(t *testing.T) {
t.Parallel()
_, err := setupConnectionManager(nil)
if !errors.Is(err, errNilConfig) {
t.Errorf("error '%v', expected '%v'", err, errNilConfig)
}
m, err := setupConnectionManager(&config.ConnectionMonitorConfig{})
assert.NoError(t, err)
if m == nil {
t.Error("expected manager")
}
}
func TestConnectionMonitorIsRunning(t *testing.T) {
t.Parallel()
m, err := setupConnectionManager(&config.ConnectionMonitorConfig{})
assert.NoError(t, err)
err = m.Start()
assert.NoError(t, err)
if !m.IsRunning() {
t.Error("expected true")
}
m.started = 0
if m.IsRunning() {
t.Error("expected false")
}
m = nil
if m.IsRunning() {
t.Error("expected false")
}
}
func TestConnectionMonitorStart(t *testing.T) {
t.Parallel()
m, err := setupConnectionManager(&config.ConnectionMonitorConfig{})
assert.NoError(t, err)
err = m.Start()
assert.NoError(t, err)
err = m.Start()
if !errors.Is(err, ErrSubSystemAlreadyStarted) {
t.Errorf("error '%v', expected '%v'", err, ErrSubSystemAlreadyStarted)
}
m = nil
err = m.Start()
if !errors.Is(err, ErrNilSubsystem) {
t.Errorf("error '%v', expected '%v'", err, ErrNilSubsystem)
}
}
func TestConnectionMonitorStop(t *testing.T) {
t.Parallel()
err := (&connectionManager{started: 1}).Stop()
if !errors.Is(err, errConnectionCheckerIsNil) {
t.Errorf("error '%v', expected '%v'", err, errConnectionCheckerIsNil)
}
m, err := setupConnectionManager(&config.ConnectionMonitorConfig{})
assert.NoError(t, err)
err = m.Start()
assert.NoError(t, err)
err = m.Stop()
assert.NoError(t, err)
err = m.Stop()
if !errors.Is(err, ErrSubSystemNotStarted) {
t.Errorf("error '%v', expected '%v'", err, ErrSubSystemNotStarted)
}
m = nil
err = m.Stop()
if !errors.Is(err, ErrNilSubsystem) {
t.Errorf("error '%v', expected '%v'", err, ErrNilSubsystem)
}
}
func TestConnectionMonitorIsOnline(t *testing.T) {
t.Parallel()
m, err := setupConnectionManager(&config.ConnectionMonitorConfig{})
assert.NoError(t, err)
err = m.Start()
assert.NoError(t, err)
// If someone runs this offline, who are we to fail them?
m.IsOnline()
err = m.Stop()
if err != nil {
t.Fatal(err)
}
if m.IsOnline() {
t.Error("expected false")
}
m.conn = nil
if m.IsOnline() {
t.Error("expected false")
}
m = nil
if m.IsOnline() {
t.Error("expected false")
}
}