mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-13 23:16:45 +00:00
1212b6750e
* OrderManager: Fix race condition in submit with ws If the ws sees the order before processSubmittedOrder then it will have assigned it an internal order id already and added it to the store. Don't treat that as an error. Instead just use the newer ws details * OrderManager: Fix error comparisson Should always use errors.Is when possible * Tests: Simplify btcusd test pair declaration * OrderManager: Improve test readability * OrderManager: Add orderstore.getByDetail test * Return a fresh pointer from orderstore.getByDetail This protects the order.Details in the store from direct access. The use-case was to allow the returned objects to be references so that future changes to them would be reflected. However we're not ready yet to allow people to touch the orders directly, because they're not protected directly by a mutex, and nothing would stop consumers contaminating the integrity of the data. We can revisit this topic later atomicly, but it's definitely tangental to the cause of action for PR #1336. * Fix GetByDetail tests to assert a new pointer * OrderManager: Avoid possible lock races This fix internalises the getByDetail because the implication of moving lock ownership out of exists/getByDetail to consumers breaks the order store struct encapsulation in a way we really don't want to. It's also more efficient * Fix spelling mistake Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * OrderManager: Fix TestSubmitOrder... description * OrderManager: Improve clarity of comment * OrderManager: Capitalise error message On failure to add to orderstore, capitalise the error message Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io> --------- Co-authored-by: Scott <gloriousCode@users.noreply.github.com> Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io>