mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-14 15:09:51 +00:00
a5b638bfb7
* GHA, tests: Add additional checks for common issues These checks include: - Ensuring that all testify funcs use their formatted variants (e.g., `assert.Equalf(t, expected, actual)` instead of `assert.Equal(t, expected, actual)`). - Replacing `%s` with %q - Enforcing consistent usage of should/must wording for testify assert/require messages * Add support for checking backticked string format specifiers and fix issues * tests: Fix error comparisons * tests: Replace errors.Is(err, nil) usage with testify and automate check * refactor: Rename ExtractPort to ExtractPortOrDefault * tests: Replace assert with require for error handling in multiple test files * tests: Replace assert with require for error handling and improve assertions in data tests * tests: Fix typo in assertion message for StreamVol test * OKX: Fix GetOpenInterestAndVolumeStrike test with instrument selection and improved assertions * OKX: Revert intentional error check * Improve error message for expiry time check in GetOpenInterestAndVolumeStrike test
130 lines
3.5 KiB
Go
130 lines
3.5 KiB
Go
package request
|
|
|
|
import (
|
|
"errors"
|
|
"net/http"
|
|
"net/url"
|
|
"slices"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/thrasher-corp/gocryptotrader/common"
|
|
)
|
|
|
|
// this doesn't need to be included in binary
|
|
func (c *clientTracker) contains(check *http.Client) bool {
|
|
c.Lock()
|
|
defer c.Unlock()
|
|
return slices.Contains(c.clients, check)
|
|
}
|
|
|
|
func TestCheckAndRegister(t *testing.T) {
|
|
t.Parallel()
|
|
err := tracker.checkAndRegister(nil)
|
|
if !errors.Is(err, errHTTPClientIsNil) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", err, errHTTPClientIsNil)
|
|
}
|
|
|
|
newLovelyClient := new(http.Client)
|
|
err = tracker.checkAndRegister(newLovelyClient)
|
|
require.NoError(t, err)
|
|
|
|
if !tracker.contains(newLovelyClient) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", false, true)
|
|
}
|
|
|
|
err = tracker.checkAndRegister(newLovelyClient)
|
|
if !errors.Is(err, errCannotReuseHTTPClient) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", err, errCannotReuseHTTPClient)
|
|
}
|
|
}
|
|
|
|
func TestDeRegister(t *testing.T) {
|
|
t.Parallel()
|
|
err := tracker.deRegister(nil)
|
|
if !errors.Is(err, errHTTPClientIsNil) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", err, errHTTPClientIsNil)
|
|
}
|
|
|
|
newLovelyClient := new(http.Client)
|
|
err = tracker.deRegister(newLovelyClient)
|
|
if !errors.Is(err, errHTTPClientNotFound) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", err, errHTTPClientNotFound)
|
|
}
|
|
|
|
err = tracker.checkAndRegister(newLovelyClient)
|
|
require.NoError(t, err)
|
|
|
|
if !tracker.contains(newLovelyClient) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", false, true)
|
|
}
|
|
|
|
err = tracker.deRegister(newLovelyClient)
|
|
require.NoError(t, err)
|
|
|
|
if tracker.contains(newLovelyClient) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", true, false)
|
|
}
|
|
}
|
|
|
|
func TestNewProtectedClient(t *testing.T) {
|
|
t.Parallel()
|
|
if _, err := newProtectedClient(nil); !errors.Is(err, errHTTPClientIsNil) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", err, errHTTPClientIsNil)
|
|
}
|
|
|
|
newLovelyClient := new(http.Client)
|
|
protec, err := newProtectedClient(newLovelyClient)
|
|
require.NoError(t, err)
|
|
|
|
if protec.protected != newLovelyClient {
|
|
t.Fatal("unexpected value")
|
|
}
|
|
}
|
|
|
|
func TestClientSetProxy(t *testing.T) {
|
|
t.Parallel()
|
|
err := (&client{}).setProxy(nil)
|
|
if !errors.Is(err, errNoProxyURLSupplied) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", err, errNoProxyURLSupplied)
|
|
}
|
|
pp, err := url.Parse("lol.com")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
err = (&client{protected: new(http.Client)}).setProxy(pp)
|
|
if !errors.Is(err, errTransportNotSet) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", err, errTransportNotSet)
|
|
}
|
|
err = (&client{protected: common.NewHTTPClientWithTimeout(0)}).setProxy(pp)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestClientSetHTTPClientTimeout(t *testing.T) {
|
|
t.Parallel()
|
|
err := (&client{protected: new(http.Client)}).setHTTPClientTimeout(time.Second)
|
|
if !errors.Is(err, errTransportNotSet) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", err, errTransportNotSet)
|
|
}
|
|
err = (&client{protected: common.NewHTTPClientWithTimeout(0)}).setHTTPClientTimeout(time.Second)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestRelease(t *testing.T) {
|
|
t.Parallel()
|
|
newLovelyClient, err := newProtectedClient(common.NewHTTPClientWithTimeout(0))
|
|
require.NoError(t, err)
|
|
|
|
if !tracker.contains(newLovelyClient.protected) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", false, true)
|
|
}
|
|
|
|
err = newLovelyClient.release()
|
|
require.NoError(t, err)
|
|
|
|
if tracker.contains(newLovelyClient.protected) {
|
|
t.Fatalf("received: '%v' but expected: '%v'", true, false)
|
|
}
|
|
}
|