Files
gocryptotrader/database/database_test.go
Adrian Gallagher a5b638bfb7 GHA: Add additional checks for common issues (#1922)
* GHA, tests: Add additional checks for common issues

These checks include:
- Ensuring that all testify funcs use their formatted variants (e.g., `assert.Equalf(t, expected, actual)` instead of `assert.Equal(t, expected, actual)`).
- Replacing `%s` with %q
- Enforcing consistent usage of should/must wording for testify assert/require messages

* Add support for checking backticked string format specifiers and fix issues

* tests: Fix error comparisons

* tests: Replace errors.Is(err, nil) usage with testify and automate check

* refactor: Rename ExtractPort to ExtractPortOrDefault

* tests: Replace assert with require for error handling in multiple test files

* tests: Replace assert with require for error handling and improve assertions in data tests

* tests: Fix typo in assertion message for StreamVol test

* OKX: Fix GetOpenInterestAndVolumeStrike test with instrument selection and improved assertions

* OKX: Revert intentional error check

* Improve error message for expiry time check in GetOpenInterestAndVolumeStrike test
2025-05-28 12:26:51 +10:00

189 lines
4.3 KiB
Go

package database
import (
"database/sql"
"errors"
"os"
"path/filepath"
"testing"
_ "github.com/mattn/go-sqlite3"
"github.com/stretchr/testify/assert"
)
func TestSetConfig(t *testing.T) {
t.Parallel()
inst := &Instance{}
err := inst.SetConfig(&Config{Verbose: true})
assert.NoError(t, err)
err = inst.SetConfig(nil)
if !errors.Is(err, ErrNilConfig) {
t.Errorf("received %v, expected %v", err, ErrNilConfig)
}
inst = nil
err = inst.SetConfig(&Config{})
if !errors.Is(err, ErrNilInstance) {
t.Errorf("received %v, expected %v", err, ErrNilInstance)
}
}
func TestSetSQLiteConnection(t *testing.T) {
t.Parallel()
inst := &Instance{}
err := inst.SetSQLiteConnection(nil)
if !errors.Is(err, errNilSQL) {
t.Errorf("received %v, expected %v", err, errNilSQL)
}
err = inst.SetSQLiteConnection(&sql.DB{})
assert.NoError(t, err)
inst = nil
err = inst.SetSQLiteConnection(nil)
if !errors.Is(err, ErrNilInstance) {
t.Errorf("received %v, expected %v", err, ErrNilInstance)
}
}
func TestSetPostgresConnection(t *testing.T) {
// there is nothing actually requiring a postgres connection specifically
// so this is testing the checks and the ability to set values
// however, such settings would be bad for a sqlite connection irl
t.Parallel()
inst := &Instance{}
databaseFullLocation := filepath.Join(DB.DataPath, "TestSetPostgresConnection")
con, err := sql.Open("sqlite3", databaseFullLocation)
assert.NoError(t, err)
err = inst.SetPostgresConnection(con)
assert.NoError(t, err)
err = con.Close()
assert.NoError(t, err)
err = os.Remove(databaseFullLocation)
assert.NoError(t, err)
}
func TestSetConnected(t *testing.T) {
t.Parallel()
inst := &Instance{}
inst.SetConnected(true)
if !inst.connected {
t.Errorf("received %v, expected %v", false, true)
}
inst.SetConnected(false)
if inst.connected {
t.Errorf("received %v, expected %v", true, false)
}
}
func TestCloseConnection(t *testing.T) {
t.Parallel()
inst := &Instance{}
databaseFullLocation := filepath.Join(DB.DataPath, "TestCloseConnection")
con, err := sql.Open("sqlite3", databaseFullLocation)
assert.NoError(t, err)
err = inst.SetSQLiteConnection(con)
assert.NoError(t, err)
err = inst.CloseConnection()
assert.NoError(t, err)
}
func TestIsConnected(t *testing.T) {
t.Parallel()
inst := &Instance{}
inst.SetConnected(true)
if !inst.IsConnected() {
t.Errorf("received %v, expected %v", false, true)
}
inst.SetConnected(false)
if inst.IsConnected() {
t.Errorf("received %v, expected %v", true, false)
}
}
func TestGetConfig(t *testing.T) {
t.Parallel()
inst := &Instance{}
cfg := inst.GetConfig()
if cfg != nil {
t.Errorf("received %v, expected %v", cfg, nil)
}
err := inst.SetConfig(&Config{Enabled: true})
assert.NoError(t, err)
cfg = inst.GetConfig()
if cfg == nil {
t.Errorf("received %v, expected %v", cfg, &Config{Enabled: true})
}
}
func TestPing(t *testing.T) {
t.Parallel()
inst := &Instance{}
databaseFullLocation := filepath.Join(DB.DataPath, "TestPing")
con, err := sql.Open("sqlite3", databaseFullLocation)
assert.NoError(t, err)
err = inst.SetSQLiteConnection(con)
assert.NoError(t, err)
inst.SetConnected(true)
err = inst.Ping()
assert.NoError(t, err)
inst.SQL = nil
err = inst.Ping()
if !errors.Is(err, errNilSQL) {
t.Errorf("received %v, expected %v", err, errNilSQL)
}
inst.SetConnected(false)
err = inst.Ping()
if !errors.Is(err, ErrDatabaseNotConnected) {
t.Errorf("received %v, expected %v", err, ErrDatabaseNotConnected)
}
inst = nil
err = inst.Ping()
if !errors.Is(err, ErrNilInstance) {
t.Errorf("received %v, expected %v", err, ErrNilInstance)
}
err = con.Close()
assert.NoError(t, err)
err = os.Remove(databaseFullLocation)
assert.NoError(t, err)
}
func TestGetSQL(t *testing.T) {
t.Parallel()
inst := &Instance{}
_, err := inst.GetSQL()
if !errors.Is(err, errNilSQL) {
t.Errorf("received %v, expected %v", err, errNilSQL)
}
databaseFullLocation := filepath.Join(DB.DataPath, "TestGetSQL")
con, err := sql.Open("sqlite3", databaseFullLocation)
assert.NoError(t, err)
err = inst.SetSQLiteConnection(con)
assert.NoError(t, err)
_, err = inst.GetSQL()
assert.NoError(t, err)
inst = nil
_, err = inst.GetSQL()
if !errors.Is(err, ErrNilInstance) {
t.Errorf("received %v, expected %v", err, ErrNilInstance)
}
}