mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-18 15:10:03 +00:00
* Websocket: Use ErrSubscribedAlready instead of errChannelAlreadySubscribed * Subscriptions: Replace Pair with Pairs Given that some subscriptions have multiple pairs, support that as the standard. * Docs: Update subscriptions in add new exch * RPC: Update Subscription Pairs * Linter: Disable testifylint.Len We deliberately use Equal over Len to avoid spamming the contents of large Slices * Websocket: Add suffix to state consts * Binance: Subscription Pairs support * Bitfinex: Subscription Pairs support * Bithumb: Subscription Pairs support * Bitmex: Subscription Pairs support * Bitstamp: Subscription Pairs support * BTCMarkets: Subscription Pairs support * BTSE: Subscription Pairs support * Coinbase: Subscription Pairs support * Coinut: Subscription Pairs support * GateIO: Subscription Pairs support * Gemini: Subscription Pairs support and improvement * Hitbtc: Subscription Pairs support * Huboi: Subscription Pairs support * Kucoin: Subscription Pairs support * Okcoin: Subscription Pairs support * Poloniex: Subscription Pairs support * Kraken: Add subscription Pairs support Note: This is a naieve implementation because we want to rebase the kraken websocket rewrite on top of this * Bybit: Subscription Pairs support * Okx: Subscription Pairs support * Bitmex: Subsription configuration * Fixes unauthenticated websocket left as CanUseAuth * Fixes auth subs happening privately * CoinbasePro: Subscription Configuration * Consolidate ProductIDs when all subscriptions are for the same list * Websocket: Log actual sent message when Verbose * Subscriptions: Improve clarity of which key is which in Match * Subscriptions: Lint fix for HugeParam * Subscriptions: Add AddPairs and move keys from test * Subscriptions: Simplify subscription keys and add key types * Subscriptions: Add List.GroupPairs Rename sub.AddPairs * Subscription: Fix ExactKey not matching 0 pairs * Subscriptions: Remove unused IdentityKey and HasPairKey * Subscriptions: Fix GetKey test * Subscriptions: Test coverage improvements * Websocket: Change State on Add/Remove * Subscriptions: Improve error context * Subscriptions: Fix Enable: false subs not ignored * Bitfinex: Fix WsAuth test failing on DataHandler DataHandler is eaten by dataMonitor now, so we need to use ToRoutine * Deribit: Subscription Pairs support * Websocket: Accept nil lists for checkSubscriptions If the user passes in a nil (implicitly empty) list, we would not panic. Therefore the burden of correctness about that data lies with them. The list of subscriptions is empty, and that's okay, and possibly convenient * Websocket: Add context to NilPointer errors * Subscriptions: Add context to nil errors * Exchange: Fix error expectations in UnsubToWSChans
137 lines
5.2 KiB
Go
137 lines
5.2 KiB
Go
package subscription
|
|
|
|
import (
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/thrasher-corp/gocryptotrader/currency"
|
|
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
|
|
"github.com/thrasher-corp/gocryptotrader/exchanges/kline"
|
|
)
|
|
|
|
var (
|
|
btcusdtPair = currency.NewPair(currency.BTC, currency.USDT)
|
|
ethusdcPair = currency.NewPair(currency.ETH, currency.USDC)
|
|
ltcusdcPair = currency.NewPair(currency.LTC, currency.USDC)
|
|
)
|
|
|
|
// TestSubscriptionString exercises the String method
|
|
func TestSubscriptionString(t *testing.T) {
|
|
s := &Subscription{
|
|
Channel: "candles",
|
|
Asset: asset.Spot,
|
|
Pairs: currency.Pairs{btcusdtPair, ethusdcPair.Format(currency.PairFormat{Delimiter: "/"})},
|
|
}
|
|
assert.Equal(t, "candles spot BTC/USDT,ETH/USDC", s.String(), "Subscription String should return correct value")
|
|
}
|
|
|
|
// TestState exercises the state getter
|
|
func TestState(t *testing.T) {
|
|
t.Parallel()
|
|
s := &Subscription{}
|
|
assert.Equal(t, InactiveState, s.State(), "State should return initial state")
|
|
s.state = SubscribedState
|
|
assert.Equal(t, SubscribedState, s.State(), "State should return correct state")
|
|
}
|
|
|
|
// TestSetState exercises the state setter
|
|
func TestSetState(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
s := &Subscription{state: UnsubscribedState}
|
|
|
|
for i := InactiveState; i <= UnsubscribedState; i++ {
|
|
assert.NoErrorf(t, s.SetState(i), "State should not error setting state %s", i)
|
|
}
|
|
assert.ErrorIs(t, s.SetState(UnsubscribedState), ErrInStateAlready, "SetState should error on same state")
|
|
assert.ErrorIs(t, s.SetState(UnsubscribedState+1), ErrInvalidState, "Setting an invalid state should error")
|
|
}
|
|
|
|
// TestString exercises the Stringer implementation
|
|
func TestString(t *testing.T) {
|
|
s := &Subscription{
|
|
Channel: "candles",
|
|
Asset: asset.Spot,
|
|
Pairs: currency.Pairs{btcusdtPair},
|
|
}
|
|
_ = s.EnsureKeyed()
|
|
assert.Equal(t, "candles spot BTC/USDT", s.String(), "String with a MatchableKey")
|
|
s.Key = 42
|
|
assert.Equal(t, "42: candles spot BTC/USDT", s.String(), "String with a MatchableKey")
|
|
}
|
|
|
|
// TestEnsureKeyed exercises the key getter and ensures it sets a self-pointer key for non
|
|
func TestEnsureKeyed(t *testing.T) {
|
|
t.Parallel()
|
|
s := &Subscription{}
|
|
k1, ok := s.EnsureKeyed().(MatchableKey)
|
|
if assert.True(t, ok, "EnsureKeyed should return a MatchableKey") {
|
|
assert.Same(t, s, k1.GetSubscription(), "Key should point to the same struct")
|
|
}
|
|
type platypus string
|
|
s = &Subscription{
|
|
Key: platypus("Gerald"),
|
|
Channel: "orderbook",
|
|
}
|
|
k2 := s.EnsureKeyed()
|
|
assert.IsType(t, platypus(""), k2, "EnsureKeyed should return a platypus")
|
|
assert.Equal(t, s.Key, k2, "Key should be the key provided")
|
|
}
|
|
|
|
// TestSubscriptionMarshalling ensures json Marshalling is clean and concise
|
|
// Since there is no UnmarshalJSON, this just exercises the json field tags of Subscription, and regressions in conciseness
|
|
func TestSubscriptionMarshaling(t *testing.T) {
|
|
t.Parallel()
|
|
j, err := json.Marshal(&Subscription{Key: 42, Channel: CandlesChannel})
|
|
assert.NoError(t, err, "Marshalling should not error")
|
|
assert.Equal(t, `{"enabled":false,"channel":"candles"}`, string(j), "Marshalling should be clean and concise")
|
|
|
|
j, err = json.Marshal(&Subscription{Enabled: true, Channel: OrderbookChannel, Interval: kline.FiveMin, Levels: 4})
|
|
assert.NoError(t, err, "Marshalling should not error")
|
|
assert.Equal(t, `{"enabled":true,"channel":"orderbook","interval":"5m","levels":4}`, string(j), "Marshalling should be clean and concise")
|
|
|
|
j, err = json.Marshal(&Subscription{Enabled: true, Channel: OrderbookChannel, Interval: kline.FiveMin, Levels: 4, Pairs: currency.Pairs{currency.NewPair(currency.BTC, currency.USDT)}})
|
|
assert.NoError(t, err, "Marshalling should not error")
|
|
assert.Equal(t, `{"enabled":true,"channel":"orderbook","pairs":"BTCUSDT","interval":"5m","levels":4}`, string(j), "Marshalling should be clean and concise")
|
|
|
|
j, err = json.Marshal(&Subscription{Enabled: true, Channel: MyTradesChannel, Authenticated: true})
|
|
assert.NoError(t, err, "Marshalling should not error")
|
|
assert.Equal(t, `{"enabled":true,"channel":"myTrades","authenticated":true}`, string(j), "Marshalling should be clean and concise")
|
|
}
|
|
|
|
// TestClone exercises Clone
|
|
func TestClone(t *testing.T) {
|
|
a := &Subscription{
|
|
Channel: TickerChannel,
|
|
Interval: kline.OneHour,
|
|
Pairs: currency.Pairs{btcusdtPair},
|
|
Params: map[string]any{"a": 42},
|
|
}
|
|
a.EnsureKeyed()
|
|
b := a.Clone()
|
|
assert.IsType(t, new(Subscription), b, "Clone must return a Subscription pointer")
|
|
assert.NotSame(t, a, b, "Clone should return a new Subscription")
|
|
assert.Nil(t, b.Key, "Clone should have a nil key")
|
|
b.Pairs[0] = ethusdcPair
|
|
assert.Equal(t, btcusdtPair, a.Pairs[0], "Pairs should be (relatively) deep copied")
|
|
b.Params["a"] = 12
|
|
assert.Equal(t, 42, a.Params["a"], "Params should be (relatively) deep copied")
|
|
a.m.Lock()
|
|
assert.True(t, b.m.TryLock(), "Clone must use a different Mutex")
|
|
}
|
|
|
|
// TestSetKey exercises SetKey
|
|
func TestSetKey(t *testing.T) {
|
|
s := &Subscription{}
|
|
s.SetKey(14)
|
|
assert.Equal(t, 14, s.Key, "SetKey should set a key correctly")
|
|
}
|
|
|
|
// TestSetPairs exercises SetPairs
|
|
func TestSetPairs(t *testing.T) {
|
|
s := &Subscription{}
|
|
s.SetPairs(currency.Pairs{btcusdtPair})
|
|
assert.Equal(t, "BTCUSDT", s.Pairs.Join(), "SetPairs should set a key correctly")
|
|
}
|