Files
gocryptotrader/exchanges/yobit/yobit_wrapper.go
Gareth Kirwan 73e200e4e7 accounts: Move to instance methods, fix races and isolate tests (#1923)
* Bybit: Fix race in TestUpdateAccountInfo and  TestWSHandleData

* DriveBy rename TestWSHandleData
* This doesn't address running with -race=2+ due to the singleton

* Accounts: Add account.GetService()

* exchange: Assertify TestSetupDefaults

* Exchanges: Add account.Service override for testing

* Exchanges: Remove duplicate IsWebsocketEnabled test from TestSetupDefaults

* Dispatch: Replace nil checks with NilGuard

* Engine: Remove deprecated printAccountHoldingsChangeSummary

* Dispatcher: Add EnsureRunning method

* Accounts: Move singleton accounts service to exchange Accounts

* Move singleton accounts service to exchange Accounts

This maintains the concept of a global store, whilst allowing exchanges
to override it when needed, particularly for testing.

APIServer:

* Remove getAllActiveAccounts from apiserver

Deprecated apiserver only thing using this, so remove it instead of
updating it

* Update comment for UpdateAccountBalances everywhere

* Docs: Add punctuation to function comments

* Bybit: Coverage for wsProcessWalletPushData Save
2025-10-28 13:52:45 +11:00

680 lines
20 KiB
Go

package yobit
import (
"context"
"errors"
"fmt"
"math"
"sort"
"strconv"
"time"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/config"
"github.com/thrasher-corp/gocryptotrader/currency"
"github.com/thrasher-corp/gocryptotrader/exchange/accounts"
exchange "github.com/thrasher-corp/gocryptotrader/exchanges"
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
"github.com/thrasher-corp/gocryptotrader/exchanges/deposit"
"github.com/thrasher-corp/gocryptotrader/exchanges/fundingrate"
"github.com/thrasher-corp/gocryptotrader/exchanges/futures"
"github.com/thrasher-corp/gocryptotrader/exchanges/kline"
"github.com/thrasher-corp/gocryptotrader/exchanges/order"
"github.com/thrasher-corp/gocryptotrader/exchanges/orderbook"
"github.com/thrasher-corp/gocryptotrader/exchanges/protocol"
"github.com/thrasher-corp/gocryptotrader/exchanges/request"
"github.com/thrasher-corp/gocryptotrader/exchanges/ticker"
"github.com/thrasher-corp/gocryptotrader/exchanges/trade"
"github.com/thrasher-corp/gocryptotrader/log"
"github.com/thrasher-corp/gocryptotrader/portfolio/withdraw"
)
// SetDefaults sets current default value for Yobit
func (e *Exchange) SetDefaults() {
e.Name = "Yobit"
e.Enabled = true
e.Verbose = true
e.API.CredentialsValidator.RequiresKey = true
e.API.CredentialsValidator.RequiresSecret = true
requestFmt := &currency.PairFormat{Delimiter: currency.UnderscoreDelimiter, Separator: currency.DashDelimiter}
configFmt := &currency.PairFormat{Delimiter: currency.UnderscoreDelimiter, Uppercase: true}
err := e.SetGlobalPairsManager(requestFmt, configFmt, asset.Spot)
if err != nil {
log.Errorln(log.ExchangeSys, err)
}
e.Features = exchange.Features{
Supports: exchange.FeaturesSupported{
REST: true,
Websocket: false,
RESTCapabilities: protocol.Features{
TickerBatching: true,
TickerFetching: true,
TradeFetching: true,
OrderbookFetching: true,
AutoPairUpdates: true,
AccountInfo: true,
GetOrder: true,
GetOrders: true,
CancelOrder: true,
UserTradeHistory: true,
CryptoDeposit: true,
CryptoWithdrawal: true,
TradeFee: true,
FiatDepositFee: true,
FiatWithdrawalFee: true,
CryptoWithdrawalFee: true,
},
WithdrawPermissions: exchange.AutoWithdrawCryptoWithAPIPermission |
exchange.WithdrawFiatViaWebsiteOnly,
},
Enabled: exchange.FeaturesEnabled{
AutoPairUpdates: true,
},
}
e.Requester, err = request.New(e.Name,
common.NewHTTPClientWithTimeout(exchange.DefaultHTTPTimeout),
// Server responses are cached every 2 seconds.
request.WithLimiter(request.NewBasicRateLimit(time.Second, 1, 1)))
if err != nil {
log.Errorln(log.ExchangeSys, err)
}
e.API.Endpoints = e.NewEndpoints()
err = e.API.Endpoints.SetDefaultEndpoints(map[exchange.URL]string{
exchange.RestSpot: apiPublicURL,
exchange.RestSpotSupplementary: apiPrivateURL,
})
if err != nil {
log.Errorln(log.ExchangeSys, err)
}
}
// Setup sets exchange configuration parameters for Yobit
func (e *Exchange) Setup(exch *config.Exchange) error {
if err := exch.Validate(); err != nil {
return err
}
if !exch.Enabled {
e.SetEnabled(false)
return nil
}
return e.SetupDefaults(exch)
}
// FetchTradablePairs returns a list of the exchanges tradable pairs
func (e *Exchange) FetchTradablePairs(ctx context.Context, _ asset.Item) (currency.Pairs, error) {
info, err := e.GetInfo(ctx)
if err != nil {
return nil, err
}
pairs := make([]currency.Pair, len(info.Pairs))
var target int
for key := range info.Pairs {
var pair currency.Pair
pair, err = currency.NewPairFromString(key)
if err != nil {
return nil, err
}
pairs[target] = pair
target++
}
return pairs, nil
}
// UpdateTradablePairs updates the exchanges available pairs and stores
// them in the exchanges config
func (e *Exchange) UpdateTradablePairs(ctx context.Context) error {
pairs, err := e.FetchTradablePairs(ctx, asset.Spot)
if err != nil {
return err
}
if err := e.UpdatePairs(pairs, asset.Spot, false); err != nil {
return err
}
return e.EnsureOnePairEnabled()
}
// UpdateTickers updates the ticker for all currency pairs of a given asset type
func (e *Exchange) UpdateTickers(ctx context.Context, a asset.Item) error {
enabledPairs, err := e.GetEnabledPairs(a)
if err != nil {
return err
}
pairsCollated, err := e.FormatExchangeCurrencies(enabledPairs, a)
if err != nil {
return err
}
result, err := e.GetTicker(ctx, pairsCollated)
if err != nil {
return err
}
for i := range enabledPairs {
fPair, err := e.FormatExchangeCurrency(enabledPairs[i], a)
if err != nil {
return err
}
curr := fPair.Lower().String()
if _, ok := result[curr]; !ok {
continue
}
resultCurr := result[curr]
err = ticker.ProcessTicker(&ticker.Price{
Pair: enabledPairs[i],
Last: resultCurr.Last,
Ask: resultCurr.Sell,
Bid: resultCurr.Buy,
Low: resultCurr.Low,
QuoteVolume: resultCurr.VolumeCurrent,
Volume: resultCurr.Vol,
ExchangeName: e.Name,
AssetType: a,
})
if err != nil {
return err
}
}
return nil
}
// UpdateTicker updates and returns the ticker for a currency pair
func (e *Exchange) UpdateTicker(ctx context.Context, p currency.Pair, a asset.Item) (*ticker.Price, error) {
if err := e.UpdateTickers(ctx, a); err != nil {
return nil, err
}
return ticker.GetTicker(e.Name, p, a)
}
// UpdateOrderbook updates and returns the orderbook for a currency pair
func (e *Exchange) UpdateOrderbook(ctx context.Context, p currency.Pair, assetType asset.Item) (*orderbook.Book, error) {
if p.IsEmpty() {
return nil, currency.ErrCurrencyPairEmpty
}
if err := e.CurrencyPairs.IsAssetEnabled(assetType); err != nil {
return nil, err
}
book := &orderbook.Book{
Exchange: e.Name,
Pair: p,
Asset: assetType,
ValidateOrderbook: e.ValidateOrderbook,
}
fPair, err := e.FormatExchangeCurrency(p, assetType)
if err != nil {
return book, err
}
orderbookNew, err := e.GetDepth(ctx, fPair.String())
if err != nil {
return book, err
}
for i := range orderbookNew.Bids {
book.Bids = append(book.Bids,
orderbook.Level{
Price: orderbookNew.Bids[i][0],
Amount: orderbookNew.Bids[i][1],
})
}
for i := range orderbookNew.Asks {
book.Asks = append(book.Asks,
orderbook.Level{
Price: orderbookNew.Asks[i][0],
Amount: orderbookNew.Asks[i][1],
})
}
err = book.Process()
if err != nil {
return book, err
}
return orderbook.Get(e.Name, p, assetType)
}
// UpdateAccountBalances retrieves currency balances
func (e *Exchange) UpdateAccountBalances(ctx context.Context, assetType asset.Item) (accounts.SubAccounts, error) {
resp, err := e.GetAccountInformation(ctx)
if err != nil {
return nil, err
}
subAccts := accounts.SubAccounts{accounts.NewSubAccount(assetType, "")}
for curr, bal := range resp.FundsInclOrders {
subAccts[0].Balances.Set(currency.NewCode(curr), accounts.Balance{
Total: bal,
Hold: bal, // Hold = FundsInclOrders balance - Funds balance; So we Set total here and then subtract Funds below
})
}
for curr, bal := range resp.Funds {
if err := subAccts[0].Balances.Add(currency.NewCode(curr), accounts.Balance{
Free: bal,
Hold: -bal, // Hold = FundsInclOrders balance - Funds balance; so we Set total above and now subtract Funds here
}); err != nil {
return nil, err
}
}
return subAccts, e.Accounts.Save(ctx, subAccts, true)
}
// GetAccountFundingHistory returns funding history, deposits and
// withdrawals
func (e *Exchange) GetAccountFundingHistory(_ context.Context) ([]exchange.FundingHistory, error) {
return nil, common.ErrFunctionNotSupported
}
// GetWithdrawalsHistory returns previous withdrawals data
func (e *Exchange) GetWithdrawalsHistory(_ context.Context, _ currency.Code, _ asset.Item) ([]exchange.WithdrawalHistory, error) {
return nil, common.ErrFunctionNotSupported
}
// GetRecentTrades returns the most recent trades for a currency and asset
func (e *Exchange) GetRecentTrades(ctx context.Context, p currency.Pair, assetType asset.Item) ([]trade.Data, error) {
var err error
p, err = e.FormatExchangeCurrency(p, assetType)
if err != nil {
return nil, err
}
var tradeData []Trade
tradeData, err = e.GetTrades(ctx, p.String())
if err != nil {
return nil, err
}
resp := make([]trade.Data, len(tradeData))
for i := range tradeData {
side := order.Buy
if tradeData[i].Type == "ask" {
side = order.Sell
}
resp[i] = trade.Data{
Exchange: e.Name,
TID: strconv.FormatInt(tradeData[i].TID, 10),
CurrencyPair: p,
AssetType: assetType,
Side: side,
Price: tradeData[i].Price,
Amount: tradeData[i].Amount,
Timestamp: tradeData[i].Timestamp.Time(),
}
}
err = e.AddTradesToBuffer(resp...)
if err != nil {
return nil, err
}
sort.Sort(trade.ByDate(resp))
return resp, nil
}
// GetHistoricTrades returns historic trade data within the timeframe provided
func (e *Exchange) GetHistoricTrades(_ context.Context, _ currency.Pair, _ asset.Item, _, _ time.Time) ([]trade.Data, error) {
return nil, common.ErrFunctionNotSupported
}
// SubmitOrder submits a new order
// Yobit only supports limit orders
func (e *Exchange) SubmitOrder(ctx context.Context, s *order.Submit) (*order.SubmitResponse, error) {
if err := s.Validate(e.GetTradingRequirements()); err != nil {
return nil, err
}
if s.Type != order.Limit {
return nil, errors.New("only limit orders are allowed")
}
fPair, err := e.FormatExchangeCurrency(s.Pair, s.AssetType)
if err != nil {
return nil, err
}
response, err := e.Trade(ctx,
fPair.String(),
s.Side.String(),
s.Amount,
s.Price)
if err != nil {
return nil, err
}
return s.DeriveSubmitResponse(strconv.FormatInt(response, 10))
}
// ModifyOrder modifies an existing order
func (e *Exchange) ModifyOrder(context.Context, *order.Modify) (*order.ModifyResponse, error) {
return nil, common.ErrFunctionNotSupported
}
// CancelOrder cancels an order by its corresponding ID number
func (e *Exchange) CancelOrder(ctx context.Context, o *order.Cancel) error {
if err := o.Validate(o.StandardCancel()); err != nil {
return err
}
orderIDInt, err := strconv.ParseInt(o.OrderID, 10, 64)
if err != nil {
return err
}
return e.CancelExistingOrder(ctx, orderIDInt)
}
// CancelBatchOrders cancels an orders by their corresponding ID numbers
func (e *Exchange) CancelBatchOrders(_ context.Context, _ []order.Cancel) (*order.CancelBatchResponse, error) {
return nil, common.ErrFunctionNotSupported
}
// CancelAllOrders cancels all orders associated with a currency pair
func (e *Exchange) CancelAllOrders(ctx context.Context, _ *order.Cancel) (order.CancelAllResponse, error) {
cancelAllOrdersResponse := order.CancelAllResponse{
Status: make(map[string]string),
}
enabledPairs, err := e.GetEnabledPairs(asset.Spot)
if err != nil {
return cancelAllOrdersResponse, err
}
allActiveOrders := make([]map[string]ActiveOrders, len(enabledPairs))
for i := range enabledPairs {
fCurr, err := e.FormatExchangeCurrency(enabledPairs[i], asset.Spot)
if err != nil {
return cancelAllOrdersResponse, err
}
activeOrdersForPair, err := e.GetOpenOrders(ctx, fCurr.String())
if err != nil {
return cancelAllOrdersResponse, err
}
allActiveOrders[i] = activeOrdersForPair
}
for i := range allActiveOrders {
for key := range allActiveOrders[i] {
orderIDInt, err := strconv.ParseInt(key, 10, 64)
if err != nil {
cancelAllOrdersResponse.Status[key] = err.Error()
continue
}
err = e.CancelExistingOrder(ctx, orderIDInt)
if err != nil {
cancelAllOrdersResponse.Status[key] = err.Error()
}
}
}
return cancelAllOrdersResponse, nil
}
// GetOrderInfo returns order information based on order ID
func (e *Exchange) GetOrderInfo(ctx context.Context, orderID string, _ currency.Pair, _ asset.Item) (*order.Detail, error) {
iOID, err := strconv.ParseInt(orderID, 10, 64)
if err != nil {
return nil, err
}
format, err := e.GetPairFormat(asset.Spot, false)
if err != nil {
return nil, err
}
resp, err := e.GetOrderInformation(ctx, iOID)
if err != nil {
return nil, err
}
for id, orderInfo := range resp {
if id != orderID {
continue
}
var symbol currency.Pair
symbol, err = currency.NewPairDelimiter(orderInfo.Pair, format.Delimiter)
if err != nil {
return nil, err
}
var side order.Side
side, err = order.StringToOrderSide(orderInfo.Type)
if err != nil {
return nil, err
}
return &order.Detail{
OrderID: id,
Amount: orderInfo.Amount,
Price: orderInfo.Rate,
Side: side,
Date: orderInfo.TimestampCreated.Time(),
Pair: symbol,
Exchange: e.Name,
}, nil
}
return nil, fmt.Errorf("%w %v", order.ErrOrderNotFound, orderID)
}
// GetDepositAddress returns a deposit address for a specified currency
func (e *Exchange) GetDepositAddress(ctx context.Context, cryptocurrency currency.Code, _, _ string) (*deposit.Address, error) {
if cryptocurrency.Equal(currency.XRP) {
// {"success":1,"return":{"status":"online","blocks":65778672,"address":996707783,"processed_amount":0.00000000,"server_time":1629425030}}
return nil, errors.New("XRP isn't supported as the API does not return a valid address")
}
addr, err := e.GetCryptoDepositAddress(ctx, cryptocurrency.String(), false)
if err != nil {
return nil, err
}
return &deposit.Address{Address: addr.Return.Address}, nil
}
// WithdrawCryptocurrencyFunds returns a withdrawal ID when a withdrawal is
// submitted
func (e *Exchange) WithdrawCryptocurrencyFunds(ctx context.Context, withdrawRequest *withdraw.Request) (*withdraw.ExchangeResponse, error) {
if err := withdrawRequest.Validate(); err != nil {
return nil, err
}
resp, err := e.WithdrawCoinsToAddress(ctx,
withdrawRequest.Currency.String(),
withdrawRequest.Amount,
withdrawRequest.Crypto.Address)
if err != nil {
return nil, err
}
if resp.Error != "" {
return nil, errors.New(resp.Error)
}
return &withdraw.ExchangeResponse{}, nil
}
// WithdrawFiatFunds returns a withdrawal ID when a
// withdrawal is submitted
func (e *Exchange) WithdrawFiatFunds(_ context.Context, _ *withdraw.Request) (*withdraw.ExchangeResponse, error) {
return nil, common.ErrFunctionNotSupported
}
// WithdrawFiatFundsToInternationalBank returns a withdrawal ID when a
// withdrawal is submitted
func (e *Exchange) WithdrawFiatFundsToInternationalBank(_ context.Context, _ *withdraw.Request) (*withdraw.ExchangeResponse, error) {
return nil, common.ErrFunctionNotSupported
}
// GetFeeByType returns an estimate of fee based on type of transaction
func (e *Exchange) GetFeeByType(ctx context.Context, feeBuilder *exchange.FeeBuilder) (float64, error) {
if feeBuilder == nil {
return 0, fmt.Errorf("%T %w", feeBuilder, common.ErrNilPointer)
}
if !e.AreCredentialsValid(ctx) && // Todo check connection status
feeBuilder.FeeType == exchange.CryptocurrencyTradeFee {
feeBuilder.FeeType = exchange.OfflineTradeFee
}
return e.GetFee(feeBuilder)
}
// GetActiveOrders retrieves any orders that are active/open
func (e *Exchange) GetActiveOrders(ctx context.Context, req *order.MultiOrderRequest) (order.FilteredOrders, error) {
err := req.Validate()
if err != nil {
return nil, err
}
format, err := e.GetPairFormat(asset.Spot, false)
if err != nil {
return nil, err
}
var orders []order.Detail
for x := range req.Pairs {
var fCurr currency.Pair
fCurr, err = e.FormatExchangeCurrency(req.Pairs[x], asset.Spot)
if err != nil {
return nil, err
}
var resp map[string]ActiveOrders
resp, err = e.GetOpenOrders(ctx, fCurr.String())
if err != nil {
return nil, err
}
for id := range resp {
var symbol currency.Pair
symbol, err = currency.NewPairDelimiter(resp[id].Pair, format.Delimiter)
if err != nil {
return nil, err
}
var side order.Side
side, err = order.StringToOrderSide(resp[id].Type)
if err != nil {
return nil, err
}
orders = append(orders, order.Detail{
OrderID: id,
Amount: resp[id].Amount,
Price: resp[id].Rate,
Side: side,
Date: resp[id].TimestampCreated.Time(),
Pair: symbol,
Exchange: e.Name,
})
}
}
return req.Filter(e.Name, orders), nil
}
// GetOrderHistory retrieves account order information
// Can Limit response to specific order status
func (e *Exchange) GetOrderHistory(ctx context.Context, req *order.MultiOrderRequest) (order.FilteredOrders, error) {
err := req.Validate()
if err != nil {
return nil, err
}
var allOrders []TradeHistory
for x := range req.Pairs {
var fPair currency.Pair
fPair, err = e.FormatExchangeCurrency(req.Pairs[x], asset.Spot)
if err != nil {
return nil, err
}
var resp map[string]TradeHistory
resp, err = e.GetTradeHistory(ctx,
0,
10000,
math.MaxInt64,
req.StartTime.Unix(),
req.EndTime.Unix(),
"DESC",
fPair.String())
if err != nil {
return nil, err
}
for key := range resp {
allOrders = append(allOrders, resp[key])
}
}
format, err := e.GetPairFormat(asset.Spot, false)
if err != nil {
return nil, err
}
orders := make([]order.Detail, len(allOrders))
for i := range allOrders {
var pair currency.Pair
pair, err = currency.NewPairDelimiter(allOrders[i].Pair, format.Delimiter)
if err != nil {
return nil, err
}
var side order.Side
side, err = order.StringToOrderSide(allOrders[i].Type)
if err != nil {
return nil, err
}
detail := order.Detail{
OrderID: strconv.FormatFloat(allOrders[i].OrderID, 'f', -1, 64),
Amount: allOrders[i].Amount,
ExecutedAmount: allOrders[i].Amount,
Price: allOrders[i].Rate,
AverageExecutedPrice: allOrders[i].Rate,
Side: side,
Status: order.Filled,
Date: allOrders[i].Timestamp.Time(),
Pair: pair,
Exchange: e.Name,
}
detail.InferCostsAndTimes()
orders[i] = detail
}
return req.Filter(e.Name, orders), nil
}
// ValidateAPICredentials validates current credentials used for wrapper functionality
func (e *Exchange) ValidateAPICredentials(ctx context.Context, assetType asset.Item) error {
_, err := e.UpdateAccountBalances(ctx, assetType)
return e.CheckTransientError(err)
}
// GetHistoricCandles returns candles between a time period for a set time interval
func (e *Exchange) GetHistoricCandles(_ context.Context, _ currency.Pair, _ asset.Item, _ kline.Interval, _, _ time.Time) (*kline.Item, error) {
return nil, common.ErrFunctionNotSupported
}
// GetHistoricCandlesExtended returns candles between a time period for a set time interval
func (e *Exchange) GetHistoricCandlesExtended(_ context.Context, _ currency.Pair, _ asset.Item, _ kline.Interval, _, _ time.Time) (*kline.Item, error) {
return nil, common.ErrFunctionNotSupported
}
// GetServerTime returns the current exchange server time.
func (e *Exchange) GetServerTime(ctx context.Context, _ asset.Item) (time.Time, error) {
info, err := e.GetInfo(ctx)
if err != nil {
return time.Time{}, err
}
return info.ServerTime.Time(), nil
}
// GetFuturesContractDetails returns all contracts from the exchange by asset type
func (e *Exchange) GetFuturesContractDetails(context.Context, asset.Item) ([]futures.Contract, error) {
return nil, common.ErrFunctionNotSupported
}
// GetLatestFundingRates returns the latest funding rates data
func (e *Exchange) GetLatestFundingRates(context.Context, *fundingrate.LatestRateRequest) ([]fundingrate.LatestRateResponse, error) {
return nil, common.ErrFunctionNotSupported
}
// UpdateOrderExecutionLimits updates order execution limits
func (e *Exchange) UpdateOrderExecutionLimits(_ context.Context, _ asset.Item) error {
return common.ErrNotYetImplemented
}
// GetCurrencyTradeURL returns the URL to the exchange's trade page for the given asset and currency pair
func (e *Exchange) GetCurrencyTradeURL(_ context.Context, a asset.Item, cp currency.Pair) (string, error) {
_, err := e.CurrencyPairs.IsPairEnabled(cp, a)
if err != nil {
return "", err
}
cp.Delimiter = currency.ForwardSlashDelimiter
return tradeBaseURL + cp.Upper().String(), nil
}