* Attempts to update orderbook so it doesn't need to sort
* Reverts the ws ob stuff. Gets rid of sorting because it happens later. Adds some exchange features
* update existing feature lists. Expands list definition to match my emotions
* Adds bithumb bitmex and bitstamp. adds a couple more types
* Features for you, features for me, features for bittrex, btcmarkets, btse, coinbasepro, coinut, exmo, gateio and gemini
* Features for hitbtc, huobi, itbit, kraken, lakebtc, lbank, localbitcoins, okcoin, okex, poloniex, yobit, zb
* Who can forget good old alphapoint?
* Adds btcmarksets websocket :glitch_crab: fixes alphapoint features
* Adds extra data not in the documentation :/
* Replaces websocket features by using protocol features. However, it breaks it due to import cycles. I'm not sure what I'll do just yet
* Removes import cycle via duplicate structs.
* Increases coverage of config with `TestCheckCurrencyConfigValues`. Moves all currency pair package types into their own files or places it at the bottom of files if necessary
* Increase coverage in code.go
* One way of determining a test has failed, is when to it fails. Removed redundant explanation
* Increases code coverage of conversion
* Lint fixes
* Fixes orderbook tests
* Re-adds sorting because its important to still have the internal pre-processed orderbook to be representative of a real orderbook
* Secret lints that did not show up via Windows linting
* Adds protocol package to contain exchange features
* Fixes protocol implementation
* Fixes ws tests
* Addresses the following: Removes st-st-stutters in config types, changes GetAvailableForexProviders -> GetSupportedForexProviders, removes errors from tests where error is nil, removes orderbook setup when not necessary, removes import newlines, removes false bools from declaration, changes should of to should have
* imports and casing
* Fixes two more nil error checks
* Fix issue for ANX live testing, incorrect format directive
* Used cpy of Balances as param for Bitstamp function, added space for ANX fatal error.
* Fix linter issue
* Drop struct field for balance and localised a variable in each individual getfee call as needed
* Really basic getSimulated fee function everywhere
* Worst case fees for all exchanges
* Adds tests, fixes comment spacing. Adds wrapper logic. Makes test api key var name consistent. Removes some okcoin ETT tests
* Removes redundant functions
* linting issues. Fixes introduces huobi issues
* More linting
* Stops trying to hide ETT problems, uses iota
* Skips ETT tests for now
* updated golangci config to enable hugeparam linter
* ModifyOrder struct usage converted to a pointer
* OrderBook conversion to struct
* More conversion of large structs to pointers
* updated golangci config to enable hugeparam linter
* ModifyOrder struct usage converted to a pointer
* OrderBook conversion to struct
* More conversion of large structs to pointers
* disabled hugeParam check for golang again
* changed based on suggested feedback and fix for no default provider
* fixed typing
* Updated SetAPIURL() & UpdateConfig() to use pointers
* Withdraw functions now take a pointer to withdrawrequest struct
* Fund Withdraw is now a pointer
* Moved GetFee functions to use a pointer due to large size of feebuilder struct
* OrderCancellation usage converted to pointer due to size of struct
* merged up upstream/master and changes made to OKgroup code
* GetOrdersRequest usage converted to a pointer
* okgroup pointer migration
* reverted golangci config back to master
* removed old anx benchmark typo
* Initial currency overhaul before service system implementation
* Remove redundant currency string in orderbook.Base
Unexport lastupdated field in orderbook.Base as it was being instantiated multiple times
Add error handling for process orderbook
* Remove redundant currency string in ticker.Price
Unexport lastupdated field in ticker.Price
Add error handling for process ticker function and fix tests
* Phase Two Update
* Update translations to use map type - thankyou to kempeng for spotting this
* Change pair method name from Display -> Format for better readability
* Fixes misspelling and tests
* Implement requested changes from GloriousCode
* Remove reduntant function and streamlined return in currency_translation.go
* Revert pair method naming conventions
* Change currency naming conventions
* Changed code type to exported Item type with underlying string to reduce complexity
* Added interim orderbook process method to orderbook.Base type
* Changed feebuilder struct field to currency.Pair
* Adds fall over system for backup fx providers
* deprecate function and children and fix linter issue with btcmarkets
* Fixed requested changes
* Fix bug and move mtx for rates
* Fixed after rebase oopsies
* Fix linter issues
* Fixes race conditions in testing functions
* Final phase coinmarketcap update
* fix linter issues
* Implement requested changes
* Adds configuration variables to increase/decrease time durations between updating currency file and fetching new currency rates
* Add a collection of tests to improve codecov
* After rebase oopsy fixes for btse
* Fix requested changes
* fix after rebase oopsies and add more efficient comparison checks within currency pair
* Fix linter issues
* Adds signature to all exchange wrappers
* Adds funky new OrderHistoryRequest type. Updates signature for GetOrderHistory to use funky new type. Adds tests for GetOrderHistory on all exchanges. Implements GetOrderHistory for ANX
* Fixes alphapoint, bitstamp, itbit, zb tests. Adds exchange functions FilterOrdersByStatusAndType, FilterOrdersByTickRange, FilterOrdersByCurrencies to easily filter returned orders. Adds tests for filters. Implements GetOrderHistory wrapper for Binance, bitfinex, bithumb, bitmex. Adds new filter funcs to implementations.
* Adds bitstamp wrapper support
* Splits up GetOrderHistory into GetOpenOrders and GetOrderHistory wraapper functions to distinguish between active and past. Renames exchange.GetOrderHistoryRequest to exchange.GetOrdersRequest. Renames any API exchange method named GetOpenOrders to GetActiveOrders. Adds test function TestGetOpenOrders for each exchange
* Reimplements the split GetOrders and GetOrderHistory for alphapoint, anx, binance, bitfinex, bithumb, bitmex, bitstamp and bittrex. Renames orderType, orderStatus constants. Adds new exchange.FilterOrdersBySide and exchange.FilterOrdersByType and removes old exchange.FilterOrdersByStatusAndType.
* Changes orderHistoryRequest to use currencypair array instead of strings, also adds fees and trade breakdown. Removes if statement preventing ANX/BTCMarkets testing. Implements Active order + Order history retrieval for Bittrex and BTCMarkets.
* Adds support for coinut and coinbasepro
* Adds Exmo support
* Adds GateIO support
* Adds Gemini support
* Adds hitbtc, huobi, hadax, itbit, kraken support for open orders & order history. Fixes switch case break and fallthroughs. Adds filtering to gateio and gemini results
* Adds support for LakeBTC, Liqui, Localbitcoin, OKCoin, OKEX
* Adds poloniex support
* Adds Wex support
* Adds Yobit support. Updates Wex support
* Adds ZB support. Removes ArrangeActAssert from tests
* Changes baseCurrency + quoteCurrency exchange.OrderDetail properties to a pair.CurrencyPair. Adds exchange name to all implementations. Fixes EXMO TestSetup
* Removes verbose setting from tests as verbosity increases the amount of noise return when testing. Noise is only helpful when debugging tests to get more helpful information to resolve the issue and so it is unnecessary to have such lengthy output when testing in bulk or via Travis CI. This commit therefore improves readability when there are no issues
* Fixes issue where gemini test sandbox api url was overridden. Handles blank response from Gemini
* Fixes verbose typo
* Removes spacing for old act assert test comments. Limits previous infinite loop to 10
* Fixes issue with filtering where orderside is never specified
* Uses proper capitalisation for ServerOrderID and OpenOrders. Reverts commenting out orde_id param for bithumb.GetOrderDetails. Removes unnecessary int logic
* Removes JSON ID fields. Uses map where appropriate for exchange order side/type. Updates OrderDetail/GetOrdersRequest type to use time fields. Remvoes comments. Removes inappropriate variable name. Adds AccountID field for alphapoint. Fixes log message formatting. Lowers errorfs to warnfs for time conversion
* Adds missed files
* Removes blank line
* Adds sorting options for orders. Adds concurrency warnings in comments. Adds test for NewCurrencyPairWithDelimiter. Removes (e *Base) from filter funcs. Updates references to filter funcs
* Fixes rebase issues. Condenses append loops.
* Fixes more receive typos. Removes some inline strings. Adds AskOrderSide and BidOrderSide. Removes hypothetical infinite loop
* Fixes issue where allTrades wasn't used in loop. Fixes assignment/typing issues
* Fixes formatting
* Add get deposit address and fix authentication issue for ZB exchange
* Add get deposit address for Yobit exchange
* Add get deposit address for Poloniex exchange
* Add get deposit address for LocalBitcoins exchange
* Remove support for deposit address on Liqui exchange
* Add get deposit address for LakeBTC exchange
* Add notes as to the reason of non implementation
* Add get deposit address for Kraken exchange
* Add get deposit address for HitBTC exchange
* Add get deposit address for GateIO exchange
* Add get deposit address for Exmo exchange
* Remove support for deposit address on Coinut exchange
* Add test case for BTC Markets function still not supported yet.
* Add get deposit address for Bittrex exchange
* Add get deposit address for Bitstamp exchange
* Add get deposit address for Bitmex exchange
Rm unused swagger.json file in Bitmex exchange
* Add get deposit address for Bithumb exchange
* Add get deposit address for Binance exchange
Fix bug in Authenticated requests, concatenates sig string on end of query
* Remove support for deposit address on ANX exchange
* Updated account type to segregate multiple accounts on an exchange.
* Fix requested changes
* Add get deposit address for Bitfinex exchange
Add parameter for getting deposit address to wrapper
* Add get deposit address for ANX exchange
* Fix misspelling in Poloniex
* Drop working field and initialisation of zero value for Account Type
* Change switch to symbol package currency code
* Adds tests for withdrawFiat and withdrawFiat to international bank to all exchanges
* Sets unsupported where FIAT withdrawal not allowed
* Updates test signatures. Adds support for bitfinex FIAT withdrawals. Adds withdrawal type of NoFiatWithdrawals. Updates exchange wrapper implementations to return errnotsupported when... not supported. Updates withdraw permissions tests to reflect nofiatwithdrawals. Adds intermediary bank support in withdrawRequest type struct
* Adds bithumb and bistamp fiat withdrawl wrapper support
* Adds BTCMarkets withdrawal support
* Adds kraken withdraw support (uses existing methods)
* Fixes line issue from rebase
* Updates notsupported for localbitcoins and okex. Updates withdraw permissions for liqui
* Adds coinbasePro withdraw support. Fixes withdraw permissions tests for liqui and localbitcoins
* Removes unnecessary data from test structs for fiat withdrawal tests
* Readds intermediary bank flag
* Removes reference
* Improves bitfinex testing, improves withdraw fiat error handling
* Reverts Kraken hardcoded testing value
* Initial commit
* Updates signature for all withdrawal methods to use new withdrawRequest struct type
* Implements crypto withdraw features & tests for Alphapoint, ANX, Binance, Bitfinex, Bitflyer, Bithumb, Bitmex, Bitstamp, Bittrex, BTCC, BTCmarkets, CoinbasePro, Coinut. Updates WithdrawRequest type with more members. Breaking change to update real order testing for increased code coverage
* Updates all realOrder tests to run when no API key is present. Updates exchange functions to handle errors better
* Implements crypto withdrawals for Exmo, GateIO, Gemini, HitBTC, Huobi, HuobiHadax, Kraken, LakeBTC, Liqui, Localbitcoins, OKCoin, OKEX, Poloniex, Wex, Yobit and ZB. Updates real order test formatting for all real order tests
* Update alphapoint. Fixes anx typos. Adds function WithdrawFiatFundsToInternationalBank to exchange wrapper interface. Adds WithdrawFiatFundsToInternationalBank to alphapoint, bitmex, coinbasepro. Updates Kraken to use TradePassword property
* Reverts alphapoint to use ErrNotYetImplemented
* Fixes line spacing and removes unnecessary line
* Changed IBotExchange interface ModifyOrder function paramater and return value to exchange type for easier addition or retraction of variables.
* Function ModifyOrder for Binance not supported via API
* Change to unsupported function for exchange ZB
* Change to unsupported function for exchange Yobit
* Add modify order support for Poloniex
* Change to unsupported function for exchange Okex
* Change to unsupported function for exchange Localbitcoins
* Change to unsupported function for exchange Liqui
* Change to unsupported function for exchange LakeBTC
* Change to unsupported function for exchange Kraken
* Change to unsupported function for exchange Itbit
* Change to unsupported function for exchange HuobiHadax
* Change to unsupported function for exchange Huobi
* Change to unsupported function for exchange HitBTC
* Change to unsupported function for exchange Gemini
* Change to unsupported function for exchange GateIO
* Change to unsupported function for exchange Exmo
* Change to unsupported function for exchange Coinut
* Change to unsupported function for exchange Coinbase
* Change to unsupported function for exchange BTCMarkets
* Change to unsupported function for exchange Bittrex
* Change to unsupported function for exchange Bitstamp
* Add modify order support for Bitmex
* Add verbose header information in request package
* Add modify order support for Bithumb exchange
* Change to unsupported function for exchange Bitflyer
* Change to unsupported function for exchange Bitfinex
* Change to unsupported function for exchange ANX
* Change interface function signature
* Rm redundant code for authenticated requests in Bithumb
* Add error check if decimal values supplied for create or modifying an order on Bitmex
* Added test functions across the exchanges
* Rm comment for modify order on Alphapoint exchange
* Update tmpl file for exchange wrapper
* Changes method signature for cancelling all orders (experitmental). Implements cancelAllOrders wrapper for alphapoint, anx, binance
* Implements cancel all wrapper for bitfinex, bitmex, bitstamp, bittrex, btcmarkets, coinbasepro and hilariously coinut
* Changes method signature to only use one OrderCancellation type. Adds support for Exmo, gateio, gemini, itbit, lakebtc
* Adds/updates support for hitbtc, huobi, hadax, itbit and kraken
* Adds support for liqui, localbitcoins, okcoin, poloniex, wex and yobit. Splits up open order methods for poloniex
* Adds bithumb, okex and zb support. BTCC for another PR
* Updates bitflyer, bithumb, bitmex, coinut, okex and zb cancelAllOrders method to cancel via enabled currency pairs rather than a singular currency
* Adds tests to all exchanges to test wrapper function CancelAllOrders
* Fixes OKEX and huobi, btcmarkets, kraken, okCoin cancel order implementations
* Fixes coinut, hitbtc and okex api for authenticated requests
* Fixes comment and spacing
* Changes the CancelAllOrders signature to return orderids and errors along with a generic error.
* Fixes OKEX delimiter
* Removes spacing and test verbosity
* Removes more spacing
* Removes space
* Fixes okex rebasing issue. Also makes the maps instead of assuming they just work
* Reimplements order cancellation for alphapoint, anx, binance, bitfinex, bithumb, bitmex, bitstamp, bittrex, btcmarkets, coinbasepro, coinut, exmo, gateio, gemini, gitbtc, huobi, hadax, itbit, kraken, lakebtc, liqui, okcoin, okex, poloniex, wex, yobit and zb wrappers. Adds new order cancellation struct type. Updates old tests that pointed to the wrong unrenamed methods
* Sets up tests for all supported exchanges. request.DoRequest errors when response status is not 200
* Updates alphapoint, coinut, hitbtc, lakebtc cancel order implementations. Finishes testing
* Adds localbitcoin cancel order wrapper support
* Fixes tests and build issues. Adds WexIssue flag for tests
* Changes CancelOrder signature to only return error. Allows exchange to format currency pairs with delimiters
* Sets up Alphapoint and ANX wrappers to use exchange implementations of submit orders
Creates const types for orderType and orderSides
* Changes wrapper func SubmitExchangeOrder return type to string to account for GUID order ID responses
* Adds binance and bitfinex new order wrapper support. Fixes alphapoint order wrapper.
* Adds bitflyer type for exchange order. Adds bithumb and bitmex wrapper support for SubmitExchangeOrder
* Fixes bitmex typo. Adds bitstamp, bittrex, coinbasePro, coinut SubmitExchangeOrder wrapper support
* Maps exchange wrapper function 'SubmitExchangeOrder' to exchange methods for exmo, gateio, gemini, hitbtc, huobi, huobihadax and itbit
* Maps exchange wrapper function 'SubmitExchangeOrder' to exchange methods for kraken, lakebtc, liqui, okcoin, okex, poloniex, wex, yobit and zb
* Updates interface, fixes wrapper type mismatch and fixes tests from changed parameters
* Adds generic support for SubmitExchangeOrder for localbitcoins_wrapper
* Updates wrappers tests and submit order implementations for anx, binance, bitfinex, bitflyer (cannot test), bitmex, bitstamp
* Fixes bitstamp tests
* Adds tests for submitting orders with bittrex, btcmarkets, coinbasepro and coinut
* Adds tests for exmo, gatio, gemini and hitbtc
Makes adjustments where necessary
* Adds tests and updates order implementations for huobi, huobiHadax, itbit, kraken, lakebtc, liqui, okcoin, okex, poloniex, wex, yobit and zb. Not all have been verified due to exchange issues
* Fixes variable names and symbol usages
* Fixes HitBTC order API implementation
* Removes formatting code. Adds error handling for unsupported order types. Fixes typo
* Fixes missed replace for new ToString function. Removes unused functions
* Changes report of unknown withdrawal type with bitshift approximation.
Improved code cov
* Updates wrapper SubmitExchangeOrder return to use a fancy new SubmitOrderResponse struct type to clarify if an order submission is successful or not
* Initial broken commit for updating exchanges to store data on whether withdrawals can be handled completely by the API
* Changes to use base exchange method to determine withdrawal permissions using bitshifting
* Adds withdrawal capabilities for alphapoint, anx, binance, bitfinex, bitflyer, bithumb, bitmex, bitstamp, bittrex exchanges
* Adds withdraw capabilities for btcmarkets, coinbasepro, coinut, exmo, gateio, gemini, hitbtc, huobi, hadax
* Adds withdraw capabilities for itbit, kraken, lakebtc, liqui, localbitcoins, okcoin, okex, poloniex, wex, yobit, zb
* Titillating tests & Wonderful wrappers
* Fixes typo, double checks all apis and corrects permissions
* Fixes gemini test
* Fixes incorrect log placement. Removes breaks
* Addresses PR comments. Changes readable function to: FormatWithdrawPermissions, adds new function 'GetWithdrawPermissions' and 'SupportsWithdrawPermissions'. Adds three functions to interface
* Removes unnecessary config_example.json additions
* Fixes bitwise comparisons. Adds more tests to highlight expected outcomes
* Adds some constants for fee types
Adds some fee calculation in an attempt to be generic
Adds fee stuff to Bittrex
Adds fee stuff to bitstamp
* Fixes bitstamp fee calculation
* Tests
Tests all scenarios for GetFeeByType
* Adds method to wrapper
Adds err to response
Checks for err
* Adds support for Bittrex fees
* Adds maker/taker dynamic to fees
Updates tests
Adds bitmex fee support
Removes unused switch case scenarios to not waste space
* Adds bithumb support for fee calculation
* Adds Bitfinex fee support
Adds list of currencies as const strings
Sets up bitflyer
* Fixes arguments
* Greatly expands symbols
Adds Binance fee calculation support
Cleans up previous exchanges
* Fixes errors for fee calculations
* Adds ANX fee support
* Adds btcc fee support
Adds alphapoint fee wrapper support
Renames method to match "enum"
Uses symbols in tests, not inline strings
* Adds support for BTCMarkets fee calculation
Adds new method to retrieve fee amount from BTCMarkets
Adds new fee type struct: FeeBuilder
Updates ANX and BTCMarkets to use new FeeBuilder type struct
Standardises the tests to run when it comes to fee calculation
* Migrates all existing exchange fee to use new feebuilder type struct
Uses standard testing model
* Fixes unit tests
* Updates maker taker fees in test config
* Removes parallel from fee testing
* Removes more parallel from tests
* Adds coinbasepro fee support
* Adds Coinut fee support
* Adds Exmo fee support
Adds maker fee support to coinut
Introduces a type for fees and bank transfers to prevent random strings being used
* Adds partial bitflyer support
Moves bitflyer to feeBuilder struct
* Adds gateio fee support
* Adds Gemini fee support
* Adds hitbtc fee support
* Adds huobi fee support
* Adds HuobiHadax fee support
* Adds itbit fee support
* Adds partial kraken fee support with trading fees
* Finishes basic Kraken fee support
* Adds basic LakeBTC fee support
* Adds basic liqui fee support
* Adds localbitcoins fee support.......
* Adds basic okcoin fee support
* Adds simple OKEX fee support
Adds many new currency symbols
Fixes liqui's fees
* Adds poloniex fee support
* Adds fee support for Yobit
* Adds WEX fee support
* Adds ZB fee support
* Removes bad reference
* Improves accuracy of variable name
* trading fee method names are now consistent
(cherry picked from commit 21c82e8b90cae590cfd73d365d7be39e1a00e973)
* Fixes rebasing issues
* Fixes issues from rebase
Removes "IsTaker" as IsMaker bool can imply taker
Updates tests to actually work.
* Adds a zero to the test
* Fixes bitfinex api endpoints and fixes fee calculations
* Updates btcmarkets trading fee calculation
* Verifies tests with apis for all exchanges except coinbasepro, itbit and bitflyer
Removes taker fee test as taker is default
* Removes redundant all exchange wrapper error checks due to the error checks being redundant
* Addresses review comments:
- Renames variables
- Changes how functions return data
- Fixes typo
* Initial overhaul of websocket connection and feeds
* Added proxy support
* Piped to routines.go
* Added new websocket file in exchanges
Refactored orderbook handling into exchange_websocket.go
Added better error responses for binance_websocket.go
General clean for binance_websocket.go
* General fixes - bitfinex_websocket.go
Refactored orderbook cache code - bitfinex_websocket.go
Removed fatal error with unhandled type - routines.go
* Added general improvements to bitmex_websocket.go
Refactored orderbook handling to exchange_websocket.go
Added variable in Item struct in orderbook.go for looking up orders by ID
* Fix issue when routines are blocked due to Data Handler not started
Updated traffic handler
General fixes for bitstamp_websocket.go
* General fixes for coinbasepro_websocket.go
* General fixes for coinut_websocket.go
Fixed error return in exchange_websocket.go
* Removed comments in coinut_wrapper.go
Refactor orderbook logic from hitbtc_websocket.go to exchange_websocket.go
* General fixes
* Removed comments
General fixes
* Updated routines.go
* After rebase fix
* Fixed update config pairs in okcoin.go
* fixed config currency issue in okcoin.go for okcoin China
* exchange_websocket.go
*Removed unused const dec
*Removed state change routine
*Improved trafficMonitor routine
*Increased verbosity for error returns
*Removed uneeded mutex locks
exchange_websocket_test.go
*Added new tests for websocket and orderbook updating
routines.go
*Removed string cased
* Fixed race conditions on sync.waitgroup in exchanges_websocket.go
* Changes variable name in config.go
* Removes unnecessary comment
* Removes indefinite lock on error return
* Removes unnecessary comment
* Adds support for BTCC websocket
Drops support for BTCC REST
* Rewords comment in exchange_websocket.go
Moves types to poloniex_types.go
* Moves types to coinut_types.go
* Removes uneeded range for accessing array variables for coinbase_websocket.go
Removes comments in coinut_types.go
* Adds verbosity flag to GCT
Suppresses verbose output from routines.go
* Fixes setting proxy for REST and Websocket per exchange
Upgrades error handling
Drops unused *url.Url variable in exchange type
* Adds test for setting proxy
* Fixes bug that closes connection due to incorrect timeout time through a proxy connection
* Clarify verbose flag message
- Modifications made to the request package. Planned improvements will be
sending requests on intervals, rate limiter back off support, dynamic tuning
and requests packaged into a request job group.
- Can modify each exchanges individual HTTP client (e.g timeout and
transport settings).
- Bot now uses an exchange config HTTP timeout value.
- Bot now uses a global HTTP timeout (configurable).
- Batched ticker request support for exchanges.
- Ticker and Orderbook fetching now are spanned accross multiple
go routines and regulated by a sync wait group.
- Fixes hack used to load exchanges, now uses a sync wait group.
- Ticker and Orderbook storage and fetching now uses mutex locks.
- New pair function for finding different pairs between two supplied
pair arrays. This is used for currency pair updates for exchange which
support dynamic updating.
- Shows removal/additions of dynamic updates currencies.
