* add data directory to config.json
* fix quality check issues
* adjust data directory only when explicitly set
* unexport ValidateSettings
* process flags earlier so they can also be used when loading config
* fix test depends on flags
* rename config.DataDir to DataDirectory
* also don't omit in JSON if empty
* datadir flag induces dry run
* log warning
* enable parallel for sub tests
* leave data dir empty in example config
* remove parallel for loadConfigWithSettings
* create a new config object instead of using a shared one
* remove a test that potentially reads user file
* rename test methods to MixedCaps
* clean up test dir after engine tests
* use global config variable
* WIP
* end of day WIP started migration of trade history
* added kline support to hitbtc huobi lbank
* added exchangehistory to all supported exchanges started work on coinbase 300 candles/request method
* end of day WIP
* removed unused ta and misc changes to flag ready for review
* yobit cleanup
* revert coinbase changES
* general code clean up and added zb support
* poloniex support added
* renamed method to FormatExchangeKlineInterval other misc fixes
* linter fixes
* linter fixes
* removed verbose
* fixed poloniex test coverage
* revert poloniex mock data
* regenerated poloniex mock data
* a very verbose clean up
* binance mock clean up
* removed unneeded t.Log()
* setting verbose to true to debug CI issue
* first pass changes addressed
* common.ErrNotYetImplemented implemented :D
* comments added
* WIP-addressed exchange requests and reverted previous GetExchangeHistory changes
* WIP-addressed exchange requests and reverted previous GetExchangeHistory changes
* increased test coverage added kraken support
* OKGroup support completed started work on address GetExchangeHistory feedback and migrating to own PR under https://github.com/xtda/gocryptotrader/tree/exchange_history
* convert zb ratelimits
* gofmt run on okcoin
* increased delay on rate limit
* gofmt package
* fixed panic with coinbene and bithumb if conversion fails
* very broken end of day WIP
* added support for GetHistoricCandlesEx to coinbase and binance
* gofmt package
* coinbase, btcmarkets, zb ex wrapper function added
* added all exchange support for ex regenerated mock data
* update bithumb to return wrapper method
* gofmt package
* end of day started work on changes
* models created for exchange/asset/currency/currencypair, new seed system created
* reworked test coverage added okgroup support general fixes/change requests addressed
* Added OneMonth
* limit checks on supportedexchanges
* reverted getexchangehistory
* started work on currency seeding and insertion
* reworked binance tesT
* added workaround for kraken panic
* :D extremely broken WIP
* renamed command to extended removed interval check on non-implemented commands
* added wrapperconfig back
* increased test coverage for FormatExchangeKlineInterval
* WIP
* increased test coverage for FormatExchangeKlineInterval bitfinex/gateio/huobi
* linter fixes
* zb kraken lbank coinbene btcmarkets support added
* removed verbose
* OK group support for other asset types added
* swapped margin to use spot endpoint
* index support added test coverage added for asset types
* added asset type to okcoin test
* gofmt
* add asset to extended method
* removed verbose
* Very broken WIP models need to be regenerated
* add support for coinbene swap increase test coverage
* removed verbose
* small clean up of okgroup wrapper functions
* verbose to troubleshoot CI issues
* removed verbose
* added error check reverted coinbasechanges
* attempting to fix broken model generation
* readme updated
* :D i broke so much
* model regeneration fixed & complete
* candle model filled out
* removed unused start/finish started work on decoupling api requests from kline package
* restructured coinbene, bithumb methods, added bitstamp support
* kraken time fix
* BTCMarkets restructure
* typo fix
* removed test for futures due to contact changing
* removed test for futures due to contact changing
* added start/end date to extended method over range
* WIP
* added sync option to candles
* converted to assettranslator
* removed verbose
* removed verbose
* removed invalid char
* reverted incorrectly removed return
* added import
* further template updates
* macos hates my keyboard :D
* misc canges
* started work on creating kline from databases eed
* x -> i
* removed verbose
* updated fixCasing to allocate var before checks
* sqlite3 supported work started
* removed time conversion
* further work on tets
* sort all outgoing kline candles
* fixCasing fix
* after/before checks added
* added parallel to test
* logic check on BTCmarkets
* removed unused param, used correct iterator
* converted HitBTC to use time.Time
* test update
* add iszero false check to candle times
* Seed exchange & OHCLV data for test usage
* updated resultlimit to 5000
* new line added
* added comment to exported const
* move date forward
* use configured ratelimit
* fixed pair for test
* panic fixed WIP on fixCasing
* fixCasing rework, started work on readme docs
* enable rate limiter for wrapper issues tool
* docs updated
* removed unused vars from tests
* removed err from return and formatted currency
* updated Yobit supported status
* Updated HitBTC to use onehour candles due to test exeuction times
* added further details to gctcli output
* added link to docs
* added link to tempalte
* disable FTX websocket in config_example
* fix poloneix
* regenerated poloniex mock data
* removed recording flag
* format on package
* moved exchange var outside of method scope
* reworked seeding into package
* verbose output improved
* removed verbose from candles
* Added comments to exported functions
* removed verbose output
* Reworking of tests
* end of day commit
* added SQLite migration for asset, test updates for exchange, added support for withdrawal for new exchange_name_id relation
* regenerated database models
* WIP
* test rework, sqlite migration updates for withdrawal
* Reworked error returns to stop duplications, format all output to UTC, changed gctscript OHLCV output to be unix timestmap, started work on seeding tool
* gofmt
* dbseed command for seeding exchanges added, removed seed from dbmigrate, LoadCSV method added for exchange
* go mod tidy
* added import candle from csv command to dbseed
* Removed reset & duplicate migrate command from helper, renamed struct to Item/Candle over Candle/Tick, added test coverage to dbseed, improved withdraw tests
* remove broken tests due to ORM generation of Fk, removed go unneeded goroutine for inserting records
* removed t.Cleanup usage because appveyor
* added test coverage to StoreInDatabase()
* removed unneeded data from config for test
* added new line
* Added down migration support to candle/asset removal, return original error and display rollback error
* removed unneeded err assignment, break out of loop on error
* add err check to method for test
* first pass changes
* WIP
* Updated migrations for both sqlite3 & postgres to create exchanges if any withdrawal_history records are found, removed migrate command
* removed argusage as usage information is provided by flags
* added inserted records return count and test coverage
* new line added
* Database: comment config details out to disable local postgresl testing by default
* added asset support
* Database: added error return when no exchanges are found, title exchange name across queries
* Fixed test data
* Database: removed migration bool from ConnectToDatabase(), removed empty line, insert asset on test
* Database: verbose linter :D
* Database/OHLCV: removed go module from dbseed command and reverted back to main module, converted interval to int64 to match other parts of code base, provided migrations to update database, poloniex fix to skip first candle
* dbseed: add completed message to output
* Database: added migration to add asset to uniq index for candle table
* Database: database -> exchange
* Database: add asset to upsert conflict
* Poloneix: fix for invalid interval
* regenerated poloniex mock data
* Database: added down migration for candle interval update
* OHCLV/Database: WIP
* OHLCV/Datastore: added new ValidateKline() method to check that asset, pair, interval are enabled/supported by exchange and updated tests
* revert configtest changes
* OHCLV/Kline: pointer assignment to ErrorKline & format pairs on check
* goimports
* migration updates
* Database/Candle: updated tests
* revert configtest changes
* ZB: updaed defaults to use uppercase pairs
* ZB: updaed defaults to use uppercase pairs
* revert pair formatting
* Switch over to .Cotains() method from pairManagement
* Added comment & ftx back 😆
* OHLCV/Datastore: (Candles): added not null to asset, (WithdrawalHistory): added not null to exchange_name_id), reworked KlineError return
* set verbose to false
* updated btc markets test
* Updated readme
* removed ability to have blank exchange name as indexing requires it
* remove old usedb and empty exchange check, return error on no data instead
* Updated kline test to match date range
* Renamed candles.exchange_id column to candles.xchange_name_id to match withdrawal table, return err on unwrap, zb fix revert
* regenerated sqlite3 models
* force UTC for sqlite.... because sqlite
* OHLCV/Datastore: upper case pairs on insert for consistency, remove unneeded rollback call on commit failure as it has no effect, move rollback outside of insertsqlite/insertpsql methods
* add error check for no candles
* nil length/cap is 0 in golang :D
* OHLCV/Datastore: updated wording on examples, removed duplicate testfile
* OHLCV/Datastore: updated README with links to dbseed
* dbtool -> dbseed
* initial update of currency system
* WIP progress
* Finish initial currency string error returns
* fix whoopsie testing for non https insecureinos
* Current WIP for getEnabledPairs check and error return
* WIP continued
* When getting enabled pairs throw error when item is not contained in available pairs list
* More updates -WIP
* Wip continued including potential interface
* Current WIP
* pairs manager pass
* drop asset string and just use the map key, plus return some errors and create more work for myself.
* clean and fixed a bug in currency.json, will not populate correctly without coinmarketcap api keys set.
* purge logger references after merge
* go mod tidy after merge
* Pointer change WIP
* fix some issues and added error returns to a few items (WIP)
* WIP
* Clean
* Fix some linter issues
* Fix more linter issues
* even more linters
* xtda nits
* revert pointer change and rm field
* Addr madcozbadd nits
* fix linter issues: shadow declarations
* Fix linter issues: gocritic huge things
* linter issue fix
* Addr nits
* flush go mod files
* after merge woops
* fix shadow dec
* Addr thrasher nits
* addr nits
* fix some issues
* more fixes
* RM println
* Addr glorious nits
* Add helper method for setting assets
* add missing format directive
* Addr nits
* Actually process new futures contracts -_- derp
* WIP for GRPC upgrade for pair management
* update config pairs
* finished disabling and enabling asset
* linked update of tradable pairs to cli
* fix oopsies
* defer writing to file on program termination for currency storage system
* update template
* don't add disabled asset items to initial sync
* Fix enable disabling a list of pairs and added in a slice error type so we can add whats allowable without throwing an error and return a report, also addressed some other nits
* WIP on getting a channel to unsub
* Wip track down unsubscribe bug and start creating streaming interface
* purge websocket orderbook object and centralised updating routine for orderbook
* general clean before interface implementation
* stage one connection interface WIP
* WIP
* repackage wshandler WIP
* find difference of subs and change signature of subscriber functions so we can batch subscriptions and unsubscription in exchanges that support it
* design change on mange subscription routine WIP
* integrated ZB with the new webosocket updates
* WIP - okex conversion
* integrate websocket upgrades for lakebtc, kraken, huobi, hitbtc, gateio, and WIP for coinbene
* integrate another range of exchanges for websocket update
* Added subscriber and unsubscriber methods to websocket functionality
* fixed tests WIP
* amalgamate cache setup with main websocket setup
* reinstate exported fields traffic alert and shutdownC to accommodate gemini and lakebtc implementations
* added in colon
* Updated websocket auth handling as they werent getting passed through. Added a setter method for websocket URL due to the Binance generated auth key/listenKey. Fixed bug which stopped reconnection.
* Fix subscribe candle bug
Fix time conversion in candle
Fix inititial candle history to datahandler
Include funding to orderbook handling
Include funding to trades
Reduce code duplication in sub and unsub functions
Added the ability to include funding currency websocket subscriptions
validated all channels and added more items todo list (Auth items)
* RM line
* bitstamp pass
* btcmarkets pass - still needs to implement unsubscriber functionality and pairs change test.
* Batch outgoing subscriptions and fix unsubscribe bug
* BTSE - bumped time to minute to reduce pinger calling by 75 calls per day. Fix authentication bug and add authentication pass into to-do. Batch outgoing subscription calls
* fix type field and batch outgoing subs and unsubs for coinbasepro
* Batch outgoing subs and unsubs
* Fixes bug when matching return from authentication
* Fix bug where params where being sent out of order due to map ,where depth items werent being subscribed too, where trying to subscribe to too many kline items caused error, where trying to get a nano secocond ID conflicted due to speed of generation.
* Add websocket capability for currency pair change by utilizing full channel subscription list in subscribe function.
* Add error handling
* Fix public: time conversions, subscription list, stopped pushing heartbeat to data handler, aggregated list of connections.
* hitBTC pass
* returned nil instead of error due to period null bids and asks updates coming through.
* Fix auth ping capture and reply. Added in interval handling for kline data. Added correct full trade data handling. Fix subscribe and unsubscribe.
* Fix when websocket auth conn and token generation fail we don't try and auth sub. Fix bug between auth and normal connection id generation and matching. Batch outgoing payloads to increase efficiency. Updated matching functions to utilise channels instead of waitgroups and go routines.
* RM debug output
* rm func to get shutdown channel
* Add unsubscriber functionality, added wsTicker type, removed return as this will impede data flow and cause reconnection when handling and processing data
* okgroup WIP
* *Added missing fields for websocket trades
*Fix bug processing kline interval
*Added fields for websocket ticker struct
*Fix auth bug
-Updated request and response matching param to interface so we can custom signature match. Stops auth subscribing before a reply is issued.
-Updated channel inclusion of pair fo auth subs as this was missing.
*Assortment of perfomance improvements
* poloniex pass
* send all trades to data handler, validated enabled and disable pairs
* initial clean
* centralised request matching mechanism
* websocket main improvements WIP
* WIP
* Websocket management via gctcli WIP
* GRPC expansion
* Updated GCTCLI with websocket url and proxy setting functionality which flushes connection
* Fix continuous spawning of routines bug on error with reconnection
* Addr linter issues
* fix subscription bug that I caused when I changed to a switch case
* fix linter issue
* fix woopsie
* End of day WIP
* Fix order submission REST, time conversion, order type conversion, orderID bugs
* fix gateio test and unsubscribe bug
* revert comment out code
* websocketAPI changed to to true in configtest.json
* fix race in gateio test
* End of day WIP for websocket tests.
* BugFix for binance when book isn't seeded. Updated websocket tests. Deprecated subscription manager. RM wrapper funcs.
* Added string title to exchange name as they are saved as lower case in type, reinstated verbose check in websocket.go
* Added verbosity check for setting websocket URL
* fix bug where the asset had a mind of its own
* purge dodgy coding
* Fix tests, drop blocking chan in websocket Dial function
* few more changes
* race condition fix for websocket tests.
* fix intermittent test failure due to underlying hash table storage
* Address madcuzbad nit
* RM superfluous printlines
* Add quick top example with paramater fields
* First pass Glorious nits
* As per madcozbad suggestion return error when enabled pair not found in full return map. Add test.
* addr madcozbadd nits
* as per glorious suggestion rm'd loadedJSON field
* adjusted ticker, added test and RM'd code that can never be executed
* Addr nits and add in crypto rand genration for ID's
* remove global channel declaration and rescoped as this was causing a lock
* as per glorious suggestion restructured return error for websocket
* addr glorious suggestions
* fix linter issues
* purge non-existent pair from testdata
* add side field to struct and parse
* addr glorious nits
* Add verbosity to error returns and logs and fix string parsing in GCTRPC
* fix speeling mistwake
* Adds websocket functionality check before flushing websocket connection
* Addr kraken panic and setting/flush websocket url stage one.
* added websocket url check before setting with tests
* Added in edge case test if by the time we call contains on available pairs it has been changed
* remove error return for func
* Continuation of tests
* continuation of tests
* Stop potential panic within pair creation function
* Implement changes to upstream
* rm sup comment
* fix bug when subscribing and unsubscribing. Also add in boolean to determine there are currencies that need to be flushed via set pairs via gctcli
* fix test
* Fix linter issues
* Fix tests
* turn websocket off in config example
* Fix issue where you cannot enable websocket when config is set to false, also added config websocket enable state saving
* Introduced err var for same error returns
* Add err var exchange base not found
* restructure function
* drop gctscript from generic response name
* drop managesub delay const as its not being used
* correctly implement websocket rate limiting for coinut
* remove quotations
* drop pair management check
* fix spelling
* return error in function to not update currency with unset role
* amalagamted enable/disable into set function and added in pairstore fetch function
* update error description
* rm function
* moved test function to sharedtestvals and move type to types.go
* append delimiter onto currency delimiter strings
* add test coverage
* rm functions as they are set as methods in base
* remove superfluous methods
* Fix issue that would occur when a subscription errored and not appending successful subs
* fix after rebase woopsie
* fix linter issues
* fix bug streamline code
* fix linter issues
* fix linter issues
* fix case where it should not change ID if set but append new
* fix whoopsie
* fix websocket tests
* fix readme, fix wrapper issues reporting template, go mod tidy
* add test coverage
* add test coverage and verified futures pariing
* add in futures bypass as its not currently supported on BTSE until API update and implementation
* removed downside/upside profit contract type as its no longer supported. Added in check in set config pairs to warn user of potential conflict and to manually remove or update.
* If asset enabled add pair and increase code coverage
* remove strings.title, set and fetch with strings.Lower but keep struct field exchangename unchanged. Streamline ticker and orderbook code.
* Add code coverage
* log error if setting default currency fails, add code coverage
* address glorious nits
* Addr xtda nits
* fix linter issues
* addr glorious nits
* xtda nits
* Addr glorious nits
* add subscription protection and removed a superfluous wait call
* fix test
* fix whoopsie
* addr xtda nits
* addr glorious nits
* Added asset types to subscriptions structs, also added in error handling for resubscription errors
* consolidated rpc returned type and added in sucessful strings
* dropped stream timing down to 100ms
* DOC changes
* proxy and url usage string additions
* WIP
* go mod tidy rides again
* Addr nits
* Addr nits, fix tests
* fix wording
* add in test case for currency matching
* Add byte length check on outbound websocket payload subscriptions
* addr thrasher nits
* Addr madcozbadd nits
* addr linter issues
* Addr glorious nits by amalgamating function into one mega amazing function.
* fix futures account subscription bug
* addr glorious nits and reinstated wg.Wait() checks
* changed string to currency delimiter string and setconnected by function
* Various bug fixes
* Deadlink, cleanup plus bug fixes
* Various Kraken fixes
* Add convert func for decimal unix timestamps
* Convert all test times to UTC
* Kraken: Make assets a pointer to prevent excessive copying
* Docker slash fix
* Address nits plus bump ITBit last checked pairs timestamp
* Set pairs to enabled pairs when getting active orders
* Use asset translator for UpdateAccountInfo and more checks for the exchange template tool
* Address MadCozBadd's nits
* Make exchange var 2 chars
* Make program more user friendly
* Project wide comment checks and exchName check
* Fix Huobi indexing bug and use correct pair formatting
* Address nits + readme change
* * Adds script link to GCT logger package
* Adds ability to save data as csv via script
* addr nits
* go mod tidy
* add glorious suggestion
* rm unused function
* fix linter issues
* clean up some issues
* Add in configuration fields to object for reflection to the csv file
* RM line :D
* address nits
* update to check for target already being set and add more test coverage
* force usage of .csv file extention && append date to client filename as to not overwrite file if collision occurs
* fix whoopsie
* linter issues
* purge getter methods
* Added glorious suggestion
* go mod tidy after merge
* niterinos
* reworked request struct and exchange response started work on validation system
* removed import cycle until work around
* Added intial withdraw support via CLI added
* Added Crypto command to gctcli
* moved var declartion to single line
* Test updates for binance and anx
* All exchange tests have been updated test coverage added to validate
* First pass at adding withdrawl select from database
* started adding basic lru cache system
* Added basic LRU cache including Add Get Remove Contains ContainsOrAdd Clear
* wording changes on comments
* removed exported var's in strut as they are not required
* Added README
* README updates
* corrected ID on commands
* rm line :D
* merged in origin/cache
* linter fixes (gofmt)
* Added basic cache lookup to events
* swapped to mutex over rwmutex updated comments
* unexported getNewest & getOldest
* unexported getNewest & getOldest
* Updated comments and cited references in source
* updated comments
* WIP
* Migrated exchange WithdrawFiat wrapper to new struct response
* Migrated exchange WithdrawFiat wrapper to new struct response
* started work on bank management
* Added exchange level banking details back with migration to banking package
* Removed broken tests for now
* Added validation to bank accounts
* removed duplicate bank details from withdraw struct
* Test coverage increased
* gofmt
* merged upstream/master with clean up
* First pass at adding command line linking to gctcli
* added validation for crypto address, added gctcli support to retreive previous withdrawal requests
* general cleanup
* general cleanup
* reordered imports
* Increased test coverage moved to database sublogger
* Pass incorrect currency no longer return error from c.CheckBankAccountConfig
* remove TestMain() for now as other tests in this package will need to be reworked
* Happy little race car
* Reverted to upstream tests
* Added test covarege for validation method, corrected response on cli protobuf
* query clean up and removal of duplicated code
* cleaned up queries into singlem ethod increased test coverage
* Migrated international fund withdraw to new exchange response and added cache size override
* Migrated international fund withdraw to new exchange response and added cache size override
* Extended gctcli commands
* lowered default cache to 25
* small code clean up
* added get by date method
* add returned error
* cli commands cleaing return error on nil results to fix out of bounds
* merged write & read helpers into one for test coverage and increased engine/withdraw test coverage
* gofmt
* Added test coverage for valid ID
* removed unused param
* converted to use timestamp package from protobuf
* gofmt
* use built in RFC3339 timestamp
* remove setting of CreatedAt & UpdatedAt and allow ORm to take care of it
* also use ptype on byid
* code flow improvements
* remove inverse conditional check and linters run
* removed test data
* removed comment
* removed comment
* also write failures to database for auditing
* converted to use default time for start & end
* Default to time.Now() minus 30 days
* Default to time.Now() minus 30 days
* small code clean up
* fixed missing semicolon on migrations, code clean up
* updated sqlite migrations
* Added additonal check for exchange level bank account if global is not found
* case sensativity fix for currency names
* use correct compare
* test coverage fixed
* removed space
* return pointer to banking.Account
* return pointer to banking.Account
* added else check back to validate()
* Added empty string as default to migration over NULL due to retrivial of data
* renamed package to log to stop side import requirement
* reverted comment changes
* reverted comment changes
* one more reverting wording back to logger
* wording changes on comments
* Bugfix, remove non-needed code and cleanup some code
* Run go mod tidy
* Remove non-needed test and fix tautological err
* Fix Huobi interim var reference
* Add exchange manager to engine
* Several improvements for engine and friends
1) New file.Exists func
2) gRPC TLS cert expiration date check and regeneration
3) New donation var for use across the codebase
4) Use Go log package until the logger is initialised
* Add cert tests and create dir tree if it doesn't exist for file.Write
* Link up donation address to documentation tool plus minor adjustments
* Fix remaining donation addrs
* Move non-needed reload exchange funcs
* Revert accidental config_example.json changes 🕯️
* Use go logger for logging until the logger has initiliased, otherwise no output will be seen
* Link up portfolio delay val and other fixes
* Run go mod tidy after dependabot PR
* Address nitterinos
* Initial rework of rework of requester - WIP
* Implementing and checking rate limits - WIP
* implemented coinbene rate limiting shenanigans
* add in remaining WIP
* fixy
* use authenticated rate limit
* drop ceiling as this can be done with a counter later
* add functionality to struct
* purge config options for rate limiting so as to keep things minimal
* prepare futures and swap rate limiting for implementation
* Address linter issues
* Addressed nits, fixed race
* fix linter issue
* remove global var as this was only setting when newrequester was called
* moved rate limit functionality into its own file
* Update Bitfinex with correct rate limit and test endpoints (WIP)
* finish off bitfinex adjustments
* fixes
* fix linter issues
* slowed rate for coinbasepro
* drop rate limit for huobi as the doc times have intermittent 429 issues.
* Set MACOSX_DEPLOYMENT_TARGET to remove linking warning
* Addr Thrasher nits
* Addr glorious nits
* unexport do request function
* fixed nitorinos
* Fixed something I missed
* move disabled rate limiter into loadexchange and use interface functionality
* Add temp quick fix
* Added config option for SetMutexProfileFraction() to profiler increased test coverage and made tests runnable standalone
* Removed duplicate host and no longer const
* Added pprof endpoint to log
* WIP
* updated appveyor and increased deadline 5 seconds due to increased linters being added
* revert files to upstream/engine
* WIP
* WIP
* mod file changes
* added script manager
* Added manager/and cli interfaces to scripting
* Added script task handler
* WIP - Added timer/repeat support and fleshed out wrapper further
* autoload support added + WIP
* WIP commit
* added account balance info
* btc markets temp work around
* WIP - merged with upstream for new order package BTC Markets responses broken
* Cancel order wrapper WIP
* order wrapper update
* Added test coverage for VM
* moved to map for VM List shutdown of all VM now handled added gctcli commands for list and stop of running scripts
* added override to load/execute for path
* fixed incorrect channel shutdown added further test coverage and restructured gctcli commands into sub commands
* increased test coverage for packages
* Added docs cleaned up tests and example scripts
* Test coverage increased for module/gct/exchange package
* windows fixes
* merged upstream/engine
* WIP
* logger fixes - removed pointer to bool check removed duplicate test check for logger
* remove unused mutex
* added inital upload support
* fix linter issues for go-fmt
* added zip support for uploading and added base for fund withdrawing
* changed error return types and also log errors, fix zip path issue
* improved error outputs and code flow
* pairs response fix added protobuf defs for stop all and list all
* added stop all running scripts general clean up and moved across to OrderManager
* linter fixes (gofmt)
* added list all command
* rewrote zip handler to be cleaner also fixed file overwrite on upload
* added query command reworked tests
* added further error checking to compileandrun corrected use of pointers for accountinfo
* bumped tengo version
* Removed named returns reworded log messages removed unused falseptr
* WIP
* Added virutal machine limit improved config options
* added model for script event added upload validation
* script_event table has been completed, tests for wrapper functions implemented
* README updates
* reverted changes opened new PR to move withdraw struct outs
* intial work on adding withdraw support after merger of withdraw package
* started work on examples
* Added crypto withdraw support
* fix switch case assignment and gofmt project
* Reworking Fiat withdraw request pending #402
* removed double pointer call
* added withdraw support for fiat currencies
* added tests for withdraw methods increased readme
* removed local tengo require and also fix linter issues
* Added default log size const added basic test for invalid script execution
* First pass at moving wrapper to validator package to allow proper validation of uploaded scripts
* Added script details to README added config test added test for no file extension
* moved tests to const and fixed incorrect pathing
* added test coverage to withdraw package
* corrected file close handling
* point to included configtest.json
* extended validator support when a script is uploaded
* Bug fix on bool logic
* Added mutex
* Don't create autit events on test execution
* reverted common to master
* moved file rename to unix timestamp format
* converted logger enabled back to pointer as i need nilness check also moved scriptid to text over blob
* started work on autoload add/remove support
* First round of PR fixes (mostly commented exports)
* Moved GCTScript load to last, removed unneeded error from cleanup()
* Comment clairty for AuitEventID
* added autoload add/remove command to cli
* added tests for autoload
* Test updates for Exchanges
* linter fixes (gofmt)
* Removed double check of engine pointer
* remove possible nil pointer on GetSpecificTicker
* Fixed not closing file handler on write that causes archive removal to fail
* file handler Close clean ups
* corrected spelling on error return and return invalid name n autoload
* moved strings to cosnt moved bool pointer creation to convert package
* new zip extractor added
* Validation has been added to archive uploads
* removed shadow var on err
* added ok check to conversion
* converted condition check
* basic test for zip extract added
* new zip handler
* reverted back to old atomic loading system
* removed shadow err
* lets add a new line
* added space to error return
* command line toggle for script now works properly
* readme updated
* set configLoaded to true
* check for configLoaded condition
* added mutex to allow for multiple access on virtual machine increased test coverage disable script manager if scripting is disabled
* linked up to enable/disablesubsystem commands
* added start/stop example to readme
* reworked logic on test as check should be done on Load()
* updated to tengo v2
* linters
* lower time on ntp client to stop slippage
* remove all fails if any fail validtion from an archive
* remove vm from list if timer is invalid
* removed shadow on err
* remove config creation from NTPCheck test
* WIP testing DB changes
* add unique constraint
* WIP: created has many model
* linters run
* basic sqlite3 support added for new database format
* linters run
* Added test coverage for script repo
* removed unused print
* updated env vars for CI instances
* updated env vars for CI instances
* Updated test packages
* Test updates for postgresql
* removed invalid tests from postgres
* remove duplication of struct and improved code flow
* general cleanup
* wording changes on log output
* use databasemgr logger and add support for autoload without file extension
* corrected test naming
* return correct error
* return correct error again version 82
* store scriptdata on creation
* Hello
* Errorln -> Errorf
* Removed unused vars
* Read me updates
* testing without parallel
* comment on exported type
* added nil check against VM for test
* add debugging information
* gofmt
* remove verbose and data sent to channel
* Added debug information
* linter fixes (gofmt)
* remove unused CompileAndRun() call
* test sleep to see if issue is timing related
* semi-concurrent map fixes
* one day i will run gofmt or setup precommit hooks
* new line :D
* increased test coverage
* added correct sleep time
* Moved over to sync map
* linter fixes (gofmt)
* goimports
* moved VM related methods to vm.go
* new line at end of file
* trying increased timeout on golangci-lint for appveyor
* add debugging information
* removed timeout
* reworked timeout logic
* linter fixes (gofmt)
* increased test coverage
* increased test coverage
* one day i will run gofmt or setup precommit hooks
* removed unused exchange test
* increased golangci-lint timeout
* Added nil check on shutdown and test coverage for it lowered timeout back to 1:30
* reworked ID system
* removed script hash as it was unused
* added comments on exported methods and read me update
* reorder code
* removed to atomic.value for test execution flag
* increased test coverage
* move add further up execution
* point to correct script file
* Adds new optional log field. Adds padding to the fields to make it have a consistent output
* Line space and correct err message
* Removes padding code
* Moves `ShowLogSystemName` to advanced settings
* Uppers the names. Prevents pointer crash. Adds to config_example.json
* Adds test scenario for nil and true ShowLogSystemName
* buffer reset
* added id field to bank struct
* fixed casing on error message
* whitespace :D
* turns out you shouldn't turn multiple tests at the same time that modify a var
* corrected param order Side -> Type, also corrected condition check for IsOrderPlaced
* send open status for GetActiveOrders
* GetActiveOrder() changes to include OrderID and status matching
* BTC Markets batch order limit fixes & SplitStringSliceByLimit method
BTC markets batch end points have limits (20 for cancel 50 for query) adds new method SplitStringSliceByLimit in common to split a slice by limit and return slice of slice
* rm line :D
* Added test for SplitStringSliceByLimit and moved to const
* ntp client reworked to not return error if no valid time servers are found but default to system
* clean up
* new line added
* use TimeMgr sublogger and wording correction on output
* Moved to DialTimeout() & Removed SetDeadline call
* removed line
* added setdeadline fix
* goimport file
* removed unused error from NTPClient as we now default to system time if no server can be reached
* Added checks for number overflows
* converted to uint as you should not be passing a negative number in
* Increased test cases for NTPClient
* Removed Helper call as no longer outputting any data from function
* removed unused param
* drop common uuid v4 func and imported package as needed
* removed common functions regarding json marshal and unmarshal and used the json package directly. WRT unmarshal it was calling reflect and converted to string which is also checked in the JSON package so it was doing a double up, this will be a tiny gain as it was directly used in the requester package for all our outbound requests.
* add in string
* explicitly throw away return error value
* atleast return the error that websocket initialise returns
* return error when not connected
* fix comment
* Adds comments
* move package declarations
* drop append whenever we call supported
* remove unused import
* Change incorrect spelling
* fix tests
* fix go import issue
* Add directories to exclusion list && change default repo string
* Add in .idea folder to directory exclusion list
* cleaned
* Added support for calling the tool outside of its file
* fix formatting
* changed strings
* Adds new file.Move func to address a bug with Golang/Docker volumes when using os.Rename
Also uses TempDir for tests instead of live directories and increases test coverage for file.Write
* Goimport the imports
* Make usage of file package name consistent so it no longer clashes with vars
* Remove outputFile if io.Copy fails
* 1) Update Dockerfile/docker-compose.yml
2) Remove inline strings for buy/sell/test pairs
3) Remove dangerous order submission values
4) Fix consistency with audit_events (all other spec files use
CamelCase)
5) Update web websocket endpoint
6) Fix main param set (and induce dryrun mode on specific command line
params)
* Engine QA
Link up exchange syncer to cmd params, disarm market selling bombs and fix OKEX endpoints
* Fix linter issue after merge
* Engine QA changes
Template updates
Wrapper code cleanup
Disarmed order bombs
Documentation updates
* Daily engine QA
Bitstamp improvements
Spelling mistakes
Add Coinbene exchange to support list
Protect API authenticated calls for Coinbene/LBank
* Engine QA changes
Fix exchange_wrapper_coverage tool
Add SupportsAsset to exchange interface
Fix inline string usage and add BCH withdrawal support
* Engine QA
Fix Bitstamp types
Inform user of errors when parsing time accross the codebase
Change time parsing warnings to errors (as they are)
Update markdown docs [with linter fixes]
* Engine QA changes
1) Add test for dryrunParamInteraction
2) Disarm OKCoin/OKEX bombs if someone accidently sets canManipulateRealOrders to true and runs all package tests
3) Actually check exchange setup errors for BTSE and Coinbene, plus address this in the wrapper template
4) Hardcode missing/non-retrievable contributors and bump the contributors
5) Convert numbers/strings to meaningful types in Bitstamp and OKEX
6) If WS is supported for the exchange wrapper template, preset authWebsocketSupport var
* Fix the shadow people
* Link the SyncContinuously paramerino
* Also show SyncContinuously in engine.PrintSettings
* Address nitterinos and use correct filepath for logs
* Bitstamp: Extract ALL THE APM
* Fix additional nitterinos
* Fix time parsing error for Bittrex
* Improved error message when no config is set on startup
* Change inccorect error wording
* bump Bitfinex websocket orderbook return length to max
* temporary fix of incorrect orderbook updates, limit to bid and ask len of 100, will be extended later if needed
* Fixed issue in binance websocket that appended 0 volume bid/ask items
* Fix panic when unmarshalling an empty pair from config
* Add get pair asset method for exchange base
Fix Bitmex orderbook stream
Unbuffer Bitmex orderbook stream
* force syncer to update ticker instead of fetch, which allows a stream
* Fix websocket last price for coinbasepro
* fix websocket ticker for coinut
* Fix websocket orderbook stream Huobi
* increase orderbook depth REST for Huobi
* Fix websocket support and ensure data integrity
* Fix time parsing issue after error checks
* check error, only process enabled currency pairs, signal websocket data processing
* expanded websocket functionality for okgroup
* Add logic to not process zero length slice for orderbooks
* fix websocket ticker only updating enabled and individual book updates
* ZB fixes to order submission/retrieval/cancellation w/ general fixes
* Quiet unnecessary warning
* updated config entry values for REST and websocket (initial hack until I come up with a better solution for asset types)
* Ch GetName function to field access modifyer & rm useless code
* Add in error I missed
* Nits addressed
* some more fixes
* Turned kraken default websocket to true and some small changes
* fixes linter issues
* Ensured okgroup books and sent update through to datahandler. Zb update as well.
* Add test case to get asset type from pair
* Add test for pairs unmarshal
* Add testing and addressed nits
* FIX linter issue
* Addressed Gees nits
* Thanks glorious spotter
* more nitorinos
* Addres even more nits
* Add stringerino 4000
* Fix for panic cause by sort slice out of range, also nits addressed
* fix linter issues
* Changed from function to field access
* Changed from function to field access
* fix for orderbook update panic, removes quick fix - caused by sync item fetching through same protocol
* Add new test and update random generator
* pass in invalid string to future ob fetching, due to futures contract expire and a http 400 error is returned
* Attempts to update orderbook so it doesn't need to sort
* Reverts the ws ob stuff. Gets rid of sorting because it happens later. Adds some exchange features
* update existing feature lists. Expands list definition to match my emotions
* Adds bithumb bitmex and bitstamp. adds a couple more types
* Features for you, features for me, features for bittrex, btcmarkets, btse, coinbasepro, coinut, exmo, gateio and gemini
* Features for hitbtc, huobi, itbit, kraken, lakebtc, lbank, localbitcoins, okcoin, okex, poloniex, yobit, zb
* Who can forget good old alphapoint?
* Adds btcmarksets websocket :glitch_crab: fixes alphapoint features
* Adds extra data not in the documentation :/
* Replaces websocket features by using protocol features. However, it breaks it due to import cycles. I'm not sure what I'll do just yet
* Removes import cycle via duplicate structs.
* Increases coverage of config with `TestCheckCurrencyConfigValues`. Moves all currency pair package types into their own files or places it at the bottom of files if necessary
* Increase coverage in code.go
* One way of determining a test has failed, is when to it fails. Removed redundant explanation
* Increases code coverage of conversion
* Lint fixes
* Fixes orderbook tests
* Re-adds sorting because its important to still have the internal pre-processed orderbook to be representative of a real orderbook
* Secret lints that did not show up via Windows linting
* Adds protocol package to contain exchange features
* Fixes protocol implementation
* Fixes ws tests
* Addresses the following: Removes st-st-stutters in config types, changes GetAvailableForexProviders -> GetSupportedForexProviders, removes errors from tests where error is nil, removes orderbook setup when not necessary, removes import newlines, removes false bools from declaration, changes should of to should have
* imports and casing
* Fixes two more nil error checks
* Migrated to goose & sqlboiler
* create tests with sqlboiler
* code clean up
* Added gct -> sqlboiler config gen
* dropped pgx support
* dropped pgx support because who needs connection pools
* reenable sqlite audit tests
* first pass of migration changes
* stuff is broken :D
* sqlboiler :D
* end of date commit
* Added comments code clean up
* revert go module files back to upstream
* bug fix
* pushed go.mod update to use correc goose version
* renamed sqlite to sqlite3 for consistency across codebase and PR feedback changes
* makefile updates
* things are broken end of day commit
* added postgresql test
* use correct database name
* travis fixes for env vars
* travis fixes for env vars
* test fixes
* run migration on test setup
* test adding postgres support to appveyor
* Skip tests on appveyor due to issues with missing binaries
* oh yeah i have to support windows don't i
* bumped goose version up
* add postgres to osx
* fix travis config as osx does not support services move spin up to before_script
* added PGDATA path fix
* pass PG_DATA to pg_ctl
* added initdb to before install
* fixes to wording and bumps up goose version
* who needs ssl anyway
* moved ssl to correct section :D
* bumped goose version up
* unbreak travis
* unbreak travis
* fix if database is disabled in config
* move strings to consts
* converted more strings to const
* improvements to sqlboiler mmodel gen
* Added contrib\sqlboiler file
* sqlboiler windows contrib fixes
* bumped goose version up
* :D whoops
* further fixes to sql models
* further fixes to sql models
* database type fix for config gen
* README update
* go.mod clean up
* added config details for appveyor
* appveyor ordering fix
* force psql9.6
* appveyor config changes
* all the environmen vars
* model changes for psql
* model changes for psql
* sqlite model fixes
* attempt at osx fix
* added error check for migration
* typos and check against goose error instead of string :D
* updated sqlboiler commit id
* bump sqlboiler version again
* set decimal package to @0bb1631
* readme and makefile updates
* bump goose version update readme and add override flag to config gen
* README typo fix and lowered inserts in test down to 20 as we are only testing that inserts work running 200 was unnecessary
* added gctcli command for audit event
* Added debug output toggle to config added both postgres & sqlite support to gctcli command
* Wording changes on errors
* set sqlite to 1 connection to stop locke database issues
* Usage update for order
* README updates with config examples
* go.mod/sum tidy
* removed lines in import second
* removed lines in imports
* convert local time to utc for database and display output
* go mod clean up and error checking to time
* renamed all packages to sqlite3
* added windows command output for sql model gen
* time conversion fix
* time conversion on gctcli
* Initial commit tearing down the websocket connection management. The purpose is to remove the traffic monitoring and dropping as syncer.go is a better manager
* Adds a readwrite mutex and helper functions to minimise inline lock/unlocks and prevent races
* Creates new WebsocketType struct to contain all parameters required. Deletes WebsocketReset. Utilises ReadMessageErrors channel for all websocket readmessages to analyse when an error returned is due to a disconnect
* Fixes issue with syncer trying to connect while connecting
* Simplifies initialisation function for websocket. Reconnects and resubscribes after disconnection
* Adds WebsocketTimeout config value to dictate when the websocket traffic monitor should die. Default to two minutes of no traffic activity. Increases test coverage and updates existing tests to work with new technologic. RE-ADDS TESTS I ACCIDENTALLY DELETED FROM PREVIOUS PR
* Removes snapshot override as its always necessary when considering reconnections. Increases test coverage. Re-adds tests that were ACCIDENTALLY DELETED. Removes unused websocket channels. Bug fix for traffic monitor to shutdown via goroutine instead of killing itself
* Fixes gateio bug for authentication errors when null. Adds little entry to syncer for when websocket is switched to rest and then back, you get a log notifying of the return. Fixes okgroup bug where ws message is sent on a disconnected ws, causing panic. Renames setConnectionStatus to setConnectedStatus. Puts connection monitor log behind verbose bool
* Fixes lingering races. Fixes bug where websocket was enabled whether you liked it or not. Removes demonstration test
* Fixes log message, renames unc, removes comments
* Fixes data race
* Removes verbosity, ensures shutdown sets connection status appropriately
* Removes go routine causing CPU spike. Stops timers properly and resets timers properly
* Renames `WsEnabled` to `Enabled`. Increases test coverage. Fixes typos. Handles unhandled errors
* The forgotten lint
* With using RWlocks, removes the channel nil check and relies on !w.IsConnected() to prevent a shutdown from recurring
* Removes extra closure step in the defer as it causes all the issues
* Prevents timer channel hangups. Minimises use of websocket Connect(). Expands disconnection error definition. Removes routine disconnection error handling. Ensures only one traffic monitor can ever be run. Renames subscriptionLock to subscriptionMutext for consistency
* Extends timeout to 30 seconds to cover for non-popular exchanges and non-popular currencies
* Updates test from rebase to use new websocket setup function
* Fixes test to ensure it tests what it says it does
* Fix bug where on parsing an alternate new config it will overwrite main config.json in gct dir
* Stop movement of config.json file from root dir when a new config is parsed in
* Stop overiding config.json at gct dir with new config.json from root directory
* RM LN :D
* Fix bug where promptforconfig in config_encryption.go overwrites default config
Ensure periphery command packages do not interact or save over configuration
Ensure tests to not save over or change current testdata/config
1) Although gRPC does server side validation currently, validate basic things
on gctcli before relaying the request to the gRPC server
2) Make pair format consistent for the exchange sycner
3) Fix OKEX ticker failure due to thinking futures info is authenticated
4) Start filling out config tests
5) Extend timeout for golangci config so that AppVeyor has time to
complete (Travis is fine)
6) Add IsSupported exchange func for easy lookup
