Ryan O'Hara-Reid
cf54764cb7
GateIO: Update websocket orderbook manager ( #1989 )
...
* gateio: websocket ob manager fix (cherry-pick me)
* fix(gateio): update websocket orderbook manager to support delay and deadline parameters
feat(subscriptions): mv ChannelKey type for subscription management from gateio to subscriptions
test(gateio): enhance tests for orderbook update manager and subscription keys
* ai: nits
* linter: fix
* Fix asset typo and add in case test
* cranktakular: nits
* cranktakular: nits after merge master
* bump time delay for cache
* fix bug where on error it never initiates another orderbook fetch
* lint: fix
* Update exchanges/gateio/ws_ob_update_manager.go
Co-authored-by: Scott <gloriousCode@users.noreply.github.com >
* glorious: nits
* linter: fix
* Update exchanges/gateio/gateio_wrapper_test.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/gateio_wrapper.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/gateio_wrapper_test.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/ws_ob_update_manager.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/ws_ob_update_manager.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/ws_ob_update_manager.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/ws_ob_update_manager_test.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* gk: nits
* Update exchanges/gateio/gateio_wrapper.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/ws_ob_update_manager.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* gk: nits
* bossking: nits
* Update exchanges/gateio/ws_ob_update_manager_test.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* gk: nits
* apply patch
* rm error state as this was on the same thread as cacheStateQueuing and had the potential to drop messages, add tests.
* linter: fix
* mock live request
* misc: fix
* Update exchanges/gateio/ws_ob_update_manager.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/ws_ob_update_manager.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/ws_ob_update_manager.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/ws_ob_update_manager.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/ws_ob_update_manager.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* gk: nits
* field name from mtx -> m
* lint: fix
* race: check fix
* thrasher-: patch adams
---------
Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io >
Co-authored-by: Scott <gloriousCode@users.noreply.github.com >
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
2025-11-27 12:21:17 +11:00
Gareth Kirwan
5d6755b76e
linters: Exclude govet shadow check on exchange instances ( #2097 )
...
* Linters: Exclude govet shadow check on e in tests
* Linters: Remove nolint rule for new(Exchange) in tests
Replay with:
```
perl -pi -e 's{(\se\s:=\s.*?)\s*//nolint:govet // Intentional shadow.*}{$1}' **/*_test.go
```
2025-10-29 09:30:23 +11:00
Gareth Kirwan
73e200e4e7
accounts: Move to instance methods, fix races and isolate tests ( #1923 )
...
* Bybit: Fix race in TestUpdateAccountInfo and TestWSHandleData
* DriveBy rename TestWSHandleData
* This doesn't address running with -race=2+ due to the singleton
* Accounts: Add account.GetService()
* exchange: Assertify TestSetupDefaults
* Exchanges: Add account.Service override for testing
* Exchanges: Remove duplicate IsWebsocketEnabled test from TestSetupDefaults
* Dispatch: Replace nil checks with NilGuard
* Engine: Remove deprecated printAccountHoldingsChangeSummary
* Dispatcher: Add EnsureRunning method
* Accounts: Move singleton accounts service to exchange Accounts
* Move singleton accounts service to exchange Accounts
This maintains the concept of a global store, whilst allowing exchanges
to override it when needed, particularly for testing.
APIServer:
* Remove getAllActiveAccounts from apiserver
Deprecated apiserver only thing using this, so remove it instead of
updating it
* Update comment for UpdateAccountBalances everywhere
* Docs: Add punctuation to function comments
* Bybit: Coverage for wsProcessWalletPushData Save
2025-10-28 13:52:45 +11:00
Ryan O'Hara-Reid
fed4b1bb14
GateIO: Fix account sequence issue, expand structs, add tests ( #2011 )
...
* gateio: fix sequence issue, expand structs, add tests (cherry-pick my nose)
* Update exchanges/gateio/gateio_websocket_futures.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update exchanges/gateio/gateio_types.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/gateio_websocket_test.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* gk: nits
* GateIO: Avoid nolint on containedctx
* Update exchanges/gateio/gateio_websocket_test.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* fixup
* Update exchanges/gateio/gateio_websocket_test.go
Co-authored-by: Scott <gloriousCode@users.noreply.github.com >
---------
Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
Co-authored-by: Scott <gloriousCode@users.noreply.github.com >
2025-09-11 13:58:46 +10:00
Ryan O'Hara-Reid
16f543666f
GateIO: Fix and standardise ping handling ( #2023 )
...
* gateio: standardise ping handlers (cherry-pick)
* Add tests and expand incoming cases for proof
* lint: fix and add commentary on ping delay
* Update exchange/websocket/connection.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/gateio/gateio_websocket.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* linter: fix
* Update exchange/websocket/connection.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* fix test
* glorious: insane catch
---------
Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io >
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
2025-09-10 21:02:09 +10:00
