cranktakular
2fd4f5ec5b
cmd/exchange_template: Update wrapper template, improve documentation ( #2009 )
...
* Updating wrapper template, updating documentation, regenerating documentation
* Renaming "streaming api" to "websocket"
* Context is now t
* Update docs/ADD_NEW_EXCHANGE.md
Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io >
* Update cmd/documentation/root_templates/root_readme.tmpl
Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io >
* Fixes an improper example and regenerates documentation
* Corrects typos
* Makes a table label consistent across files
---------
Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io >
2025-11-11 11:07:26 +11:00
Scott
61d720b72f
exchanges: Use singular futures settlement currency ( #2092 )
...
* Change settlement to singular currency
* whoops.go
* bitmex fix
* minor updates
* 64 divided by 2
* whoops2.go
* ROBOT ROCK
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* ROCK ROCK ROCK ROCK ROBOT
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* shazNit
* currencies unmarshal and code use
* Update currency/currencies.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/btse/btse_wrapper.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* reuse comment for better clarity
* collapses entire thing
* shazLint
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
2025-11-10 13:21:54 +11:00
Gareth Kirwan
5d6755b76e
linters: Exclude govet shadow check on exchange instances ( #2097 )
...
* Linters: Exclude govet shadow check on e in tests
* Linters: Remove nolint rule for new(Exchange) in tests
Replay with:
```
perl -pi -e 's{(\se\s:=\s.*?)\s*//nolint:govet // Intentional shadow.*}{$1}' **/*_test.go
```
2025-10-29 09:30:23 +11:00
Gareth Kirwan
73e200e4e7
accounts: Move to instance methods, fix races and isolate tests ( #1923 )
...
* Bybit: Fix race in TestUpdateAccountInfo and TestWSHandleData
* DriveBy rename TestWSHandleData
* This doesn't address running with -race=2+ due to the singleton
* Accounts: Add account.GetService()
* exchange: Assertify TestSetupDefaults
* Exchanges: Add account.Service override for testing
* Exchanges: Remove duplicate IsWebsocketEnabled test from TestSetupDefaults
* Dispatch: Replace nil checks with NilGuard
* Engine: Remove deprecated printAccountHoldingsChangeSummary
* Dispatcher: Add EnsureRunning method
* Accounts: Move singleton accounts service to exchange Accounts
* Move singleton accounts service to exchange Accounts
This maintains the concept of a global store, whilst allowing exchanges
to override it when needed, particularly for testing.
APIServer:
* Remove getAllActiveAccounts from apiserver
Deprecated apiserver only thing using this, so remove it instead of
updating it
* Update comment for UpdateAccountBalances everywhere
* Docs: Add punctuation to function comments
* Bybit: Coverage for wsProcessWalletPushData Save
2025-10-28 13:52:45 +11:00
Adrian Gallagher
bb122dcafa
codebase: Remove web frontend and related services ( #2067 )
...
* codebase: Remove web frontend and related services
* refactor: Update StartPPROF to accept context and adjust related tests
* refactor: Simplify SetIfZero functions and update related tests
* config: Clarify DowngradeConfig method documentation regarding permanent removal of deprecated fields
* refactor: Rename setIfZeroAndWarn to setDefaultIfZeroWarn for clarity and update related calls
* refactor: Update error handling in DataHistoryManager and remove redundant error variable
2025-09-30 13:32:09 +10:00
Ryan O'Hara-Reid
0b60693ff5
exchanges: Update ModifyOrder comments for clarity ( #2044 )
...
Co-authored-by: shazbert <ryan.oharareid@thrasher.io >
2025-09-30 11:23:10 +10:00
Ryan O'Hara-Reid
9f8b783c20
exchanges: Refactor UpdateTradablePairs method to remove forceUpdate parameter ( #2043 )
...
* Refactor UpdateTradablePairs method to remove forceUpdate parameter
- Updated the signature of UpdateTradablePairs in multiple exchange wrappers to remove the forceUpdate boolean parameter.
- Adjusted related test cases to reflect the change in method signature.
- Ensured that the UpdatePairs method calls within UpdateTradablePairs no longer reference the removed parameter.
* update exchange wrapper template
* linter: fix
* glorious: nits
* thrasher/glorious: nits
* Update exchanges/exchange_test.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/exchange_test.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* Update exchanges/exchange_test.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
* fix things
* misc: fix
* Update exchanges/exchange_test.go
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
---------
Co-authored-by: shazbert <ryan.oharareid@thrasher.io >
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
2025-09-22 12:20:23 +10:00
cranktakular
fd9aaf00a2
Coinbase: Update exchange implementation ( #1480 )
...
* Slight enhance of Coinbase tests
Continual enhance of Coinbase tests
The revamp continues
Oh jeez the Orderbook part's unfinished don't look
Coinbase revamp, Orderbook still unfinished
* Coinbase revamp; CreateReport is still WIP
* More coinbase improvements; onto sandbox testing
* Coinbase revamp continues
* Coinbase revamp continues
* Coinbasepro revamp is ceaseless
* Coinbase revamp, starting on advanced trade API
* Coinbase Advanced Trade Starts in Ernest
V3 done, onto V2
Coinbase revamp nears completion
Coinbase revamp nears completion
Test commit should fail
Coinbase revamp nears completion
* Coinbase revamp stage wrapper
* Coinbase wrapper coherence continues
* Coinbase wrapper continues writhing
* Coinbase wrapper & codebase cleanup
* Coinbase updates & wrap progress
* More Coinbase wrapper progress
* Wrapper is wrapped, kinda
* Test & type checking
* Coinbase REST revamp finished
* Post-merge fix
* WS revamp begins
* WS Main Revamp Done?
* CB websocket tidying up
* Coinbase WS wrapperupperer
* Coinbase revamp done??
* Linter progress
* Continued lint cleanup
* Further lint cleanup
* Increased lint coverage
* Does this fix all sloppy reassigns & shadowing?
* Undoing retry policy change
* Documentation regeneration
* Coinbase code improvements
* Providing warning about known issue
* Updating an error to new format
* Making gocritic happy
* Review adherence
* Endpoints moved to V3 & nil pointer fixes
* Removing seemingly superfluous constant
* Glorious improvements
* Removing unused error
* Partial public endpoint addition
* Slight improvements
* Wrapper improvements; still a few errors left in other packages
* A lil Coinbase progress
* Json cleaning
* Lint appeasement
* Config repair
* Config fix (real)
* Little fix
* New public endpoint incorporation
* Additional fixes
* Improvements & Appeasements
* LineSaver
* Additional fixes
* Another fix
* Fixing picked nits
* Quick fixies
* Lil fixes
* Subscriptions: Add List.Enabled
* CoinbasePro: Add subscription templating
* fixup! CoinbasePro: Add subscription templating
* fixup! CoinbasePro: Add subscription templating
* Comment fix
* Subsequent fixes
* Issues hopefully fixed
* Lint fix
* Glorious fixes
* Json formatting
* ShazNits
* (L/N)i(n/)t
* Adding a test
* Tiny test improvement
* Template patch testing
* Fixes
* Further shaznits
* Lint nit
* JWT move and other fixes
* Small nits
* Shaznit, singular
* Post-merge fix
* Post-merge fixes
* Typo fix
* Some glorious nits
* Required changes
* Stop going
* Alias attempt
* Alias fix & test cleanup
* Test fix
* GetDepositAddress logic improvement
* Status update: Fixed
* Lint fix
* Happy birthday to PR 1480
* Cleanups
* Necessary nit corrections
* Fixing sillybug
* As per request
* Programming progress
* Order fixes
* Further fixies
* Test fix
* Pre-merge fixes
* More shaznits
* Context
* Sonic error handling
* Import fix
* Better Sonic error handling
* Perfect Sonic error handling?
* F purge
* Coinbase improvements
* API Update Conformity
* Coinbase continuation
* Coinbase order improvements
* Coinbase order improvements
* CreateOrderConfig improvements
* Managing API updates
* Coinbase API update progression
* jwt rename
* Comment link fix
* Coinbase v2 cleanup
* Post-merge fixes
* Review fixes
* GK's suggestions
* Linter fix
* Minor gbjk fixes
* Nit fixes
* Merge fix
* Lint fixes
* Coinbase rename stage 1
* Coinbase rename stage 2
* Coinbase rename stage 3
* Coinbase rename stage 4
* Coinbase rename final fix
* Coinbase: PoC on converting to request structs
* Applying requested changes
* Many review fixes, handled
* Thrashed by nits
* More minor modifications
* The last nit!?
---------
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com >
2025-09-16 13:37:00 +10:00
