d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 23:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Coinbase: Update exchange implementation (#1480)

Browse Source 
* Slight enhance of Coinbase tests

Continual enhance of Coinbase tests

The revamp continues

Oh jeez the Orderbook part's unfinished don't look

Coinbase revamp, Orderbook still unfinished

* Coinbase revamp; CreateReport is still WIP

* More coinbase improvements; onto sandbox testing

* Coinbase revamp continues

* Coinbase revamp continues

* Coinbasepro revamp is ceaseless

* Coinbase revamp, starting on advanced trade API

* Coinbase Advanced Trade Starts in Ernest

V3 done, onto V2

Coinbase revamp nears completion

Coinbase revamp nears completion

Test commit should fail

Coinbase revamp nears completion

* Coinbase revamp stage wrapper

* Coinbase wrapper coherence continues

* Coinbase wrapper continues writhing

* Coinbase wrapper & codebase cleanup

* Coinbase updates & wrap progress

* More Coinbase wrapper progress

* Wrapper is wrapped, kinda

* Test & type checking

* Coinbase REST revamp finished

* Post-merge fix

* WS revamp begins

* WS Main Revamp Done?

* CB websocket tidying up

* Coinbase WS wrapperupperer

* Coinbase revamp done??

* Linter progress

* Continued lint cleanup

* Further lint cleanup

* Increased lint coverage

* Does this fix all sloppy reassigns & shadowing?

* Undoing retry policy change

* Documentation regeneration

* Coinbase code improvements

* Providing warning about known issue

* Updating an error to new format

* Making gocritic happy

* Review adherence

* Endpoints moved to V3 & nil pointer fixes

* Removing seemingly superfluous constant

* Glorious improvements

* Removing unused error

* Partial public endpoint addition

* Slight improvements

* Wrapper improvements; still a few errors left in other packages

* A lil Coinbase progress

* Json cleaning

* Lint appeasement

* Config repair

* Config fix (real)

* Little fix

* New public endpoint incorporation

* Additional fixes

* Improvements & Appeasements

* LineSaver

* Additional fixes

* Another fix

* Fixing picked nits

* Quick fixies

* Lil fixes

* Subscriptions: Add List.Enabled

* CoinbasePro: Add subscription templating

* fixup! CoinbasePro: Add subscription templating

* fixup! CoinbasePro: Add subscription templating

* Comment fix

* Subsequent fixes

* Issues hopefully fixed

* Lint fix

* Glorious fixes

* Json formatting

* ShazNits

* (L/N)i(n/)t

* Adding a test

* Tiny test improvement

* Template patch testing

* Fixes

* Further shaznits

* Lint nit

* JWT move and other fixes

* Small nits

* Shaznit, singular

* Post-merge fix

* Post-merge fixes

* Typo fix

* Some glorious nits

* Required changes

* Stop going

* Alias attempt

* Alias fix & test cleanup

* Test fix

* GetDepositAddress logic improvement

* Status update: Fixed

* Lint fix

* Happy birthday to PR 1480

* Cleanups

* Necessary nit corrections

* Fixing sillybug

* As per request

* Programming progress

* Order fixes

* Further fixies

* Test fix

* Pre-merge fixes

* More shaznits

* Context

* Sonic error handling

* Import fix

* Better Sonic error handling

* Perfect Sonic error handling?

* F purge

* Coinbase improvements

* API Update Conformity

* Coinbase continuation

* Coinbase order improvements

* Coinbase order improvements

* CreateOrderConfig improvements

* Managing API updates

* Coinbase API update progression

* jwt rename

* Comment link fix

* Coinbase v2 cleanup

* Post-merge fixes

* Review fixes

* GK's suggestions

* Linter fix

* Minor gbjk fixes

* Nit fixes

* Merge fix

* Lint fixes

* Coinbase rename stage 1

* Coinbase rename stage 2

* Coinbase rename stage 3

* Coinbase rename stage 4

* Coinbase rename final fix

* Coinbase: PoC on converting to request structs

* Applying requested changes

* Many review fixes, handled

* Thrashed by nits

* More minor modifications

* The last nit!?

---------

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>
This commit is contained in:
cranktakular
2025-09-16 13:37:00 +10:00
committed by GitHub
parent d957ddae62
commit fd9aaf00a2
78 changed files with 8850 additions and 3937 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
exchanges/ticker/ticker.go
View File

@@ -7,6 +7,7 @@ import (
"time"
"github.com/gofrs/uuid"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/common/key"
"github.com/thrasher-corp/gocryptotrader/currency"
"github.com/thrasher-corp/gocryptotrader/dispatch"
@@ -15,9 +16,8 @@ import (
// Public errors
var (
ErrTickerNotFound = errors.New("no ticker found")
ErrBidEqualsAsk = errors.New("bid equals ask this is a crossed or locked market")
ErrExchangeNameIsEmpty = errors.New("exchange name is empty")
ErrTickerNotFound = errors.New("no ticker found")
ErrBidEqualsAsk = errors.New("bid equals ask this is a crossed or locked market")
)
var (
@@ -66,7 +66,7 @@ func SubscribeToExchangeTickers(exchange string) (dispatch.Pipe, error) {
// GetTicker checks and returns a requested ticker if it exists
func GetTicker(exchange string, p currency.Pair, a asset.Item) (*Price, error) {
if exchange == "" {
return nil, ErrExchangeNameIsEmpty
return nil, common.ErrExchangeNameNotSet
}
if p.IsEmpty() {
return nil, currency.ErrCurrencyPairEmpty
@@ -93,7 +93,7 @@ func GetExchangeTickers(exchange string) ([]*Price, error) {
func (s *Service) getExchangeTickers(exchange string) ([]*Price, error) {
if exchange == "" {
return nil, ErrExchangeNameIsEmpty
return nil, common.ErrExchangeNameNotSet
}
exchange = strings.ToLower(exchange)
s.mu.Lock()
@@ -136,7 +136,7 @@ func ProcessTicker(p *Price) error {
}
if p.ExchangeName == "" {
return ErrExchangeNameIsEmpty
return common.ErrExchangeNameNotSet
}
if p.Pair.IsEmpty() {
@@ -223,7 +223,7 @@ func (s *Service) setItemID(t *Ticker, p *Price, exch string) error {
// getAssociations links a singular book with its dispatch associations
func (s *Service) getAssociations(exch string) ([]uuid.UUID, error) {
if exch == "" {
return nil, ErrExchangeNameIsEmpty
return nil, common.ErrExchangeNameNotSet
}
var ids []uuid.UUID
exchangeID, ok := s.Exchange[exch]

7
exchanges/ticker/ticker_test.go
View File

@@ -12,6 +12,7 @@ import (
"github.com/gofrs/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/common/key"
"github.com/thrasher-corp/gocryptotrader/currency"
"github.com/thrasher-corp/gocryptotrader/dispatch"
@@ -423,7 +424,7 @@ func TestProcessTicker(t *testing.T) { // non-appending function to tickers
func TestGetAssociation(t *testing.T) {
_, err := service.getAssociations("")
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
service.mux = nil
@@ -437,7 +438,7 @@ func TestGetAssociation(t *testing.T) {
func TestGetExchangeTickersPublic(t *testing.T) {
_, err := GetExchangeTickers("")
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
}
func TestGetExchangeTickers(t *testing.T) {
@@ -448,7 +449,7 @@ func TestGetExchangeTickers(t *testing.T) {
}
_, err := s.getExchangeTickers("")
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
_, err = s.getExchangeTickers("test")
assert.ErrorIs(t, err, errExchangeNotFound)